dyna_form 0.1.0 → 0.1.3

data/CHANGELOG

@@ -0,0 +1,6 @@
+2014-08-13 Willux <zaikaus1@gmail.com>
+
+  * Removed the dangerous 'DynaForm::Base#submit!' method
+  * Ensured that 'DynaForm::Base#submit' returns a boolean if the validations pass.
+  * Allow users to add validations in the form class.
+  * Updated README.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    dyna_form (0.1.0)
+    dyna_form (0.1.3)
       activerecord
       activesupport
 

data/README.md

@@ -81,6 +81,8 @@ and submit it:
 `DynaForm#submit!` calls `ActiveRecord::Base#create!`. Which means that whatever
 exception `ActiveRecord::Base#create!` throws, `DynaForm#submit!` will throw.
 
+You are welcome to add any validations you want in the form class. It'll allow you to keep your models skinnier and encapsulate any form functionality in a single class.
+
 ## Contributing
 
 1. Fork it ( https://github.com/willux/dyna_form/fork )

data/lib/dyna_form/base.rb

@@ -41,12 +41,10 @@ module DynaForm
       @lazy_initialization ? create_var(method, arguments.first) : super
     end
 
-    def submit!
-      submissions.each { |s| s.submit! }
-    end
-
     def submit
-      submissions.each { |s| s.submit }
+      result = true
+      submissions.each { |s| result && s.submit }
+      result
     end
 
     def persisted?

data/lib/dyna_form/submission.rb

@@ -7,23 +7,16 @@ module DynaForm
       @attributes = attributes.clone
     end    
 
-    def submit!
-      submit_helper(true)
-    end
-
     def submit
-      submit_helper(false)
-    end
-
-    private
-
-    def submit_helper(dangerous)
       attrs = @attributes.select { |k, _| @variables.include?(k.to_sym) }
 
       class_name = @model
-      dangerous ? Kernel.const_get(class_name).create!(attrs) : Kernel.const_get(class_name).create(attrs)  
+      new_object = Kernel.const_get(class_name).new(attrs)
+      new_object.save
     end
 
+    private
+
     def parse_model(model)
       str_model = model.to_s
       words = str_model.split("_")

data/lib/dyna_form/version.rb

@@ -1,3 +1,3 @@
 module DynaForm
-  VERSION = "0.1.0"
+  VERSION = "0.1.3"
 end

data/spec/dyna_form/submission_spec.rb

@@ -44,7 +44,7 @@ describe DynaForm::Submission do
         attrs = { :first_name => "Who", :last_name => "Cares" }
 
         expect(Kernel).to receive(:const_get).with("AdminUser").and_return(hypo_object)
-        expect(hypo_object).to receive(:create).with(attrs).and_raise("User created")
+        expect(hypo_object).to receive(:new).with(attrs).and_raise("User created")
 
         submission = DynaForm::Submission.new(AdminUser, variables, attributes)
         expect { submission.submit }.to raise_error("User created")

metadata

@@ -1,7 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: dyna_form
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.3
+  prerelease: 
 platform: ruby
 authors:
 - Willux
@@ -13,71 +14,81 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 3.0.0
 description: We want to avoid nested forms while creating a form based on some object.
@@ -89,8 +100,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
+- .gitignore
+- .rspec
+- CHANGELOG
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -111,26 +123,27 @@ files:
 homepage: ''
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: A gem used to help delegate form fields to their respective models.
 test_files:
 - spec/dyna_form/base_spec.rb
@@ -139,3 +152,4 @@ test_files:
 - spec/support/admin_user.rb
 - spec/support/test_form.rb
 - spec/support/test_form_again.rb
+has_rdoc: 

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: ebe2e3f52047f575f890cb82eac1285e34c80d6f
-  data.tar.gz: 307dd2232cbfda97c6ef3dbe723f57135b697a8a
-SHA512:
-  metadata.gz: ccbbb29668da0e8dae6fbeeed2522157d6193ae10935409a11f33c327a61689e32d4d8f68a353de4ac9c512f83e6d56e68c87cf97538010cb9ec45b65ced66c0
-  data.tar.gz: 00400aba310c964d9269fe2bb7bc6ca2359f26701c14406fece26fa7f4251fa569b088409d785aa649e2d2c35fe45961be114c46c152fd0d68a264820dcae8cd