dwh 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d91ce7dc2866f584744c0636918a6e4d5a2d189d3356b08fcee2b60ee40b5317
-  data.tar.gz: 51e0c508c1a77e5302493868a3e493547ec00fc022195a1b31f581b49abb843b
+  metadata.gz: fd8f7098719fc4a93610c3295a6bcbbf14e8487f07cb8dec86c9b95df7805b4e
+  data.tar.gz: a18967ab069c582d12bd3eaaa7d97f5242e3380c9f348e1fd2809da4c82ace88
 SHA512:
-  metadata.gz: 1ac97b11067710faab814ff16f4e17e46ffa70acc7281e3c45c86e32861feb5eb7207d9f372f29849bc7453f891241c5715624024fc82f5d660d098d812990e5
-  data.tar.gz: 2aa0820ef26779facc52dc41797403930ebb39186fc0eb81146b310395e8a0052c2d23c1468ee3991ec901204cd9d4f1ce079cf1d86d2c69c7a6616a07b2093e
+  metadata.gz: 27599ae5ac8ddd1db8fddf7d9714318eb36f98cb66ff73ed71026dddb0ab4f97e8f2f060dde216e6217485b1627cdc5ce7031254aca92da20395334a61d9bb57
+  data.tar.gz: a560342b601b038bd8e1d6d30708822433b09d83bef6094a3a1839e5cd0b09dae4bdbffce45e945f43ec1b6fc6e894e1def9d1c3d2a4c76d38a6a2c7cac3f3b6

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 ## [Unreleased]
 
+## [0.5.1] - 2026-08-03
+
+### Fixed
+
+- **Factory#shutdown**: `case pool.class` never matched (every call fell into `else`); undefined `c` NameError when closing live connections; symbol branch called `delete` on the pool instead of the map. Shutdown now matches on the argument, removes the map entry before closing, and tolerates unknown names.
+- **Factory#pool**: check-then-set race could orphan a pool under concurrent first-use; creation is now mutex-guarded.
+- **Factory#start_reaper**: no longer checks out a connection just to log stats (which created connections and reset idle clocks); Idle/Available labels use `pool.idle` / `pool.available`; iterates a snapshot; rescues `PoolShuttingDownError` per pool so a retired pool cannot kill the reaper thread.
+- **DuckDb#close**: use `@connection&.disconnect` so closing an already-closed adapter does not open a new connection.
+- **DuckDb.close_all**: close then clear instead of deleting while iterating (which could skip entries).
+
 ## [0.5.0] - 2026-06-19
 
 ### Added

data/README.md

@@ -33,11 +33,11 @@ The adapter only has 5 core methods (6 including the connection method).  A YAML
 - **PostgreSQL** - Full-featured RDBMS with advanced SQL support
 - **MySQL** - Popular open-source database
 - **SQL Server** - Microsoft's enterprise database
+- **ClickHouse** - High performance analytical database
+- **Databricks** - Lakehouse SQL warehouse
 
 ## Integrations Coming Soon
 
-- **ClickHouse** - High performance analytical db
-- **Databricks** - Big data compute engine
 - **MotherDuck** - Hosted DuckDB service
 
 ## Quick Start
@@ -137,4 +137,4 @@ This project is available as open source under the terms of the MIT License.
 
 ## Version
 
-Current version: 0.1.0
+Current version: 0.5.0

data/lib/dwh/adapters/duck_db.rb

@@ -56,10 +56,9 @@ module DWH
       # we open one instance but many connections. Use this
       # method to close them all.
       def self.close_all
-        databases.each do |key, db|
-          db.close
-          databases.delete(key)
-        end
+        # Iterate values then clear — mutating the hash while each-ing skips entries.
+        databases.each_value(&:close)
+        databases.clear
       end
 
       # This disconnects the current connection but
@@ -68,7 +67,9 @@ module DWH
       #
       # (see Adapter#close)
       def close
-        connection.disconnect
+        # Use @connection directly: #connection opens a new handle when nil,
+        # which would re-open just to close.
+        @connection&.disconnect
         @connection = nil
       end
 

data/lib/dwh/factory.rb

@@ -46,6 +46,11 @@ module DWH
       @pools ||= {}
     end
 
+    # Mutex guarding pool creation / map mutation.
+    def pool_mutex
+      @pool_mutex ||= Mutex.new
+    end
+
     # The canonical way of creating an adapter instance
     # in DWH.
     # @param adapter_name [String, Symbol]
@@ -64,62 +69,80 @@ module DWH
     # Create a pool of connections for a given name and adapter.
     # Returns existing pool if it was already created.
     #
-    # @param name [String] custom name for your pool
+    # @param name [String, Symbol] custom name for your pool (stored as String)
     # @param adapter_name [String, Symbol]
     # @param config [Hash] connection options
     # @param timeout [Integer] pool checkout time out
     # @param size [Integer] size of the pool
     def pool(name, adapter_name, config, timeout: 5, size: 10)
-      if pools.key?(name)
-        pools[name]
-      else
-        pools[name] = ConnectionPool.new(size: size, timeout: timeout) do
-          create(adapter_name, config)
+      name = name.to_s
+      pool_mutex.synchronize do
+        if pools.key?(name)
+          pools[name]
+        else
+          pools[name] = ConnectionPool.new(size: size, timeout: timeout) do
+            create(adapter_name, config)
+          end
         end
       end
     end
 
     # Shutdown a specific pool or all pools
-    # @param pool [String, ConnectionPool, nil] pool or name of pool
+    # @param pool [String, Symbol, ConnectionPool, nil] pool or name of pool
     #   or nil to shut everything down
     def shutdown(pool = nil)
-      case pool.class
-      when String
-        pools[pool].shutdown { it.close }
-        pools.delete(pool)
-      when Symbol
-        pools[pool.to_s].shutdown { it.close }
-        pools[pool.to_s].delete
-      when ConnectionPool
-        pool.shutdown { it.close }
-        pools.delete(pools.key(pool))
-      else
-        pools.each_value do |val|
-          val.shutdown { c.close }
+      # Mutate the map under the same mutex as pool creation so a concurrent
+      # create cannot be orphaned by @pools = {} / delete racing it.
+      # Close outside the lock — ConnectionPool#shutdown can wait on check-in.
+      to_close = pool_mutex.synchronize do
+        case pool
+        when String, Symbol
+          # Delete first so a raising close cannot leave a dead pool in the map.
+          removed = pools.delete(pool.to_s)
+          removed ? [removed] : []
+        when ConnectionPool
+          key = pools.key(pool)
+          pools.delete(key) if key
+          [pool]
+        else
+          closing = pools.values
+          @pools = {}
+          closing
         end
-        @pools = {}
       end
+      to_close.each { |p| p.shutdown { it.close } }
     end
 
     # Start reaper that will periodically clean up
     # unused or idle connections.
     # @param frequency [Integer] defaults to 300 seconds
+    # @return [Thread] the reaper thread
     def start_reaper(frequency = 300)
       logger.info 'Starting DB Adapter reaper process'
       Thread.new do
         loop do
-          pools.each do |name, pool|
-            logger.info "DB POOL FOR #{name} STATS:"
-            pool.with do
-              logger.info "\tSize:      #{pool.size}"
-              logger.info "\tIdle:      #{pool.available}"
-              logger.info "\tAvailable: #{pool.available}"
-            end
-            pool.reap(frequency) { it.close }
-          end
+          reaper_tick(frequency)
           sleep frequency
         end
       end
     end
+
+    # One reaper cycle: log pool stats (without checking out) and reap idle connections.
+    # Safe to call from tests; rescues per-pool so a shut-down pool cannot kill the loop.
+    # @param frequency [Integer] idle threshold passed to ConnectionPool#reap
+    def reaper_tick(frequency = 300)
+      # Snapshot so concurrent shutdown deletions do not mutate while we iterate.
+      pools.to_a.each do |name, pool|
+        logger.info "DB POOL FOR #{name} STATS:"
+        logger.info "\tSize:      #{pool.size}"
+        logger.info "\tIdle:      #{pool.idle}"
+        logger.info "\tAvailable: #{pool.available}"
+        pool.reap(frequency) { it.close }
+      rescue ConnectionPool::PoolShuttingDownError => e
+        logger.info "Skipping reaper for pool #{name}: #{e.class}"
+      rescue StandardError => e
+        logger.error "Reaper error for pool #{name}: #{e.class}: #{e.message}"
+      end
+    end
   end
 end

data/lib/dwh/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DWH
-  VERSION = '0.5.0'
+  VERSION = '0.5.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dwh
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Ajo Abraham