duty_calculator 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5ed8beb4c4232821afa3d6f8be62dd98ed3b179f
-  data.tar.gz: ec47b5f65e53b2be578322d7bf25d04737692c7f
+  metadata.gz: da4d51bf8a977b247e81ccc0e740f83e6d32a513
+  data.tar.gz: ad9381a27607fb9e63ab1d388ad5c2fba5fd05c8
 SHA512:
-  metadata.gz: 69ae696b897280cf5a2376a8a06fc87d7b784d87bd0acb3d59ec073af2ccd9668e134a38d1cce1d8e6edebda096ecc073a97be17375077e4fb40224ab3b67865
-  data.tar.gz: 88dbb06e724660c0ee0285cf651e13a3caf633f4f7fec2c18a8253918022a11c8a0df29d57e11e61d9d42ce2e849b318b5c50092593268f0351bcab96e63df39
+  metadata.gz: dbc1d596554960cc2c69d812de23aa99cdd4197a13652028f61af8a7d99057c7444cb56ad69f3bc2eee424233f36282fd74d6ccc7bdf5d32351dec1fd82b5f5c
+  data.tar.gz: f1531aff60374c32f2769ca52094464bbc5eb331e8c3d65a5a5de3372c848bdf239d168e340c6819bf4541f6e25f6f9e0afa2d352d90e1a0e3dde83a0490757a

data/duty_calculator.gemspec

@@ -6,8 +6,8 @@ require 'duty_calculator/version'
 Gem::Specification.new do |spec|
   spec.name          = "duty_calculator"
   spec.version       = DutyCalculator::VERSION
-  spec.authors       = ["Thomas Hanley"]
-  spec.email         = ["tom@walkerandcompany.com"]
+  spec.authors       = ["Thomas Hanley", "Rachel Heaton"]
+  spec.email         = ["tom@walkerandcompany.com", "rachel@walkerandcompany.com"]
   spec.summary       = %q{Wrapper for dutycalculator.com}
   spec.description   = %q{API documentation http://www.dutycalculator.com/api-center/dutycalculator-api-2-1-documentation/}
   spec.homepage      = "https://github.com/tjhanley/duty-calculator"

data/lib/duty_calculator/calculation.rb

@@ -16,26 +16,32 @@ module DutyCalculator
         raise ArgumentError, "Missing arguments from hash #{msg.to_s}" if msg.size >= 1
         return params
       end
-    end
 
-    def self.get(params={})
-      qs = params.collect do |k,v|
-            if v.kind_of?(Array)
-              memo = ""
-              v.each_with_index do |value, index|
-                memo << "#{k}[#{index}]=#{value}"
-                memo << "&" if v.size > (index+1)
-              end
-              memo
-            else
-              "#{k}=#{v}"
+      def transform_params(params)
+        params.inject({}) do |transformed, key_value|
+          k = key_value.first
+          v = key_value.last
+          if v.kind_of?(Array)
+            transformed[k] = {}
+            v.each_with_index do |value, index|
+              transformed[k][index] = value
             end
+          else
+            transformed[k] = v
           end
+          transformed
+        end
+      end
+    end
+
+    def self.get(params={})
+      transformed_params = transform_params(validate_params(params))
       conn = DutyCalculator::Client.new
-      resp = conn.get "#{DutyCalculator::Client.api_base}/calculation?#{qs.join('&')}"
+      resp = conn.get "#{DutyCalculator::Client.api_base}/calculation", transformed_params
       raise Exception, "Duty Calculator Error: #{DutyCalculator::ErrorMessages.for_code(resp.body["error"]["code"])}" if resp.body["error"]
       raise Exception, "HTTP Status Code #{resp.status}" if resp.status.to_i != 200
       return resp.body
     end
+
   end
 end

data/lib/duty_calculator/client.rb

@@ -6,8 +6,6 @@ module DutyCalculator
         # middleware
         faraday.use FaradayMiddleware::FollowRedirects
         faraday.use FaradayMiddleware::EncodeJson
-        # request defs
-        faraday.use Faraday::Request::UrlEncoded
         # response defs
         faraday.use Faraday::Response::ParseXml
         faraday.use Faraday::Response::Mashify

data/lib/duty_calculator/version.rb

@@ -1,3 +1,3 @@
 module DutyCalculator
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/duty_calculator/calculation_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+module DutyCalculator
+  describe Configuration do
+    describe ".transform_params" do
+      context "for a single product" do
+        let(:params) do
+          {
+            from: "US",
+            to: "CA",
+            shipping_mode: "USPS",
+            insurance: 0.0,
+            currency: "USD",
+            cat: [ "1234.00" ],
+            hs: [ "CA" ],
+            sku: [ "300101" ],
+            qty: [ 1 ]
+          }
+        end
+
+        it "makes a hash with numerical index keys for array values" do
+          transformed = DutyCalculator::Calculation.transform_params(params)
+
+          expect(transformed["from"]).to eq(params[:from])
+          expect(transformed["cat"]).to eq({ 0 => params[:cat].first })
+        end
+      end
+
+      context "for multiple products" do
+        let(:params) do
+          {
+            from: "US",
+            to: "CA",
+            shipping_mode: "USPS",
+            insurance: 0.0,
+            currency: "USD",
+            cat: [ "1234.00", "5678.00" ],
+            hs: [ "CA", "CA" ],
+            sku: [ "300101", "300102" ],
+            qty: [ 1, 2 ]
+          }
+        end
+
+        it "makes a hash with numerical index keys for array values" do
+          transformed = DutyCalculator::Calculation.transform_params(params)
+
+          expect(transformed["from"]).to eq(params[:from])
+          expect(transformed["cat"]).to eq({ 0 => params[:cat].first, 1 => params[:cat].last })
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: duty_calculator
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Thomas Hanley
+- Rachel Heaton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-11 00:00:00.000000000 Z
+date: 2015-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -111,6 +112,7 @@ dependencies:
 description: API documentation http://www.dutycalculator.com/api-center/dutycalculator-api-2-1-documentation/
 email:
 - tom@walkerandcompany.com
+- rachel@walkerandcompany.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -132,6 +134,7 @@ files:
 - lib/duty_calculator/currency.rb
 - lib/duty_calculator/error_messages.rb
 - lib/duty_calculator/version.rb
+- spec/duty_calculator/calculation_spec.rb
 - spec/duty_calculator/configuration_spec.rb
 - spec/duty_calculator/currency_spec.rb
 - spec/spec_helper.rb
@@ -160,6 +163,7 @@ signing_key:
 specification_version: 4
 summary: Wrapper for dutycalculator.com
 test_files:
+- spec/duty_calculator/calculation_spec.rb
 - spec/duty_calculator/configuration_spec.rb
 - spec/duty_calculator/currency_spec.rb
 - spec/spec_helper.rb