durl-rails 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c35976a924894217ab9f42710a3bdfda50c0a2a6
-  data.tar.gz: ab0114a5ee3ec0738b44cf71cc4cf5453e6bac54
+  metadata.gz: 58a2b99266d6c01152bc1a1aa514a3d44fc42d83
+  data.tar.gz: a0e2672b679e6985f945f22aa532eb746ec83d5d
 SHA512:
-  metadata.gz: eb96535badd1f389ccb451787bc6e89bfaabdc6534c0a6e00bbd7e3085c0082066da64ca9da936b6d841f3d3a97d64783dd35940a242113043b7cba96b72436e
-  data.tar.gz: a4243ae9d30727c85047c2030c7a456e12f8a7e21f2b6eb143ec4888991d22c92728906ee055b112c2411ed21720f589d067598eb5d037f6b02dcbdb7ca41a21
+  metadata.gz: 94f0f6fedcf96c1cce2f0d520b82ea685e0f52a779eaf66d7c12ddafd64b30617972970c914941bfff29fab254b34e405981b39e009f7e27f8235b8cc1ddd072
+  data.tar.gz: 5bd5ede616cf00ad0b76d2c5f80355c93458188dc7dfd7c021bf7f062afae44b59ad76bbb7910b654dcc0ddc18864a2fe70410607d30929e00a74e2db15952e7

data/README.md

@@ -50,7 +50,8 @@ You're done!
 
 ## Contributing
 
-Feel free to open an issue ticket if you find something that could be improved. 
+If the NPM DURL library changes, run rake update_durl and commit.
+It will pull from source the latest version of DURL and will also bump the version of this gem.
 
 ## Acknowledgements
 

data/VERSIONS.md

@@ -3,3 +3,4 @@
 | Gem    | dURL   |
 |--------|--------|
 | 1.0.0  | 1.0.5  |
+| 1.0.1  | 1.0.6  |

data/lib/durl/rails/version.rb

@@ -1,6 +1,6 @@
 module Durl
   module Rails
-    VERSION = "1.0.0"
-    DURL_VERSION = "1.0.5"
+    VERSION = "1.0.1"
+    DURL_VERSION = "1.0.6"
   end
 end

data/vendor/assets/javascripts/durl.js

@@ -1,6 +1,6 @@
 /*
  * File: durl.js
- * Version: 1.0.5
+ * Version: 1.0.6
  * Desc: DURL keeps your i-frame's Deep URL stored in the hash fragment of your parent page
  * Doc: https://github.com/tkasten/durl
  * Author: Tyler Kasten tyler.kasten@gmail.com
@@ -51,37 +51,37 @@ Durl.prototype.bootAsConsumer = function(){
 }
 
 Durl.prototype.matchDeepPath = function(path) {
-  /**
-    *
-    * DURL will store its durl (deep url) in the consumer's hash fragment in the
-    * form of `this.deep_url_var_name=url_encoded_url`
-    * 
-    * But we don't know how the consumer is using their hash fragment so we try
-    * to make safe, unobtrusive assumptions about how to integrate our data into
-    * their fragment. Consider the following potential use cases on their end:
-    *
-    * TKK TODO - spec these cases (also need more cases/clean-up etc)...
-    *
-    * Hash Bang style followed with traditional path and url variables
-    * www.example.com/page/path?var1=stuff#!/some/path?p1=v1&durl=value!&p2=v2z
-    * www.example.com/page/path?var1=stuff#!/some/path?p1=v1&durl=value!
-    *
-    * Same as above case but no consumer variables mixed with durl
-    * www.example.com/page/path?vars=stuff#!/some/path?durl=value!
-    *
-    * No Bang(!) just right into the variables
-    * www.example.com/page/path#?p1=v2&durl=value!
-    *
-    * Same as above but no consumer variables mixed with durl
-    * www.example.com/page/path#?durl=value!
-    *
-    */
-
   pattern = new RegExp("(\\?|&)" + this.deep_url_var_name + "=([^&\n]*)")
   return pattern.exec(this.vanillaHash()) || '' // [whole match, joiner, url]
 }
 
 Durl.prototype.setDURL = function(new_url) {
+/**
+  *
+  * DURL will store its durl (deep url) in the consumer's hash fragment in the
+  * form of `this.deep_url_var_name=url_encoded_url`
+  * 
+  * But we don't know how the consumer is using their hash fragment so we try
+  * to make safe, unobtrusive assumptions about how to integrate our data into
+  * their fragment. Consider the following potential use cases on their end:
+  *
+  * TKK TODO - spec these cases (also need more cases/clean-up etc)...
+  *
+  * Hash Bang style followed with traditional path and url variables
+  * www.example.com/page/path?var1=stuff#!/some/path?p1=v1&durl=value!&p2=v2z
+  * www.example.com/page/path?var1=stuff#!/some/path?p1=v1&durl=value!
+  *
+  * Same as above case but no consumer variables mixed with durl
+  * www.example.com/page/path?vars=stuff#!/some/path?durl=value!
+  *
+  * No Bang(!) just right into the variables
+  * www.example.com/page/path#?p1=v2&durl=value!
+  *
+  * Same as above but no consumer variables mixed with durl
+  * www.example.com/page/path#?durl=value!
+  *
+  */
+
   new_url = new_url || ''
   hash = this.vanillaHash()
 
@@ -97,9 +97,35 @@ Durl.prototype.setDURL = function(new_url) {
     hash += hash.indexOf('?') == -1 ? '?' : '&'
     hash += this.deep_url_var_name + "=" + new_url
   }
-
   this.log('replacing location: ' + hash)
-  location.replace('#' + hash)
+  // the following would be ideal but `history` object isn't supported < IE11
+  // history.replaceState(undefined, undefined, "#hash_value")
+
+  // so I did this instead...
+
+  // location.replace('#' + hash)
+
+  // That worked great. No new history transaction or page navigation event.
+  // However if the document has a silly base tag in it like:
+
+  // <base href="http://example.com/">
+
+  // Then this approach behaves as if you said:
+
+  // location.replace('example.com/#hash_value_here')
+
+  // That's cool if you're actually sitting on example.com/, but if you at
+  // a path like example.com/some/page and you:
+
+  // location.replace('#' + hash)
+
+  // it navigate off to that base url plus the hash fragment.
+
+  // This seem obvious when you read it here, but is was a nasty gotcha
+  // if your consumer sets the damned 'base' tag.
+
+  // So anyways, here we just force it to stay local like this:
+  location.replace(window.location.pathname + '#' + hash)
 }
 
 Durl.prototype.getDeepPath = function() {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: durl-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Tyler Kasten
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-06 00:00:00.000000000 Z
+date: 2017-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -92,7 +92,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: durl-rails
-rubygems_version: 2.4.6
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Use dURL with Rails 3+