dupe 0.4.0 → 0.4.1

data/lib/dupe/mock.rb

@@ -3,6 +3,8 @@ class Dupe
     class Mock #:nodoc:
       include Dupe::Network::RestValidation
       
+      class ResourceNotFoundError < StandardError; end
+      
       attr_reader :verb
       attr_reader :url_pattern
       attr_reader :response
@@ -27,17 +29,23 @@ class Dupe
       def mocked_response(url)
         raise(
           StandardError, 
-          "Tried to mock a response to a non-matched url! This should never occur."
+          "Tried to mock a response to a non-matched url! This should never occur. My pattern: #{@url_pattern}. Url: #{url}"
         ) unless match?(url)
       
         grouped_results = url_pattern.match(url)[1..-1]
         resp = @response.call *grouped_results
       
         case resp
+          when NilClass
+            raise ResourceNotFoundError, "Failed with 404: the request '#{url}' returned nil." 
           when Dupe::Database::Record
             resp = resp.to_xml(:root => resp.__model__.name.to_s)
           when Array
-            resp = resp.to_xml(:root => resp.first.__model__.name.to_s.pluralize)
+            if resp.empty?
+              resp = [].to_xml :root => 'results'
+            else
+              resp = resp.to_xml(:root => resp.first.__model__.name.to_s.pluralize)
+            end
         end
         
         Dupe.network.log.add_request @verb, url, resp

data/spec/lib_specs/mock_spec.rb

@@ -42,13 +42,19 @@ describe Dupe::Network::Mock do
   end
   
   describe "mocked_response" do
-    describe "on a mock object whose response returns a Dupe.find" do
+    describe "on a mock object whose response returns a Dupe.find with actual results" do
       it "should convert the response result to xml" do
         url_pattern = %r{/books/(\d+)\.xml}
         response = proc {|id| Dupe.find(:book) {|b| b.id == id.to_i}}
         book = Dupe.create :book
         mock = Dupe::Network::Mock.new :get, url_pattern, response
         mock.mocked_response('/books/1.xml').should == book.to_xml(:root => 'book')
+        
+        proc { mock.mocked_response('/books/2.xml') }.should raise_error(Dupe::Network::Mock::ResourceNotFoundError)
+        
+        Dupe.define :author
+        mock = Dupe::Network::Mock.new :get, %r{/authors\.xml$}, proc {Dupe.find :authors}
+        mock.mocked_response('/authors.xml').should == [].to_xml(:root => 'results')
       end
       
       it "should add a request to the Dupe::Network#log" do
@@ -61,6 +67,48 @@ describe Dupe::Network::Mock do
         Dupe.network.log.requests.length.should == 1
       end
     end
+    
+    describe "on a mock object whose response returns nil" do
+      it "should raise an error" do
+        url_pattern = %r{/authors/(\d+)\.xml}
+        response = proc { |id| Dupe.find(:author) {|a| a.id == id.to_i}}
+        Dupe.define :author
+        mock = Dupe::Network::Mock.new :get, url_pattern, response
+        proc {mock.mocked_response('/authors/1.xml')}.should raise_error(Dupe::Network::Mock::ResourceNotFoundError)
+      end
+    end
+    
+    describe "on a mock object whose response returns an empty array" do
+      it "should convert the empty array to an xml array record set with root 'results'" do        
+        Dupe.define :author
+        mock = Dupe::Network::Mock.new :get, %r{/authors\.xml$}, proc {Dupe.find :authors}
+        mock.mocked_response('/authors.xml').should == [].to_xml(:root => 'results')
+      end
+      
+      it "should add a request to the Dupe::Network#log" do
+        Dupe.define :author
+        mock = Dupe::Network::Mock.new :get, %r{/authors\.xml$}, proc {Dupe.find :authors}
+        Dupe.network.log.requests.length.should == 0
+        mock.mocked_response('/authors.xml')
+        Dupe.network.log.requests.length.should == 1
+      end
+    end
+    
+    describe "on a mock object whose response returns an array of duped records" do
+      it "should convert the array to xml" do        
+        Dupe.create :author  
+        mock = Dupe::Network::Mock.new :get, %r{/authors\.xml$}, proc {Dupe.find :authors}
+        mock.mocked_response('/authors.xml').should == Dupe.find(:authors).to_xml(:root => 'authors')
+      end
+      
+      it "should add a request to the Dupe::Network#log" do
+        Dupe.create :author
+        mock = Dupe::Network::Mock.new :get, %r{/authors\.xml$}, proc {Dupe.find :authors}
+        Dupe.network.log.requests.length.should == 0
+        mock.mocked_response('/authors.xml')
+        Dupe.network.log.requests.length.should == 1
+      end
+    end    
   end
   
   

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: dupe
 version: !ruby/object:Gem::Version 
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors: 
 - Matt Parker
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-12-30 00:00:00 -05:00
+date: 2010-01-01 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency