dumped_railers 0.3.1 → 0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cbb1709558461827585966be0f48b9741555fc9d70cd22a6c7970cb22260e6a6
-  data.tar.gz: f4db2cebc825ff52aeda68f2e06e466dd16663172e4b76289347374e35b046d4
+  metadata.gz: 5025d07432c51021973eb7064be24d2a1cacbff2a31919c87341bc2f6a71693d
+  data.tar.gz: bbd212538475cda7a08278da201e151acbd13bfe8f05dd3558d257f485217ad2
 SHA512:
-  metadata.gz: 51ddf56172e72afb4977cb899be013ac6678627905df7e90b6dc147b2afcfd0b2b6c9cd010e8a9a500dd9aa48ccc2a0ff70cf82fc02778fa7ef505f0d8df7f52
-  data.tar.gz: 24ee1c963fb89cb99dfcb2064c3d77e0e626525a14452e362aa12aeb9dd9f5f6409feb5c44a8f53ecb91d1eacd92f4793c8ab440714b1177a24d4d573048e7f0
+  metadata.gz: 02f2ac6903602017cf440ba1c7431922dc600880665d4768da022031b62806673bae06d4a66bd6d134cab7a3e002734b453c76f838a0f256454094de3166eed4
+  data.tar.gz: 9d6d3ea246624629e0b1a24bd42ab301623e1fefe6699cb009b1558fed0e878c47fd41288c31ef5ca6e62fbb51e254cc57b71a0d139aad2f631063d6c541fe09

data/CHANGELOG.md

@@ -44,6 +44,13 @@
 ### Added
 - Support `before_save`/`after_save` callbacks with import! method. The callbacks are invoked just before (or after) each table's records are saved.
 
-## [0.3.0]
+## [0.3.1]
 ### Added
 - Accept multiple (array) callbacks for `before_save` / `after_save` arguments with DumpedRailers.import!.
+
+## [0.4.0]
+### Changed
+- **BREAKING** preprocessor interface has changed so as that its API have consistency with that of callbacks.
+  - Preprocessors now require arguments (`model`, `attributes`) in this order. Before version < 0.4, it was (`attributes`, `model`)
+  - Attributes needs to be updated destructively within preprocessors. Return values are no longer required reflect the changes.
+

data/README.md

@@ -103,15 +103,15 @@ end
 DumpedRailers.dump!(User, Item, base_dir: 'tmp/', preprocessors: [MaskingPreprocessor.new])
 ```
 
-* "Preprocessors" can be lambda, or module, or any objects that can repond to #call(atrs, model).
+* "Preprocessors" can be lambda, or module, or any objects that can repond to #call(model, attributes).
 
 
 ```ruby
 class MaskingPreprocessor
-  def call(attrs, model)
-    attrs.map { |col, value|
-      col.match?(/password/) ? [col, '<MASKED>'] : [col, value]
-    }.to_h
+  def call(model, attrs)
+    attrs.each { |col, _value|
+      attrs[col] = '<MASKED>' if col.match?(/password/)
+    }
   end
 end
 ```
@@ -119,10 +119,12 @@ end
 * a lambda object can be accepted as well
 
 ```ruby
-masking_preprocessor = -> (attrs, model) { attrs.transform_values(&:upcase) }
+masking_preprocessor = -> (model, attrs) { attrs.transform_values!(&:upcase) }
 ```
 
-NOTE: The proprocessors must return attributes in the same format `{ attributes_name: value }` so that preprocessors and dump handlers can preprocessors in nested manner.
+NOTE:
+* In order to reflect changes to the output, **preprocessors must change the attributes destructively**.
+* If you set multiple preprocessors, each preprocessor will be invoked sequentially from left to right, which means your second preprocessor receives attributes only after your first preprocessor update them.
 
 ### Limiting Import with Authorized Models Only
 

data/gemfiles/Gemfile.rails_6.1

@@ -1,6 +1,6 @@
 source "https://rubygems.org"
 
 # Specify your gem's dependencies in dumped_railers.gemspec
-gem 'activerecord', '6.1.0'
+gem 'activerecord', '6.1.1'
 
 gemspec path: '../'

data/lib/dumped_railers/fixture_builder/record.rb

@@ -11,11 +11,11 @@ module DumpedRailers
 
       def build!
         id = @record.id
-        attributes = 
-          @preprocessors.inject(@record.attributes) { |attrs, preprocessor|
-            preprocessor.call(attrs, @model)
-          }
-  
+        attributes = @record.attributes.deep_dup
+        @preprocessors.each do |preprocessor|
+          preprocessor.call(@model, attributes)
+        end
+
         # convert "belong_to association" foreign keys into record-unique labels
         @model.reflect_on_all_associations.select(&:belongs_to?).each do |rel|
           # skip ignorables
@@ -39,15 +39,15 @@ module DumpedRailers
 
         [record_label_for(@model.name, id), attributes]
       end
-    
+
       private
-  
+
       def record_label_for(class_name, id, type=nil)
         return nil unless id
 
         identifier = "#{class_name.to_s.underscore}_#{id}"
         type_specifier = "(#{type})" if type
-  
+
         "__#{identifier}#{type_specifier}"
       end
     end

data/lib/dumped_railers/preprocessor/strip_ignorables.rb

@@ -7,8 +7,8 @@ module DumpedRailers
         @ignorable_columns = ignorable_columns.compact.map(&:to_s)
       end
 
-      def call(attributes, _model)
-        attributes.reject { |column_name, _v|
+      def call(_model, attributes)
+        attributes.delete_if { |column_name, _v|
           @ignorable_columns.include?(column_name)
         }
       end

data/lib/dumped_railers/version.rb

@@ -1,3 +1,3 @@
 module DumpedRailers
-  VERSION = '0.3.1'
+  VERSION = '0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dumped_railers
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: '0.4'
 platform: ruby
 authors:
 - Koji Onishi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-01-08 00:00:00.000000000 Z
+date: 2021-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler