duffel 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7d8b5557e0783d46497128c02928f779cbf1f7ff
-  data.tar.gz: a9babc104a73f8fdde5148f9fba5654c18fd9bf3
+  metadata.gz: f95bb4cf610f9be60c7dfe01671fa23158b8989c
+  data.tar.gz: 832e42fe8597aed4c2e611460059f224420de231
 SHA512:
-  metadata.gz: a80a022e07991c7ca4d8b80f5786f4e1ac1f1c20f0f60878b64a40b1b1312033b8dcf9e9c3f560fc0dc92e50cb23d987722354d725cd0f54c9be2f851acd39a3
-  data.tar.gz: c37a98a23cc8fcb6106333bbc6d1fb24af74d206d986e2d637054300176352b4aa72e3ef62ac6f190d7ca10be37f720bc27c9d9580eb1d2d8e4709eebad9d088
+  metadata.gz: eef9c610a64e30f2ca4af58a5fa8c0e0c502d9e79ce21faaa4e973255c2da291caebf1c2c4c2e0bd9ff1926e9ecf372b15742b21ddeb245cc2a0caffa00a3239
+  data.tar.gz: c7299ef2a77d0a88f002e29c9e8ba5bf135edbafe9104f46caf4d1f73ab6089e00740945bfdf7e86136d834c6f0869584cf5a903474b3da68cee360132922704

data/.travis.yml

@@ -1,6 +1,5 @@
 language: ruby
 rvm:
-  - 1.8.7
   - 1.9.2
   - 1.9.3
   - 2.0.0

data/README.md

@@ -1,6 +1,6 @@
 # Duffel
 
-Fetch your environment settings. Raise errors or set defaults when a setting does not exist.
+Fetch your environment variables. Raise errors or set defaults when a variable does not exist.
 
 ## Installation
 
@@ -60,7 +60,7 @@ Calling `Settings.env_variable_name` will still return you your environment vari
 
 I know.  
 
-### Why did you do it this way and not this [obviously better way]
+### Why did you do it this way and not [obviously better way]?
 
 Because I probably don't know the obviously better way. Feel free to submit a pull request or open an issue and I'll look into it!
 
@@ -68,7 +68,7 @@ Because I probably don't know the obviously better way. Feel free to submit a pu
 
 ## Contributing
 
-1. Fork it ( https://github.com/[my-github-username]/duffel/fork )
+1. Fork it ( https://github.com/ericroberts/duffel/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/duffel.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = Duffel::VERSION
   spec.authors       = ["Eric Roberts"]
   spec.email         = ["ericroberts@gmail.com"]
-  spec.summary       = "Fetch your environment settings."
-  spec.description   = "Fetch your environment settings. Raise errors or set defaults when a setting does not exist."
+  spec.summary       = "Fetch your environment variables."
+  spec.description   = "Fetch your environment variables. Raise errors or set defaults when a setting does not exist."
   spec.homepage      = "https://github.com/ericroberts/duffel"
   spec.license       = "MIT"
 

data/lib/duffel.rb

@@ -1,18 +1,34 @@
 class Duffel
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 
-  def self.method_missing(method, *args, &block)
-    fetch_default = lambda do |key|
-      raise KeyError.new("key not found: #{key}")
+  class << self
+
+    def method_missing(method, *args, &block)
+      define_singleton_method(method) do |options={}|
+        options ||= {}
+        return_value = options.fetch(:fallback, fetch_default)
+        fallback = format_return_value(return_value)
+
+        env_name = method.to_s.upcase
+        ENV.fetch(env_name, &fallback)
+      end
+      self.send(method, args.first)
     end
 
-    define_singleton_method(method) do |options=(args.first || {})|
-      return_value = options.fetch(:fallback, fetch_default)
-      fallback = return_value.is_a?(Proc) ? return_value : lambda { |key| return_value }
+  protected
+
+    def format_return_value(value)
+      if value.is_a?(Proc)
+        value
+      else
+        lambda { |_key| value }
+      end
+    end
 
-      env_name = method.to_s.upcase
-      ENV.fetch(env_name, &fallback)
+    def fetch_default
+      lambda do |key|
+        raise KeyError.new("key not found: #{key}")
+      end
     end
-    self.send(method)
   end
 end

data/spec/lib/duffel_spec.rb

@@ -1,6 +1,8 @@
 require 'duffel'
 
 describe Duffel do
+  subject { Duffel }
+
   it 'should not raise an error' do
     expect { subject }.to_not raise_error
   end
@@ -18,23 +20,81 @@ describe Duffel do
           ).to eq 'blah'
         end
 
+        it 'should be idempotent' do
+          expect(
+            subject.another_non_existing_method(:fallback => 'blah')
+          ).to eq 'blah'
+          expect(
+            subject.another_non_existing_method(:fallback => 'blah')
+          ).to eq 'blah'
+        end
+
+        it 'should allow a different fallback the next time it is called' do
+          expect(
+            subject.another_non_existing_method(:fallback => 'foo')
+          ).to eq 'foo'
+        end
+
+        it 'should allow nothing to be passed and to raise a key error' do
+          expect{
+            subject.another_non_existing_method
+          }.to raise_error KeyError
+        end
+
         context 'fallback is nil' do
           it 'should return nil' do
             expect(
               subject.yet_another_non_existing_method(:fallback => nil)
             ).to eq nil
           end
+
+          it 'should be idempotent' do
+            expect(
+              subject.yet_another_non_existing_method(:fallback => nil)
+            ).to eq nil
+            expect(
+              subject.yet_another_non_existing_method(:fallback => nil)
+            ).to eq nil
+          end
+
+          it 'should allow a different fallback the next time it is called' do
+            expect(
+              subject.yet_another_non_existing_method(:fallback => 'bar')
+            ).to eq 'bar'
+          end
+
+          it 'should allow nothing to be passed and to raise a key error' do
+            expect{
+              subject.yet_another_non_existing_method
+            }.to raise_error KeyError
+          end
         end
       end
     end
 
     context 'with a matching environment variable' do
-      before { expect(ENV).to receive(:fetch).with('AN_EXISTING_METHOD').and_return(response) }
+      before do
+        allow(ENV).to(
+          receive(:fetch).
+          with('AN_EXISTING_METHOD').
+          and_return(response)
+        )
+      end
+
       let(:response) { 'response' }
 
       it 'should return the env variable' do
         expect(subject.an_existing_method).to eq response
       end
+
+      it 'should be idempotent' do
+        expect(subject.an_existing_method).to eq response
+        expect(subject.an_existing_method).to eq response
+      end
+
+      it 'should not return the fallback when the env variable exists' do
+        expect(subject.an_existing_method(fallback: 'foo')).to eq response
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: duffel
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Eric Roberts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-10 00:00:00.000000000 Z
+date: 2014-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,7 +52,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-description: Fetch your environment settings. Raise errors or set defaults when a
+description: Fetch your environment variables. Raise errors or set defaults when a
   setting does not exist.
 email:
 - ericroberts@gmail.com
@@ -93,6 +93,6 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: Fetch your environment settings.
+summary: Fetch your environment variables.
 test_files:
 - spec/lib/duffel_spec.rb