ductwork 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd349349c33899f1c8cdcf97339176dd72fb6397df4dbccba7445946337810b1
-  data.tar.gz: 39560169d62cd46193221f6d74f00524b39314bc470787213f891260bcc5a3db
+  metadata.gz: 936ce40a67d02217db84222c1a30d002c2214b73585c04a05022ce91d87160a6
+  data.tar.gz: c87fc48ed8be92be080f4ecf7c1c58f33d09a532d6ff7ca8c9d99143e2f21dae
 SHA512:
-  metadata.gz: 62b5cc64d92c9b5caf225624bb51a252d550f48bbcbc4f5a73ffc19e464964477f41bceec74a654c783859890fcfab84305327abdf4685fa460ffbeb6e35fdff
-  data.tar.gz: 0d4483bcd3dce63092438c392cc6089f9b8ad9a8e5730cb133fbc7bacd22d0a82ff6afdabb285c447593afcc13979d3f74df3d57801861eb13815d91d5744a46
+  metadata.gz: 237854d56ac87c1552813541a1ef1d275db94fe16637b96ca7997ee7939a31a5d442b145851d1e25c49a37a4320a39421de338fb9260848c5b51f5d678efdf2a
+  data.tar.gz: 7c18082ff55ca438f2a9c7d5f0cb8932c5933d66462a43bb6a1637807d0dd301ec51190e432d84ec370b916e4b666fe93574b2cea38c260c60bddef8dbda7ab7

data/CHANGELOG-PRO.md

@@ -1,7 +1,15 @@
 # Ductwork Pro Changelog
 
-## [1.1.1] (Unreleased)
-
+## [1.1.1]
+
+- fix: use `Ductwork::DatabaseClock` instead of `Time.current` for every `started_at` Pro stamps, mirroring the OSS fix
+- fix: evaluate the step-timeout deadline in the database (`DatabaseClock.ago_sql`) instead of subtracting `attempt.started_at` from the worker's `Time.current`, so an NTP correction mid-job cannot stretch or collapse a step's timeout
+- fix: temporarily handle multiple return types from `Branch.with_latest_claimed` - this is a result of changes in OSS from v1.1.0 and v1.1.1
+- fix: log the claimed job/branch of a dead thread before the restart clears it
+- fix: add rubocop cop for ensuring `updated_at` is updated (copied from OSS)
+- fix: explicitly set `updated_at` for queries that update the record directly
+- fix: mirror OSS `halt_branch_and_resolve_run_without_rescue!` implementation
+- fix: walk the `collapse` fan-in with an explicit keyset scan so each batch is one indexed range seek, instead of a per-batch subquery plus a second `in_batches` query that re-ran the whole scope
 - fix: don't use `unique_by` argument for `insert_all` for mysql and trilogy database adapters
 
 ## [1.1.0]

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Ductwork Changelog
 
+## [1.1.2]
+
+- fix: lazily create configuration
+- fix: prevent step's idempotency key from returning `nil`
+
 ## [1.1.1]
 
 - fix: use database clock instead of `Time.current` to avoid clock skew in `Branch#latest_step` paths

data/lib/ductwork/engine.rb

@@ -20,7 +20,6 @@ module Ductwork
     end
 
     initializer "ductwork.configure" do
-      Ductwork.configuration ||= Ductwork::Configuration.new
       Ductwork.logger ||= Ductwork::Configuration::DEFAULT_LOGGER
     end
   end

data/lib/ductwork/models/execution.rb

@@ -29,7 +29,7 @@ module Ductwork
         job_klass: job.klass
       )
       args = JSON.parse(job.input_args)["args"]
-      instance = Object.const_get(job.klass).build_for_execution(job.step.run_id, *args)
+      instance = Object.const_get(job.klass).build_for_execution(job.step.run_id, job.step.id, *args)
       create_attempt!(started_at: Time.current)
       output_payload = nil
 

data/lib/ductwork/models/step.rb

@@ -40,23 +40,22 @@ module Ductwork
          converge: "converge",
          dampen: "dampen"
 
-    def self.build_for_execution(run_id, *, **)
+    def self.build_for_execution(run_id, idempotency_key, *, **)
       instance = allocate
       instance.instance_variable_set(:@run_id, run_id)
+      instance.instance_variable_set(:@idempotency_key, idempotency_key)
       instance.send(:initialize, *, **)
       instance
     end
 
-    alias_attribute :idempotency_key, :id
-
     def run_id
       @run_id || (@attributes && super)
     end
 
-    # The result_type of the most recent execution to finish for this step's
-    # job, used to distinguish *why* a step failed (e.g. `errored!` writes
-    # "failure", `crashed!` writes "process_crashed"). Returns nil when no
-    # execution has produced a result yet.
+    def idempotency_key
+      @idempotency_key || (@attributes && id)
+    end
+
     def terminal_result_type
       return if job.blank?
 

data/lib/ductwork/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ductwork
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/lib/ductwork.rb

@@ -11,8 +11,12 @@ require "zeitwerk"
 
 module Ductwork
   class << self
-    attr_accessor :app_executor, :configuration, :loader, :logger
-    attr_writer :defined_pipelines, :hooks
+    attr_accessor :app_executor, :loader, :logger
+    attr_writer :configuration, :defined_pipelines, :hooks
+
+    def configuration
+      @configuration ||= Ductwork::Configuration.new
+    end
 
     def eager_load
       loader.eager_load

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ductwork
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Tyler Ewing