ductwork 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10cf03c4f8237368de710c2ee604a9d20cf40c2dcebfda776fe490a38ba26aad
-  data.tar.gz: fd44065015e06a493905b493b847df2de01d779f7451662b186a458cb1cc9977
+  metadata.gz: 8ab7c6e79c26352d990680a3913a26ea8bd4bc9999136b4ee1a1846c06e74523
+  data.tar.gz: 7adb0603119c80d5edc54e94de44828bba2c927edad418e5944d594ba21f734a
 SHA512:
-  metadata.gz: 712b5f00ad1a1a1c736dd186f04dce4a85f2ba3d57df234a5d1182d91483530f0722c9a153e1a4f8517142657ffc8f486e39e6bcd51c28b66f4df5a5958e5455
-  data.tar.gz: 18c7d56494dc4251310e73bffe47c56e80820634dce555ac2e8d2d46b65973242adc621004dada1efa94cb353063ab650bcb833cec2c7d0cffd635727b808fa1
+  metadata.gz: 83be2952cf26ebbee28521df07b68ee29e87ade164a70a87ede7c7bcfc1ef5525097b1346757d76e34d4fc25535c5489f56900fa763006d923bd8491dcba520f
+  data.tar.gz: 53cabb6cdfa4f96f847ddc68818a3f0a87d59ca443282700eca5f690a8a01805e46dbd925990565630bb5c45dc728183de251629488d055f8062d136f06dff7e

data/CHANGELOG.md

@@ -1,10 +1,16 @@
 # Ductwork Changelog
 
+## [0.2.1]
+
+- fix: do not splat arguments when executing a job nor triggering a pipeline
+- fix: do not splat arguments when enqueuing a job and fix related spec
+- fix: add missing `dependent: :destroy` on certain associations
+
 ## [0.2.0]
 
-- fix: allow steps to be chained while pipeline is expanded or divided (before collapsing or combining) - before this incorrectly raised a `CollapseError` or `CombineError`
-- feat: validate argument(s) passed to step transition DSL methods to be valid step class
 - feat: validate all pipeline definitions on rails boot
+- feat: validate argument(s) passed to step transition DSL methods to be valid step class
+- fix: allow steps to be chained while pipeline is expanded or divided (before collapsing or combining) - before this incorrectly raised a `CollapseError` or `CombineError`
 
 ## [0.1.0]
 

data/README.md

@@ -75,7 +75,7 @@ class UsersRequiringEnrichment
 
   def execute
     ids = User.where("data_last_refreshed_at < ?", @days_outdated.days.ago).ids
-    Rails.logger.info("Enriching #{ids.length} users' data")
+    Ductwork.logger.info("Enriching #{ids.length} users' data")
 
     # Return value becomes input to the next step
     ids

data/app/models/ductwork/execution.rb

@@ -3,9 +3,9 @@
 module Ductwork
   class Execution < Ductwork::Record
     belongs_to :job, class_name: "Ductwork::Job"
-    has_one :availability, class_name: "Ductwork::Availability", foreign_key: "execution_id"
-    has_one :run, class_name: "Ductwork::Run", foreign_key: "execution_id"
-    has_one :result, class_name: "Ductwork::Result", foreign_key: "execution_id"
+    has_one :availability, class_name: "Ductwork::Availability", foreign_key: "execution_id", dependent: :destroy
+    has_one :run, class_name: "Ductwork::Run", foreign_key: "execution_id", dependent: :destroy
+    has_one :result, class_name: "Ductwork::Result", foreign_key: "execution_id", dependent: :destroy
 
     validates :retry_count, presence: true
     validates :started_at, presence: true

data/app/models/ductwork/job.rb

@@ -60,7 +60,7 @@ module Ductwork
       end
     end
 
-    def self.enqueue(step, *args)
+    def self.enqueue(step, args)
       Ductwork::Record.transaction do
         job = step.create_job!(
           klass: step.klass,
@@ -89,7 +89,7 @@ module Ductwork
         job_klass: klass
       )
       args = JSON.parse(input_args)["args"]
-      instance = Object.const_get(klass).new(*args)
+      instance = Object.const_get(klass).new(args)
       run = execution.create_run!(
         started_at: Time.current
       )

data/app/models/ductwork/pipeline.rb

@@ -48,7 +48,7 @@ module Ductwork
         Ductwork.defined_pipelines << name.to_s
       end
 
-      def trigger(*args)
+      def trigger(args)
         if pipeline_definition.nil?
           raise DefinitionError, "Pipeline must be defined before triggering"
         end
@@ -71,7 +71,7 @@ module Ductwork
             step_type: :start,
             started_at: Time.current
           )
-          Ductwork::Job.enqueue(step, *args)
+          Ductwork::Job.enqueue(step, args)
 
           pipeline
         end

data/app/models/ductwork/step.rb

@@ -3,7 +3,7 @@
 module Ductwork
   class Step < Ductwork::Record
     belongs_to :pipeline, class_name: "Ductwork::Pipeline"
-    has_one :job, class_name: "Ductwork::Job", foreign_key: "step_id"
+    has_one :job, class_name: "Ductwork::Job", foreign_key: "step_id", dependent: :destroy
 
     validates :klass, presence: true
     validates :status, presence: true

data/lib/ductwork/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ductwork
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ductwork
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Tyler Ewing