duck-hunt 0.0.6 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e83a3b44d7c09021e9473a718dbe41a359ca2e606cb4aeed705186c67f419ed0
-  data.tar.gz: a6963371ad99552cecb8b7a69f5a15d8bcade5115b14924e216b9b9dae26c5b6
+  metadata.gz: 75d1dd61f15a97d225e5c9536b1af5146983565c57ac7de01d1dac4c1b7b679b
+  data.tar.gz: cc7eb8aa77af9aa931ee5431da737415b407ae78eac74cfddb0ec79d5ecc3441
 SHA512:
-  metadata.gz: 021500d3fbb1bb1d22c5ec8579ec1d556a868f394e92684f8e5d3217308abfe28270b0d4669d36f6ecdedc204fa81e0143c0af9fe78ad3bd2eac5b8539158b15
-  data.tar.gz: 93f9948d65a24c6a6a2c4ffed665f7325bb7c09aa50c4ac53de25cdcc5f151d05d50e5329d55153dc95042d0bb4d187b9005bcc0fe57b4d2da5da9700937adec
+  metadata.gz: 351f223a9c7744958224e809aacaae26c87dc5e21489a29d55b41e5a0cd8c27870ff6716ad1f4b63353c93bf5f5b1bcfea707cbd97db8b2b9ba8a8df2aecc49e
+  data.tar.gz: d0c47052a4073c6133ec3c63967b25b29f1f7c185fa9906b4830fe15abf2e8c1b01eafdfecf943cf445b691b1d7a64378aa89fe34652192ff7d74b43a1018a4a

data/lib/duck-hunt/validators/greater_than.rb

@@ -8,7 +8,11 @@ module DuckHunt
       end
 
       def valid?(value)
-        return value > @value
+        if value.respond_to?(:length)
+          return value.length > @value
+        else
+          return value > @value
+        end
       end
 
       def error_message

data/lib/duck-hunt/validators/greater_than_or_equal_to.rb

@@ -8,7 +8,11 @@ module DuckHunt
       end
 
       def valid?(value)
-        return value >= @value
+        if value.respond_to?(:length)
+          return value.length >= @value
+        else
+          return value >= @value
+        end
       end
 
       def error_message

data/lib/duck-hunt/validators/less_than.rb

@@ -8,7 +8,11 @@ module DuckHunt
       end
 
       def valid?(value)
-        return value < @value
+        if value.respond_to?(:length)
+          return value.length < @value
+        else
+          return value < @value
+        end
       end
 
       def error_message

data/lib/duck-hunt/validators/less_than_or_equal_to.rb

@@ -8,7 +8,11 @@ module DuckHunt
       end
 
       def valid?(value)
-        return value <= @value
+        if value.respond_to?(:length)
+          return value.length <= @value
+        else
+          return value <= @value
+        end
       end
 
       def error_message

data/lib/duck-hunt/version.rb

@@ -1,3 +1,3 @@
 module DuckHunt
-  VERSION = "0.0.6"
+  VERSION = "0.1.0"
 end

data/test/properties/float_test.rb

@@ -13,7 +13,7 @@ describe DuckHunt::Properties::Float, "validation" do
   end
 
   it "should be able to validate a BigDecimal floating point" do
-    bigdecimal = BigDecimal.new("3.4")
+    bigdecimal = BigDecimal("3.4")
     bigdecimal.must_be_instance_of BigDecimal
     @property.valid?(bigdecimal).must_equal true
     @property.errors.size.must_equal 0

data/test/properties/integer_test.rb

@@ -39,7 +39,7 @@ describe DuckHunt::Properties::Integer, "validation" do
   end
 
   it "should not be able to parse a BigDecimal floating point" do
-    bigdecimal = BigDecimal.new("3.4")
+    bigdecimal = BigDecimal("3.4")
     bigdecimal.must_be_instance_of BigDecimal
     @property.valid?(bigdecimal).must_equal false
     @property.errors.size.must_equal 1

data/test/properties/numeric_test.rb

@@ -13,7 +13,7 @@ describe DuckHunt::Properties::Numeric, "validation" do
   end
 
   it "should be able to validate a BigDecimal floating point" do
-    bigdecimal = BigDecimal.new("3.4")
+    bigdecimal = BigDecimal("3.4")
     bigdecimal.must_be_instance_of BigDecimal
     @property.valid?(bigdecimal).must_equal true
     @property.errors.size.must_equal 0

data/test/validators/greater_than_or_equal_to_test.rb

@@ -30,6 +30,26 @@ describe DuckHunt::Validators::GreaterThanOrEqualTo, "Validation" do
 end
 
 
+describe DuckHunt::Validators::GreaterThanOrEqualTo, "Validation (length check)" do
+  before do
+    @validator = DuckHunt::Validators::GreaterThanOrEqualTo.new(3)
+  end
+
+  it "returns true if the value provided is greater than or equal to the value given" do
+    @validator.valid?("aaaa").must_equal true
+    @validator.valid?([1,2,3,4]).must_equal true
+    @validator.valid?({a: 1, b: 2, c: 3}).must_equal true
+  end
+
+  it "returns false if the value provided is less than the value given" do
+    @validator.valid?("aa").must_equal false
+    @validator.valid?([1,2]).must_equal false
+    @validator.valid?({a: 1, b: 2}).must_equal false
+    @validator.valid?({}).must_equal false
+    @validator.valid?("").must_equal false
+  end
+end
+
 
 describe DuckHunt::Validators::GreaterThanOrEqualTo, "error message" do
   it "should have the correct error message based on the value provided" do

data/test/validators/greater_than_test.rb

@@ -29,6 +29,25 @@ describe DuckHunt::Validators::GreaterThan, "Validation" do
   end
 end
 
+describe DuckHunt::Validators::GreaterThan, "Validation (length check)" do
+  before do
+    @validator = DuckHunt::Validators::GreaterThan.new(3)
+  end
+
+  it "returns true if the value provided is greater than the value given" do
+    @validator.valid?("aaaa").must_equal true
+    @validator.valid?([1,2,3,4]).must_equal true
+    @validator.valid?({a: 1, b: 2, c: 3, d: 4}).must_equal true
+  end
+
+  it "returns false if the value provided is less than the value given" do
+    @validator.valid?("aaa").must_equal false
+    @validator.valid?([1,2,3]).must_equal false
+    @validator.valid?({a: 1, b: 2, c: 3}).must_equal false
+    @validator.valid?({}).must_equal false
+    @validator.valid?("").must_equal false
+  end
+end
 
 
 describe DuckHunt::Validators::GreaterThan, "error message" do

data/test/validators/less_than_or_equal_to_test.rb

@@ -30,6 +30,24 @@ describe DuckHunt::Validators::LessThanOrEqualTo, "Validation" do
   end
 end
 
+describe DuckHunt::Validators::LessThanOrEqualTo, "Validation (length check)" do
+  before do
+    @validator = DuckHunt::Validators::LessThanOrEqualTo.new(3)
+  end
+
+  it "returns true if the value provided is less than or equal to the value given" do
+    @validator.valid?("aaa").must_equal true
+    @validator.valid?([1,2]).must_equal true
+    @validator.valid?({}).must_equal true
+  end
+
+  it "returns false if the value provided is greater than the value provided" do
+    @validator.valid?("aaaa").must_equal false
+    @validator.valid?([1,2,3,4,5]).must_equal false
+    @validator.valid?({a: 1, b: 2, c: 3, d: 4}).must_equal false
+  end
+end
+
 
 
 describe DuckHunt::Validators::LessThanOrEqualTo, "error message" do

data/test/validators/less_than_test.rb

@@ -29,7 +29,26 @@ describe DuckHunt::Validators::LessThan, "Validation" do
   end
 end
 
+describe DuckHunt::Validators::LessThan, "Validation (length check)" do
+  before do
+    @validator = DuckHunt::Validators::LessThan.new(3)
+  end
 
+  it "returns true if the value provided is less than the value given" do
+    @validator.valid?("aa").must_equal true
+    @validator.valid?([1]).must_equal true
+    @validator.valid?({}).must_equal true
+    @validator.valid?("").must_equal true
+  end
+
+  it "returns false if the value provided is greater than the value provided" do
+    @validator.valid?("aaa").must_equal false
+    @validator.valid?([1,2,3]).must_equal false
+    @validator.valid?("aaaa").must_equal false
+    @validator.valid?([1,2,3,4,5]).must_equal false
+    @validator.valid?({a: 1, b: 2, c: 3, d: 4}).must_equal false
+  end
+end
 
 describe DuckHunt::Validators::LessThan, "error message" do
   it "should have the correct error message based on the value provided" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: duck-hunt
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.1.0
 platform: ruby
 authors:
 - Thomas Cannon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-09 00:00:00.000000000 Z
+date: 2020-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest