ducalis 0.5.13 → 0.5.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 75bd9a05b686683a5a460a113fc81089795ddc36
-  data.tar.gz: 88fccc0c3fec65985a012b90c303ee6ae907b80e
+  metadata.gz: dee09942e0904fe18f8abf7a345305cbdfd8989c
+  data.tar.gz: f93046f6e097760d0a5768dc3f2212b9d2cfe834
 SHA512:
-  metadata.gz: 8085d59b75d50d3db357845b7104e5cce09e3712b9fc76d0bbc1ceff63456335888d947395fda9089fc3421f87f243c537ac46fb617217775e5ed75dbc93fd9e
-  data.tar.gz: 5925c8c9286eb4b6fc758e818782e8467a9390c51897a56eccd7b6dac53145b0a11494f6b7901b11bdc524461ae182bc6fc5b5393638ec03f3f267f0ad2fd954
+  metadata.gz: b039f3df86b92eb0ccda9d61c8eaa3ac32995d9de8cc60f9f372b5c6a50b524d7dfb37385de66d3d63dd4ae4a4d97f88950a26388a225057d533da62f98e5cf7
+  data.tar.gz: 1278017d4fafa60ff80a176e3c2d1a4fea13a76bf279c29a3879100c46a479b33a8691992e16ed96d520b4562d59d638120657a66ce540ce8498d4f3a2c137b5

data/.travis.yml

@@ -1,8 +1,9 @@
 language: ruby
 rvm:
-  - 2.2.8
-  - 2.3.4
-  - 2.4.2
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
 before_install:
   - gem update --system
   - gem --version
+  - gem install bundler

data/DOCUMENTATION.md

@@ -630,6 +630,11 @@ User.where(id: 7).delete
 User.where(id: 7).save(validate: false)
 ```
 
+![](https://placehold.it/10/f03c15/000000?text=+) raises `update_column` method calling
+```ruby
+User.where(id: 7).update_column(admin: false)
+```
+
 ![](https://placehold.it/10/f03c15/000000?text=+) raises `toggle!` method calling
 ```ruby
 User.where(id: 7).toggle!
@@ -745,6 +750,16 @@ Group.find(8)
 Group.includes(:profiles).find(8)
 ```
 
+![](https://placehold.it/10/f03c15/000000?text=+) raises if AR search was called with find_by id
+```ruby
+Group.includes(:profiles).find_by(id: 8)
+```
+
+![](https://placehold.it/10/f03c15/000000?text=+) raises if AR search was called on unnamespaced constant
+```ruby
+::Group.find(8)
+```
+
 ![](https://placehold.it/10/f03c15/000000?text=+) ignores where statements and still raises error
 ```ruby
 Group.includes(:profiles).where(name: "John").find(8)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ducalis (0.5.13)
+    ducalis (0.5.14)
       git (~> 1.3, >= 1.3.0)
       policial (= 0.0.4)
       regexp-examples (~> 1.3, >= 1.3.2)
@@ -36,7 +36,7 @@ GEM
     method_source (0.9.0)
     multi_json (1.12.2)
     multipart-post (2.0.0)
-    octokit (4.7.0)
+    octokit (4.8.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     parser (2.4.0.2)
       ast (~> 2.3)

data/lib/ducalis/cops/preferable_methods.rb

@@ -19,15 +19,44 @@ module Ducalis
     end
 
     DESCRIPTION = {
-      # Method => [Alternative, Reason, Callable condition]
-      toggle!: ['toggle.save', 'it is not invoking validations', ALWAYS_TRUE],
-      save: [:save, 'it is not invoking validations', VALIDATE_CHECK],
-      delete: [:destroy, 'it is not invoking callbacks', DELETE_CHECK],
-      delete_all: [:destroy_all, 'it is not invoking callbacks', ALWAYS_TRUE],
-      update_attribute: [:update, 'it is not invoking validation', ALWAYS_TRUE],
-      update_column: [:update, 'it is not invoking callbacks', ALWAYS_TRUE],
+      # Method => [
+      #   Alternative,
+      #   Reason,
+      #   Callable condition
+      # ]
+      toggle!: [
+        '`toggle.save`',
+        'it is not invoking validations',
+        ALWAYS_TRUE
+      ],
+      save: [
+        '`save`',
+        'it is not invoking validations',
+        VALIDATE_CHECK
+      ],
+      delete: [
+        '`destroy`',
+        'it is not invoking callbacks',
+        DELETE_CHECK
+      ],
+      delete_all: [
+        '`destroy_all`',
+        'it is not invoking callbacks',
+        ALWAYS_TRUE
+      ],
+      update_attribute: [
+        '`update` (`update_attributes` for Rails versions < 4)',
+        'it is not invoking validations',
+        ALWAYS_TRUE
+      ],
+      update_column: [
+        '`update` (`update_attributes` for Rails versions < 4)',
+        'it is not invoking callbacks',
+        ALWAYS_TRUE
+      ],
       update_columns: [
-        :update, 'it is not invoking validations, callbacks and updated_at',
+        '`update` (`update_attributes` for Rails versions < 4)',
+        'it is not invoking validations, callbacks and updated_at',
         ALWAYS_TRUE
       ]
     }.freeze

data/lib/ducalis/cops/protected_scope_cop.rb

@@ -16,23 +16,14 @@ module Ducalis
     MESSAGE
 
     def on_send(node)
-      _, method_name, *args = *node
-      return unless method_name == :find
-      return if args.empty?
-      return unless children(node).any? { |subnode| subnode.type == :const }
+      return unless [find_method?(node), find_by_id?(node)].any?
+      return unless const_like?(node)
       add_offense(node, :expression, OFFENSE)
     end
 
-    private
-
-    def children(node)
-      current_nodes = [node]
-      while current_nodes.any? { |subnode| subnode.child_nodes.count != 0 }
-        current_nodes = current_nodes.flat_map do |subnode|
-          subnode.child_nodes.count.zero? ? subnode : subnode.child_nodes
-        end
-      end
-      current_nodes
-    end
+    def_node_search :const_like?, '(const ...)'
+    def_node_search :find_method?, '(send (...) :find (...))'
+    def_node_search :find_by_id?,
+                    '(send (...) :find_by (:hash (:pair (:sym :id) (...))))'
   end
 end

data/lib/ducalis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ducalis
-  VERSION = '0.5.13'
+  VERSION = '0.5.14'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ducalis
 version: !ruby/object:Gem::Version
-  version: 0.5.13
+  version: 0.5.14
 platform: ruby
 authors:
 - Ignat Zakrevsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-19 00:00:00.000000000 Z
+date: 2017-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git