ducalis 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d8343e259ebf63adaefe044ec87484acc61c8572
-  data.tar.gz: 2101456f1a13e60eed9507d5fb0197c5731d206d
+  metadata.gz: 42a073dbbd32041b55d28da53f799726b9f2ce28
+  data.tar.gz: ebc20a2e3383aa7838a193b247bbfbe40abae580
 SHA512:
-  metadata.gz: 81e5b952ed401b04376ec5fd3078e288cb29c4b2d5e03e29b8c94d30f336f5eff66611ea278f4ee0d001004dbe0ba69fdb532f3dc44b8b8fad70736b33970642
-  data.tar.gz: 8d773d44b74dc550ed7a6a1ecaea8ab833328fa088a914eccca28282f2fbcc9136bc7dcd1a91f2f25c29d9d0fafcc76f30ab024a24afff789020b37bee7369fd
+  metadata.gz: c5ad451e36f98fc805296f6f5b3792a5cd2a46002bfb1be7031dab51079885809572eb6873ac931cf7f19079ad60486716e923df42f525928142bb22a8500d02
+  data.tar.gz: 466f33f3f4e8ab9c3af682fbd452c3e0d203d2c1c03c7fe3cba77d4055acc09004207ec2ab5b2b85b7a95f872de1d75bfef5b3541e8b8adecc55159f16b4859e

data/.rubocop.yml

@@ -8,8 +8,5 @@ AllCops:
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*.rb'
-Lint/InterpolationCheck:
-  Exclude:
-    - 'spec/**/*.rb'
 Style/Documentation:
   Enabled: false

data/.travis.yml

@@ -1,6 +1,6 @@
 language: ruby
 rvm:
-  - 2.4.2
+  - 2.3.4
 before_install:
   - gem update --system
   - gem --version

data/Gemfile.lock

@@ -1,11 +1,11 @@
 PATH
   remote: .
   specs:
-    ducalis (0.4.1)
+    ducalis (0.5.0)
       git (~> 1.3, >= 1.3.0)
       policial (= 0.0.4)
       regexp-examples (~> 1.3, >= 1.3.2)
-      rubocop (= 0.50)
+      rubocop (~> 0.46.0, >= 0.45.0)
       thor (~> 0.20.0)
 
 GEM
@@ -38,7 +38,6 @@ GEM
     multipart-post (2.0.0)
     octokit (4.7.0)
       sawyer (~> 0.8.0, >= 0.5.3)
-    parallel (1.12.0)
     parser (2.4.0.0)
       ast (~> 2.2)
     policial (0.0.4)
@@ -68,11 +67,10 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
     rspec-support (3.7.0)
-    rubocop (0.50.0)
-      parallel (~> 1.10)
-      parser (>= 2.3.3.1, < 3.0)
+    rubocop (0.46.0)
+      parser (>= 2.3.1.1, < 3.0)
       powerpack (~> 0.1)
-      rainbow (>= 2.2.2, < 3.0)
+      rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
     ruby-progressbar (1.9.0)

data/Rakefile

@@ -5,7 +5,7 @@ require 'rspec/core/rake_task'
 require 'rubocop/rake_task'
 
 RuboCop::RakeTask.new do |task|
-  task.options = %w[--auto-correct]
+  task.options = %w(--auto-correct)
 end
 
 task :documentation do
@@ -14,4 +14,4 @@ task :documentation do
 end
 
 RSpec::Core::RakeTask.new(:spec)
-task default: %i[rubocop spec]
+task default: %i(rubocop spec)

data/bin/ducalis

@@ -21,7 +21,7 @@ Env `GITHUB_TOKEN` should be available to receive PRs files."
 end
 
 if Ducalis::PassedArgs.ci_mode?
-  Ducalis::CLI.start(ARGV - %w[--ci])
+  Ducalis::CLI.start(ARGV - %w(--ci))
 else
   Ducalis::PassedArgs.process_args!
 

data/ducalis.gemspec

@@ -31,6 +31,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'git', '~> 1.3', '>= 1.3.0'
   spec.add_dependency 'policial', '0.0.4'
   spec.add_dependency 'regexp-examples', '~> 1.3', '>= 1.3.2'
-  spec.add_dependency 'rubocop', '= 0.50'
+  spec.add_dependency 'rubocop', '>= 0.45.0', '~> 0.46.0'
   spec.add_dependency 'thor', '~> 0.20.0'
 end

data/lib/ducalis/cops/callbacks_activerecord.rb

@@ -9,7 +9,7 @@ module Ducalis
               '/services: to construct new objects. You can read more [here]'\
               '(https://medium.com/planet-arkency/a61fd75ab2d3).'
     MODELS_CLASS_NAMES = ['ApplicationRecord', 'ActiveRecord::Base'].freeze
-    METHODS_BLACK_LIST = %i[
+    METHODS_BLACK_LIST = %i(
       after_commit
       after_create
       after_destroy
@@ -26,7 +26,7 @@ module Ducalis
       before_save
       before_update
       before_validation
-    ].freeze
+    ).freeze
 
     def on_class(node)
       _classdef_node, superclass, _body = *node

data/lib/ducalis/cops/controllers_except.rb

@@ -5,8 +5,8 @@ require 'rubocop'
 module Ducalis
   class ControllersExcept < ::RuboCop::Cop::Cop
     include RuboCop::Cop::DefNode
-    FILTERS = %i[before_filter after_filter around_filter
-                 before_action after_action around_action].freeze
+    FILTERS = %i(before_filter after_filter around_filter
+                 before_action after_action around_action).freeze
     OFFENSE = %(
 Prefer to use `:only` over `:except` in controllers because it's more explicit \
 and will be easier to maintain for new developers.

data/lib/ducalis/cops/private_instance_assign.rb

@@ -31,7 +31,7 @@ start: `@_name`.
 
     def check_memo(node)
       return if node.to_a.first.to_s.start_with?('@_')
-      add_offense(node, :expression, OFFENSE + ADD_OFFENSE)
+      add_offense(node, :expression, [OFFENSE, ADD_OFFENSE].join(' '))
     end
 
     attr_reader :triggered

data/lib/ducalis/cops/rest_only_cop.rb

@@ -5,7 +5,7 @@ require 'rubocop'
 module Ducalis
   class RestOnlyCop < RuboCop::Cop::Cop
     include RuboCop::Cop::DefNode
-    WHITELIST = %i[index show new edit create update destroy].freeze
+    WHITELIST = %i(index show new edit create update destroy).freeze
     OFFENSE = %(
 It's better for controllers to stay adherent to REST:
 http://jeromedalbert.com/how-dhh-organizes-his-rails-controllers/

data/lib/ducalis/cops/strings_in_activerecords.rb

@@ -11,10 +11,10 @@ It's hard to test, grep sources, code highlighting and so on.
 Consider using of symbols or lambdas for complex expressions.
     ).strip
     VALIDATEBLE_METHODS =
-      ::Ducalis::CallbacksActiverecord::METHODS_BLACK_LIST + %i[
+      ::Ducalis::CallbacksActiverecord::METHODS_BLACK_LIST + %i(
         validates
         validate
-      ]
+      )
 
     def on_send(node)
       _, method_name, *args = *node
@@ -31,7 +31,7 @@ Consider using of symbols or lambdas for complex expressions.
     def skip_node?(current_node)
       key, value = *current_node
       return true unless current_node.type == :pair
-      return true unless %w[if unless].include?(key.source)
+      return true unless %w(if unless).include?(key.source)
       return true unless value.type == :str
       false
     end

data/lib/ducalis/cops/useless_only.rb

@@ -5,8 +5,8 @@ require 'rubocop'
 module Ducalis
   class UselessOnly < RuboCop::Cop::Cop
     include RuboCop::Cop::DefNode
-    FILTERS = %i[before_filter after_filter around_filter
-                 before_action after_action around_action].freeze
+    FILTERS = %i(before_filter after_filter around_filter
+                 before_action after_action around_action).freeze
     OFFENSE = %(
 Seems like there is no any reason to keep before filter only for one action. \
 Maybe it will be better to inline it?

data/lib/ducalis/documentation.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'parser/current'
+require 'rubocop'
 
 class SpecsProcessor < Parser::AST::Processor
   attr_reader :cases

data/lib/ducalis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ducalis
-  VERSION = '0.4.1'
+  VERSION = '0.5.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ducalis
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Ignat Zakrevsky
@@ -68,16 +68,22 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.45.0
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.50'
+        version: 0.46.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.45.0
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.50'
+        version: 0.46.0
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement