ducalis 0.11.1 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f37cdd7057ceecfbfee6683af5b297e384c02c1aa31392cfd676d15839b3ef8b
-  data.tar.gz: 0d6581dd6029ed5e29b0d7bda5e37062e30378d67c0910cf2f8ae186674af6c1
+  metadata.gz: 9aadaf2bffe42d747bfec8a03418ca1ba12fff39018e1b32305ad71c4108f5b3
+  data.tar.gz: 42115ba6b4ba38977f7cf65eeb8684b90dea5faaeaf4a7bea17e03b0768c79a2
 SHA512:
-  metadata.gz: b831a202e63c4abb94b3721b8bd95cf25afacc7322910f45498abe0895e0c6495f8ba8ea61267df20b0d5b21c9cada5963b43b6893b0613c16a858bcec071fac
-  data.tar.gz: 205701a52658e6f888d3bc93668367d1a71302c4f134613e004069c2592c891df892a2c0f726bb0ce7166401844eb39cee64830d45d0dbf5415397ef4be77276
+  metadata.gz: 384403e2c35a226966cbe8e3102fbed36bff5bcba77cc963f3d2dd5c670a66ac7e766dd3f0231a7005bc97091bcb23f55180a6eda7de2b3553072c55a2a926c9
+  data.tar.gz: f267d508e2b72e8f70acbf842703c8563f8b16893bf534c8abf8b02d16b682e0fde539e976969791b27d3578dee9db9d3746302cf9d4875f643d35ba8fc34ef3

data/.codeclimate.yml

@@ -1,6 +1,6 @@
 engines:
   rubocop:
     enabled: true
-    channel: rubocop-0-52
+    channel: rubocop-0-60
     config:
       file: .rubocop.yml

data/.gitignore

@@ -1,3 +1,4 @@
+/.idea/
 /.bundle/
 /.yardoc
 /_yardoc/

data/.travis.yml

@@ -1,8 +1,8 @@
 language: ruby
 rvm:
   - 2.2.9
-  - 2.3.6
-  - 2.4.3
+  - 2.3.8
+  - 2.4.5
 before_install:
   - gem update --system
   - gem --version
@@ -12,5 +12,5 @@ script:
   - bash bin/legacy_versions_test.sh
 matrix:
   include:
-    - rvm: 2.5.0
-      env: IGNORE_LEGACY=true
+    - rvm: 2.5.3
+      env: IGNORE_LEGACY=true WITH_DOCS=true

data/Gemfile.lock

@@ -1,10 +1,11 @@
 PATH
   remote: .
   specs:
-    ducalis (0.11.1)
+    ducalis (0.12.0)
       git (~> 1.3, >= 1.3.0)
       octokit (>= 4.7.0)
       regexp-examples (~> 1.3, >= 1.3.2)
+      regexp_parser (>= 0.5.0)
       rubocop (>= 0.45.0)
 
 GEM
@@ -15,25 +16,26 @@ GEM
     ast (2.4.0)
     coderay (1.1.2)
     diff-lcs (1.3)
-    faraday (0.15.2)
+    faraday (0.15.3)
       multipart-post (>= 1.2, < 3)
-    git (1.4.0)
-    jaro_winkler (1.5.1)
+    git (1.5.0)
+    jaro_winkler (1.5.1-x86_64-darwin-17)
     method_source (0.9.0)
     multipart-post (2.0.0)
-    octokit (4.9.0)
+    octokit (4.13.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     parallel (1.12.1)
-    parser (2.5.1.2)
+    parser (2.5.3.0)
       ast (~> 2.4.0)
     powerpack (0.1.2)
     pry (0.11.3)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    public_suffix (3.0.2)
+    public_suffix (3.0.3)
     rainbow (3.0.0)
     rake (12.3.0)
     regexp-examples (1.4.3)
+    regexp_parser (1.2.0)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
       rspec-expectations (~> 3.7.0)
@@ -47,14 +49,14 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
     rspec-support (3.7.1)
-    rubocop (0.58.2)
+    rubocop (0.60.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
+      unicode-display_width (~> 1.4.0)
     ruby-progressbar (1.10.0)
     sawyer (0.8.1)
       addressable (>= 2.3.5, < 2.6)

data/README.md

@@ -24,7 +24,7 @@ __Ducalis__ is CLI application. By defaukt it will notify you about any possible
  violations in CLI.
 
 ```
-ducalis
+ducalis .
 ducalis app/controllers/
 ```
 
@@ -32,16 +32,16 @@ __Ducalis__ allows to pass build even with violations it's make sense to run
 __Ducalis__ across current branch or index:
 
 ```
-ducalis --branch
-ducalis --index
+ducalis --branch .
+ducalis --index .
 ```
 
 Additionally you can pass `--reporter` argument to notify about found violations
  in boundaries of PR:
 
 ```
-ducalis --reporter "author/repo#42"
-ducalis --reporter "circleci"
+ducalis --reporter "author/repo#42" .
+ducalis --reporter "circleci" .
 ```
 
 _N.B._ You should provide `GITHUB_TOKEN` Env to allow __Ducalis__ download your

data/config/.ducalis.yml

@@ -31,6 +31,10 @@ Ducalis/PreferableMethods:
 Ducalis/Recursion:
   Enabled: true
 
+Ducalis/ComplexRegex:
+  Enabled: true
+  MaxComplexity: 3
+
 Ducalis/CaseMapping:
   Enabled: true
 
@@ -48,7 +52,7 @@ Ducalis/PossibleTap:
   Enabled: false
 
 Ducalis/PublicSend:
-  Enabled: false
+  Enabled: true
 
 Ducalis/FetchExpression:
   Enabled: true

data/ducalis.gemspec

@@ -30,5 +30,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'git', '~> 1.3', '>= 1.3.0'
   spec.add_dependency 'octokit', '>= 4.7.0'
   spec.add_dependency 'regexp-examples', '~> 1.3', '>= 1.3.2'
+  spec.add_dependency 'regexp_parser', '>= 0.5.0'
   spec.add_dependency 'rubocop', '>= 0.45.0'
 end

data/lib/ducalis.rb

@@ -30,36 +30,6 @@ require 'ducalis/cli_arguments'
 require 'ducalis/patch'
 require 'ducalis/git_access'
 
-require 'ducalis/cops/black_list_suffix'
-require 'ducalis/cops/callbacks_activerecord'
-require 'ducalis/cops/case_mapping'
-require 'ducalis/cops/controllers_except'
-require 'ducalis/cops/data_access_objects'
-require 'ducalis/cops/descriptive_block_names'
-require 'ducalis/cops/enforce_namespace'
-require 'ducalis/cops/evlis_overusing'
-require 'ducalis/cops/extensions/type_resolving'
-require 'ducalis/cops/facade_pattern'
-require 'ducalis/cops/fetch_expression'
-require 'ducalis/cops/keyword_defaults'
-require 'ducalis/cops/module_like_class'
-require 'ducalis/cops/multiple_times'
-require 'ducalis/cops/only_defs'
-require 'ducalis/cops/options_argument'
-require 'ducalis/cops/params_passing'
-require 'ducalis/cops/possible_tap'
-require 'ducalis/cops/preferable_methods'
-require 'ducalis/cops/private_instance_assign'
-require 'ducalis/cops/protected_scope_cop'
-require 'ducalis/cops/public_send'
-require 'ducalis/cops/raise_without_error_class'
-require 'ducalis/cops/recursion'
-require 'ducalis/cops/regex_cop'
-require 'ducalis/cops/rest_only_cop'
-require 'ducalis/cops/rubocop_disable'
-require 'ducalis/cops/standard_methods'
-require 'ducalis/cops/strings_in_activerecords'
-require 'ducalis/cops/too_long_workers'
-require 'ducalis/cops/uncommented_gem'
-require 'ducalis/cops/unlocked_gem'
-require 'ducalis/cops/useless_only'
+Dir[File.join('.', 'lib', 'ducalis', 'cops', '**', '*.rb')].each do |file|
+  require file
+end

data/lib/ducalis/cli_arguments.rb

@@ -40,6 +40,7 @@ module Ducalis
         ARGV.include?(to_key(mode))
       end
       return unless git_mode
+
       ARGV.delete(to_key(git_mode))
       GitAccess.instance.flag = git_mode
     end

data/lib/ducalis/cops/black_list_suffix.rb

@@ -17,6 +17,7 @@ module Ducalis
     def on_class(node)
       classdef_node, _superclass, _body = *node
       return unless with_blacklisted_suffix?(classdef_node.source)
+
       add_offense(node, :expression, OFFENSE)
     end
 
@@ -24,6 +25,7 @@ module Ducalis
 
     def with_blacklisted_suffix?(name)
       return if cop_config['BlackList'].to_a.empty?
+
       cop_config['BlackList'].any? { |suffix| name.end_with?(suffix) }
     end
   end

data/lib/ducalis/cops/callbacks_activerecord.rb

@@ -40,6 +40,7 @@ module Ducalis
     def on_send(node)
       return unless in_model?
       return unless METHODS_BLACK_LIST.include?(node.method_name)
+
       add_offense(node, :selector, OFFENSE)
     end
   end

data/lib/ducalis/cops/complex_cases/smart_delete_check.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module ComplexCases
+  class SmartDeleteCheck
+    WHITE_LIST = %w[File cache file params attrs options].freeze
+
+    def self.call(who, what, args)
+      !new(who, what, args).false_positive?
+    end
+
+    def initialize(who, _what, args)
+      @who = who
+      @args = args
+    end
+
+    def false_positive?
+      [
+        called_with_stringlike?,
+        many_args?,
+        whitelisted?
+      ].any?
+    end
+
+    private
+
+    def called_with_stringlike?
+      %i[sym str].include?(@args.first && @args.first.type)
+    end
+
+    def many_args?
+      @args.count > 1
+    end
+
+    def whitelisted?
+      WHITE_LIST.any? { |regex| @who.to_s.include?(regex) }
+    end
+  end
+end

data/lib/ducalis/cops/complex_regex.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+require 'regexp_parser'
+
+module Ducalis
+  class ComplexRegex < RuboCop::Cop::Cop
+    include RuboCop::Cop::DefNode
+
+    OFFENSE = <<-MESSAGE.gsub(/^ +\|\s/, '').strip
+      | It seems like this regex is a little bit complex. It's better to increase code readability by using long form with "\\x".
+    MESSAGE
+    DEFAULT_COST = 0
+    COMPLEX_TYPES_COSTS = {
+      quantifier: 1,
+      meta: 1,
+      assertion: 1,
+      group: 0.5
+    }.freeze
+
+    def on_begin(node)
+      regex_using(node).each do |regex_desc|
+        next if formatted?(regex_desc) || simple?(regex_desc.first)
+
+        add_offense(regex_desc.first, :expression, OFFENSE)
+      end
+    end
+
+    private
+
+    def simple?(regex_node)
+      Regexp::Scanner.scan(
+        Regexp.new(regex_node.source)
+      ).map do |type, _, _, _, _|
+        COMPLEX_TYPES_COSTS.fetch(type, DEFAULT_COST)
+      end.inject(:+) <= maximal_complexity
+    end
+
+    def maximal_complexity
+      cop_config['MaxComplexity']
+    end
+
+    def formatted?(regex_desc)
+      regex_desc.size > 1
+    end
+
+    def_node_search :regex_long_form?, '(regopt :x)'
+    def_node_search :regex_using, '(regexp $... (regopt ...))'
+  end
+end

data/lib/ducalis/cops/controllers_except.rb

@@ -15,8 +15,10 @@ module Ducalis
       _, method_name, *args = *node
       hash_node = args.find { |subnode| subnode.type == :hash }
       return unless FILTERS.include?(method_name) && hash_node
+
       type, _method_names = decomposite_hash(hash_node)
       return unless type == s(:sym, :except)
+
       add_offense(node, :selector, OFFENSE)
     end
 

data/lib/ducalis/cops/data_access_objects.rb

@@ -22,6 +22,7 @@ module Ducalis
     def on_send(node)
       return unless in_controller?
       return unless NODE_EXPRESSIONS.include?(node.to_a.first)
+
       add_offense(node, :expression, OFFENSE)
     end
   end

data/lib/ducalis/cops/enforce_namespace.rb

@@ -12,12 +12,14 @@ module Ducalis
 
     def on_class(node)
       return if !node.parent.nil? || !in_service?
+
       add_offense(node, :expression, OFFENSE)
     end
 
     def on_module(node)
       return if !node.parent.nil? || !in_service?
       return if contains_class?(node) || contains_classes?(node)
+
       add_offense(node, :expression, OFFENSE)
     end
 

data/lib/ducalis/cops/evlis_overusing.rb

@@ -16,11 +16,13 @@ module Ducalis
 
     def on_send(node)
       return unless nested_try?(node)
+
       add_offense(node, :expression, OFFENSE)
     end
 
     def on_csend(node)
       return unless node.child_nodes.any?(&:csend_type?)
+
       add_offense(node, :expression, OFFENSE)
     end
 

data/lib/ducalis/cops/extensions/type_resolving.rb

@@ -40,6 +40,7 @@ module TypeResolving
 
   def in_controller?
     return false if @superclass_name.nil?
+
     @superclass_name.end_with?(*CONTROLLER_SUFFIXES)
   end
 

data/lib/ducalis/cops/facade_pattern.rb

@@ -19,8 +19,11 @@ module Ducalis
     def on_def(node)
       return unless in_controller?
       return if non_public?(node)
-      return if instance_variables_matches(node).count < max_instance_variables
-      add_offense(node, :expression, OFFENSE)
+
+      assigns = instance_variables_matches(node)
+      return if assigns.count < max_instance_variables
+
+      assigns.each { |assign| add_offense(assign, :expression, OFFENSE) }
     end
 
     private

data/lib/ducalis/cops/fetch_expression.rb

@@ -4,7 +4,7 @@ require 'rubocop'
 
 module Ducalis
   class FetchExpression < RuboCop::Cop::Cop
-    HASH_CALLING_REGEX = /\:\[\]/ # params[:key]
+    HASH_CALLING_REGEX = /\:\[\]/.freeze # params[:key]
 
     OFFENSE = <<-MESSAGE.gsub(/^ +\|\s/, '').strip
       | You can use `fetch` instead:
@@ -19,6 +19,7 @@ module Ducalis
 
     def investigate(processed_source)
       return unless processed_source.ast
+
       matching_nodes(processed_source.ast).each do |node|
         add_offense(node, :expression, format(OFFENSE,
                                               source: correct_variant(node)))

data/lib/ducalis/cops/keyword_defaults.rb

@@ -6,12 +6,17 @@ module Ducalis
   class KeywordDefaults < RuboCop::Cop::Cop
     OFFENSE = <<-MESSAGE.gsub(/^ +\|\s/, '').strip
       | Prefer to use keyword arguments for defaults. It increases readability and reduces ambiguities.
+      | It is ok if an argument is single and the name obvious from the function declaration.
     MESSAGE
 
     def on_def(node)
       args = node.type == :defs ? node.to_a[2] : node.to_a[1]
+
+      return if args.to_a.one?
+
       args.children.each do |arg_node|
         next unless arg_node.type == :optarg
+
         add_offense(node, :expression, OFFENSE)
       end
     end

data/lib/ducalis/cops/module_like_class.rb

@@ -13,8 +13,10 @@ module Ducalis
     def on_class(node)
       _name, inheritance, body = *node
       return if !inheritance.nil? || body.nil? || allowed_include?(body)
+
       matched = matched_args(body)
       return if matched.empty?
+
       add_offense(node, :expression,
                   format(OFFENSE, args:
                       matched.map { |arg| "`#{arg}`" }.join(', ')))
@@ -24,12 +26,14 @@ module Ducalis
 
     def allowed_include?(body)
       return if cop_config['AllowedIncludes'].to_a.empty?
+
       (all_includes(body) & cop_config['AllowedIncludes']).any?
     end
 
     def matched_args(body)
       methods_defintions = children(body).select(&public_method_definition?)
       return [] if methods_defintions.count == 1 && with_initialize?(body)
+
       methods_defintions.map(&method_args).inject(&:&).to_a
     end
 

data/lib/ducalis/cops/multiple_times.rb

@@ -29,12 +29,11 @@ module Ducalis
 
     def on_def(body)
       multiple = [
-        date_today(body),
-        date_current(body),
-        time_current(body),
-        time_now(body)
+        date_today(body), date_current(body), date_yesterday(body),
+        time_current(body), time_now(body)
       ].map(&:to_a).compact.flatten.to_a
       return if multiple.count < 2
+
       multiple.each do |time_node|
         add_offense(time_node, :expression, OFFENSE)
       end
@@ -44,6 +43,7 @@ module Ducalis
 
     def_node_search :date_today, '(send (const _ :Date) :today)'
     def_node_search :date_current, '(send (const _ :Date) :current)'
+    def_node_search :date_yesterday, '(send (const _ :Date) :yesterday)'
     def_node_search :time_current, '(send (const _ :Time) :current)'
     def_node_search :time_now, '(send (const _ :Time) :now)'
   end

data/lib/ducalis/cops/only_defs.rb

@@ -19,6 +19,7 @@ module Ducalis
       return if !inheritance.nil? || body.nil?
       return unless !instance_methods_definitions?(body) &&
                     class_methods_defintions?(body)
+
       add_offense(node, :expression, OFFENSE)
     end
 

data/lib/ducalis/cops/options_argument.rb

@@ -39,6 +39,7 @@ module Ducalis
 
     def on_def(node)
       return unless options_like_arg?(node)
+
       add_offense(node, :expression, OFFENSE)
     end
 

data/lib/ducalis/cops/params_passing.rb

@@ -20,6 +20,7 @@ module Ducalis
 
     def inspect_args(args)
       return if Array(args).empty?
+
       args.find { |arg| arg == PARAMS_CALL }.tap do |node|
         return node if node
       end
@@ -28,6 +29,7 @@ module Ducalis
 
     def inspect_hash(args)
       return if args.nil?
+
       args.children.find { |arg| arg.to_a[1] == PARAMS_CALL }
     end
   end

data/lib/ducalis/cops/possible_tap.rb

@@ -26,31 +26,34 @@ module Ducalis
       return if body.nil?
       return unless (possibe_var = return_var?(body) || return_var_call?(body))
       return unless (assign_node = find_assign(body, possibe_var))
+
       add_offense(assign_node, :expression, OFFENSE)
     end
 
     private
 
-    def unwrap_asign(node)
+    def unwrap_assign(node)
       node.type == :or_asgn ? node.children.first : node
     end
 
     def find_assign(body, var_node)
       subnodes(body).find do |subnode|
-        unwrap_asign(subnode).type == PAIRS[var_node.type] &&
-          unwrap_asign(subnode).to_a.first == var_node.to_a.first
+        unwrap_assign(subnode).type == PAIRS[var_node.type] &&
+          unwrap_assign(subnode).to_a.first == var_node.to_a.first
       end
     end
 
     def return_var?(body)
       return unless body.children.last.respond_to?(:type)
       return unless ASSIGNS.include?(body.children.last.type)
+
       body.children.last
     end
 
     def return_var_call?(body)
       return unless last_child(body).respond_to?(:children)
       return if last_child(body).type == :if
+
       subnodes(last_child(body).to_a.first).find do |node|
         ASSIGNS.include?(node.type)
       end
@@ -58,6 +61,7 @@ module Ducalis
 
     def subnodes(node)
       return [] unless node.respond_to?(:children)
+
       ([node] + node.children).select { |child| child.respond_to?(:type) }
     end
 

data/lib/ducalis/cops/preferable_methods.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rubocop'
+require 'ducalis/cops/complex_cases/smart_delete_check'
 
 module Ducalis
   class PreferableMethods < RuboCop::Cop::Cop
@@ -8,15 +9,8 @@ module Ducalis
       | Prefer to use %<alternative>s method instead of %<original>s because of %<reason>s.
     MESSAGE
 
-    WHITE_LIST = %w[cache file params attrs options].freeze
-
     ALWAYS_TRUE = ->(_who, _what, _args) { true }
 
-    DELETE_CHECK = lambda do |who, _what, args|
-      !%i[sym str].include?(args.first && args.first.type) &&
-        args.count <= 1 && WHITE_LIST.none? { |regex| who.to_s.include?(regex) }
-    end
-
     VALIDATE_CHECK = lambda do |_who, _what, args|
       (args.first && args.first.source) =~ /validate/
     end
@@ -40,7 +34,7 @@ module Ducalis
       delete: [
         '`destroy`',
         'it is not invoking callbacks',
-        DELETE_CHECK
+        ComplexCases::SmartDeleteCheck
       ],
       delete_all: [
         '`destroy_all`',
@@ -70,8 +64,10 @@ module Ducalis
     def on_send(node)
       who, what, *args = *node
       return unless DESCRIPTION.key?(what)
+
       alternative, reason, condition = DESCRIPTION.fetch(what)
       return unless condition.call(who, what, args)
+
       add_offense(node, :expression, format(OFFENSE, original: what,
                                                      alternative: alternative,
                                                      reason: reason))

data/lib/ducalis/cops/private_instance_assign.rb

@@ -22,6 +22,7 @@ module Ducalis
       return unless in_controller?
       return unless non_public?(node)
       return check_memo(node) if node.parent.type == :or_asgn
+
       add_offense(node, :expression, OFFENSE)
     end
 
@@ -29,6 +30,7 @@ module Ducalis
 
     def check_memo(node)
       return if node.to_a.first.to_s.start_with?('@_')
+
       add_offense(node, :expression, [OFFENSE, ADD_OFFENSE].join(' '))
     end
   end

data/lib/ducalis/cops/protected_scope_cop.rb

@@ -22,6 +22,7 @@ module Ducalis
     def on_send(node)
       return unless [find_method?(node), find_by_id?(node)].any?
       return unless const_like?(node)
+
       add_offense(node, :expression, OFFENSE)
     end
 

data/lib/ducalis/cops/public_send.rb

@@ -10,6 +10,7 @@ module Ducalis
 
     def on_send(node)
       return unless send_call?(node)
+
       add_offense(node, :expression, OFFENSE)
     end
 

data/lib/ducalis/cops/raise_without_error_class.rb

@@ -12,6 +12,7 @@ module Ducalis
       _who, what, *args = *node
       return if what != :raise
       return if args.first && args.first.type != :str
+
       add_offense(node, :expression, OFFENSE)
     end
   end

data/lib/ducalis/cops/recursion.rb

@@ -12,6 +12,7 @@ module Ducalis
       @method_name, _args, body = *node
       return unless body
       return unless send_call?(body) || send_self_call?(body)
+
       add_offense(node, :expression, OFFENSE)
     end
 

data/lib/ducalis/cops/regex_cop.rb

@@ -44,6 +44,7 @@ module Ducalis
     def on_begin(node)
       not_defined_regexes(node).each do |regex|
         next if SELF_DESCRIPTIVE.include?(regex.source) || const_dynamic?(regex)
+
         add_offense(regex, :expression, format(OFFENSE, present_node(regex)))
       end
     end

data/lib/ducalis/cops/rest_only_cop.rb

@@ -22,8 +22,10 @@ module Ducalis
     def on_def(node)
       return unless in_controller?
       return if non_public?(node)
+
       method_name, = *node
       return if WHITELIST.include?(method_name)
+
       add_offense(node, :expression, OFFENSE)
     end
     alias on_defs on_def

data/lib/ducalis/cops/rubocop_disable.rb

@@ -10,8 +10,10 @@ module Ducalis
 
     def investigate(processed_source)
       return unless processed_source.ast
+
       processed_source.comments.each do |comment_node|
         next unless comment_node.loc.expression.source =~ /rubocop:disable/
+
         add_offense(comment_node, :expression, OFFENSE)
       end
     end

data/lib/ducalis/cops/standard_methods.rb

@@ -14,6 +14,7 @@ module Ducalis
     def on_def(node)
       name, _args, _body = *node
       return unless BLACK_LIST.include?(name)
+
       add_offense(node, :expression, OFFENSE)
     end
   end

data/lib/ducalis/cops/strings_in_activerecords.rb

@@ -19,8 +19,10 @@ module Ducalis
       _, method_name, *args = *node
       return unless VALIDATEBLE_METHODS.include?(method_name)
       return if args.empty?
+
       node.to_a.last.each_child_node do |current_node|
         next if skip_node?(current_node)
+
         add_offense(node, :selector, format(OFFENSE, method_name: method_name))
       end
     end
@@ -32,6 +34,7 @@ module Ducalis
       return true unless current_node.type == :pair
       return true unless %w[if unless].include?(key.source)
       return true unless value.type == :str
+
       false
     end
   end

data/lib/ducalis/cops/too_long_workers.rb

@@ -16,8 +16,10 @@ module Ducalis
 
     def on_class(node)
       return unless in_worker?
+
       length = code_length(node)
       return unless length > max_length
+
       add_offense(node, :expression, "#{OFFENSE} [#{length}/#{max_length}]")
     end
   end

data/lib/ducalis/cops/uncommented_gem.rb

@@ -16,9 +16,11 @@ module Ducalis
 
     def investigate(processed_source)
       return unless processed_source.ast
+
       gem_declarations(processed_source.ast).select do |node|
         _, _, gemname, _args = *node
         next if commented?(processed_source, node)
+
         add_offense(node, :selector,
                     format(OFFENSE, gem: gemname.loc.expression.source))
       end
@@ -36,6 +38,7 @@ module Ducalis
 
     def allowed_args?(args)
       return false if args.nil? || args.type != :hash
+
       args.children.any? do |arg_node|
         !ALLOWED_KEYS.include?(arg_node.children.first.source)
       end

data/lib/ducalis/cops/unlocked_gem.rb

@@ -10,6 +10,7 @@ module Ducalis
 
     def investigate(processed_source)
       return unless processed_source.ast
+
       gem_declarations(processed_source.ast).select do |node|
         _, _, gemname, _args = *node
         add_offense(node, :selector,

data/lib/ducalis/cops/useless_only.rb

@@ -32,9 +32,11 @@ module Ducalis
       _, method_name, *args = *node
       hash_node = args.find { |subnode| subnode.type == :hash }
       return unless FILTERS.include?(method_name) && hash_node
+
       type, method_names = decomposite_hash(hash_node)
       return unless type == s(:sym, :only)
       return unless method_names.children.count == 1
+
       add_offense(node, :selector, OFFENSE)
     end
 

data/lib/ducalis/documentation.rb

@@ -8,10 +8,10 @@ require 'parser/current'
 class SpecsProcessor < Parser::AST::Processor
   attr_reader :cases
 
-  LINE_BEGIN_OPEN_SQUARE_BRACKET = /\A\[/  # "/[/1, 2, 3]\n"
-  CLOSE_SQUARE_BRACKET_END_LINE = /\]\z/   # "[1, 2, 3/]\n/"
-  LINE_BEGIN_QUOTE = /\A[\'|\"]/           # "/'/idddqd',"
-  QUOTE_COMMA_END_LINE = /[\'|\"]\,?\z/    # "'iddqd/',/"
+  LINE_BEGIN_OPEN_SQUARE_BRACKET = /\A\[/.freeze  # "/[/1, 2, 3]\n"
+  CLOSE_SQUARE_BRACKET_END_LINE = /\]\z/.freeze   # "[1, 2, 3/]\n/"
+  LINE_BEGIN_QUOTE = /\A[\'|\"]/.freeze           # "/'/idddqd',"
+  QUOTE_COMMA_END_LINE = /[\'|\"]\,?\z/.freeze    # "'iddqd/',/"
 
   def initialize(*)
     super

data/lib/ducalis/git_access.rb

@@ -9,7 +9,7 @@ class GitAccess
 
   MODES = {
     branch: ->(git) { git.diff('origin/master') },
-    index:  ->(git) { git.diff('HEAD') }
+    index: ->(git) { git.diff('HEAD') }
   }.freeze
 
   include Diffs
@@ -29,6 +29,7 @@ class GitAccess
 
   def for(path)
     return find(path) unless path.include?(Dir.pwd)
+
     find(Pathname.new(path).relative_path_from(Pathname.new(Dir.pwd)).to_s)
   end
 
@@ -40,6 +41,7 @@ class GitAccess
 
   def changes
     return default_value if flag.nil? || !under_git?
+
     @changes ||= patch_diffs
   end
 
@@ -53,6 +55,7 @@ class GitAccess
 
   def default_value
     raise Ducalis::MissingGit unless flag.nil?
+
     []
   end
 

data/lib/ducalis/patch.rb

@@ -2,10 +2,10 @@
 
 module Ducalis
   class Patch
-    RANGE_LINE = /^@@ .+\+(?<line_number>\d+),/
-    MODIFIED_LINE = /^\+(?!\+|\+)/
-    NOT_REMOVED_LINE = /^[^-]/
-    ANY_LINE = /.*/
+    RANGE_LINE = /^@@ .+\+(?<line_number>\d+),/.freeze
+    MODIFIED_LINE = /^\+(?!\+|\+)/.freeze
+    NOT_REMOVED_LINE = /^[^-]/.freeze
+    ANY_LINE = /.*/.freeze
 
     DIFF_LINES = {
       RANGE_LINE => lambda do |lines, _line_number, line, _position|

data/lib/ducalis/patched_rubocop/git_turget_finder.rb

@@ -5,6 +5,7 @@ module PatchedRubocop
     def find_files(base_dir, flags)
       replacement = GitAccess.instance.changed_files
       return replacement unless replacement.empty?
+
       super
     end
   end

data/lib/ducalis/rubo_cop.rb

@@ -3,6 +3,7 @@
 module PatchedRubocop
   CURRENT_VERSION = Gem::Version.new(RuboCop::Version.version)
   ADAPTED_VERSION = Gem::Version.new('0.46.0')
+  SPEC_CHANGES_VERSION = Gem::Version.new('0.59.0')
 end
 
 module RuboCop

data/lib/ducalis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ducalis
-  VERSION = '0.11.1'.freeze
+  VERSION = '0.12.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ducalis
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.12.0
 platform: ruby
 authors:
 - Ignat Zakrevsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-07 00:00:00.000000000 Z
+date: 2018-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git
@@ -64,6 +64,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.2
+- !ruby/object:Gem::Dependency
+  name: regexp_parser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -111,6 +125,8 @@ files:
 - lib/ducalis/cops/black_list_suffix.rb
 - lib/ducalis/cops/callbacks_activerecord.rb
 - lib/ducalis/cops/case_mapping.rb
+- lib/ducalis/cops/complex_cases/smart_delete_check.rb
+- lib/ducalis/cops/complex_regex.rb
 - lib/ducalis/cops/controllers_except.rb
 - lib/ducalis/cops/data_access_objects.rb
 - lib/ducalis/cops/descriptive_block_names.rb