ducalis 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4558fbf8708c836a3ed1b13c07831f92f02f60a3e428996df38002ba68540440
-  data.tar.gz: b8423308b7ad62219226f0db48bebbcd9bde088f7ba3a938e93c078e914c08ee
+  metadata.gz: 32df7c2136c9843336bff23949966d6a557932631bc0d143a0b76111981aef71
+  data.tar.gz: 0b05601c199203849589a13c5469dccc3a6017dfbe07661c96d5f073846507d7
 SHA512:
-  metadata.gz: c91904bc9d0a53b0d626e642d4cc86b0436457e20e4d623c530116869dcd34c6df8e41f9447ab3688f3e2c0b4f7866ca300c83f91e5a67587379f1e7676cb14d
-  data.tar.gz: 45307edbf9c217bf7f757b59f3d98e5fec1902a60bb8079c043a4a846d3d653ce301a8de146cd911b74603c80c08a64db524292046b5f0dfdf0fc66567fc3148
+  metadata.gz: 7b2362aacc03c71f192f5fe671c8dd6270311a39f8be31b9fa712b9e67be36a114590ced0c21cd82a0d846d47a6d150592c63d7bf46ee691cd8c821220ace4e8
+  data.tar.gz: c49866725411c9e47a40967b171338651a0a8fc9ff8d1288c8d688be178e8ec80598971371fa1281dac5efbc94cfbbafc50287c2e20741714e711f39f8911530

data/Gemfile

@@ -10,3 +10,4 @@ gem 'bundler', '~> 1.16.a'
 gem 'pry', '~> 0.10', '>= 0.10.0'
 gem 'rake', '~> 12.1'
 gem 'rspec', '~> 3.0'
+gem 'single_cov', group: :test

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ducalis (0.9.0)
+    ducalis (0.10.0)
       git (~> 1.3, >= 1.3.0)
       octokit (>= 4.1.0)
       regexp-examples (~> 1.3, >= 1.3.2)
@@ -15,7 +15,7 @@ GEM
     ast (2.4.0)
     coderay (1.1.2)
     diff-lcs (1.3)
-    faraday (0.15.0)
+    faraday (0.15.1)
       multipart-post (>= 1.2, < 3)
     git (1.3.0)
     method_source (0.9.0)
@@ -57,6 +57,7 @@ GEM
     sawyer (0.8.1)
       addressable (>= 2.3.5, < 2.6)
       faraday (~> 0.8, < 1.0)
+    single_cov (1.0.3)
     unicode-display_width (1.3.2)
 
 PLATFORMS
@@ -68,6 +69,7 @@ DEPENDENCIES
   pry (~> 0.10, >= 0.10.0)
   rake (~> 12.1)
   rspec (~> 3.0)
+  single_cov
 
 BUNDLED WITH
    1.16.1

data/README.md

@@ -6,7 +6,7 @@
 
 __Ducalis__ is RuboCop-based static code analyzer for enterprise Rails applications.
 
-Documentation available at https://ducalis-rb.github.io/.
+Documentation available at https://ducalis-rb.github.io/. Changelog at https://ducalis-rb.github.io/log.
 
 __Ducalis__ isn't style checker and could sometimes be false-positive it's not
 necessary to follow all it rules, the main purpose of __Ducalis__ is help to find

data/lib/ducalis/cops/black_list_suffix.rb

@@ -5,7 +5,7 @@ require 'rubocop'
 module Ducalis
   class BlackListSuffix < RuboCop::Cop::Cop
     OFFENSE = <<-MESSAGE.gsub(/^ +\|\s/, '').strip
-      | Please, avoid using of class suffixes like `Meneger`, `Client` and so on. If it has no parts, change the name of the class to what each object is managing.
+      | Please, avoid using of class suffixes like `Manager`, `Client` and so on. If it has no parts, change the name of the class to what each object is managing.
 
       | It's ok to use Manager as subclass of Person, which is there to refine a type of personal that has management behavior to it.
     MESSAGE
@@ -24,7 +24,7 @@ module Ducalis
 
     def with_blacklisted_suffix?(name)
       return if cop_config['BlackList'].to_a.empty?
-      cop_config['BlackList'].any? { |suffix| name =~ /#{suffix}\Z/ }
+      cop_config['BlackList'].any? { |suffix| name.end_with?(suffix) }
     end
   end
 end

data/lib/ducalis/cops/keyword_defaults.rb

@@ -10,7 +10,6 @@ module Ducalis
 
     def on_def(node)
       args = node.type == :defs ? node.to_a[2] : node.to_a[1]
-      return unless args
       args.children.each do |arg_node|
         next unless arg_node.type == :optarg
         add_offense(node, :expression, OFFENSE)

data/lib/ducalis/cops/uncommented_gem.rb

@@ -17,8 +17,7 @@ module Ducalis
     def investigate(processed_source)
       return unless processed_source.ast
       gem_declarations(processed_source.ast).select do |node|
-        _, _, gemname, args = *node
-        next if args.nil? || args.type == :str
+        _, _, gemname, _args = *node
         next if commented?(processed_source, node)
         add_offense(node, :selector,
                     format(OFFENSE, gem: gemname.loc.expression.source))

data/lib/ducalis/documentation.rb

@@ -35,8 +35,8 @@ class SpecsProcessor < Parser::AST::Processor
 
   def source_code(node)
     prepare_code(node).tap do |code|
-      code.shift if code.first.empty?
-      code.pop if code.last.empty?
+      code.shift if code.first.to_s.empty?
+      code.pop if code.last.to_s.empty?
     end
   end
 

data/lib/ducalis/git_access.rb

@@ -17,7 +17,8 @@ class GitAccess
 
   attr_accessor :flag, :repo, :id
 
-  def store_pull_request!(repo, id)
+  def store_pull_request!(info)
+    repo, id = info
     self.repo = repo
     self.id = id
   end
@@ -50,12 +51,11 @@ class GitAccess
   end
 
   def default_value
-    raise MissingGit unless flag.nil?
+    raise Ducalis::MissingGit unless flag.nil?
     []
   end
 
   def find(path)
-    return NilDiff.new(nil, path) if changes.empty?
-    changes.find { |diff| diff.path == path }
+    changes.find { |diff| diff.path == path } || NilDiff.new(nil, path)
   end
 end

data/lib/ducalis/github_formatter.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 class GithubFormatter < RuboCop::Formatter::BaseFormatter
+  attr_reader :all
+
   def started(_target_files)
     @all = []
   end

data/lib/ducalis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ducalis
-  VERSION = '0.9.0'.freeze
+  VERSION = '0.10.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ducalis
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - Ignat Zakrevsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-09 00:00:00.000000000 Z
+date: 2018-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git