dubdubdub 0.3.4 → 0.3.5

data/dubdubdub.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "dubdubdub"
-  s.version = "0.3.4"
+  s.version = "0.3.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["James Hu"]
-  s.date = "2013-03-22"
+  s.date = "2013-04-03"
   s.description = "A library that provides web utility methods with proxification."
   s.email = "axsuul@gmail.com"
   s.extra_rdoc_files = [

data/lib/dubdubdub.rb

@@ -1,6 +1,6 @@
 class DubDubDub
   # Version
-  VERSION = "0.3.4"
+  VERSION = "0.3.5"
 
   attr_accessor :client
 

data/lib/dubdubdub/client.rb

@@ -99,10 +99,8 @@ class DubDubDub::Client
 
   # Helper method to browse by using a GET request via Mechanize
   def browse(url, *args)
-    handle_net_http_exceptions do
-      handle_mechanize_exceptions do
-        mechanize.get(url, *args)
-      end
+    handle_mechanize_exceptions do
+      mechanize.get(url, *args)
     end
   end
 
@@ -124,7 +122,7 @@ class DubDubDub::Client
 
   def handle_mechanize_exceptions(&block)
     begin
-      yield
+      handle_net_http_exceptions { yield }
     rescue Mechanize::RedirectLimitReachedError => e
       raise DubDubDub::RedirectLimitReachedError
     rescue Mechanize::ResponseCodeError => e
@@ -134,7 +132,7 @@ class DubDubDub::Client
 
   def handle_rest_client_exceptions(&block)
     begin
-      yield
+      handle_net_http_exceptions { yield }
     rescue RestClient::MaxRedirectsReached => e
       raise DubDubDub::RedirectLimitReachedError
     rescue RestClient::Exception => e

data/spec/dubdubdub_spec.rb

@@ -190,6 +190,29 @@ describe DubDubDub do
     it "raise the proper exception when exceeding maximum redirects", vcr: { cassette_name: "get/infinite_redirects", record: :once } do
       lambda { www.get("http://wayback.archive.org/web/20050204085854im_/http://www.drpep.com/images/home_19.gif") }.should raise_error(DubDubDub::RedirectLimitReachedError)
     end
+
+    it "raises proper timeout exception if it times out", vcr: { cassette_name: "get/timeout", record: :once } do
+      pending "Long running test, comment out to run it"
+      ip_address = "4.4.4.4"
+      lambda { www.get(ip_address) }.should raise_error(DubDubDub::ResponseError)
+
+      begin
+        www.get(ip_address)
+      rescue DubDubDub::ResponseError => e
+        e.code.should == 408
+      end
+    end
+
+    it "raises proper exception if domain doesn't resolve", vcr: { cassette_name: "get/domain_unresolvable", record: :once } do
+      domain = "balhblahlbal123123123123.com"
+      lambda { www.get(domain) }.should raise_error(DubDubDub::ResponseError)
+
+      begin
+        www.get(domain)
+      rescue DubDubDub::ResponseError => e
+        e.code.should == 404
+      end
+    end
   end
 
   describe '#crawl' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dubdubdub
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-22 00:00:00.000000000 Z
+date: 2013-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -211,7 +211,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1417612097550344492
+      hash: -3903339609961508869
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: