dscf-banking 0.4.3 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62982b0cad2a1b7cb691b2dc9ea75d8ab9df94874ab14e8ebf666f12196a6594
-  data.tar.gz: 502e5b823ae9b25c029e4894ee577b3cbf03d4381cd553ab620259ddd0821d4f
+  metadata.gz: f764f4b5e4f7553dc346b1835f96121e002bfa92099433ba364188e143ad9fa1
+  data.tar.gz: b36403d3550af4a8a95bb107da9aeab7b5c7b7de91fcc90f6041f9e3bb0027ce
 SHA512:
-  metadata.gz: 9100d4ae1ddc8996c123dc4818544e53416aa9acc846e654523db07be7bbb54c06a32aac5f175dfd5a2022ba036aaa24383f63ad835e18dbd2236864f1a20cee
-  data.tar.gz: 1254e95686e5f38bd48be9bf1671456e0c909dc848b8971391d68ead6c74e6f1390f14841fd2466f276700da184f7a4ca85af81cfd6715293be70861660f023c
+  metadata.gz: ee47d83e10b5bb5a69c4ca40e27282e41d0bd8838df800ddd22f019059c1972b0dbc43dd49187b0ee03894d5cc6e2373c7049b83507656ec537b9832e7e13394
+  data.tar.gz: 792bd5f2fc5c96a072cca1ee59b3b3a818be47ab5905497448b0c193e4fee8ad4eca86d7ff2c5587d05bd8a07093d23591dee242a26768b0b11e56b5f1e51b60

data/app/services/dscf/banking/voucher_service.rb

@@ -54,7 +54,7 @@ module Dscf
         self
       end
 
-      def redeem_voucher(code:, amount:, recipient_mobile:, destination_account: nil)
+      def redeem_voucher(code:, amount:, recipient_mobile: nil, destination_account: nil)
         amount = amount.to_f
         code = code.to_s.strip.upcase
         @voucher = Dscf::Banking::Voucher.find_by(code: code)
@@ -64,8 +64,8 @@ module Dscf
           return self
         end
 
-        return self unless validate_redeem_params(amount, recipient_mobile)
-        return self unless validate_voucher_state(@voucher, amount, recipient_mobile)
+        return self unless validate_redeem_params(amount)
+        return self unless validate_voucher_state(@voucher, amount)
         return self unless ensure_voucher_settlement_funds(@voucher.currency, amount)
 
         if destination_account
@@ -84,7 +84,7 @@ module Dscf
             voucher: @voucher,
             amount: amount,
             currency: @voucher.currency,
-            recipient_mobile: recipient_mobile,
+            recipient_mobile: recipient_mobile.presence || "N/A",
             destination_account: destination_account,
             redeemed_at: Time.current
           )
@@ -197,21 +197,16 @@ module Dscf
         30.days.from_now
       end
 
-      def validate_redeem_params(amount, recipient_mobile)
+      def validate_redeem_params(amount)
         if amount <= 0
           add_error("Redemption amount must be greater than zero")
           return false
         end
 
-        if recipient_mobile.to_s.strip.empty?
-          add_error("Recipient mobile is required")
-          return false
-        end
-
         true
       end
 
-      def validate_voucher_state(voucher, amount, recipient_mobile)
+      def validate_voucher_state(voucher, amount)
         if voucher.cancelled?
           add_error("Voucher is cancelled")
           return false
@@ -227,11 +222,6 @@ module Dscf
           return false
         end
 
-        if voucher.recipient_mobile != recipient_mobile
-          add_error("Recipient mobile does not match")
-          return false
-        end
-
         if voucher.remaining_amount.to_f < amount
           add_error("Insufficient voucher balance")
           return false

data/lib/dscf/banking/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Banking
-    VERSION = "0.4.3"
+    VERSION = "0.4.5"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-banking
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.5
 platform: ruby
 authors:
 - Asrat Efrem
 bindir: bin
 cert_chain: []
-date: 2026-02-24 00:00:00.000000000 Z
+date: 2026-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails