dscf-banking 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9fc221b52889b3f647a6bf2aece413c37920cd18b793e15507d0c54d10d64049
-  data.tar.gz: 36c852689c3e64245e5b3f36bbd31d54506e04e82fb259329e4c711274ce9e48
+  metadata.gz: 1b7834f2745a3928e7857c8460f4f85ef499ea7a760b1ca8d3dabeb3545886b8
+  data.tar.gz: 373cb2daa82e54960ee7e0219bd9cbc61576246e5516600f1796369ad9431395
 SHA512:
-  metadata.gz: 35049ee207d00a654faf0f8bdebf0e24c6cbed1e0534a923814040bd88d667b89e8bb643e7b35ff14555cce633b68d99c0fce786a4a8e2b6ecac0aff06c28cd0
-  data.tar.gz: d3d6818202de5b7ecdcfc5a7d33495a0d4040b2c00b8f63b0ed13a45645c7a53852209e960c6cb89770f51578e3893843afd1023fa96e061f74ab769666e58b8
+  metadata.gz: 1f7ab2f858766b2b722baa9fdc837646dbb686e18066e92f997a7e2cb5e80b8089d6ec1eedd109428a456ec8d4a4a6a6c8f79b7eb9268a92fb17074bd2b54b67
+  data.tar.gz: 347cfd2b812e210a23bd255be66429a73fc492f28d74cb112a8d93672c9acd60e1fa2236ed65beadf38a75c96d1c6118b80da441ab070b048d02b726a8f12804

data/app/controllers/dscf/banking/applications_controller.rb

@@ -5,18 +5,21 @@ module Dscf::Banking
 
     # Custom default context for applications
     reviewable_context :default,
-      statuses: %w[draft submitted under_review approved rejected],
+      statuses: %w[draft submitted under_review approved rejected request_modification],
       initial_status: "submitted",
       transitions: {
         "draft" => %w[submitted],
-        "submitted" => %w[under_review approved rejected],
-        "under_review" => %w[approved rejected]
+        "submitted" => %w[under_review approved rejected request_modification],
+        "under_review" => %w[approved rejected request_modification],
+        "request_modification" => %w[submitted]
       },
       actions: {
         submit: { status: "submitted" },
         assign_for_review: { status: "under_review" },
         approve: { status: "approved" },
-        reject: { status: "rejected", require_feedback: true }
+        reject: { status: "rejected", require_feedback: true },
+        request_modification: { status: "request_modification", require_feedback: true },
+        resubmit: { status: "submitted", update_model: true }
       }
 
     private
@@ -49,7 +52,7 @@ module Dscf::Banking
     end
 
     def eager_loaded_associations
-      [ :user, :virtual_account_product, :documents, reviews: { reviewed_by: :user_profile } ]
+      [ :user, :virtual_account_product, reviews: { reviewed_by: :user_profile } ]
     end
 
     def allowed_order_columns
@@ -58,10 +61,10 @@ module Dscf::Banking
 
     def default_serializer_includes
       {
-        index: [:user, :virtual_account_product, :documents, reviews: { reviewed_by: :user_profile }],
-        show: [:user, :virtual_account_product, :account, :documents, reviews: { reviewed_by: :user_profile }],
-        create: [:documents, :reviews],
-        update: [:user, :virtual_account_product, :account, :documents, reviews: { reviewed_by: :user_profile }]
+        index: [:user, :virtual_account_product, reviews: { reviewed_by: :user_profile }],
+        show: [:user, :virtual_account_product, :account, reviews: { reviewed_by: :user_profile }],
+        create: [:reviews],
+        update: [:user, :virtual_account_product, :account, reviews: { reviewed_by: :user_profile }]
       }
     end
   end

data/app/controllers/dscf/banking/documents_controller.rb

@@ -1,154 +0,0 @@
-module Dscf::Banking
-  class DocumentsController < ApplicationController
-    include Dscf::Core::Common
-
-    def index
-      documents = Dscf::Core::Document.all
-
-      # Handle nested routes
-      if params[:application_id].present?
-        documents = documents.where(documentable_type: "Dscf::Banking::Application", documentable_id: params[:application_id])
-      end
-
-      # Filter by documentable type and ID if provided
-      if params[:documentable_type].present? && params[:documentable_id].present?
-        documents = documents.where(documentable_type: params[:documentable_type], documentable_id: params[:documentable_id])
-      end
-
-      # Filter by document type if provided
-      documents = documents.where(document_type: params[:document_type]) if params[:document_type].present?
-
-      # Apply ordering
-      order_column = allowed_order_columns.include?(params[:order_by]) ? params[:order_by] : "created_at"
-      order_direction = %w[asc desc].include?(params[:order_direction]) ? params[:order_direction] : "desc"
-      documents = documents.order("#{order_column} #{order_direction}")
-
-      render json: {
-        success: true,
-        data: documents.map { |document| document_data(document) }
-      }
-    end
-
-    def show
-      document = Dscf::Core::Document.find(params[:id])
-      render json: {
-        success: true,
-        data: document_data(document)
-      }
-    rescue ActiveRecord::RecordNotFound
-      render json: {
-        success: false,
-        error: "Document not found"
-      }, status: :not_found
-    end
-
-    def create
-      document_params = model_params
-
-      # Handle nested routes - set documentable_type and documentable_id from URL params
-      if params[:application_id].present?
-        document_params[:documentable_type] = "Dscf::Banking::Application"
-        document_params[:documentable_id] = params[:application_id]
-      end
-
-      document = Dscf::Core::Document.new(document_params)
-
-      if document.save
-        render json: {
-          success: true,
-          data: document_data(document)
-        }, status: :created
-      else
-        render json: {
-          success: false,
-          error: "Failed to create document",
-          errors: document.errors.full_messages
-        }, status: :unprocessable_content
-      end
-    end
-
-    def update
-      document = Dscf::Core::Document.find(params[:id])
-
-      if document.update(model_params)
-        render json: {
-          success: true,
-          data: document_data(document)
-        }
-      else
-        render json: {
-          success: false,
-          error: "Failed to update document",
-          errors: document.errors.full_messages
-        }, status: :unprocessable_content
-      end
-    rescue ActiveRecord::RecordNotFound
-      render json: {
-        success: false,
-        error: "Document not found"
-      }, status: :not_found
-    end
-
-    def destroy
-      document = Dscf::Core::Document.find(params[:id])
-
-      if document.destroy
-        render json: {
-          success: true,
-          message: "Document deleted successfully"
-        }
-      else
-        render json: {
-          success: false,
-          error: "Failed to delete document"
-        }, status: :unprocessable_content
-      end
-    rescue ActiveRecord::RecordNotFound
-      render json: {
-        success: false,
-        error: "Document not found"
-      }, status: :not_found
-    end
-
-    private
-
-    def document_data(document)
-      {
-        id: document.id,
-        document_type: document.document_type,
-        file_url: document.file_url,
-        documentable_type: document.documentable_type,
-        documentable_id: document.documentable_id,
-        verified_by: document.verified_by,
-        created_at: document.created_at,
-        updated_at: document.updated_at
-      }
-    rescue => e
-      # Handle cases where file_url might fail (e.g., ActiveStorage not set up)
-      {
-        id: document.id,
-        document_type: document.document_type,
-        file_url: nil,
-        documentable_type: document.documentable_type,
-        documentable_id: document.documentable_id,
-        verified_by: document.verified_by,
-        created_at: document.created_at,
-        updated_at: document.updated_at
-      }
-    end
-
-    def model_params
-      params.require(:document).permit(
-        :document_type,
-        :documentable_type,
-        :documentable_id,
-        :verified_by_id,
-        :file
-      )
-    end
-
-    def allowed_order_columns
-      %w[id document_type created_at updated_at]
-    end
-  end
-end

data/app/models/dscf/banking/application.rb

@@ -8,7 +8,6 @@ module Dscf::Banking
     belongs_to :assigned_branch_manager, class_name: "Dscf::Core::User", optional: true
     belongs_to :virtual_account_product, class_name: "Dscf::Banking::VirtualAccountProduct"
     has_one :account, class_name: "Dscf::Banking::Account"
-    has_many :documents, as: :documentable, class_name: "Dscf::Core::Document"
 
     validates :application_number, presence: true, uniqueness: true, length: { maximum: 50 }
     validates :applicant_type, presence: true
@@ -54,7 +53,7 @@ module Dscf::Banking
     end
 
     def self.ransackable_associations(auth_object = nil)
-      %w[user virtual_account_product account reviews documents]
+      %w[user virtual_account_product account reviews]
     end
 
     private

data/app/serializers/dscf/banking/application_serializer.rb

@@ -9,7 +9,6 @@ module Dscf::Banking
     belongs_to :assigned_branch_manager, optional: true
     has_one :account, serializer: AccountSerializer, if: :has_account?
     has_many :reviews, serializer: Dscf::Core::ReviewSerializer
-    has_many :documents, serializer: Dscf::Banking::DocumentSerializer
 
     def has_account?
       object.has_account?

data/app/serializers/dscf/banking/document_serializer.rb

@@ -1,7 +0,0 @@
-module Dscf::Banking
-  class DocumentSerializer < ActiveModel::Serializer
-    attributes :id, :document_type, :file_url, :created_at, :updated_at
-
-    belongs_to :verified_by, polymorphic: true, optional: true
-  end
-end

data/config/locales/en.yml

@@ -18,8 +18,12 @@ en:
       assign_for_review: "Application assigned for review successfully"
       approve: "Application approved successfully"
       reject: "Application rejected successfully"
+      request_modification: "Modification requested for application"
+      resubmit: "Application resubmitted successfully"
     errors:
       submit: "Failed to submit application"
       assign_for_review: "Failed to assign application for review"
       approve: "Failed to approve application"
-      reject: "Failed to reject application"
+      reject: "Failed to reject application"
+      request_modification: "Failed to request modification for application"
+      resubmit: "Failed to resubmit application"

data/config/routes.rb

@@ -27,12 +27,11 @@ Dscf::Banking::Engine.routes.draw do
       patch :assign_for_review
       patch :approve
       patch :reject
+      patch :request_modification
+      patch :resubmit
     end
-    resources :documents, only: [:index, :create]
   end
 
-  resources :documents
-
   resources :transaction_types
 
   resources :transactions do

data/lib/dscf/banking/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Banking
-    VERSION = "0.2.3"
+    VERSION = "0.2.4"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-banking
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Eyosiyas Mekbib
 bindir: bin
 cert_chain: []
-date: 2025-10-12 00:00:00.000000000 Z
+date: 2025-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails