dscf-banking 0.1.16 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3be6cb234512da6ec3f02e719d9f3a7315c29711a1510541c4f6431bb7c2934a
-  data.tar.gz: 4e1d771356543e224441f1c68b4e8d343c755be3dbc72299e79cec4871e4fabd
+  metadata.gz: '094b7617272cff3416e77ed910c60da7f90887cea49f72e091c25f1afd53ed69'
+  data.tar.gz: 1a0f6c7facbbabfd8c1bac7681a9acd6cd104dd09cb5b23115ed0859a977ae7f
 SHA512:
-  metadata.gz: 7b45b884c53a7fa29feb90a0d33aa584b48b961560504eaa97a2802446e32d8508169e180557947195b34fb5d02ee25fe728ae1d881180d45f13238b230ec305
-  data.tar.gz: 2f0828d64d4dee6222e155e97dfeae0f1bcfb66f9162ae7566baf34b82cd5c603821def2de710633662206993cf6055817c766a5a9706a595a069e69e16465a8
+  metadata.gz: 5b9dd2e200c84a1a7cc56f4d857589b9ea732f7a9497184286e47f1aa989ee116449ce55a2d28153ab95e817e99c419ceaa19a2a143c0085e4a9b0e59b081621
+  data.tar.gz: 7af432c8545eac1b2537376d23cb5802bf2fb31964f89377b39e36d96fc26646f19e9ad1f4bb0c9c7a21fd62c4f8f3df3ca38f5bf34f21e76cbd578dc6b46608

data/app/controllers/dscf/banking/accounts_controller.rb

@@ -2,6 +2,106 @@ module Dscf::Banking
   class AccountsController < ApplicationController
     include Dscf::Core::Common
 
+    def index
+      accounts = Dscf::Banking::Account.all
+
+      # Apply filters that require joins
+      if params[:user_id].present?
+        accounts = accounts.joins(:application).where("dscf_banking_applications.user_id = ?", params[:user_id])
+      end
+
+      # Apply other filters
+      accounts = accounts.where(status: params[:status]) if params[:status].present?
+      accounts = accounts.where(currency: params[:currency]) if params[:currency].present?
+      accounts = accounts.where(application_id: params[:application_id]) if params[:application_id].present?
+      accounts = accounts.where(virtual_account_product_id: params[:virtual_account_product_id]) if params[:virtual_account_product_id].present?
+      accounts = accounts.where(active: params[:active]) if params[:active].present?
+
+      # Apply ordering
+      order_column = allowed_order_columns.include?(params[:order_by]) ? params[:order_by] : "created_at"
+      order_direction = %w[asc desc].include?(params[:order_direction]) ? params[:order_direction] : "desc"
+      accounts = accounts.order("#{order_column} #{order_direction}")
+
+      render json: {
+        success: true,
+        data: accounts.map { |account| account_data(account) }
+      }
+    end
+
+    def show
+      account = Dscf::Banking::Account.find(params[:id])
+      render json: {
+        success: true,
+        data: account_data(account)
+      }
+    rescue ActiveRecord::RecordNotFound
+      render json: {
+        success: false,
+        error: "Account not found"
+      }, status: :not_found
+    end
+
+    def create
+      account = Dscf::Banking::Account.new(model_params)
+
+      if account.save
+        render json: {
+          success: true,
+          data: account_data(account)
+        }, status: :created
+      else
+        render json: {
+          success: false,
+          error: "Failed to create account",
+          errors: account.errors.full_messages
+        }, status: :unprocessable_entity
+      end
+    end
+
+    def update
+      account = Dscf::Banking::Account.find(params[:id])
+
+      if account.update(model_params)
+        render json: {
+          success: true,
+          data: account_data(account)
+        }
+      else
+        render json: {
+          success: false,
+          error: "Failed to update account",
+          errors: account.errors.full_messages
+        }, status: :unprocessable_entity
+      end
+    rescue ActiveRecord::RecordNotFound
+      render json: {
+        success: false,
+        error: "Account not found"
+      }, status: :not_found
+    end
+
+    def destroy
+      account = Dscf::Banking::Account.find(params[:id])
+
+      if account.destroy
+        render json: {
+          success: true,
+          message: "Account deleted successfully"
+        }
+      else
+        render json: {
+          success: false,
+          error: "Failed to delete account",
+          errors: account.errors.full_messages
+        }, status: :bad_request
+      end
+    rescue ActiveRecord::RecordNotFound
+      render json: {
+        success: false,
+        error: "Account not found"
+      }, status: :not_found
+    end
+
     def activate
       account = Dscf::Banking::Account.find(params[:id])
 
@@ -112,6 +212,7 @@ module Dscf::Banking
         active: account.active,
         application_id: account.application_id,
         virtual_account_product_id: account.virtual_account_product_id,
+        account_properties: account.account_properties,
         created_at: account.created_at,
         updated_at: account.updated_at
       }
@@ -135,7 +236,7 @@ module Dscf::Banking
     end
 
     def eager_loaded_associations
-      [ :application, :virtual_account_product ]
+      []
     end
 
     def allowed_order_columns

data/db/seeds.rb

@@ -1,125 +1,51 @@
 # db/seeds.rb
-
-# DEBUG: Confirm seed file execution and model availability
-puts "Seed file started"
-puts "Dscf::Core::User loaded? => #{defined?(Dscf::Core::User)}"
-puts "Dscf::Core::Role loaded? => #{defined?(Dscf::Core::Role)}"
-
-# DSCF Banking Engine Seed Data
-# This file seeds the database with sample data for all models in the correct dependency order
-
-puts "Starting DSCF Banking Engine seed data..."
-
-
-# 1. Seed roles (if model exists)
+# This file should contain all the record creation needed to seed the database with its default values.
+# The data can then be loaded with the bin/rails db:seed command (or created alongside the database with db:setup).
+#
+# Examples:
+#
+#   movies = Movie.create([{ name: "Star Wars" }, { name: "Lord of the Rings" }])
+#   Character.create(name: "Luke", movie: movies.first)
+
+# Seed roles based on RBAC documentation
 puts "Seeding roles..."
-if defined?(Dscf::Core::Role)
-  user_role = Dscf::Core::Role.find_or_create_by(code: 'user') do |role|
-    role.name = 'User'
-  end
-  officer_role = Dscf::Core::Role.find_or_create_by(code: 'virtual_account_officer') do |role|
-    role.name = 'Virtual Account Officer'
-  end
-  manager_role = Dscf::Core::Role.find_or_create_by(code: 'virtual_account_manager') do |role|
-    role.name = 'Virtual Account Manager'
-  end
-  kyc_officer_role = Dscf::Core::Role.find_or_create_by(code: 'kyc_officer') do |role|
-    role.name = 'KYC Officer'
-  end
-  branch_manager_role = Dscf::Core::Role.find_or_create_by(code: 'branch_manager') do |role|
-    role.name = 'Branch Manager'
-  end
-  puts "✓ Roles created/found"
-else
-  puts "Warning: Dscf::Core::Role model not found. Skipping role seeding."
-end
-# 2. Seed users with roles (if model exists)
+user_role = Role.find_or_create_by(name: 'User')
+officer_role = Role.find_or_create_by(name: 'Virtual Account Officer')
+manager_role = Role.find_or_create_by(name: 'Virtual Account Manager')
+kyc_officer_role = Role.find_or_create_by(name: 'KYC Officer')
+branch_manager_role = Role.find_or_create_by(name: 'Branch Manager')
+puts "Roles seeded successfully."
+
+# Seed users with roles
 puts "Seeding users..."
-if defined?(Dscf::Core::User)
-  user1 = Dscf::Core::User.find_or_create_by(email: "user@banking.com") do |u|
-    u.phone = "+251911123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user1.roles << user_role if defined?(user_role)
-  puts "Created user: #{user1.email} (user@banking.com)"
-
-  user2 = Dscf::Core::User.find_or_create_by(email: "virtual_account_officer@banking.com") do |u|
-    u.phone = "+251922123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user2.roles << officer_role if defined?(officer_role)
-  puts "Created user: #{user2.email} (virtual_account_officer@banking.com)"
+# Create users and assign roles
+user1 = User.create(name: "Abebe Kebede", email: "abebe@example.com", password: "SecurePassword123!")
+user1.roles << user_role
+puts "Created user: #{user1.name}"
 
-  user3 = Dscf::Core::User.find_or_create_by(email: "virtual_account_manager@banking.com") do |u|
-    u.phone = "+251933123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user3.roles << manager_role if defined?(manager_role)
-  puts "Created user: #{user3.email} (virtual_account_manager@banking.com)"
+user2 = User.create(name: "Tigist Haile", email: "tigist@example.com", password: "SecurePassword123!")
+user2.roles << officer_role
+puts "Created user: #{user2.name}"
 
-  user4 = Dscf::Core::User.find_or_create_by(email: "user_virtual_account_officer@banking.com") do |u|
-    u.phone = "+251944123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user4.roles << user_role if defined?(user_role)
-  user4.roles << officer_role if defined?(officer_role)
-  puts "Created user: #{user4.email} (user_virtual_account_officer@banking.com)"
+user3 = User.create(name: "Dawit Mekonnen", email: "dawit@example.com", password: "SecurePassword123!")
+user3.roles << manager_role
+puts "Created user: #{user3.name}"
 
-  user5 = Dscf::Core::User.find_or_create_by(email: "virtual_account_manager2@banking.com") do |u|
-    u.phone = "+251955123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user5.roles << manager_role if defined?(manager_role)
-  puts "Created user: #{user5.email} (virtual_account_manager2@banking.com)"
+# Additional users for testing
+user4 = User.create(name: "Hirut Assefa", email: "hirut@example.com", password: "SecurePassword123!")
+user4.roles << [ user_role, officer_role ]  # User with multiple roles if supported
+puts "Created user: #{user4.name}"
 
-  user6 = Dscf::Core::User.find_or_create_by(email: "kyc_officer@banking.com") do |u|
-    u.phone = "+251966123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user6.roles << kyc_officer_role if defined?(kyc_officer_role)
-  puts "Created user: #{user6.email} (kyc_officer@banking.com)"
+user5 = User.create(name: "Solomon Tesfaye", email: "solomon@example.com", password: "SecurePassword123!")
+user5.roles << manager_role
+puts "Created user: #{user5.name}"
 
-  user7 = Dscf::Core::User.find_or_create_by(email: "branch_manager@banking.com") do |u|
-    u.phone = "+251977123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user7.roles << branch_manager_role if defined?(branch_manager_role)
-  puts "Created user: #{user7.email} (branch_manager@banking.com)"
-else
-  puts "Warning: Dscf::Core::User model not found. Skipping user seeding."
-end# 3. Seed transaction types (engine model)
-puts "Seeding transaction types..."
-if defined?(Dscf::Banking::TransactionType)
-  transaction_types = [
-    { name: "Deposit", code: "DEP" },
-    { name: "Withdrawal", code: "WDL" },
-    { name: "Transfer", code: "TRF" },
-    { name: "Interest Credit", code: "INTC" },
-    { name: "Fee Debit", code: "FEED" }
-  ]
+user6 = User.create(name: "Mulugeta Bekele", email: "mulugeta@example.com", password: "SecurePassword123!")
+user6.roles << kyc_officer_role
+puts "Created user: #{user6.name}"
 
-  transaction_types.each do |attrs|
-    Dscf::Banking::TransactionType.find_or_create_by(code: attrs[:code]) do |tt|
-      tt.name = attrs[:name]
-    end
-  end
-  puts "✓ Transaction types created/found"
-else
-  puts "Warning: Dscf::Banking::TransactionType not found. Skipping transaction type seeding."
-end
+user7 = User.create(name: "Fikirte Alemayehu", email: "fikirte@example.com", password: "SecurePassword123!")
+user7.roles << branch_manager_role
+puts "Created user: #{user7.name}"
 
-puts "DSCF Banking Engine seed data completed successfully!"
+puts "Seeding completed successfully."

data/lib/dscf/banking/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Banking
-    VERSION = "0.1.16"
+    VERSION = "0.2.0"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-banking
 version: !ruby/object:Gem::Version
-  version: 0.1.16
+  version: 0.2.0
 platform: ruby
 authors:
 - Eyosiyas Mekbib
 bindir: bin
 cert_chain: []
-date: 2025-09-20 00:00:00.000000000 Z
+date: 2025-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails