dry-validation 0.13.1 → 0.13.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66ce6c3fe11f428f8552627416495ac25fc71367cd2baf551748c98f0cbfccf4
-  data.tar.gz: 97d1341fc9b6b7cede1544c12a165e8a14c84178b4186bfb5595c80bd9e81ed5
+  metadata.gz: 1a31ac4653e7f148d6ee09543b38c81f9670bc40c51c8644414aacc000e66357
+  data.tar.gz: 2c84a8c6b29bb290f3e24505a9f52c1abcc31c777b54ed4140bc38225e5410d2
 SHA512:
-  metadata.gz: a237d513a5b6695ee8a31ba7ced7d7c745941dc5694388bc669ef836184a3e01e68c95f0550836dfac6ef26f4301715e4376faa9acc4082ff8ca37e7fd4dc717
-  data.tar.gz: 6b8b1f080122332b63877ac9b114ee4f07e3185a893452d50a4156b6360a339ed05f14ced976b4a58bfbe456f0cf7493c26dd236af802e32465e5cfd0ca56e24
+  metadata.gz: afb6b1de3fea9028ec2d4ffd481b9a49a79f2a9192c0101122a00c4b567d99e5d53083c130cc1789d643b9c80a5b7c98384e776d36c746a3ca1ff83ea80b1caf
+  data.tar.gz: d287f0d13f12c65a476de805e6fd95175eea35da74b679dd0fcb98e8ac616e000cf465db769b2e53e5db2e082173c30a3c8c16cffe0537517e96dbd499e8d004

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# v0.13.2 2019-05-12
+
+### Fixed
+
+* Caching message templates uses restricted set of known keys to calculate cache keys (solnic)
+
+[Compare v0.13.1...v0.13.2](https://github.com/dry-rb/dry-validation/compare/v0.13.1...v0.13.2)
+
 # v0.13.1 2019-03-22
 
 ### Changed

data/Gemfile

@@ -14,11 +14,6 @@ end
 group :tools do
   gem 'pry-byebug', platform: :mri
   gem 'pry', platform: :jruby
-
-  unless ENV['TRAVIS']
-    gem 'mutant', git: 'https://github.com/mbj/mutant'
-    gem 'mutant-rspec', git: 'https://github.com/mbj/mutant'
-  end
 end
 
 group :benchmarks do

data/lib/dry/validation/messages/abstract.rb

@@ -40,6 +40,8 @@ module Dry
           String => 'string'
         )
 
+        CACHE_KEYS = %i[path message_type val_type arg_type locale].freeze
+
         def self.cache
           @cache ||= Concurrent::Map.new { |h, k| h[k] = Concurrent::Map.new }
         end
@@ -59,14 +61,24 @@ module Dry
           get(path, options) if key?(path, options)
         end
 
-        def call(*args)
-          cache.fetch_or_store(args.hash) do
-            path, opts = lookup(*args)
+        def call(predicate, options = EMPTY_HASH)
+          cache.fetch_or_store(cache_key(predicate, options)) do
+            path, opts = lookup(predicate, options)
             get(path, opts) if path
           end
         end
         alias_method :[], :call
 
+        if ::Hash.instance_methods.include?(:slice)
+          def cache_key(predicate, options)
+            [predicate, options.slice(*CACHE_KEYS)]
+          end
+        else
+          def cache_key(predicate, options)
+            [predicate, options.select { |key,| CACHE_KEYS.include?(key) }]
+          end
+        end
+
         def lookup(predicate, options = {})
           tokens = options.merge(
             root: root,
@@ -100,7 +112,7 @@ module Dry
         end
 
         def cache
-          @cache ||= self.class.cache[self]
+          @cache ||= self.class.cache[hash]
         end
 
         def default_locale

data/lib/dry/validation/version.rb

@@ -1,5 +1,5 @@
 module Dry
   module Validation
-    VERSION = '0.13.1'.freeze
+    VERSION = '0.13.2'.freeze
   end
 end

data/spec/spec_helper.rb

@@ -50,6 +50,10 @@ RSpec.configure do |config|
         self
       end
     end
+
+    Dry::Validation::Messages::Abstract.instance_variable_set('@cache', nil)
+    Dry::Validation::Messages::YAML.instance_variable_set('@cache', nil)
+    Dry::Validation::Messages::I18n.instance_variable_set('@cache', nil) if defined?(I18n)
   end
 
   config.after do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-validation
 version: !ruby/object:Gem::Version
-  version: 0.13.1
+  version: 0.13.2
 platform: ruby
 authors:
 - Andy Holland
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-22 00:00:00.000000000 Z
+date: 2019-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -371,7 +371,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A simple validation library