dry-types 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a22d275ce9f27a5be0edd1ce02714dbf571ee95abab2ab8e127b88e61317ac3
-  data.tar.gz: 8708d3ceb67ff3a726ae0363fe04fd08da440f3fdf7ae4e2f5632104fdf33810
+  metadata.gz: 2b3fc7a2d5685f6e867418934765d0e3a4ecfbc5b62385ee371a38e15c09e9b1
+  data.tar.gz: 07ef4d9b60132cf459fbf18709e44b275e23f94141a3dc975d2eb50e7ac500e8
 SHA512:
-  metadata.gz: 5ff0c69309f200eef77442aef6e9452046f75394c16b00f0be12cdbad04a8c34a1a02e87e0347fb1875fc0241a83f79e1b70576ad4d4e5202cde40257af3e3bb
-  data.tar.gz: 6eef147d7238f8ead4f254f37a0f018d5fc932ea3dd87bf334c06c3f0eb4110372078c4dcfad27c80a1dcfe161cc6955942d1daeffda6cd8980f3770b7a3c8b1
+  metadata.gz: 1b82208815b88c0c3291b4bb6db0ddf781d2cd13fad10e98b265b79bf070a2099c5a010cb20a313f9f3833a6b6f6ce2839938a51c34d73a1eaa4eaf2952868af
+  data.tar.gz: cccb4e835c977bfa978e4fd7d9d253810e9c83b9e5b181bb44b544caff966bd71957c7d730de17f2d5081f05a0be527495bf16b6222bbbe3657fa897fc33e085

data/.github/ISSUE_TEMPLATE/---bug-report.md

@@ -9,11 +9,7 @@ assignees: ''
 
 **Before you submit this: WE ONLY ACCEPT BUG REPORTS AND FEATURE REQUESTS**
 
-For more information see [our contribution guidelines](https://github.com/rom-rb/rom/blob/master/CONTRIBUTING.md)
-
-**Before you report**
-
-:warning: If you have a problem related to a schema, please **report it under [dry-schema issues](https://github.com/dry-rb/dry-schema/issues/new?assignees=&labels=bug&template=---bug-report.md&title=)** instead.
+For more information see `CONTRIBUTING.md`.
 
 **Describe the bug**
 

data/.github/workflows/custom_ci.yml

@@ -3,7 +3,7 @@ name: ci
 on:
   push:
     paths:
-      - .github/workflows/ci.yml
+      - .github/workflows/custom_ci.yml
       - lib/**
       - spec/**
 
@@ -57,7 +57,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        image: ["jruby:9.2.8", "ruby:rc"]
+        image: ["jruby:9.2.9", "ruby:rc"]
         dry_logic_from_master: ["true", "false"]
     container:
       image: ${{matrix.image}}

data/.rubocop.yml

@@ -87,3 +87,6 @@ Naming/MethodName:
 
 Style/AsciiComments:
   Enabled: false
+
+Style/DateTime:
+  Enabled: false

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+# 1.2.2 2019-12-14
+
+## Fixed
+
+- `Types.Contructor` doesn't re-wrap class instances implementing type interface, this fixes some quirks in dry-struct (flash-gordon)
+
+## Changed
+
+- Types now use immutable equalizers. This should improve performance in certain cases e.g. in ROM (flash-gordon)
+- Attempting to use non-symbol keys in hash schemas raises an error. We always supported only symbols as keys but there was no check, now it'll throw an argument error. If you want to convert strings to symbols, use `Hash#with_key_transform` (flash-gordon)
+- Params and JSON types accept Time/Date/Datetime instances and boolean values. This can be useful in tests but we discourage you from relying on this behavior in production code. For example, building structs with `Params` types is considered a smell. There are dedicated tools for coercion, namely dry-schema and dry-validation. Be responsible user of dry-types! ❤ (flash-gordon)
+
+[Compare v1.2.1...v1.2.2](https://github.com/dry-rb/dry-types/compare/v1.2.1...v1.2.2)
+
 # 1.2.1 2019-11-07
 
 ## Fixed

data/Gemfile

@@ -12,6 +12,8 @@ group :test do
   platform :mri do
     gem 'simplecov', require: false
   end
+
+  gem 'dry-struct'
 end
 
 group :tools do

data/README.md

@@ -1,21 +1,20 @@
 [gem]: https://rubygems.org/gems/dry-types
-[travis]: https://travis-ci.com/dry-rb/dry-types
+[ci]: https://github.com/dry-rb/dry-types/actions?query=workflow%3Aci
 [codeclimate]: https://codeclimate.com/github/dry-rb/dry-types
-[coveralls]: https://coveralls.io/r/dry-rb/dry-types
 [inchpages]: http://inch-ci.org/github/dry-rb/dry-types
 [chat]: https://dry-rb.zulipchat.com
 
 # dry-types [![Join the chat at https://dry-rb.zulipchat.com](https://img.shields.io/badge/dry--rb-join%20chat-%23346b7a.svg)][chat]
 
 [![Gem Version](https://badge.fury.io/rb/dry-types.svg)][gem]
-[![Build Status](https://travis-ci.com/dry-rb/dry-types.svg?branch=master)][travis]
+[![Build Status](https://github.com/dry-rb/dry-types/workflows/ci/badge.svg)][ci]
 [![Code Climate](https://codeclimate.com/github/dry-rb/dry-types/badges/gpa.svg)][codeclimate]
 [![Test Coverage](https://codeclimate.com/github/dry-rb/dry-types/badges/coverage.svg)][codeclimate]
 [![Inline docs](http://inch-ci.org/github/dry-rb/dry-types.svg?branch=master)][inchpages]
 
 ## Links
 
-* [Documentation](http://dry-rb.org/gems/dry-types)
+- [Documentation](http://dry-rb.org/gems/dry-types)
 
 ## Development
 

data/docsite/source/hash-schemas.html.md

@@ -143,7 +143,7 @@ user_hash[{}]
 Type transformations work perfectly with inheritance, you don't have to define same rules more than once:
 
 ```ruby
-SymbolizeAndOptionalSchema = Types::Hash.
+SymbolizeAndOptionalSchema = Types::Hash
   .schema({})
   .with_key_transform(&:to_sym)
   .with_type_transform { |type| type.required(false) }

data/dry-types.gemspec

@@ -35,7 +35,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'concurrent-ruby', '~> 1.0'
   spec.add_runtime_dependency 'dry-container', '~> 0.3'
   spec.add_runtime_dependency 'dry-core', '~> 0.4', '>= 0.4.4'
-  spec.add_runtime_dependency 'dry-equalizer', '~> 0.2', '>= 0.2.2'
+  spec.add_runtime_dependency 'dry-equalizer', '~> 0.3'
   spec.add_runtime_dependency 'dry-inflector', '~> 0.1', '>= 0.1.2'
   spec.add_runtime_dependency 'dry-logic', '~> 1.0', '>= 1.0.2'
 

data/lib/dry/types/builder_methods.rb

@@ -83,7 +83,11 @@ module Dry
       # @return [Dry::Types::Type]
       def Constructor(klass, cons = nil, &block)
         if klass.is_a?(Type)
-          klass.constructor(cons || block || klass.method(:new))
+          if cons || block
+            klass.constructor(cons || block)
+          else
+            klass
+          end
         else
           Nominal(klass).constructor(cons || block || klass.method(:new))
         end

data/lib/dry/types/coercions.rb

@@ -39,6 +39,8 @@ module Dry
           rescue ArgumentError, RangeError => e
             CoercionError.handle(e, &block)
           end
+        elsif input.is_a?(::Date)
+          input
         elsif block_given?
           yield
         else
@@ -60,6 +62,8 @@ module Dry
           rescue ArgumentError => e
             CoercionError.handle(e, &block)
           end
+        elsif input.is_a?(::DateTime)
+          input
         elsif block_given?
           yield
         else
@@ -81,6 +85,8 @@ module Dry
           rescue ArgumentError => e
             CoercionError.handle(e, &block)
           end
+        elsif input.is_a?(::Time)
+          input
         elsif block_given?
           yield
         else

data/lib/dry/types/coercions/params.rb

@@ -14,7 +14,7 @@ module Dry
         FALSE_VALUES = %w[0 off Off OFF f false False FALSE F n no No NO N].freeze
         BOOLEAN_MAP = ::Hash[
           TRUE_VALUES.product([true]) + FALSE_VALUES.product([false])
-        ].freeze
+        ].merge(true => true, false => false).freeze
 
         extend Coercions
 

data/lib/dry/types/constrained.rb

@@ -14,7 +14,7 @@ module Dry
       include Decorator
       include Builder
       include Printable
-      include Dry::Equalizer(:type, :rule, inspect: false)
+      include Dry::Equalizer(:type, :rule, inspect: false, immutable: true)
 
       # @return [Dry::Logic::Rule]
       attr_reader :rule

data/lib/dry/types/constructor.rb

@@ -10,7 +10,7 @@ module Dry
     #
     # @api public
     class Constructor < Nominal
-      include Dry::Equalizer(:type, :options, inspect: false)
+      include Dry::Equalizer(:type, :options, inspect: false, immutable: true)
 
       # @return [#call]
       attr_reader :fn

data/lib/dry/types/constructor/function.rb

@@ -146,7 +146,7 @@ module Dry
           last_arg.equal?(:block)
         end
 
-        include Dry::Equalizer(:fn)
+        include Dry::Equalizer(:fn, immutable: true)
 
         attr_reader :fn
 

data/lib/dry/types/default.rb

@@ -10,7 +10,7 @@ module Dry
     class Default
       # @api private
       class Callable < Default
-        include Dry::Equalizer(:type, inspect: false)
+        include Dry::Equalizer(:type, inspect: false, immutable: true)
 
         # Evaluates given callable
         # @return [Object]
@@ -23,7 +23,7 @@ module Dry
       include Decorator
       include Builder
       include Printable
-      include Dry::Equalizer(:type, :value, inspect: false)
+      include Dry::Equalizer(:type, :value, inspect: false, immutable: true)
 
       # @return [Object]
       attr_reader :value

data/lib/dry/types/enum.rb

@@ -9,7 +9,7 @@ module Dry
     # @api public
     class Enum
       include Type
-      include Dry::Equalizer(:type, :mapping, inspect: false)
+      include Dry::Equalizer(:type, :mapping, inspect: false, immutable: true)
       include Decorator
       include Builder
 

data/lib/dry/types/errors.rb

@@ -2,7 +2,7 @@
 
 module Dry
   module Types
-    extend Dry::Core::ClassAttributes
+    extend ::Dry::Core::ClassAttributes
 
     # @!attribute [r] namespace
     #   @return [Container{String => Nominal}]
@@ -12,7 +12,7 @@ module Dry
 
     # Base class for coercion errors raise by dry-types
     #
-    class CoercionError < StandardError
+    class CoercionError < ::StandardError
       # @api private
       def self.handle(exception, meta: Undefined)
         if block_given?
@@ -34,7 +34,7 @@ module Dry
       # @api private
       def initialize(message, meta: Undefined, backtrace: Undefined)
         unless message.is_a?(::String)
-          raise ArgumentError, "message must be a string, #{message.class} given"
+          raise ::ArgumentError, "message must be a string, #{message.class} given"
         end
 
         super(message)
@@ -74,9 +74,9 @@ module Dry
       end
     end
 
-    MapError = Class.new(CoercionError)
+    MapError = ::Class.new(CoercionError)
 
-    SchemaKeyError = Class.new(CoercionError)
+    SchemaKeyError = ::Class.new(CoercionError)
     private_constant(:SchemaKeyError)
 
     class MissingKeyError < SchemaKeyError

data/lib/dry/types/extensions/maybe.rb

@@ -10,7 +10,7 @@ module Dry
     # @api public
     class Maybe
       include Type
-      include Dry::Equalizer(:type, :options, inspect: false)
+      include Dry::Equalizer(:type, :options, inspect: false, immutable: true)
       include Decorator
       include Builder
       include Printable

data/lib/dry/types/lax.rb

@@ -13,7 +13,7 @@ module Dry
       include Decorator
       include Builder
       include Printable
-      include Dry::Equalizer(:type, inspect: false)
+      include Dry::Equalizer(:type, inspect: false, immutable: true)
 
       undef :options, :constructor
 

data/lib/dry/types/nominal.rb

@@ -19,7 +19,7 @@ module Dry
       include Meta
       include Builder
       include Printable
-      include Dry::Equalizer(:primitive, :options, :meta, inspect: false)
+      include Dry::Equalizer(:primitive, :options, :meta, inspect: false, immutable: true)
 
       # @return [Class]
       attr_reader :primitive

data/lib/dry/types/result.rb

@@ -8,7 +8,7 @@ module Dry
     #
     # @api public
     class Result
-      include Dry::Equalizer(:input, inspect: false)
+      include Dry::Equalizer(:input, inspect: false, immutable: true)
 
       # @return [Object]
       attr_reader :input
@@ -43,7 +43,7 @@ module Dry
       #
       # @api public
       class Failure < Result
-        include Dry::Equalizer(:input, :error, inspect: false)
+        include Dry::Equalizer(:input, :error, inspect: false, immutable: true)
 
         # @return [#to_s]
         attr_reader :error

data/lib/dry/types/schema/key.rb

@@ -17,7 +17,7 @@ module Dry
       class Key
         extend ::Dry::Core::Deprecations[:'dry-types']
         include Type
-        include Dry::Equalizer(:name, :type, :options, inspect: false)
+        include Dry::Equalizer(:name, :type, :options, inspect: false, immutable: true)
         include Decorator
         include Builder
         include Printable
@@ -31,6 +31,10 @@ module Dry
             type.meta.fetch(:required) { !type.meta.fetch(:omittable, false) }
           end
 
+          unless name.is_a?(::Symbol)
+            raise ArgumentError, "Schemas can only contain symbol keys, #{name.inspect} given"
+          end
+
           super(type, name, required: required, **options)
           @name = name
         end

data/lib/dry/types/sum.rb

@@ -14,7 +14,7 @@ module Dry
       include Options
       include Meta
       include Printable
-      include Dry::Equalizer(:left, :right, :options, :meta, inspect: false)
+      include Dry::Equalizer(:left, :right, :options, :meta, inspect: false, immutable: true)
 
       # @return [Type]
       attr_reader :left

data/lib/dry/types/version.rb

@@ -2,6 +2,6 @@
 
 module Dry
   module Types
-    VERSION = '1.2.1'
+    VERSION = '1.2.2'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-types
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-07 00:00:00.000000000 Z
+date: 2019-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -64,20 +64,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.2.2
+        version: '0.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.2.2
+        version: '0.3'
 - !ruby/object:Gem::Dependency
   name: dry-inflector
   requirement: !ruby/object:Gem::Requirement