dry-transaction 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e09ce8534f0529de0e5feaeb72a882ac04b1b4a
-  data.tar.gz: 511ab8cb1bb59ca3c40e506e39a95b9b7c47898e
+  metadata.gz: a1086edb5c79856eea4443feca03571381d01656
+  data.tar.gz: 396497b3dc1c00bac2b526d5dd9b2db3b94aec86
 SHA512:
-  metadata.gz: 9e3cb97c3772c704e15c2e1bb76d58bd163c3eb88663d834d0964610f3eb413b216940f3a1271deea081e50745a13577ee144f6c25fc5cedd54955d47dbbc1a1
-  data.tar.gz: bb448e0f12ec06cc3abf6f753bb84d2f1b09430ef28deda5b7763f81e2d06b22ed97c20ea695dcd5eb24737537acf4d30e001148f026a1f7d9a9a2e84baebfac
+  metadata.gz: 99f8334aabeda041d3d591affdde7030ddf9c227149a9f98230949adb076561fc903413bad9a51a634eeb26c6ccbe416bceb2d3a156dcf8a5d003b4d14df06e1
+  data.tar.gz: 1157a95e3126ea8108bbea2c795f1e094bcadd4ecddb26c1e62af2c1a9ebef7c32b181d9d67b3a62df0326f681c2ab7bd3448e302dcc42c43bfaa0c6a21e0a01

data/Gemfile

@@ -1,3 +1,13 @@
 source "https://rubygems.org"
 
 gemspec
+
+group :test do
+  gem "codeclimate-test-reporter", require: nil
+  gem "byebug", platform: :mri
+end
+
+group :tools do
+  gem "pry"
+  gem "dry-container"
+end

data/Gemfile.lock

@@ -1,17 +1,33 @@
 PATH
   remote: .
   specs:
-    dry-transaction (0.5.0)
+    dry-transaction (0.6.0)
+      dry-container (>= 0.2.8)
       kleisli
       wisper (>= 1.6.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    byebug (8.2.2)
+    codeclimate-test-reporter (0.5.0)
+      simplecov (>= 0.7.1, < 1.0.0)
+    coderay (1.1.1)
+    concurrent-ruby (1.0.1)
     diff-lcs (1.2.5)
     docile (1.1.5)
+    dry-configurable (0.1.4)
+      concurrent-ruby (~> 1.0)
+    dry-container (0.3.1)
+      concurrent-ruby (~> 1.0)
+      dry-configurable (~> 0.1, >= 0.1.3)
     json (1.8.3)
     kleisli (0.2.7)
+    method_source (0.8.2)
+    pry (0.10.3)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
     rake (10.4.2)
     rspec (3.3.0)
       rspec-core (~> 3.3.0)
@@ -31,6 +47,7 @@ GEM
       json (~> 1.8)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.0)
+    slop (3.6.0)
     wisper (1.6.1)
     yard (0.8.7.6)
 
@@ -38,8 +55,12 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.10)
+  bundler (~> 1.11.2)
+  byebug
+  codeclimate-test-reporter
+  dry-container
   dry-transaction!
+  pry
   rake (~> 10.4.2)
   rspec (~> 3.3.0)
   simplecov (~> 0.10.0)

data/README.md

@@ -11,192 +11,12 @@
 [![Code Climate](https://img.shields.io/codeclimate/github/dry-rb/dry-transaction.svg)][code_climate]
 [![API Documentation Coverage](http://inch-ci.org/github/dry-rb/dry-transaction.svg)][inch]
 
-dry-transaction is a business transaction DSL. It provides a simple way to define a complex business transaction that includes processing by many different objects. It makes error handling a primary concern by using a “[Railway Oriented Programming](http://fsharpforfunandprofit.com/rop/)” approach for capturing and returning errors from any step in the transaction.
+dry-transaction is a business transaction DSL. It provides a simple way to define a complex business transaction that includes processing by many different objects.
 
-dry-transaction is based on the following ideas:
+## Links
 
-* A business transaction is a series of operations where each can fail and stop processing.
-* A business transaction resolves its dependencies using an external container object and it doesn’t know any details about the individual operation objects except their identifiers.
-* A business transaction can describe its steps on an abstract level without being coupled to any details about how individual operations work.
-* A business transaction doesn’t have any state.
-* Each operation shouldn’t accumulate state, instead it should receive an input and return an output without causing any side-effects.
-* The only interface of a an operation is `#call(input)`.
-* Each operation provides a meaningful functionality and can be reused.
-* Errors in any operation can be easily caught and handled as part of the normal application flow.
-
-## Why?
-
-Requiring a business transaction’s steps to exist as independent operations directly addressable via a container means that they can be tested in isolation and easily reused throughout your application. Following from this, keeping the business transaction to a series of high-level, declarative steps ensures that it’s easy to understand at a glance.
-
-The output of each step is wrapped in a [Kleisli](https://github.com/txus/kleisli) `Either` object (`Right` for success or `Left` for failure). This allows the steps to be chained together and ensures that processing stops in the case of a failure. Returning an `Either` from the overall transaction also allows for error handling to remain a primary concern without it getting in the way of tidy, straightforward operation logic. Wrapping the step output also means that you can work with a wide variety of operations within your application – they don’t need to return an `Either` already.
-
-## Usage
-
-### Container
-
-All you need to use dry-transaction is a container to hold your application’s operations. Each operation must respond to `#call(input)`.
-
-The operations will be resolved from the container via `#[]`. For our examples, we’ll use a plain hash:
-
-```ruby
-container = {
-  process:  -> input { {name: input["name"], email: input["email"]} },
-  validate: -> input { input[:email].nil? ? raise(ValidationFailure, "not valid") : input },
-  persist:  -> input { DB << input and true }
-}
-```
-
-For larger apps, you may like to consider something like [dry-container](https://github.com/dryrb/dry-container).
-
-### Defining a transaction
-
-Define a transaction to bring your opererations together:
-
-```ruby
-save_user = Dry.Transaction(container: container) do
-  map :process
-  try :validate, catch: ValidationFailure
-  tee :persist
-end
-```
-
-Operations are formed into steps using _step adapters._ Step adapters wrap the output of your operations to make them easy to integrate into a transaction. The following adapters are available:
-
-* `step` – the operation already returns an `Either` object (`Right(output)` for success and `Left(output)` for failure), and needs no special handling.
-* `map` – any output is considered successful and returned as `Right(output)`
-* `try` – the operation may raise an exception in an error case. This is caught and returned as `Left(exception)`. The output is otherwise returned as `Right(output)`.
-* `tee` – the operation interacts with some external system and has no meaningful output. The original input is passed through and returned as `Right(input)`.
-
-### Calling a transaction
-
-Calling a transaction will run its operations in their specified order, with the output of each operation becoming the input for the next.
-
-```ruby
-DB = []
-
-save_user.call("name" => "Jane", "email" => "jane@doe.com")
-# => Right({:name=>"Jane", :email=>"jane@doe.com"})
-
-DB
-# => [{:name=>"Jane", :email=>"jane@doe.com"}]
-```
-
-Each transaction returns a result value wrapped in a `Left` or `Right` object (based on the output of its final step). You can handle these results (including errors arising from particular steps) with a match block:
-
-```ruby
-save_user.call(name: "Jane", email: "jane@doe.com") do |m|
-  m.success do |value|
-    puts "Succeeded!"
-  end
-
-  m.failure :validate do |error|
-    # In a more realistic example, you’d loop through a list of messages in `errors`.
-    puts "Please provide an email address."
-  end
-
-  m.failure do |error|
-    puts "Couldn’t save this user."
-  end
-end
-```
-
-### Passing additional step arguments
-
-Additional arguments for step operations can be passed at the time of calling your transaction. Provide these arguments as an array, and they’ll be [splatted](https://endofline.wordpress.com/2011/01/21/the-strange-ruby-splat/) into the front of the operation’s arguments. This means that transactions can effectively support operations with any sort of `#call(*args, input)` interface.
-
-```ruby
-DB = []
-
-container = {
-  process:  -> input { {name: input["name"], email: input["email"]} },
-  validate: -> allowed, input { input[:email].include?(allowed) ? raise(ValidationFailure, "not allowed") : input },
-  persist:  -> input { DB << input and true }
-}
-
-save_user = Dry.Transaction(container: container) do
-  map :process
-  try :validate, catch: ValidationFailure
-  tee :persist
-end
-
-input = {"name" => "Jane", "email" => "jane@doe.com"}
-save_user.call(input, validate: ["doe.com"])
-# => Right({:name=>"Jane", :email=>"jane@doe.com"})
-
-save_user.call(input, validate: ["smith.com"])
-# => Left("not allowed")
-```
-
-### Subscribing to step notifications
-
-As well as pattern matching on the final transaction result, you can subscribe to individual steps and trigger specific behaviour based on their success or failure:
-
-```ruby
-NOTIFICATIONS = []
-
-module UserPersistListener
-  extend self
-
-  def persist_success(user)
-    NOTIFICATIONS << "#{user[:email]} persisted"
-  end
-
-  def persist_failure(user)
-    NOTIFICATIONS << "#{user[:email]} failed to persist"
-  end
-end
-
-
-input = {"name" => "Jane", "email" => "jane@doe.com"}
-
-save_user.subscribe(persist: UserPersistListener)
-save_user.call(input, validate: ["doe.com"])
-
-NOTIFICATIONS
-# => ["jane@doe.com persisted"]
-```
-
-This pub/sub mechanism is provided by the [Wisper](https://github.com/krisleech/wisper) gem. You can subscribe to specific steps using the `#subscribe(step_name: listener)` API, or subscribe to all steps via `#subscribe(listener)`.
-
-### Extending transactions
-
-You can extend existing transactions by inserting or removing steps. See the [API docs](http://www.rubydoc.info/github/dry-rb/dry-transaction/Dry/Transaction/Sequence) for more information.
-
-### Working with a larger container
-
-In practice, your container won’t be a trivial collection of generically named operations. You can keep your transaction step names simple by using the `with:` option to provide the identifiers for the operations within your container:
-
-```ruby
-save_user = Dry.Transaction(container: large_whole_app_container) do
-  map :process, with: "attributes.user"
-  try :validate, with: "validations.user", catch: ValidationFailure
-  tee :persist, with: "persistance.commands.update_user"
-end
-```
-
-## Installation
-
-Add this line to your application’s `Gemfile`:
-
-```ruby
-gem "dry-transaction"
-```
-
-Run `bundle` to install the gem.
-
-## Documentation
-
-View the [full API documentation](http://www.rubydoc.info/github/dry-rb/dry-transaction) on RubyDoc.info.
-
-## Contributing
-
-Bug reports and pull requests are welcome on [GitHub](http://github.com/dry-rb/dry-transaction).
-
-## Credits
-
-dry-transaction is developed and maintained by [Icelab](http://icelab.com.au/).
-
-dry-transaction’s error handling is based on Scott Wlaschin’s [Railway Oriented Programming](http://fsharpforfunandprofit.com/rop/), found via Zohaib Rauf’s [Railway Oriented Programming in Elixir](http://zohaib.me/railway-programming-pattern-in-elixir/) blog post. dry-transaction’s behavior as a business transaction library draws heavy inspiration from Piotr Solnica’s [Transflow](http://github.com/solnic/transflow) and Gilbert B Garza’s [Solid Use Case](https://github.com/mindeavor/solid_use_case). Josep M. Bach’s [Kleisli](https://github.com/txus/kleisli) gem makes functional programming patterns in Ruby accessible and fun. Thank you all!
+* [Documentation](http://dry-rb.org/gems/dry-transaction)
+* [API documentation](http://www.rubydoc.info/github/dry-rb/dry-transaction)
 
 ## License
 

data/lib/dry/transaction/dsl.rb

@@ -1,41 +1,39 @@
 require "dry/transaction/step"
 require "dry/transaction/step_adapters"
-require "dry/transaction/step_adapters/base"
-require "dry/transaction/step_adapters/map"
-require "dry/transaction/step_adapters/raw"
-require "dry/transaction/step_adapters/tee"
-require "dry/transaction/step_adapters/try"
 require "dry/transaction/sequence"
 
 module Dry
   module Transaction
+    # @api private
     class DSL
-      # @api private
-      attr_reader :options
-
-      # @api private
       attr_reader :container
-
-      # @api private
+      attr_reader :step_adapters
       attr_reader :steps
 
-      # @api private
       def initialize(options, &block)
-        @options = options
         @container = options.fetch(:container)
+        @step_adapters = options.fetch(:step_adapters, StepAdapters)
         @steps = []
 
-        instance_exec(&block)
+        instance_eval(&block)
+      end
+
+      def respond_to_missing?(method_name)
+        step_adapters.key?(method_name)
       end
 
-      StepAdapters.each do |adapter_name, adapter_class|
-        define_method adapter_name do |step_name, options = {}|
-          operation = container[options.fetch(:with, step_name)]
-          steps << Step.new(step_name, adapter_class.new(operation, options))
-        end
+      def method_missing(method_name, *args)
+        return super unless step_adapters.key?(method_name)
+
+        step_adapter = step_adapters[method_name]
+        step_name = args.first
+        options = args.last.is_a?(Hash) ? args.last : {}
+        operation_name = options.delete(:with) || step_name
+        operation = container[operation_name]
+
+        steps << Step.new(step_adapter, step_name, operation_name, operation, options)
       end
 
-      # @api private
       def call
         Sequence.new(steps)
       end

data/lib/dry/transaction/sequence.rb

@@ -72,7 +72,7 @@ module Dry
       #   my_transaction.subscribe(my_listener)
       #
       # @example Subscribing to notifications from specific steps
-      #   my_transaction.subscirbe(some_step: my_listener, another_step: another_listener)
+      #   my_transaction.subscribe(some_step: my_listener, another_step: another_listener)
       #
       # Notifications are implemented using the [Wisper](wisper) gem.
       #

data/lib/dry/transaction/step.rb

@@ -7,23 +7,29 @@ module Dry
     class Step
       include Wisper::Publisher
 
+      attr_reader :step_adapter
       attr_reader :step_name
+      attr_reader :operation_name
       attr_reader :operation
+      attr_reader :options
       attr_reader :call_args
 
-      def initialize(step_name, operation, call_args = [])
+      def initialize(step_adapter, step_name, operation_name, operation, options, call_args = [])
+        @step_adapter = step_adapter
         @step_name = step_name
+        @operation_name = operation_name
         @operation = operation
+        @options = options
         @call_args = call_args
       end
 
       def with_call_args(*call_args)
-        self.class.new(step_name, operation, call_args)
+        self.class.new(step_adapter, step_name, operation_name, operation, options, call_args)
       end
 
       def call(input)
         args = call_args + [input]
-        result = operation.call(*args)
+        result = step_adapter.call(self, *args)
 
         result.fmap { |value|
           broadcast :"#{step_name}_success", value
@@ -35,7 +41,7 @@ module Dry
       end
 
       def arity
-        operation.arity
+        operation.is_a?(Proc) ? operation.arity : operation.method(:call).arity
       end
     end
   end

data/lib/dry/transaction/step_adapters.rb

@@ -1,27 +1,14 @@
-require "forwardable"
+require "dry-container"
 
 module Dry
   module Transaction
-    module StepAdapters
-      @registry = {}
-
-      class << self
-        attr_reader :registry
-        private :registry
-
-        extend Forwardable
-        def_delegators :registry, :[], :each
-
-        # Register a step adapter.
-        #
-        # @param [Symbol] name the name to expose for adding steps to a transaction
-        # @param klass the step adapter class
-        #
-        # @api public
-        def register(name, klass)
-          registry[name.to_sym] = klass
-        end
-      end
+    class StepAdapters
+      extend Dry::Container::Mixin
     end
   end
 end
+
+require "dry/transaction/step_adapters/map"
+require "dry/transaction/step_adapters/raw"
+require "dry/transaction/step_adapters/tee"
+require "dry/transaction/step_adapters/try"

data/lib/dry/transaction/step_adapters/map.rb

@@ -1,14 +1,14 @@
 module Dry
   module Transaction
-    module StepAdapters
+    class StepAdapters
       # @api private
-      class Map < Base
-        def call(*args, input)
-          Right(operation.call(*args, input))
+      class Map
+        def call(step, *args, input)
+          Right(step.operation.call(*args, input))
         end
       end
 
-      register :map, Map
+      register :map, Map.new
     end
   end
 end

data/lib/dry/transaction/step_adapters/raw.rb

@@ -1,14 +1,22 @@
+require "kleisli"
+
 module Dry
   module Transaction
-    module StepAdapters
+    class StepAdapters
       # @api private
-      class Raw < Base
-        def call(*args, input)
-          operation.call(*args, input)
+      class Raw
+        def call(step, *args, input)
+          result = step.operation.call(*args, input)
+
+          unless result.is_a?(Kleisli::Either)
+            raise ArgumentError, "step +#{step.step_name}+ must return an Either object"
+          end
+
+          result
         end
       end
 
-      register :step, Raw
+      register :step, Raw.new
     end
   end
 end

data/lib/dry/transaction/step_adapters/tee.rb

@@ -1,15 +1,15 @@
 module Dry
   module Transaction
-    module StepAdapters
+    class StepAdapters
       # @api private
-      class Tee < Base
-        def call(*args, input)
-          operation.call(*args, input)
+      class Tee
+        def call(step, *args, input)
+          step.operation.call(*args, input)
           Right(input)
         end
       end
 
-      register :tee, Tee
+      register :tee, Tee.new
     end
   end
 end

data/lib/dry/transaction/step_adapters/try.rb

@@ -1,21 +1,20 @@
 module Dry
   module Transaction
-    module StepAdapters
+    class StepAdapters
       # @api private
-      class Try < Base
-        def initialize(*)
-          super
-          raise ArgumentError, "+try+ steps require one or more exception classes provided via +catch:+" unless options[:catch]
-        end
+      class Try
+        def call(step, *args, input)
+          unless step.options[:catch]
+            raise ArgumentError, "+try+ steps require one or more exception classes provided via +catch:+"
+          end
 
-        def call(*args, input)
-          Right(operation.call(*args, input))
-        rescue *Array(options[:catch]) => e
+          Right(step.operation.call(*args, input))
+        rescue *Array(step.options[:catch]) => e
           Left(e)
         end
       end
 
-      register :try, Try
+      register :try, Try.new
     end
   end
 end

data/lib/dry/transaction/version.rb

@@ -1,6 +1,6 @@
 module Dry
   # Business transaction DSL.
   module Transaction
-    VERSION = "0.5.0".freeze
+    VERSION = "0.6.0".freeze
   end
 end

data/spec/examples.txt

@@ -1,41 +1,43 @@
 example_id                                               | status | run_time        |
 -------------------------------------------------------- | ------ | --------------- |
-./spec/integration/passing_step_arguments_spec.rb[1:1:1] | passed | 0.00101 seconds |
-./spec/integration/passing_step_arguments_spec.rb[1:2:1] | passed | 0.00284 seconds |
-./spec/integration/passing_step_arguments_spec.rb[1:3:1] | passed | 0.00047 seconds |
-./spec/integration/publishing_step_events_spec.rb[1:1:1] | passed | 0.00063 seconds |
-./spec/integration/publishing_step_events_spec.rb[1:1:2] | passed | 0.00518 seconds |
-./spec/integration/publishing_step_events_spec.rb[1:2:1] | passed | 0.00041 seconds |
-./spec/integration/publishing_step_events_spec.rb[1:2:2] | passed | 0.00036 seconds |
+./spec/integration/custom_step_adapters_spec.rb[1:1]     | passed | 0.00032 seconds |
+./spec/integration/passing_step_arguments_spec.rb[1:1:1] | passed | 0.001 seconds   |
+./spec/integration/passing_step_arguments_spec.rb[1:2:1] | passed | 0.00021 seconds |
+./spec/integration/passing_step_arguments_spec.rb[1:3:1] | passed | 0.0002 seconds  |
+./spec/integration/publishing_step_events_spec.rb[1:1:1] | passed | 0.00089 seconds |
+./spec/integration/publishing_step_events_spec.rb[1:1:2] | passed | 0.00323 seconds |
+./spec/integration/publishing_step_events_spec.rb[1:2:1] | passed | 0.00071 seconds |
+./spec/integration/publishing_step_events_spec.rb[1:2:2] | passed | 0.00032 seconds |
 ./spec/integration/transaction_spec.rb[1:1:1]            | passed | 0.00166 seconds |
-./spec/integration/transaction_spec.rb[1:1:2]            | passed | 0.00049 seconds |
-./spec/integration/transaction_spec.rb[1:1:3]            | passed | 0.00045 seconds |
-./spec/integration/transaction_spec.rb[1:1:4]            | passed | 0.00101 seconds |
-./spec/integration/transaction_spec.rb[1:1:5]            | passed | 0.00028 seconds |
-./spec/integration/transaction_spec.rb[1:2:1]            | passed | 0.00024 seconds |
-./spec/integration/transaction_spec.rb[1:2:2]            | passed | 0.00022 seconds |
-./spec/integration/transaction_spec.rb[1:2:3]            | passed | 0.00033 seconds |
-./spec/integration/transaction_spec.rb[1:2:4]            | passed | 0.00038 seconds |
-./spec/integration/transaction_spec.rb[1:2:5]            | passed | 0.00021 seconds |
-./spec/integration/transaction_spec.rb[1:2:6]            | passed | 0.00022 seconds |
-./spec/integration/transaction_spec.rb[1:3:1]            | passed | 0.00214 seconds |
-./spec/integration/transaction_spec.rb[1:3:2]            | passed | 0.00037 seconds |
+./spec/integration/transaction_spec.rb[1:1:2]            | passed | 0.00031 seconds |
+./spec/integration/transaction_spec.rb[1:1:3]            | passed | 0.00024 seconds |
+./spec/integration/transaction_spec.rb[1:1:4]            | passed | 0.00033 seconds |
+./spec/integration/transaction_spec.rb[1:1:5]            | passed | 0.00036 seconds |
+./spec/integration/transaction_spec.rb[1:2:1]            | passed | 0.00029 seconds |
+./spec/integration/transaction_spec.rb[1:2:2]            | passed | 0.00023 seconds |
+./spec/integration/transaction_spec.rb[1:2:3]            | passed | 0.00025 seconds |
+./spec/integration/transaction_spec.rb[1:2:4]            | passed | 0.00025 seconds |
+./spec/integration/transaction_spec.rb[1:2:5]            | passed | 0.00026 seconds |
+./spec/integration/transaction_spec.rb[1:2:6]            | passed | 0.00024 seconds |
+./spec/integration/transaction_spec.rb[1:3:1]            | passed | 0.00242 seconds |
+./spec/integration/transaction_spec.rb[1:3:2]            | passed | 0.00023 seconds |
 ./spec/integration/transaction_spec.rb[1:3:3]            | passed | 0.00022 seconds |
-./spec/unit/sequence_spec.rb[1:1:1]                      | passed | 0.00014 seconds |
-./spec/unit/sequence_spec.rb[1:1:2]                      | passed | 0.00032 seconds |
-./spec/unit/sequence_spec.rb[1:1:3]                      | passed | 0.00032 seconds |
-./spec/unit/sequence_spec.rb[1:1:4]                      | passed | 0.00013 seconds |
-./spec/unit/sequence_spec.rb[1:2:1]                      | passed | 0.00031 seconds |
-./spec/unit/sequence_spec.rb[1:2:2]                      | passed | 0.00017 seconds |
-./spec/unit/sequence_spec.rb[1:2:3]                      | passed | 0.00012 seconds |
-./spec/unit/sequence_spec.rb[1:2:4]                      | passed | 0.00013 seconds |
-./spec/unit/sequence_spec.rb[1:3:1]                      | passed | 0.00013 seconds |
-./spec/unit/sequence_spec.rb[1:3:2]                      | passed | 0.00014 seconds |
-./spec/unit/sequence_spec.rb[1:4:1]                      | passed | 0.00034 seconds |
-./spec/unit/sequence_spec.rb[1:4:2]                      | passed | 0.00031 seconds |
-./spec/unit/sequence_spec.rb[1:4:3]                      | passed | 0.00016 seconds |
-./spec/unit/sequence_spec.rb[1:4:4]                      | passed | 0.00011 seconds |
-./spec/unit/sequence_spec.rb[1:4:5:1]                    | passed | 0.00017 seconds |
-./spec/unit/sequence_spec.rb[1:4:5:2]                    | passed | 0.00033 seconds |
-./spec/unit/sequence_spec.rb[1:4:6:1]                    | passed | 0.00033 seconds |
-./spec/unit/sequence_spec.rb[1:4:6:2]                    | passed | 0.00015 seconds |
+./spec/integration/transaction_spec.rb[1:4:1]            | passed | 0.00026 seconds |
+./spec/unit/sequence_spec.rb[1:1:1]                      | passed | 0.00028 seconds |
+./spec/unit/sequence_spec.rb[1:1:2]                      | passed | 0.00017 seconds |
+./spec/unit/sequence_spec.rb[1:1:3]                      | passed | 0.00015 seconds |
+./spec/unit/sequence_spec.rb[1:1:4]                      | passed | 0.00017 seconds |
+./spec/unit/sequence_spec.rb[1:2:1]                      | passed | 0.0003 seconds  |
+./spec/unit/sequence_spec.rb[1:2:2]                      | passed | 0.00021 seconds |
+./spec/unit/sequence_spec.rb[1:2:3]                      | passed | 0.0023 seconds  |
+./spec/unit/sequence_spec.rb[1:2:4]                      | passed | 0.00161 seconds |
+./spec/unit/sequence_spec.rb[1:3:1]                      | passed | 0.00018 seconds |
+./spec/unit/sequence_spec.rb[1:3:2]                      | passed | 0.00018 seconds |
+./spec/unit/sequence_spec.rb[1:4:1]                      | passed | 0.00027 seconds |
+./spec/unit/sequence_spec.rb[1:4:2]                      | passed | 0.0003 seconds  |
+./spec/unit/sequence_spec.rb[1:4:3]                      | passed | 0.00017 seconds |
+./spec/unit/sequence_spec.rb[1:4:4]                      | passed | 0.00014 seconds |
+./spec/unit/sequence_spec.rb[1:4:5:1]                    | passed | 0.0002 seconds  |
+./spec/unit/sequence_spec.rb[1:4:5:2]                    | passed | 0.00018 seconds |
+./spec/unit/sequence_spec.rb[1:4:6:1]                    | passed | 0.00021 seconds |
+./spec/unit/sequence_spec.rb[1:4:6:2]                    | passed | 0.00021 seconds |

data/spec/integration/custom_step_adapters_spec.rb

@@ -0,0 +1,37 @@
+RSpec.describe "Custom step adapters" do
+  let(:transaction) {
+    Dry.Transaction(container: container, step_adapters: Test::CustomStepAdapters) do
+      map :process
+      tee :persist
+      enqueue :deliver
+    end
+  }
+
+  let(:container) {
+    {
+      process: -> input { {name: input["name"], email: input["email"]} },
+      persist: -> input { Test::DB << input and true },
+      deliver: -> input { "Delivered email to #{input[:email]}" },
+    }
+  }
+
+  before do
+    Test::DB = []
+    Test::QUEUE = []
+
+    module Test
+      class CustomStepAdapters < Dry::Transaction::StepAdapters
+        register :enqueue, -> step, *args, input {
+          Test::QUEUE << step.operation.call(*args, input)
+          Right(input)
+        }
+      end
+    end
+  end
+
+  it "supports custom step adapters" do
+    input = {"name" => "Jane", "email" => "jane@doe.com"}
+    transaction.call(input)
+    expect(Test::QUEUE).to include("Delivered email to jane@doe.com")
+  end
+end

data/spec/integration/transaction_spec.rb

@@ -136,4 +136,16 @@ RSpec.describe "Transactions" do
       expect(transaction.call(input).value).to eq "raw failure"
     end
   end
+
+  context "non-confirming raw step result" do
+    let(:input) { {"name" => "Jane", "email" => "jane@doe.com"} }
+
+    before do
+      container[:verify] = -> input { "failure" }
+    end
+
+    it "raises an exception" do
+      expect { transaction.call(input) }.to raise_error(ArgumentError)
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,7 +1,11 @@
-require "simplecov"
-SimpleCov.minimum_coverage 100
-SimpleCov.start do
-  add_filter "/spec/"
+if RUBY_ENGINE == "ruby"
+  require "codeclimate-test-reporter"
+  CodeClimate::TestReporter.start
+
+  require "simplecov"
+  SimpleCov.start do
+    add_filter "/spec/"
+  end
 end
 
 require "dry-transaction"

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: dry-transaction
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Tim Riley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-16 00:00:00.000000000 Z
+date: 2016-04-05 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: dry-container
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.8
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.8
 - !ruby/object:Gem::Dependency
   name: kleisli
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: 1.11.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: 1.11.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -127,7 +141,6 @@ files:
 - lib/dry/transaction/sequence.rb
 - lib/dry/transaction/step.rb
 - lib/dry/transaction/step_adapters.rb
-- lib/dry/transaction/step_adapters/base.rb
 - lib/dry/transaction/step_adapters/map.rb
 - lib/dry/transaction/step_adapters/raw.rb
 - lib/dry/transaction/step_adapters/tee.rb
@@ -135,6 +148,7 @@ files:
 - lib/dry/transaction/step_failure.rb
 - lib/dry/transaction/version.rb
 - spec/examples.txt
+- spec/integration/custom_step_adapters_spec.rb
 - spec/integration/passing_step_arguments_spec.rb
 - spec/integration/publishing_step_events_spec.rb
 - spec/integration/transaction_spec.rb

data/lib/dry/transaction/step_adapters/base.rb

@@ -1,20 +0,0 @@
-module Dry
-  module Transaction
-    module StepAdapters
-      # @api private
-      class Base
-        attr_reader :operation
-        attr_reader :options
-
-        def initialize(operation, options)
-          @operation = operation
-          @options = options
-        end
-
-        def arity
-          operation.is_a?(Proc) ? operation.arity : operation.method(:call).arity
-        end
-      end
-    end
-  end
-end