dry-transaction-extra 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 655e43f9df76abfb9b93f04cf55ea437635662ffcfef58b78d1227f63d8560af
-  data.tar.gz: 8343148513834477223867d864b9270f85109780b64ccbcd182373694cc2bd6b
+  metadata.gz: b418dfe409a43af2be1442c9816531076a476c16aa459b5203b49fb32d840836
+  data.tar.gz: be20845e12107f4e7b7b8b086dbead6b7920a1baf1bce41bd847922807c3e9d9
 SHA512:
-  metadata.gz: ff3ce715ed177028996635b2bac116604447266d0952f7ef8ed33c1b69f3d727b3171903310233768d086af583b3103d258910cc34365b012ef57450f6faccf5
-  data.tar.gz: 07012d6bbd9be48f99646389d020c90c92a9efdf02da014f66e3cccc04540fb122bf7ddbc26a2cbc5799a9c1d1671fb7399d2e0278f50b2a734004d7b816e73a
+  metadata.gz: d48878a62c1a65a8202021d7ccbb4a4e7c63cc4bc75e825a9f115c6060b75fefdd53abb2a2412acd869edaf9cb5f659f8a93804cd9d7d1a9fbf98f887cc464a9
+  data.tar.gz: c5fca1261a2e76d32a2b45ca33c0ab0f51cd911c61f8904306ff8437c6896a183d1108e6d6fbc8d26ec0fdb208d947e52707aa401efd6738e4eb1ad153d1d401

data/.rubocop.yml

@@ -1,5 +1,6 @@
 AllCops:
   TargetRubyVersion: 3.2
+  NewCops: enable
 
 Layout/LineLength:
   Max: 120

data/README.md

@@ -25,11 +25,18 @@ require "dry-transaction-extra"
 
 Dry::Transaction::Extra defines a few extra steps you can use:
 
- * [merge][#merge] -- Merges the output of the step with the input args. Best used with keyword arguments.
- * [tap][#tap] -- Similar to Ruby `Kernel#tap`, discards the return value of the step
+ * [merge](#merge) -- Merges the output of the step with the input args. Best
+   used with keyword arguments.
+ * [tap](#tap) -- Similar to Ruby `Kernel#tap`, discards the return value of the step
    and returns the original input. If the step fails, then returns the Failure
    instead.
- * [valid][#valid] -- Runs a Dry::Schema or Dry::Validation::Contract on the input, and transforms the validation Result to a Result monad.
+ * [valid](#valid) -- Runs a Dry::Schema or Dry::Validation::Contract on the
+   input, and transforms the validation Result to a Result monad.
+ * [use](#use) -- Invokes another transaction (or any other callable), and
+   merges the result.
+ * [maybe](#maybe) -- Optionally invokes another transaction by first
+   attempting to invoke the validator. If the validation fails, it continues to
+   the next step without failing.
 
 #### `merge`
 
@@ -173,8 +180,8 @@ valid ParamsValidator
 
 #### `maybe`
 
-Maybe combines the [`use`][#use] step with the [Validation
-extension][#validation]. Before attempting to run the provided transaction, it
+Maybe combines the [`use`]( #use ) step with the [Validation
+extension]( #validation ). Before attempting to run the provided transaction, it
 first runs its defined validator. If that validation passes, then it invokes
 the transaction. If the validation fails, however, then the transaction
 continues on, silently ignoring the failure. This is useful in several
@@ -227,7 +234,7 @@ class CreateUser
 
 #### Validation
 
-In addition to the [valid][#valid] step adapter, Dry::Transaction::Extra has
+In addition to the [valid]( #valid ) step adapter, Dry::Transaction::Extra has
 support for an explicit "pre-flight" validation that runs as the first step. 
 
 ```ruby
@@ -263,7 +270,7 @@ MyTransaction.new.call(args)
 MyTransaction.call(args)
 ```
 
-This is particularly useful when invoking transactions via the [`use`][#use] and [`maybe`][#maybe] steps:
+This is particularly useful when invoking transactions via the [`use`]( #use ) and [`maybe`]( #maybe ) steps:
 
 ```
 use   MyTransaction

data/lib/dry/transaction/extra/steps/maybe.rb

@@ -41,9 +41,13 @@ module Dry
                 txn = container[key] if key
                 raise NoValidatorError, txn unless txn.respond_to? :validator
 
-                result = txn.validator.new.call(*args).to_monad
-                result.bind { txn.call(*args) }
-                      .or { Success(*args) }
+                result = txn.validator.new.call(*args)
+                if result.failure?
+                  # Rails.logger.debug "Skipping #{txn} because of errors: #{result.errors.to_h}"
+                  return Success(*args)
+                end
+
+                txn.call(*args)
               end
             rescue NoMethodError => e
               raise e unless e.name == :name

data/lib/dry/transaction/extra/version.rb

@@ -3,7 +3,7 @@
 module Dry
   module Transaction
     module Extra
-      VERSION = "0.1.0"
+      VERSION = "0.1.1"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-transaction-extra
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Paul Sadauskas
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-01-24 00:00:00.000000000 Z
+date: 2023-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-monads
@@ -128,7 +128,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Extra steps and functionality for Dry::Transaction