dry-monitor 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 8efc7beb94cb02a20c12514ad8beea5914a069d957b48f7c089b588fce4c8bf1
-  data.tar.gz: ad200194b170bfdfdb8f3fe473078c6b309fc73170203deb27b61b1ace4afad4
+SHA1:
+  metadata.gz: ca2399eb8989f99e9840024b317599e731b2e357
+  data.tar.gz: 01e127fab50b60edcc4ac61846907341fd826e23
 SHA512:
-  metadata.gz: bd7e41300b4ea1c908719cd69efd6e9bd357978af9c5ae71a39a38dde35c59c5f989d26208fa56763854dcd6f7b581d87782eb26baf65ea00a944f182151767e
-  data.tar.gz: fc6c2027758916b5447648c176f1a839fa172f1f2e0561b8c471bbcdfb79f670f5dfcab1588f7cac1d46978e118f14869f297d8211a24f3fa0992f7d5a26cabb
+  metadata.gz: 5175053c85e8ae01f9892a3e17fe3e2c54820379cfabde8624893ff35833d7aa9c34bc3c1bf741cab7be77fd519fd6c8bc825997934b58506a3769e63d3bc669
+  data.tar.gz: f01dc548ac3b1f02f72d6b5c7ed875b3100e86af9d6168be33b6910c1170979675cd4634e393dc41c53bc404ec947d2e3c38a11b3ae6d0e132b91298d62900fb

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# v0.1.2 2018-01-04
+
+### Fixed
+
+* Rack logger no longer prevents arbitrary payload in `:error` events (solnic)
+
 # v0.1.1 2018-01-03
 
 ### Fixed

data/lib/dry/monitor/rack/logger.rb

@@ -36,8 +36,8 @@ module Dry
             log_stop_request(env, status, time)
           end
 
-          rack_monitor.on(:error) do |exception:|
-            log_exception(exception)
+          rack_monitor.on(:error) do |event|
+            log_exception(event[:exception])
           end
         end
 

data/lib/dry/monitor/version.rb

@@ -1,5 +1,5 @@
 module Dry
   module Monitor
-    VERSION = '0.1.1'.freeze
+    VERSION = '0.1.2'.freeze
   end
 end

data/spec/integration/rack_middleware_spec.rb

@@ -17,13 +17,15 @@ RSpec.describe Dry::Monitor::Rack::Middleware do
     Dry::Monitor::Rack::Logger.new(Dry::Monitor::Logger.new(log_file_path))
   end
 
-  describe '#call' do
-    let(:env) do
-      { 'REQUEST_METHOD' => 'GET', 'PATH_INFO' => '/hello-world', 'REMOTE_ADDR' => '0.0.0.0', 'QUERY_STRING' => query_params }
-    end
+  let(:env) do
+    { 'REQUEST_METHOD' => 'GET',
+      'PATH_INFO' => '/hello-world',
+      'REMOTE_ADDR' => '0.0.0.0',
+      'QUERY_STRING' => query_params }
+  end
 
-    let(:query_params) do
-      %w[
+  let(:query_params) do
+    %w[
         _csrf=123456
         password=secret
         user[password]=secret
@@ -34,8 +36,9 @@ RSpec.describe Dry::Monitor::Rack::Middleware do
         ids[]=1
         ids[]=2
       ].join('&')
-    end
+  end
 
+  describe '#call' do
     before do
       File.open(log_file_path, 'w').close
       rack_logger.attach(middleware)
@@ -62,12 +65,34 @@ RSpec.describe Dry::Monitor::Rack::Middleware do
       captured = []
 
       middleware.on(:error) do |event|
-        captured << event.payload
+        captured << event[:exception]
+        captured << event[:env]
       end
 
-      middleware.instrument(:error, exception: 'oops')
+      exception = 'oops'
+      env = { 'REQUEST_METHOD' => 'GET' }
+
+      middleware.instrument(:error, exception: exception, env: env)
+
+      expect(captured).to eql([exception, env])
+    end
+  end
+
+  describe 'rack logger' do
+    before do
+      File.open(log_file_path, 'w').close
+      rack_logger.attach(middleware)
+    end
+
+    it 'logs exceptions' do
+      exception = double(:exception, message: 'oops', backtrace: ['/some/path.rb'])
+
+      middleware.instrument(:error, exception: exception, env: env)
+
+      log_file_content = File.read(log_file_path)
 
-      expect(captured).to eql([exception: 'oops'])
+      expect(log_file_content).to include('oops')
+      expect(log_file_content).to include('/some/path.rb')
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-monitor
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-03 00:00:00.000000000 Z
+date: 2018-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rouge
@@ -168,7 +168,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Monitoring and instrumentation APIs