dry-initializer 2.4.0 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 41bfe9bf29562e8ff2f907653002f1d1bae2e7bf
-  data.tar.gz: de76e955208183a7e617367e553cfb97bfbfbf75
+  metadata.gz: 861264b64b414e7ff11f68071a530e3208093092
+  data.tar.gz: f3426ffd2670dbe47c276d67fd972e86fdeb9677
 SHA512:
-  metadata.gz: c86812a57b0471dcee12d5ef97495036b350317eb8fea8044a2e85bfd21b68aa5f6f627b6bce7f882533c8fdc3137d52640493e966c195bbcd03d53e8861697a
-  data.tar.gz: 726234048ec21a22da06de940bd25e3aae5ef0244b4489b238d856ba8a7992dab57af385fadf0a3f2553817257cf71cf56ed62ef688764507d54e66afd304e3b
+  metadata.gz: 3205f5f09066d20a3f05255a71ae8451ec6c00b0c6701bdf2fb4d8a854a61d49d5b1eea952d4cd08d05e3165e8748d73dd1e530a39a12d85bb90e5514bf6c37c
+  data.tar.gz: 05205f55be677d470f553ec0e9fcf8d357ffc3ba245c9195b144c24cac478dd3aa2e1e8d6bcbbd6fc1b6b04d92d8e3e8345762bc76838651dab26d90632a31d2

data/README.md

@@ -70,11 +70,11 @@ See full documentation on the [Dry project official site][docs]
 
 ## Benchmarks
 
-The `dry-initializer` is pretty fast for rubies 2.2+ [comparing to other libraries][benchmarks].
+The `dry-initializer` is pretty fast for rubies 2.3+ [comparing to other libraries][benchmarks].
 
 ## Compatibility
 
-Tested under rubies [compatible to MRI 2.2+](.travis.yml).
+Tested under rubies [compatible to MRI 2.3+](.travis.yml).
 
 ## Contributing
 

data/dry-initializer.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "dry-initializer"
-  gem.version  = "2.4.0"
+  gem.version  = "2.5.0"
   gem.author   = ["Vladimir Kochnev (marshall-lee)", "Andrew Kozin (nepalez)"]
   gem.email    = "andrew.kozin@gmail.com"
   gem.homepage = "https://github.com/dryrb/dry-initializer"
@@ -16,5 +16,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rspec", "~> 3.0"
   gem.add_development_dependency "rake", "> 10"
   gem.add_development_dependency "dry-types", "> 0.5.1"
-  gem.add_development_dependency "rubocop", "~> 0.42"
+  gem.add_development_dependency "rubocop", "~> 0.49.0"
 end

data/lib/dry/initializer.rb

@@ -27,8 +27,7 @@ module Dry
 
     # Adds or redefines a parameter of [#dry_initializer]
     # @param  [Symbol]       name
-    # @param  [#call, nil]   coercer (nil)
-    # @option opts [#call]   :type
+    # @param  [#call, nil]   type (nil)
     # @option opts [Proc]    :default
     # @option opts [Boolean] :optional
     # @option opts [Symbol]  :as

data/lib/dry/initializer/builders/attribute.rb

@@ -60,22 +60,22 @@ module Dry::Initializer::Builders
 
     def default_line
       return unless @default
-      "#{@val} = instance_exec(&#{@item}.default) if #{@val} == #{@null}"
+      "#{@val} = instance_exec(&#{@item}.default) if #{@null} == #{@val}"
     end
 
     def coercion_line
       return unless @type
       arity = @type.is_a?(Proc) ? @type.arity : @type.method(:call).arity
       if arity.abs == 1
-        "#{@val} = #{@item}.type.call(#{@val}) unless #{@val} == #{@null}"
+        "#{@val} = #{@item}.type.call(#{@val}) unless #{@null} == #{@val}"
       else
-        "#{@val} = #{@item}.type.call(#{@val}, self) unless #{@val} == #{@null}"
+        "#{@val} = #{@item}.type.call(#{@val}, self) unless #{@null} == #{@val}"
       end
     end
 
     def assignment_line
       "#{@ivar} = #{@val}" \
-      " unless #{@val} == #{@null} && instance_variable_defined?(:#{@ivar})"
+      " unless #{@null} == #{@val} && instance_variable_defined?(:#{@ivar})"
     end
   end
 end

data/lib/dry/initializer/builders/reader.rb

@@ -38,7 +38,7 @@ module Dry::Initializer::Builders
       return unless @null
       [
         "def #{@target}",
-        "  #{@ivar} unless #{@ivar} == Dry::Initializer::UNDEFINED",
+        "  #{@ivar} unless Dry::Initializer::UNDEFINED == #{@ivar}",
         "end"
       ]
     end

data/lib/dry/initializer/config.rb

@@ -51,8 +51,7 @@ module Dry::Initializer
 
     # Adds or redefines a parameter
     # @param  [Symbol]       name
-    # @param  [#call, nil]   coercer (nil)
-    # @option opts [#call]   :type
+    # @param  [#call, nil]   type (nil)
     # @option opts [Proc]    :default
     # @option opts [Boolean] :optional
     # @option opts [Symbol]  :as
@@ -80,7 +79,7 @@ module Dry::Initializer
         key = item.target
         next unless instance.respond_to? key
         val = instance.send(key)
-        obj[key] = val unless val == null
+        obj[key] = val unless null == val
       end
     end
 
@@ -91,7 +90,7 @@ module Dry::Initializer
       definitions.values.each_with_object({}) do |item, obj|
         key = item.target
         val = instance.send(:instance_variable_get, item.ivar)
-        obj[key] = val unless val == null
+        obj[key] = val unless null == val
       end
     end
 

data/spec/coercion_of_nil_spec.rb

@@ -0,0 +1,25 @@
+describe "coercion of nil" do
+  before do
+    class Test::Foo
+      extend Dry::Initializer
+      param :bar, proc(&:to_i)
+    end
+
+    class Test::Baz
+      include Dry::Initializer.define -> do
+        param :qux, proc(&:to_i)
+      end
+    end
+  end
+
+  let(:foo) { Test::Foo.new(nil) }
+  let(:baz) { Test::Baz.new(nil) }
+
+  it "works with extend syntax" do
+    expect(foo.bar).to eq 0
+  end
+
+  it "works with include syntax" do
+    expect(baz.qux).to eq 0
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-initializer
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0
 platform: ruby
 authors:
 - Vladimir Kochnev (marshall-lee)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-02 00:00:00.000000000 Z
+date: 2018-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -59,14 +59,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.42'
+        version: 0.49.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.42'
+        version: 0.49.0
 description: 
 email: andrew.kozin@gmail.com
 executables: []
@@ -110,6 +110,7 @@ files:
 - lib/tasks/benchmark.rake
 - lib/tasks/profile.rake
 - spec/attributes_spec.rb
+- spec/coercion_of_nil_spec.rb
 - spec/custom_dispatchers_spec.rb
 - spec/custom_initializer_spec.rb
 - spec/default_values_spec.rb
@@ -153,6 +154,7 @@ specification_version: 4
 summary: DSL for declaring params and options of the initializer
 test_files:
 - spec/attributes_spec.rb
+- spec/coercion_of_nil_spec.rb
 - spec/custom_dispatchers_spec.rb
 - spec/custom_initializer_spec.rb
 - spec/default_values_spec.rb