dry-equalizer 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1280055a0b7064bb007c07dc9633688d1c5ddb0e
-  data.tar.gz: 1eb6898c8bf1f15c2783450098ca688902efd9ed
+SHA256:
+  metadata.gz: 3a819572ea7edadec962667cf45602118b745509ee33a86bbf440153340500f6
+  data.tar.gz: 725faa38c3a44a8ccb1a79e33e194f3aed15d2d08778167a90d144950d85718a
 SHA512:
-  metadata.gz: 1996023f8b02db4e528061e1b4041fdd93bfc0248a0e8fd96d4d2239a234ac3359b32c727c81e58ace335eb8fc8797e49079e8041ce814b72cac105a094c5d17
-  data.tar.gz: a1ca9a8c7d27b5feda84484ef4c98927feb48bd8e4cc6126ee232a62e0c92f1f60aa59a7eb16f9b359faf6c1b6f2d3e161249ce97b46c7a49bd60495e8162715
+  metadata.gz: 6b7145d6579f21bbd00dee972501f4251c60dea36f7e4c22eb4ea20ec640fe4e115b1ffc5da597354be807f2d844030a6ffa64a8712a660a543cb470f5801ddb
+  data.tar.gz: 3d2bc74a8e66dee5e2873391a2a37a8768c063d5e36e17fca6dd5986129483ee7e2ba361335d4de65cd2c2b03070a8987e16eb6bae196dc89f9d5280f814c6ee

data/.travis.yml

@@ -1,23 +1,27 @@
 language: ruby
-bundler_args: --without yard guard benchmarks
-script: "bundle exec rake spec"
 cache: bundler
-sudo: false
+bundler_args: --without benchmarks tools
+script:
+  - bundle exec rake
+before_install:
+  - gem update --system
+after_success:
+  - '[ -d coverage ] && bundle exec codeclimate-test-reporter'
 rvm:
-  - 2.0
-  - 2.1
-  - 2.2
-  - ruby-head
-  - rbx-2
-matrix:
-  include:
-    - rvm: jruby-9000
-      env: JRUBY_OPTS="$JRUBY_OPTS --debug --2.0"  # for simplecov
-    - rvm: jruby-head
-      env: JRUBY_OPTS="$JRUBY_OPTS --debug --2.0"  # for simplecov
-  allow_failures:
-    - rvm: jruby-9000
-    - rvm: jruby-head
-    - rvm: rbx-2
-    - rvm: ruby-head
-  fast_finish: true
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
+  - jruby-9.1.15.0
+env:
+  global:
+    - COVERAGE=true
+    - JRUBY_OPTS='--dev -J-Xmx1024M'
+notifications:
+  email: false
+  webhooks:
+    urls:
+      - https://webhooks.gitter.im/e/19098b4253a72c9796db
+    on_success: change  # options: [always|never|change] default: always
+    on_failure: always  # options: [always|never|change] default: always
+    on_start: false     # default: false

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# v0.2.1 2018-04-26
+
+### Fixed
+
+* Including equalizer module with same keys multiple times won't cause duped keys in `inspect` output (radar)
+
+[Compare v0.2.0...v0.2.1](https://github.com/dry-rb/dry-equalizer/compare/v0.2.0...v0.2.1)
+
 # v0.2.0 2015-11-13
 
 Really make it work with MRI 2.0 again (it's Friday 13th OK?!)

data/CONTRIBUTING.md

@@ -1,11 +1,29 @@
-Contributing
-------------
-
-* If you want your code merged into the mainline, please discuss the proposed changes with me before doing any work on it. This library is still in early development, and the direction it is going may not always be clear. Some features may not be appropriate yet, may need to be deferred until later when the foundation for them is laid, or may be more applicable in a plugin.
-* Fork the project.
-* Make your feature addition or bug fix.
-  * Follow this [style guide](https://github.com/dkubb/styleguide).
-* Add specs for it. This is important so I don't break it in a future version unintentionally. Tests must cover all branches within the code, and code must be fully covered.
-* Commit, do not mess with Rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
-* Run "rake ci". This must pass and not show any regressions in the metrics for the code to be merged.
-* Send me a pull request. Bonus points for topic branches.
+# Issue Guidelines
+
+## Reporting bugs
+
+If you found a bug, report an issue and describe what's the expected behavior versus what actually happens. If the bug causes a crash, attach a full backtrace. If possible, a reproduction script showing the problem is highly appreciated.
+
+## Reporting feature requests
+
+Report a feature request **only after discussing it first on [discuss.dry-rb.org](https://discuss.dry-rb.org)** where it was accepted. Please provide a concise description of the feature, don't link to a discussion thread, and instead summarize what was discussed.
+
+## Reporting questions, support requests, ideas, concerns etc.
+
+**PLEASE DON'T** - use [discuss.dry-rb.org](http://discuss.dry-rb.org) instead.
+
+# Pull Request Guidelines
+
+A Pull Request will only be accepted if it addresses a specific issue that was reported previously, or fixes typos, mistakes in documentation etc.
+
+Other requirements:
+
+1) Do not open a pull request if you can't provide tests along with it. If you have problems writing tests, ask for help in the related issue.
+2) Follow the style conventions of the surrounding code. In most cases, this is standard ruby style.
+3) Add API documentation if it's a new feature
+4) Update API documentation if it changes an existing feature
+5) Bonus points for sending a PR to [github.com/dry-rb/dry-rb.org](github.com/dry-rb/dry-rb.org) which updates user documentation and guides
+
+# Asking for help
+
+If these guidelines aren't helpful, and you're stuck, please post a message on [discuss.dry-rb.org](https://discuss.dry-rb.org).

data/Gemfile

@@ -1,11 +1,15 @@
-# encoding: utf-8
-
 source 'https://rubygems.org'
 
+gemspec
+
 group :development, :test do
   gem 'rake'
-  gem 'anima', '~> 0.2.0' # for MRI >= 2.0
-  gem 'rspec', '~> 3.4'
+  gem 'rspec', '~> 3.5'
 end
 
-gemspec
+group :test do
+  platform :mri do
+    gem "codeclimate-test-reporter", require: false
+    gem 'simplecov', require: false
+  end
+end

data/README.md

@@ -1,24 +1,23 @@
-dry-equalizer
-=========
+# dry-equalizer <a href="https://gitter.im/dry-rb/chat" target="_blank">![Join the chat at https://gitter.im/dry-rb/chat](https://badges.gitter.im/Join%20Chat.svg)</a>
 
 Module to define equality, equivalence and inspection methods
 
-[![Gem Version](http://img.shields.io/gem/v/equalizer.svg)][gem]
-[![Build Status](http://img.shields.io/travis/dryrb/dry-equalizer.svg)][travis]
-[![Dependency Status](http://img.shields.io/gemnasium/dryrb/dry-equalizer.svg)][gemnasium]
-[![Code Climate](http://img.shields.io/codeclimate/github/dryrb/dry-equalizer.svg)][codeclimate]
+[![Gem Version](http://img.shields.io/gem/v/dry-equalizer.svg)][gem]
+[![Build Status](http://img.shields.io/travis/dry-rb/dry-equalizer.svg)][travis]
+[![Maintainability](https://api.codeclimate.com/v1/badges/5a9a139af1d4a80a28c4/maintainability)](https://codeclimate.com/github/dry-rb/dry-equalizer/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/5a9a139af1d4a80a28c4/test_coverage)](https://codeclimate.com/github/dry-rb/dry-equalizer/test_coverage)
 
-[gem]: https://rubygems.org/gems/equalizer
-[travis]: https://travis-ci.org/dryrb/dry-equalizer
-[gemnasium]: https://gemnasium.com/dryrb/dry-equalizer
-[codeclimate]: https://codeclimate.com/github/dryrb/dry-equalizer
+[gem]: https://rubygems.org/gems/dry-equalizer
+[travis]: https://travis-ci.org/dry-rb/dry-equalizer
+[gemnasium]: https://gemnasium.com/dry-rb/dry-equalizer
+[codeclimate]: https://codeclimate.com/github/dry-rb/dry-equalizer
 
 Examples
 --------
 
 ``` ruby
 class GeoLocation
-  include Equalizer.new(:latitude, :longitude)
+  include Dry::Equalizer(:latitude, :longitude)
 
   attr_reader :latitude, :longitude
 
@@ -50,8 +49,8 @@ Supported Ruby Versions
 This library aims to support and is [tested against][travis] the following Ruby
 implementations:
 
-* Ruby 2.1
-* Ruby 2.2
+* MRI 2.2+
+* JRuby 9.x
 
 If something doesn't work on one of these versions, it's a bug.
 

data/dry-equalizer.gemspec

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require File.expand_path('../lib/dry/equalizer/version', __FILE__)
 
 Gem::Specification.new do |gem|
@@ -9,7 +7,7 @@ Gem::Specification.new do |gem|
   gem.email       = %w[dan.kubb@gmail.com mbj@schirp-dso.com]
   gem.description = 'Module to define equality, equivalence and inspection methods'
   gem.summary     = gem.description
-  gem.homepage    = 'https://github.com/dkubb/equalizer'
+  gem.homepage    = 'https://github.com/dryrb/dry-equalizer'
   gem.licenses    = 'MIT'
 
   gem.require_paths    = %w[lib]

data/lib/dry/equalizer.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 module Dry
   # Build an equalizer module for the inclusion in other class
   #
@@ -21,7 +19,7 @@ module Dry
     #
     # @api private
     def initialize(*keys)
-      @keys = keys
+      @keys = keys.uniq
       define_methods
       freeze
     end
@@ -88,8 +86,8 @@ module Dry
       keys = @keys
       define_method(:inspect) do | |
         klass = self.class
-      name  = klass.name || klass.inspect
-      "#<#{name}#{keys.map { |key| " #{key}=#{__send__(key).inspect}" }.join}>"
+        name  = klass.name || klass.inspect
+        "#<#{name}#{keys.map { |key| " #{key}=#{__send__(key).inspect}" }.join}>"
       end
     end
 
@@ -122,7 +120,7 @@ module Dry
       #
       # @api public
       def ==(other)
-        other.kind_of?(self.class) && cmp?(__method__, other)
+        other.is_a?(self.class) && cmp?(__method__, other)
       end
     end # module Methods
   end # class Equalizer

data/lib/dry/equalizer/version.rb

@@ -1,8 +1,6 @@
-# encoding: utf-8
-
 module Dry
   class Equalizer < Module
     # Gem version
-    VERSION = '0.2.0'.freeze
+    VERSION = '0.2.1'.freeze
   end # class Equalizer
 end

data/spec/spec_helper.rb

@@ -1,16 +1,13 @@
-# encoding: utf-8
+if RUBY_ENGINE == 'ruby' && ENV['COVERAGE'] == 'true'
+  require 'yaml'
+  rubies = YAML.load(File.read(File.join(__dir__, '..', '.travis.yml')))['rvm']
+  latest_mri = rubies.select { |v| v =~ /\A\d+\.\d+.\d+\z/ }.max
 
-if ENV['COVERAGE'] == 'true'
-  require 'simplecov'
-
-  SimpleCov.start do
-    command_name 'spec:unit'
-
-    add_filter 'config'
-    add_filter 'spec'
-    add_filter 'vendor'
-
-    minimum_coverage 100
+  if RUBY_VERSION == latest_mri
+    require 'simplecov'
+    SimpleCov.start do
+      add_filter '/spec/'
+    end
   end
 end
 
@@ -19,7 +16,11 @@ require 'dry-equalizer'
 RSpec.configure do |config|
   config.raise_errors_for_deprecations!
 
+  config.disable_monkey_patching!
+
   config.expect_with :rspec do |expect_with|
     expect_with.syntax = :expect
   end
+
+  config.warnings = true
 end

data/spec/support/config_alias.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'rbconfig'
 
 ::Config = RbConfig unless defined?(::Config)

data/spec/unit/equalizer/included_spec.rb

@@ -1,8 +1,6 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
-describe Dry::Equalizer, '#included' do
+RSpec.describe Dry::Equalizer, '#included' do
   subject { descendant.instance_exec(object) { |mod| include mod } }
 
   let(:object)     { described_class.new        }

data/spec/unit/equalizer/methods/eql_predicate_spec.rb

@@ -1,8 +1,6 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
-describe Dry::Equalizer::Methods, '#eql?' do
+RSpec.describe Dry::Equalizer::Methods, '#eql?' do
   subject { object.eql?(other) }
 
   let(:object) { described_class.new(true) }

data/spec/unit/equalizer/methods/equality_operator_spec.rb

@@ -1,8 +1,6 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
-describe Dry::Equalizer::Methods, '#==' do
+RSpec.describe Dry::Equalizer::Methods, '#==' do
   subject { object == other }
 
   let(:object)          { described_class.new(true) }

data/spec/unit/equalizer/universal_spec.rb

@@ -1,9 +1,6 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
-describe Dry::Equalizer do
-  let(:object) { described_class }
+RSpec.describe Dry::Equalizer do
   let(:name)   { 'User'          }
   let(:klass)  { ::Class.new     }
 
@@ -18,7 +15,7 @@ describe Dry::Equalizer do
 
     let(:instance) { klass.new }
 
-    it { should be_instance_of(object) }
+    it { should be_instance_of(described_class) }
 
     it { should be_frozen }
 
@@ -98,7 +95,7 @@ describe Dry::Equalizer do
       klass.send(:include, subject)
     end
 
-    it { should be_instance_of(object) }
+    it { should be_instance_of(described_class) }
 
     it { should be_frozen }
 
@@ -155,4 +152,42 @@ describe Dry::Equalizer do
       end
     end
   end
+
+  context 'with duplicate keys' do
+    subject { Dry::Equalizer(*keys) }
+
+    let(:keys)       { %i[firstname firstname lastname].freeze  }
+    let(:firstname)  { 'John'                                   }
+    let(:lastname)   { 'Doe'                                    }
+    let(:instance)   { klass.new(firstname, lastname)           }
+
+    let(:klass) do
+      ::Class.new do
+        attr_reader :firstname, :lastname
+        private :firstname, :lastname
+
+        def initialize(firstname, lastname)
+          @firstname = firstname
+          @lastname = lastname
+        end
+      end
+    end
+
+    before do
+      # specify the class #inspect method
+      allow(klass).to receive_messages(name: nil, inspect: name)
+      klass.send(:include, subject)
+    end
+
+    it { should be_instance_of(described_class) }
+
+    it { should be_frozen }
+
+    describe '#inspect' do
+      it 'returns the expected string' do
+        expect(instance.inspect)
+          .to eql('#<User firstname="John" lastname="Doe">')
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-equalizer
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Dan Kubb
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-13 00:00:00.000000000 Z
+date: 2018-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -63,7 +63,7 @@ files:
 - spec/unit/equalizer/methods/eql_predicate_spec.rb
 - spec/unit/equalizer/methods/equality_operator_spec.rb
 - spec/unit/equalizer/universal_spec.rb
-homepage: https://github.com/dkubb/equalizer
+homepage: https://github.com/dryrb/dry-equalizer
 licenses:
 - MIT
 metadata: {}
@@ -83,7 +83,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Module to define equality, equivalence and inspection methods
@@ -92,4 +92,3 @@ test_files:
 - spec/unit/equalizer/methods/eql_predicate_spec.rb
 - spec/unit/equalizer/methods/equality_operator_spec.rb
 - spec/unit/equalizer/universal_spec.rb
-has_rdoc: