dry-configurable 0.13.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b1292743d03212bcca735f18e876046b27cb3859a561a9b714704627542a324
-  data.tar.gz: 5d9f334008b7d055bbcbadf21feb61dbef8888ed01cc877e54cd7f5959b46f48
+  metadata.gz: 90bd271135f8ccb892c1cf3afc448f92fe50587567725e860de78b4ed58bb57a
+  data.tar.gz: 8580ad144d2fa3e0189c65a9873282db49c8ddd7d5c349b0f4d6f292e7f675ce
 SHA512:
-  metadata.gz: 1b9bbe538bd93cc27e87e7e97a83bd1f98757d776d215028b88bb8d8b085a2114c53b7f4e3ad1d77ae70b21d99652a7bbe65d978106f897e784374456cb615db
-  data.tar.gz: 9fdeb06faf9888965037a364560c10364342731e7c825d56d4fd1cdeeb929992e201ef1f6fb3b14d4fb68ee037588e3a064a8f2236588d0417599e55df7a6a89
+  metadata.gz: b6613b8677ab724316dde1440ff0640021621d48eec1e0ca1125e28dfdb82bfd94800a3bf5d511fc704062dded24de5bd266012c7145028f2d2322a2837ad77c
+  data.tar.gz: 69a5d08bfbf53bc232ec8f0fb56186576fe1fe5128205d9597b87bccce750bc94256da9cd9644fa94b4e175f6f86911bad99e866f627e06f2386c29fbc89a634

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 <!--- DO NOT EDIT THIS FILE - IT'S AUTOMATICALLY GENERATED VIA DEVTOOLS --->
 
+## 0.14.0 2022-01-14
+
+
+### Changed
+
+- Settings defined after an access to `config` will still be made available on that `config`. (#130 by @timriley)
+- Cloneable settings are cloned immediately upon assignment. (#130 by @timriley)
+- Changes to config values in parent classes after subclasses have already been created will not be propogated to those subclasses. Subclasses created _after_ config values have been changed in the parent _will_ receive those config values. (#130 by @timriley)
+
+[Compare v0.13.0...v0.14.0](https://github.com/dry-rb/dry-configurable/compare/v0.13.0...v0.14.0)
+
 ## 0.13.0 2021-09-12
 
 
@@ -8,8 +19,8 @@
 - Added flags to determine whether to warn on the API usage deprecated in this release (see "Changed" section below). Set these to `false` to suppress the warnings. (#124 by @timriley)
 
   ```ruby
-  Dry::Configurable.warn_on_setting_constructor_block = false
-  Dry::Configurable.warn_on_setting_positional_default = false
+  Dry::Configurable.warn_on_setting_constructor_block false
+  Dry::Configurable.warn_on_setting_positional_default false
   ```
 
 ### Fixed

data/README.md

@@ -8,7 +8,7 @@
 # dry-configurable [![Join the chat at https://dry-rb.zulipchat.com](https://img.shields.io/badge/dry--rb-join%20chat-%23346b7a.svg)][chat]
 
 [![Gem Version](https://badge.fury.io/rb/dry-configurable.svg)][gem]
-[![CI Status](https://github.com/dry-rb/dry-configurable/workflows/CI/badge.svg)][actions]
+[![CI Status](https://github.com/dry-rb/dry-configurable/workflows/ci/badge.svg)][actions]
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/0276a97990e04eb0ac722b3e7f3620b5)][codacy]
 [![Codacy Badge](https://api.codacy.com/project/badge/Coverage/0276a97990e04eb0ac722b3e7f3620b5)][codacy]
 [![Inline docs](http://inch-ci.org/github/dry-rb/dry-configurable.svg?branch=master)][inchpages]
@@ -22,8 +22,8 @@
 
 This library officially supports the following Ruby versions:
 
-* MRI `>= 2.6.0`
-* ~~jruby~~ `>= 9.3` (we are waiting for [2.6 support](https://github.com/jruby/jruby/issues/6161))
+* MRI `>= 2.7.0`
+* jruby `>= 9.3` (postponed until 2.7 is supported)
 
 ## License
 

data/dry-configurable.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
   spec.metadata["source_code_uri"]   = "https://github.com/dry-rb/dry-configurable"
   spec.metadata["bug_tracker_uri"]   = "https://github.com/dry-rb/dry-configurable/issues"
 
-  spec.required_ruby_version = ">= 2.6.0"
+  spec.required_ruby_version = ">= 2.7.0"
 
   # to update dependencies edit project.yml
   spec.add_runtime_dependency "concurrent-ruby", "~> 1.0"

data/lib/dry/configurable/class_methods.rb

@@ -13,12 +13,11 @@ module Dry
       include Methods
 
       # @api private
-      def inherited(klass)
+      def inherited(subclass)
         super
 
-        parent_settings = (respond_to?(:config) ? config._settings : _settings)
-
-        klass.instance_variable_set("@_settings", parent_settings)
+        subclass.instance_variable_set("@_settings", _settings.dup)
+        subclass.instance_variable_set("@_config", config.dup) if respond_to?(:config)
       end
 
       # Add a setting to the configuration
@@ -71,6 +70,11 @@ module Dry
       #
       # @api public
       def config
+        # The _settings provided to the Config remain shared between the class and the
+        # Config. This allows settings defined _after_ accessing the config to become
+        # available in subsequent accesses to the config. The config is duped when
+        # subclassing to ensure it remains distinct between subclasses and parent classes
+        # (see `.inherited` above).
         @config ||= Config.new(_settings)
       end
 

data/lib/dry/configurable/config.rb

@@ -23,7 +23,7 @@ module Dry
 
       # @api private
       def initialize(settings)
-        @_settings = settings.dup
+        @_settings = settings
         @_resolved = Concurrent::Map.new
       end
 

data/lib/dry/configurable/instance_methods.rb

@@ -12,7 +12,11 @@ module Dry
     module Initializer
       # @api private
       def initialize(*)
+        # Dup settings at time of initializing to ensure setting values are specific to
+        # this instance. This does mean that any settings defined on the class _after_
+        # initialization will not be available on the instance.
         @config = Config.new(self.class._settings.dup)
+
         super
       end
       ruby2_keywords(:initialize) if respond_to?(:ruby2_keywords, true)

data/lib/dry/configurable/setting.rb

@@ -62,9 +62,17 @@ module Dry
       def initialize(name, input: Undefined, default: Undefined, **options)
         @name = name
         @writer_name = :"#{name}="
+        @options = options
+
+        # Setting collections (see `Settings`) are shared between the configurable class
+        # and its `config` object, so for cloneable individual settings, we duplicate
+        # their _values_ as early as possible to ensure no impact from unintended mutation
         @input = input
         @default = default
-        @options = options
+        if cloneable?
+          @input = input.dup
+          @default = default.dup
+        end
 
         evaluate if input_defined?
       end

data/lib/dry/configurable/version.rb

@@ -3,6 +3,6 @@
 module Dry
   module Configurable
     # @api public
-    VERSION = "0.13.0"
+    VERSION = "0.14.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-configurable
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.14.0
 platform: ruby
 authors:
 - Andy Holland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-12 00:00:00.000000000 Z
+date: 2022-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -122,7 +122,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="