dry-configurable 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ad76ba634372fef286ee4ed41858c38db434eb2
-  data.tar.gz: 0137864a8d45cb1c0e1b0b583263d12fe2a4aeea
+  metadata.gz: 46579bd4de4bb1af8dde20589fb0d47d3b41935e
+  data.tar.gz: fa9e7b2e214c41414d343c6318bb96417f8bc934
 SHA512:
-  metadata.gz: 439db458f72ce8c7a1ed41565916078d8fc2659002daf2218492297b2f5d25d41b6de52aa1538c27acb6203b464d5ce2391793ab0de4fdaefac1d64234c5f6a8
-  data.tar.gz: 869183f4d81a902494e20d183fa116c2afd5aa54c526c6fcdd2b0a52c717e493c62fbc47228f14de3066413d5e1b2075ef8503633248fdccbb9818c8592cb314
+  metadata.gz: 0c8ba92eaf7f53656a1b7249c215a8ec489803e83ee989e9714b56e3863a46e972b07851265cee6435b1e5772d8b731b191a3d5357b42430114c16b2e5000be5
+  data.tar.gz: 9c2ccdc38093402a7d6660b3c7380f133837f69f4a743312bca62623a9190f49b571398bf8f64a73d3c6744cdca9432b8bbbe981b27eb672de92943bef92ebc8

data/lib/dry/configurable.rb

@@ -38,8 +38,9 @@ module Dry
 
     # @private
     def inherited(subclass)
-      subclass.instance_variable_set(:@_config_mutex, @_config_mutex)
-      subclass.instance_variable_set(:@_settings, @_settings)
+      subclass.instance_variable_set(:@_config_mutex, Mutex.new)
+      subclass.instance_variable_set(:@_settings, @_settings.clone)
+      subclass.instance_variable_set(:@_config, @_config.clone) if defined?(@_config)
       super
     end
 

data/lib/dry/configurable/version.rb

@@ -1,6 +1,6 @@
 module Dry
   module Configurable
     # @api public
-    VERSION = '0.1.2'.freeze
+    VERSION = '0.1.3'.freeze
   end
 end

data/spec/support/shared_examples/configurable.rb

@@ -56,9 +56,7 @@ RSpec.shared_examples 'a configurable class' do
           klass.setting :database do
             setting :dsn, 'sqlite:memory'
           end
-        end
 
-        before do
           klass.configure do |config|
             config.database.dsn = 'jdbc:sqlite:memory'
           end
@@ -68,6 +66,43 @@ RSpec.shared_examples 'a configurable class' do
           expect(klass.config.database.dsn).to eq('jdbc:sqlite:memory')
         end
       end
+
+      context 'when inherited' do
+        before do
+          klass.setting :dsn
+          klass.configure do |config|
+            config.dsn = 'jdbc:sqlite:memory'
+          end
+        end
+
+        subject!(:subclass) { Class.new(klass) }
+
+        it 'retains its configuration' do
+          expect(subclass.config.dsn).to eq('jdbc:sqlite:memory')
+        end
+
+        context 'when the inherited config is modified' do
+          before do
+            subclass.configure do |config|
+              config.dsn = 'jdbc:sqlite:file'
+            end
+          end
+
+          it 'does not modify the original' do
+            expect(klass.config.dsn).to eq('jdbc:sqlite:memory')
+          end
+        end
+
+        context 'when the inherited settings are modified' do
+          before do
+            subclass.setting :db
+          end
+
+          it 'does not modify the original' do
+            expect(klass._settings.keys).to_not include(:db)
+          end
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-configurable
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Andy Holland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-14 00:00:00.000000000 Z
+date: 2016-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thread_safe
@@ -111,7 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A mixin to add configuration functionality to your classes