dry-configurable 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bbbc7ef5946aeb5c65bbb665c46f83889bb96bd3
-  data.tar.gz: c07ffda1dbf3139f8ee01c5fdf1c58256f7dfa69
+  metadata.gz: 3ad76ba634372fef286ee4ed41858c38db434eb2
+  data.tar.gz: 0137864a8d45cb1c0e1b0b583263d12fe2a4aeea
 SHA512:
-  metadata.gz: 978be50370afebe7518aad050bac45771d2fc7d48b45159537d4f6d8998deb3297ce26f0c6eb04214cf6f3dfc039f599b69b521c0aa6bfed993ea59bc301f634
-  data.tar.gz: d532e06d2d8236f3c1bad62d416300621a9bb30ec769743987faeaf67fcab743bd04593dccf466dbfeff801ca99c47877f8f591904c8babd066d9ee92c15250a
+  metadata.gz: 439db458f72ce8c7a1ed41565916078d8fc2659002daf2218492297b2f5d25d41b6de52aa1538c27acb6203b464d5ce2391793ab0de4fdaefac1d64234c5f6a8
+  data.tar.gz: 869183f4d81a902494e20d183fa116c2afd5aa54c526c6fcdd2b0a52c717e493c62fbc47228f14de3066413d5e1b2075ef8503633248fdccbb9818c8592cb314

data/README.md

@@ -2,7 +2,10 @@
 
 <a href="https://rubygems.org/gems/dry-configurable" target="_blank">![Gem Version](https://badge.fury.io/rb/dry-configurable.svg)</a>
 <a href="https://travis-ci.org/dryrb/dry-configurable" target="_blank">![Build Status](https://travis-ci.org/dryrb/dry-configurable.svg?branch=master)</a>
-<a href="http://inch-ci.org/github/dryrb/dry-configurable" target="_blank">![Inline docs](http://inch-ci.org/github/dryrb/dry-configurable.svg?branch=master&style=flat)</a>
+<a href="https://gemnasium.com/dryrb/dry-configurable" target="_blank">![Dependency Status](https://gemnasium.com/dryrb/dry-configurable.svg)</a>
+<a href="https://codeclimate.com/github/dryrb/dry-configurable" target="_blank">![Code Climate](https://codeclimate.com/github/dryrb/dry-configurable/badges/gpa.svg)</a>
+<a href="http://inch-ci.org/github/dryrb/dry-configurable" target="_blank">![Documentation Status](http://inch-ci.org/github/dryrb/dry-configurable.svg?branch=master&style=flat)</a>
+
 
 ## Synopsis
 

data/lib/dry/configurable.rb

@@ -2,6 +2,8 @@ require 'thread_safe'
 require 'dry/configurable/config'
 require 'dry/configurable/version'
 
+# A collection of micro-libraries, each intended to encapsulate
+# a common task in Ruby
 module Dry
   # A simple configuration mixin
   #
@@ -15,7 +17,7 @@ module Dry
   #     end
   #   end
   #
-  #   App.confiure do |config|
+  #   App.configure do |config|
   #     config.database.dsn = 'jdbc:sqlite:memory'
   #   end
   #
@@ -33,6 +35,14 @@ module Dry
         @_settings = ThreadSafe::Cache.new
       end
     end
+
+    # @private
+    def inherited(subclass)
+      subclass.instance_variable_set(:@_config_mutex, @_config_mutex)
+      subclass.instance_variable_set(:@_settings, @_settings)
+      super
+    end
+
     # Return configuration
     #
     # @return [Dry::Configurable::Config]
@@ -44,6 +54,7 @@ module Dry
         @_config = Config.new(*_settings.keys).new(*_settings.values) unless _settings.empty?
       end
     end
+
     # Return configuration
     #
     # @yield [Dry::Configuration::Config]
@@ -54,6 +65,7 @@ module Dry
     def configure
       yield(config) if block_given?
     end
+
     # Add a setting to the configuration
     #
     # @param [Mixed] key

data/lib/dry/configurable/version.rb

@@ -1,6 +1,6 @@
 module Dry
   module Configurable
     # @api public
-    VERSION = '0.1.1'.freeze
+    VERSION = '0.1.2'.freeze
   end
 end

data/spec/integration/configurable_spec.rb

@@ -1,91 +1,25 @@
 RSpec.describe Dry::Configurable do
-  describe 'settings' do
-    context 'without default value' do
-      let(:configuration) do
-        Class.new do
-          extend Dry::Configurable
-
-          setting :dsn
-        end
-      end
-
-      it 'returns nil' do
-        expect(configuration.config.dsn).to be(nil)
+  context 'when extended' do
+    let(:klass) do
+      Class.new do
+        extend Dry::Configurable
       end
     end
 
-    context 'with default value' do
-      let(:configuration) do
-        Class.new do
-          extend Dry::Configurable
-
-          setting :dsn, 'sqlite:memory'
-        end
-      end
-
-      it 'returns the default value' do
-        expect(configuration.config.dsn).to eq('sqlite:memory')
-      end
-    end
-
-    context 'nested configuration' do
-      let(:configuration) do
-        Class.new do
-          extend Dry::Configurable
-
-          setting :database do
-            setting :dsn, 'sqlite:memory'
-          end
-        end
-      end
-
-      it 'returns the default value' do
-        expect(configuration.config.database.dsn).to eq('sqlite:memory')
-      end
-    end
+    it_behaves_like 'a configurable class'
   end
 
-  describe 'configuration' do
-    context 'without nesting' do
-      let(:configuration) do
-        Class.new do
-          extend Dry::Configurable
-
-          setting :dsn, 'sqlite:memory'
-        end
-      end
-
-      before do
-        configuration.configure do |config|
-          config.dsn = 'jdbc:sqlite:memory'
-        end
-      end
-
-      it 'updates the config value' do
-        expect(configuration.config.dsn).to eq('jdbc:sqlite:memory')
+  context 'when extended then inherited' do
+    let(:base_klass) do
+      Class.new do
+        extend Dry::Configurable
       end
     end
 
-    context 'with nesting' do
-      let(:configuration) do
-        Class.new do
-          extend Dry::Configurable
-
-          setting :database do
-            setting :dsn, 'sqlite:memory'
-          end
-        end
-      end
-
-      before do
-        configuration.configure do |config|
-          config.database.dsn = 'jdbc:sqlite:memory'
-        end
-      end
-
-      it 'updates the config value' do
-        expect(configuration.config.database.dsn).to eq('jdbc:sqlite:memory')
-      end
+    let(:klass) do
+      Class.new(base_klass)
     end
+
+    it_behaves_like 'a configurable class'
   end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,7 @@
 # encoding: utf-8
 
 require 'dry/configurable'
+
+Dir[Pathname(__FILE__).dirname.join('support/**/*.rb').to_s].each do |file|
+  require file
+end

data/spec/support/shared_examples/configurable.rb

@@ -0,0 +1,73 @@
+RSpec.shared_examples 'a configurable class' do
+  describe Dry::Configurable do
+    describe 'settings' do
+      context 'without default value' do
+        before do
+          klass.setting :dsn
+        end
+
+        it 'returns nil' do
+          expect(klass.config.dsn).to be(nil)
+        end
+      end
+
+      context 'with default value' do
+        before do
+          klass.setting :dsn, 'sqlite:memory'
+        end
+
+        it 'returns the default value' do
+          expect(klass.config.dsn).to eq('sqlite:memory')
+        end
+      end
+
+      context 'nested configuration' do
+        before do
+          klass.setting :database do
+            setting :dsn, 'sqlite:memory'
+          end
+        end
+
+        it 'returns the default value' do
+          expect(klass.config.database.dsn).to eq('sqlite:memory')
+        end
+      end
+    end
+
+    describe 'configuration' do
+      context 'without nesting' do
+        before do
+          klass.setting :dsn, 'sqlite:memory'
+        end
+
+        before do
+          klass.configure do |config|
+            config.dsn = 'jdbc:sqlite:memory'
+          end
+        end
+
+        it 'updates the config value' do
+          expect(klass.config.dsn).to eq('jdbc:sqlite:memory')
+        end
+      end
+
+      context 'with nesting' do
+        before do
+          klass.setting :database do
+            setting :dsn, 'sqlite:memory'
+          end
+        end
+
+        before do
+          klass.configure do |config|
+            config.database.dsn = 'jdbc:sqlite:memory'
+          end
+        end
+
+        it 'updates the config value' do
+          expect(klass.config.database.dsn).to eq('jdbc:sqlite:memory')
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: dry-configurable
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Andy Holland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-20 00:00:00.000000000 Z
+date: 2015-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thread_safe
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -73,11 +73,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .rubocop.yml
-- .rubocop_todo.yml
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -90,6 +90,7 @@ files:
 - rakelib/rubocop.rake
 - spec/integration/configurable_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples/configurable.rb
 homepage: https://github.com/dryrb/dry-configurable
 licenses:
 - MIT
@@ -100,20 +101,21 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: A mixin to add configuration functionality to your classes
 test_files:
 - spec/integration/configurable_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples/configurable.rb