dry-behaviour 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 01a2f3844b89e2b41e719f309945c2c66d7717ff
-  data.tar.gz: 6497f54746f681a0b0a281a8c0404b7b55bb8fad
+  metadata.gz: 68e9909166c5283d9505f7be6f541334aea5d161
+  data.tar.gz: 2319fcbbb2da7b56aff3825e44788d44da99a688
 SHA512:
-  metadata.gz: 22ebe373dd9ec2b4b30babcd3c8f3130f5ae9f229a8f152ffe9eaaf4291cc0cd7ec2f2d1850ed1c8e89b4a956765244330ad992df8039320abb114049118be75
-  data.tar.gz: 4ddc32d58f0f52ca11496945df99342d1238b1e78636d5d5668d44ed56a225e37e96fa22cbbd236b25d3d4ec8ca4a71f7a44e7924cdb9af32d2982896cf7b9dd
+  metadata.gz: cd3f037341b4f6f2e28d9e4478d763fc6bd554d09e5be20be2ac08c2fad405be3a2ce8e45a273cdd0c6bbbf26efd8ee0abaf4edb6d48e4760c933ebaf54d1397
+  data.tar.gz: cea7c3a4b77dbc7cc4215e38b853c92d96670fe8677c771a2d1914b6e60293d163fc00d9bd3a60b97966849e5a7f025cb3b39c0b30afb933c62e25dfdafb4497

data/.travis.yml

@@ -3,6 +3,7 @@ rvm:
   - 2.1.1
   - 2.1.10
   - 2.2.2
-  - 2.3.1
-  - 2.4.0
+  - 2.3.2
+  - 2.4.2
+  - 2.5.1
 before_install: gem install bundler -v 1.10.6

data/lib/dry/behaviour/black_tie.rb

@@ -24,7 +24,9 @@ module Dry
       (instance_methods(false) - ims).each { |m| class_eval { module_function m } }
 
       singleton_class.send :define_method, :method_missing do |method, *_args|
-        raise Dry::Protocol::NotImplemented.new(:method, inspect, method)
+        raise Dry::Protocol::NotImplemented.new(
+          :method, inspect, method: method, self: self
+        )
       end
 
       singleton_class.send :define_method, :implementation_for do |receiver|
@@ -33,16 +35,21 @@ module Dry
         end.reject(&:nil?).first
       end
 
-      BlackTie.protocols[self].each do |method, *_| # FIXME: CHECK PARAMS CORRESPONDENCE HERE
+      BlackTie.protocols[self].each do |method, *_| # FIXME: CHECK ARITY HERE
         singleton_class.send :define_method, method do |receiver = nil, *args|
           impl = implementation_for(receiver)
-          raise Dry::Protocol::NotImplemented.new(:protocol, inspect, receiver.class) unless impl
+          raise Dry::Protocol::NotImplemented.new(
+            :protocol, inspect,
+            method: method, receiver: receiver, args: args, self: self
+          ) unless impl
           begin
             impl[method].(*args.unshift(receiver))
-          rescue NoMethodError => e
-            raise Dry::Protocol::NotImplemented.new(:method, inspect, e.message)
-          rescue ArgumentError => e
-            raise Dry::Protocol::NotImplemented.new(:method, inspect, "#{method} (#{e.message})")
+          rescue => e
+            raise Dry::Protocol::NotImplemented.new(
+                :nested, inspect,
+                cause: e,
+                method: method, receiver: receiver, args: args, impl: impl, self: self
+              )
           end
         end
       end

data/lib/dry/behaviour/version.rb

@@ -1,5 +1,5 @@
 module Dry
   module Behaviour
-    VERSION = '0.6.0'.freeze
+    VERSION = '0.7.0'.freeze
   end
 end

data/lib/dry/errors/not_implemented.rb

@@ -1,15 +1,39 @@
 module Dry
   module Protocol
     class NotImplemented < StandardError
-      def initialize(type, proto, impl)
-        super case type
-              when :protocol
-                "Protocol “#{proto}” is not implemented for “#{impl}”."
-              when :method
-                "Protocol “#{proto}” does not declare method “#{impl}”."
-              else
-                "Protocol “#{proto}” is invalid."
-              end
+      attr_reader :proto, :details
+
+      def initialize(type, proto, **details)
+        @proto, @details = proto, details
+
+        @details[:message] =
+          case type
+          when :protocol
+            "Protocol “#{@proto}” is not implemented for “#{@details[:receiver].class}”."
+          when :method
+            "Protocol “#{@proto}” does not declare method “#{@details[:method]}”."
+          when :nested
+            "Protocol “#{@proto}” failed to invoke the implementation.\n" \
+            " ⮩  caused by “#{cause.class}” with a message\n" \
+            " ⮩    “#{cause.message}”\n" \
+            " ⮩  rescue this exception and inspect `NotImplemented#cause' for details."
+          else
+            "Protocol “#{proto}” is invalid."
+          end
+
+        super(@details[:message])
+
+        if @details[:cause]
+          set_backtrace(
+            @details[:cause].backtrace.reject do |line| # FIXME drop_while ??
+              line =~ %r[dry-behaviour/lib/dry/behaviour]
+            end
+          )
+        end
+      end
+
+      def cause
+        @details[:cause] ||= super
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-behaviour
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Aleksei Matiushkin
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-02 00:00:00.000000000 Z
+date: 2018-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler