drg_cms 0.4.39 → 0.4.53

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c72a699a0ff7d2c728862a4704654a2a23e826ba
-  data.tar.gz: 162273135c2be3ca8e6ed94a6ee56e00eec2255a
+  metadata.gz: 2170ac5278d4127c49a981b33ffc4c7971ab2044
+  data.tar.gz: 0d227664c634c0169283c71a1cd3dde2b49a8015
 SHA512:
-  metadata.gz: 22893cf485499702a541f39f41bb480cae7244a742f05c2ed5c9c29c37a62ccde3bdf622dd8af22f2bc8f3925bb9c2f8c3e073d68d025c7c7d11a4240f82ec64
-  data.tar.gz: 9d9c0acaf0a7e8eaa27f945ad2e6fbe9e734cc23fc77282de50647bba0f80d98b416be80d993768f2149c3f7be198aefa0b7d07e34966f219afccacf9118d363
+  metadata.gz: dad0892b0d68cbaeed030987a03657e4b2fee598fb42f06bf961ed02a1e5b393201167c3fd391eed286270a22b791fc9a7e7aa3ec6a4ec9f1c8da958a573e990
+  data.tar.gz: c6a933b22b907d199464fe1099ec205a12800a2841c80d8c92a1f76cee167ad8f2a69db4f3382b8da843f0dd69319632799398e874038143dd8fd095cbc46495

data/README.md

@@ -0,0 +1,49 @@
+# DrgCms
+
+DRG CMS is cms build on strong foundations of Ruby on Rails and Mongo DB.
+
+Project Tracking
+----------------
+
+* [DrgCms Website and Documentation](http://www.drgcms.org)
+* [DrgCms Testing website](http://test.drgcms.org)
+
+Compatibility
+-------------
+
+DRG CMS is tested against MRI 1.9.3, 2.0.0, 2.1.0.
+
+Documentation
+-------------
+
+Please see the DRG CMS website for up-to-date documentation:
+[www.drgcms.org](http://www.drgcms.org)
+
+License
+-------
+
+Copyright (c) 2012-2015 Damjan Rems
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+Credits
+-------
+
+Damjan Rems: damjan dot rems at gmail dot com

data/app/assets/javascripts/drg_cms/drg_cms.js

@@ -40,12 +40,12 @@ dumpAttributes = function(obj) {
 };
 
 /*******************************************************************
- * Used for removing background from iframe element. 
+ * Used for removing background from iframe element. It is of course not working.
  *******************************************************************/
 remove_background_from_iframe = function(obj) {
   var head = obj.head;
   var css = '<style type="text/css">' +
-            'body{background: none;} ' +
+            'body{background: none; background-picture:none; } ' +
             '</style>';
   $(head).append(css);    
 };
@@ -226,10 +226,10 @@ $(document).ready( function() {
 //    console.log(this.contentWindow.document.body.offsetHeight);
     if (this.contentWindow.document.body.offsetHeight > 10) {
       this.style.height = (this.contentWindow.document.body.offsetHeight + 30) + 'px'; 
-    }
-    remove_background_from_iframe(this.contentWindow.document);
 // scroll to it
-    $('#iframe_edit').dc_scroll_view();
+      $('#iframe_edit').dc_scroll_view();
+    }
+//    remove_background_from_iframe(this.contentWindow.document);
   });
   
 /*******************************************************************
@@ -249,7 +249,7 @@ $(document).ready( function() {
     }
     else if (req == "post") { 
       data = $('form').serialize(); 
-      alert(data);
+//      alert(data);
     }
     else { 
       data = {}; 
@@ -412,7 +412,7 @@ element = $(this).find(':first').attr('id');
  * Force reload of parent page if this div appears
  *******************************************************************/
   $('#div-reload-parent').load( function() {
-    alert('div-reload-parent 1');
+//    alert('div-reload-parent 1');
     parent.location.href=parent.location.href
   });
 
@@ -420,7 +420,7 @@ element = $(this).find(':first').attr('id');
  * Force reload of parent page if this div appears
  *******************************************************************/
   $('#div-reload').load( function() {
-    alert('div-reload 1');
+//    alert('div-reload 1');
     location.href=location.href
   });
   

data/app/assets/stylesheets/drg_cms/drg_cms.css

@@ -24,27 +24,25 @@
 */
 
 body {
-  font-family: helvetica;
-  font-size: 13px;
-  margin: 0px;
-  vertical-align: middle;
-}
-
-.text-with-select {
-  width: 24px;
+font-family: helvetica;
+font-size: 12px;
+margin: 0px;
+vertical-align: middle;
 }
 
 textarea, input, select {
-  font-family: helvetica;
-  font-size: 13px;  
-  padding: 4px;
-  border: solid 1px #fff;
-  box-shadow: rgba(0,0,0, 0.1) 0px 0px 4px;
-  border-radius: 2px;
-  background: linear-gradient(#ffe 2%, #fff 100%); 
-  color: #222;
+/*font-family: helvetica;
+font-size: 13px;  */
+padding: 4px;
+border: solid 1px #888;
+box-shadow: rgba(0,0,0, 0.1) 0px 0px 4px;
+border-radius: 2px;
+background: linear-gradient(#ffd 4%, #fff 100%); 
+color: #222;
 }
 
+input { padding: 6px;}
+
 select#record_select { padding: 1px;}
 
 hr {
@@ -53,7 +51,6 @@ border: none;
 height: 2px;
 }
 
-
 .div {
   background-color: red; 
   border: 0px;
@@ -78,6 +75,11 @@ a:link, a:active, a:visited { color: #c43; text-decoration: none; background: tr
 a:hover { text-decoration: none; color: #000; }
 a img { border: none; }
 
+
+.text-with-select {
+width: 24px;
+}
+
 .no-borders {
   padding: 0px;
   border-spacing: 0px;
@@ -346,14 +348,14 @@ a img { border: none; }
   border-bottom: 1px solid #eee;
 }
 .dc-readonly {
-  margin-left: 4px;
+  margin-left: 2px;
   margin-top: 2px;
   padding: 3px;
-  border: solid 1px #ddd;
+  border: solid 1px #aaa;
   border-right: solid 1px #fff;
   border-bottom: 0px;
   border-radius: 2px;
-  background: linear-gradient(#e8e8e8 2%, #fff 100%); 
+  background: linear-gradient(#eee 1%,  #fff 90%); 
 }
 
 .dc-color-odd {

data/app/controllers/cmsedit_controller.rb

@@ -22,14 +22,66 @@
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
 
+########################################################################
+# This is main controller for processing actions by DRG forms. It provides 
+# CRUD actions for editing MongoDB documents. DRG CMS does not require controller
+# to be made for every document model but centers all actions into single 
+# controller. Logic required to control data entry is provided within DRG 
+# forms which are loaded dynamically for every action.
+# 
+# Most of data entry controls must therefore be done in document models definitions. 
+# And there are controls that cannot be done in document models. Like controls
+# which include url parameters or accessing session variables. This is hard to be done
+# in model therefore cmsedit_controls had to be invented. cmsedit_controls are
+# modules with methods that are injected into cmsedit_controller and act in runtime like 
+# they are part of cmsedit_controller. 
+# 
+# Since Ruby and Rails provide some automagic loading of modules DRG CMS controls must be saved 
+# into app/controllers/drgcms_controls folder. Every model can have its own controls file. 
+# dc_page model's controls live in dc_page_controls.rb file. If model has embedded document
+# its control's would be found in model_embedded_controls.rb. By convention module names
+# are declared in camel case, so our dc_page_controls.rb declares DrgcmsControls::DcPageControls module.
+# 
+# Controls (among other) may contain 6 fixed callback methods.
+# These methods are:
+# * dc_new_record
+# * dc_before_edit
+# * dc_before_save
+# * dc_after_save
+# * dc_before_delete
+# * dc_after_delete
+# 
+# Methods dc_before_edit, before_save or before_delete may also effect flow of the application. If
+# method return false (not nil but FalseClass) normal flow of the program is interrupted and last operation
+# is canceled. 
+# 
+# Second control methods that can be declared in DRG CMS controls are filters for
+# viewing and sorting documents. It is often required that dynamic filters are 
+# applied to result_set documents. 
+# 
+#    result_set:
+#      filter: current_users_documents
+#      
+# Example implemented controls method:
+# 
+#    def current_users_documents
+#      if dc_user_can(DcPermission::CAN_READ)
+#        dc_page.where(created_by: session[:user_id])
+#      else
+#        flash[:error] = 'You can not perform this operation!'
+#        nil
+#      end
+#    end
+#      
+# If filter method returns false user will be presented with flash error.
+########################################################################
 class CmseditController < DcApplicationController
-#before_filter :check_authorization, :except => [:login]
 before_action :check_authorization, :except => [:show, :login]
 
 ########################################################################
-# check_sort_options
+# Will check and set sorting options for current result set. Subroutine of index method.
 ########################################################################
-def check_sort_options()
+def check_sort_options() #:nodoc:
   table_name = @tables.first[1]
   old_sort = session[table_name][:sort].to_s
   sort, direction = old_sort.split(' ')
@@ -49,9 +101,9 @@ def check_sort_options()
 end
 
 ########################################################################
-# check_filter_options. As simple as possible
+# Will check and set current filter options for result set. Subroutine of index method.
 ########################################################################
-def check_filter_options()
+def check_filter_options() #:nodoc:
   table_name = @tables.first[1]
   session[table_name] ||= {}
 # process page
@@ -100,11 +152,18 @@ end
 ########################################################################
 def index
 # If result_set is not defined on form, then it will fail. :return_to should know where to go
-  return process_return_to(params[:return_to]) if @form['result_set'].nil?
-#  
+  if @form['result_set'].nil?
+    return process_return_to(params[:return_to] || 'reload') 
+  end
+# result set is defined by filter method in control object
   if @form['result_set']['filter']
     if respond_to?(@form['result_set']['filter'])
       @records = send @form['result_set']['filter']
+# something iz wrong. flash[] should have explanation.
+      return render(action:  :index) if @records.class == FalseClass
+# pagination      
+      per_page = (@form['result_set']['per_page'] || 30).to_i
+      @records = @records.page(params[:page]).per(per_page) if per_page > 0
     else
       p "Error: result_set:filter: #{@form['result_set']['filter']} not found in controls!"
     end
@@ -115,6 +174,7 @@ def index
     else
       rec = @tables.first[0].find(@ids.first)          # top most document.id
       1.upto(@tables.size - 2) { |i| rec = rec.send(@tables[i][1].pluralize).find(@ids[i]) }  # find embedded childrens by ids
+#      p rec,@tables, @tables.last[1].pluralize
       @records = rec.send(@tables.last[1].pluralize)   # current embedded set
 # sort by order if order field is present in model
       if @tables.last[1].classify.constantize.respond_to?(:order)
@@ -130,39 +190,35 @@ def index
 end
 
 ########################################################################
-# Filter
+# Filter action. 
 ########################################################################
 def filter
   index
 end
 
 ########################################################################
-# Show is (ab)used to do some usefull things
+# Show is (ab)used for direct login and logout into cmsedit controller. Login
+# and logout actions can be directly performed by calling http://site.com/cmsedit/login
 ########################################################################
 def show
   case
   when params[:id].in?(%w(login logout)) then # show login menu
     session[:edit_mode] = 0 
-#    dc_collect_menu_forms
     render action: 'show', layout: 'cms'
-#  when params[:id] == 'copy_clipboard'
-#    return copy_clipboard
-#  when params[:id] == 'paste_clipboard'
-#    return paste_clipboard
   end
 end
 
 ########################################################################
 # Show is used to display menu
 ########################################################################
-def login
+def login #:nodoc:
 #  session[:edit_mode] = 0 if params[:id].in? %w(login logout) # show login menu
 #  dc_collect_menu_forms
   render action: 'show', layout: 'cms'
 end
 
 ########################################################################
-# New action
+# New action.
 ########################################################################
 def new
   if (m = callback_method('before_new') )
@@ -197,35 +253,55 @@ def new
 end
 
 ########################################################################
-# duplicate_record. For now not needed
+# Duplicate embedded document. Since embedded documents are returned differently 
+# then top level document. Subroutine of duplicate_socument.
 ########################################################################
-=begin
-def duplicate_record(source, dest)
-# params['dup_fields'] += ',' if params['dup_fields'] # for easier field matching
-  source.attribute_names.each do |attr_name|
-    next if attr_name == '_id'
-    p [attr_name, source[attr_name].class]
-    if source[attr_name].class == Array
-#      dest.save
-       source[attr_name].each do |a|
-         p a
-         rec = dest.send(source[attr_name]).new
-         duplicate_record(a, rec)
-         rec.save!
-       end
-    else
-# if duplicate string must be added. Usefull for unique attributes
+def duplicate_embedded(source) #:nodoc:
+# TODO Works for two embedded levels. Dies with third and more levels.
+  dest = {}
+  source.each do |attr_name, value|
+    next if attr_name == '_id' # don't duplicate _id
+    if value.class == Array
+      dest[attr_name] = []
+      value.each do |ar|
+        dest[attr_name] << duplicate_embedded(ar)
+      end
+    else      
+# if duplicate string must be added. Useful for unique attributes
       add_duplicate = params['dup_fields'].to_s.match(attr_name + ',')
-      p ["*",add_duplicate]
-      dest.send("#{attr_name}=", source[attr_name])# + (add_duplicate ? ' duplicate' : '')) if source[attr_name] # can be nil
+      dest[attr_name] = value
+      dest[attr_name] << ' dup' if add_duplicate
     end
   end
-  dest.save!
+  dest
 end
-=end
 
 ########################################################################
-# Create or duplicate action
+# Will create duplicate document of source document. This method is used for 
+# duplicating document and is called from create action.
+########################################################################
+def duplicate_document(source)
+  dest = {}
+  source.attribute_names.each do |attr_name|
+    next if attr_name == '_id' # don't duplicate _id
+# if duplicate string must be added. Useful for unique attributes
+    add_duplicate = params['dup_fields'].to_s.match(attr_name + ',')
+    dest[attr_name] = source[attr_name]
+    dest[attr_name] << ' dup' if add_duplicate
+  end
+#  
+  source.embedded_relations.keys.each do |embedded_name|
+    next if source[embedded_name].nil? # it happens
+    dest[embedded_name] = []
+    source[embedded_name].each do |ar|
+      dest[embedded_name] << duplicate_embedded(ar)
+    end
+  end
+  dest
+end
+
+########################################################################
+# Create (or duplicate) action. Action is also used for turning filter on.
 ########################################################################
 def create
 # abusing create for turning filter on
@@ -250,16 +326,12 @@ def create
     end
   else # duplicate record
     find_record
-    #create_new_empty_record
-    #duplicate_record(@source, @record)
-    dup = @record.dup
-    dup.created_at = Time.now if dup.respond_to?('created_at') # yep it is also duplicated
+    params['dup_fields'] += ',' if params['dup_fields'] # for easier field matching
+    new_doc = duplicate_document(@record)
+    create_new_empty_record(new_doc)
+    update_standards()
+    @record.save!
 
-    params['dup_fields'].to_s.split(',').each do |df|
-      dup[df] = dup[df] + ' duplicate' if dup.respond_to?(df) # avoid errors
-    end
-    update_standards(dup)
-    dup.save!
     index
   end
 end
@@ -277,22 +349,19 @@ def edit
   @parms['action'] = 'update'
 end
 
-=begin
-########################################################################
-# TODO Think of better way for loginng and displaying menu
-# Show action.
-########################################################################
-def show
-  find_record
-#  @parms['action'] = 'show'
-end
-=end
-
 ########################################################################
 # Update action.
 ########################################################################
 def update
   find_record
+# check if record was not updated in mean time
+  if @record.respond_to?(:updated_at)
+    if params[:last_updated_at].to_i != @record.updated_at.to_i
+      flash[:error] = t('drgcms.updated_by_other')
+      return render(action: :edit)
+    end
+  end
+#   
   if dc_user_can(DcPermission::CAN_EDIT_ALL) or
     ( @record.respond_to?('created_by') and
       @record.created_by == session[:user_id] and
@@ -311,7 +380,7 @@ def update
 end
 
 ########################################################################
-# Destroy document
+# Destroy action. Used also for enabling and disabling record.
 ########################################################################
 def destroy
   find_record
@@ -381,6 +450,7 @@ end
 
 protected
 
+=begin
 ########################################################################
 # Processes on_save_ok form directive. Data is saved to session for
 # safety reasons.
@@ -390,11 +460,13 @@ def process_on_save_ok
   session[:on_save_ok_commit] = params[:commit]
   eval(params[:on_save_ok])
 end
+=end
 
 ########################################################################
-# Merges two forms. With a little help of https://www.ruby-forum.com/topic/142809 
+# Merges two forms when current form extends other form. Subroutine of read_yaml.
+# With a little help of https://www.ruby-forum.com/topic/142809 
 ########################################################################
-def forms_merge(hash1, hash2)
+def forms_merge(hash1, hash2) 
   target = hash1.dup
   hash2.keys.each do |key|
     if hash2[key].is_a? Hash and hash1[key].is_a? Hash
@@ -408,7 +480,7 @@ def forms_merge(hash1, hash2)
 end
 
 ########################################################################
-# Read yaml form file
+# Read drgcms form into yaml object. Subroutine of check_authorization.
 ########################################################################
 def read_yaml
   table_name = decamelize_type(params[:table].strip)
@@ -424,8 +496,8 @@ def read_yaml
     form = YAML.load_file( dc_find_form_file(@form['extend']) )
     @form = forms_merge(form, @form)
   end
-# add readonly key to form if readonly parameter is passed  
-  @form['readonly'] = 1 if @form['readonly'] and %w(1 yes true).include?(@form['readonly'].to_s.downcase.strip)
+# add readonly key to form if readonly parameter is passed in url
+  @form['readonly'] = 1 if params['readonly'] and %w(1 yes true).include?(params['readonly'].to_s.downcase.strip)
 #  p '2',@form
 # !!!!!! Always use strings for key names since @parms['table'] != @parms[:table]
   @parms = { 'table' => table_name, 'ids' => ids, 'formname' => formname,
@@ -433,10 +505,11 @@ def read_yaml
 end
 
 ############################################################################
-# Check if user is authorized for the action.
-# If everything is OK it also loads form definition.
+# Check if user is authorized for the action. If authorization is in order it will also
+# load DRG form.
 ############################################################################
 def check_authorization
+  params[:table] ||= params[:formname]
 # Extend class with methods defined in drgcms_controls module. May include embedded forms therefor ; => _ 
   controls_string = params[:table].gsub(';','_') + '_control'
   controls = ("DrgcmsControls::#{controls_string.classify}".constantize rescue nil)
@@ -459,9 +532,9 @@ def check_authorization
 end
 
 ########################################################################
-# Find record for edit, update or delete.
+# Find current record (document) for edit, update or delete.
 ########################################################################
-def find_record
+def find_record #:nodoc:
   if @tables.size == 1
     @record = @tables.first[0].find(params[:id])
   else
@@ -474,33 +547,18 @@ end
 ########################################################################
 # Creates new empty record for new and create action.
 ########################################################################
-def create_new_empty_record
+def create_new_empty_record(initial_data=nil) #:nodoc:
   if @tables.size == 1
-    @record = @tables.first[0].new
+    @record = @tables.first[0].new(initial_data)
   else
     rec = @tables.first[0].find(@ids.first)             # top most record
     1.upto(@tables.size - 2) { |i| rec = rec.send(@tables[i][1].pluralize).find(@ids[i]) }  # find embedded childrens by ids
-    @record = rec.send(@tables.last[1].pluralize).new   # new record
+    @record = rec.send(@tables.last[1].pluralize).new(initial_data)   # new record
   end
 end
-=begin
-########################################################################
-# Get data for multitext_autocomplete field. That is field which is saved as record[kats_****]
-#
-# @param [ name ] Name of field
-########################################################################
-def get_data_multitext_autocomplete(name)
-  r = []
-  params['record'].each do |k,v|
-# if it starts with - then it was removed
-    r << BSON::ObjectId(v) if k.match("#{name}_") and v[0,1] != '-'
-  end
-  r.uniq!
-  r
-end
-=end
+
 ########################################################################
-# update_standard fields like updated_by, created_by
+# Update standard fields like updated_by, created_by, site_id
 ########################################################################
 def update_standards(record = @record)
   record.updated_by = session[:user_id] if record.respond_to?('updated_by')
@@ -514,9 +572,9 @@ end
 
 ########################################################################
 # Since tabs have been introduced on form it is a little more complicated
-# to get all active field names on form. This method does it.
+# to get all edit fields on form. This method does it. Subroutine of save_data.
 ########################################################################
-def fields_on_form()
+def fields_on_form() #:nodoc:
   fields = []
   if @form['form']['fields']
 # second element of array is hash. Get only hash element
@@ -530,14 +588,11 @@ def fields_on_form()
 end
 
 ########################################################################
-# Save changes to journal table. Saves all parameters to retrive record if needed.
-#
-# @example usage before save
-#   save_journal(@record.changes)
-# @example usage on delete
-#   save_journal(true)
-#
-# @param [ changes ] Changes for the record
+# Save document changes to journal table. Saves all parameters to retrieve record if needed.
+# 
+# [Parameters:]
+# [operation] 'delete' or 'update'.
+# [changes] Current document changed fields.
 ########################################################################
 def save_journal(operation, changes = {})
 #  return unless session[:save_journal]
@@ -564,10 +619,10 @@ def save_journal(operation, changes = {})
 end
 
 ########################################################################
-# Determines if callback method is defined in parameters or in model. 
+# Determines if callback method is defined in parameters or in control module. 
 # Returns callback method name or nil if not defined.
 ########################################################################
-def callback_method(key)
+def callback_method(key) #:nodoc:
   data_key = key.gsub('_','-') # data fields translate _ to -
   cb = case
     when params['data'] && params['data'][data_key] then params['data'][data_key]
@@ -576,7 +631,6 @@ def callback_method(key)
     when params[key] then params[key]
     else nil
   end
-#  p [ '***********************',key, cb, params['data'],params['key']]
 #  
   ret = case
     when cb.nil? then cb # otherwise there will be errors in next lines
@@ -592,19 +646,22 @@ end
 ########################################################################
 # Calls callback method.
 ########################################################################
-def call_callback_method(m)
+def call_callback_method(m) #:nodoc:
   send(m) if respond_to?(m)  
 end
 
 ########################################################################
-# Same as javascript_tag helper
+# Same as javascript_tag helper. Ajax form actions may results in javascript code to be returned.
+# This will add javascript tag to code.
 ########################################################################
-def js_tag(script)
+def js_tag(script) #:nodoc:
   "<script type=\"text/javascript\">#{script}</script>"
 end
 
 ########################################################################
-# Process return_to parameter when set on a form or set by callbacks.
+# Process return_to parameter when defined on form or set by controls methods. 
+# params['return_to'] may contain 'index', 'reload' or 'parent.reload' or any valid url to
+# return to, after successful controls method call.
 ########################################################################
 def process_return_to(return_to)
   script = case
@@ -617,37 +674,34 @@ def process_return_to(return_to)
 end
 
 ########################################################################
-# Save_data. Save only fields on form.
+# Save edited data. Take care that only fields defined on form are affected. 
+# It also saves journal data and calls before_save and after_save callbacks.
 ########################################################################
 def save_data
   fields = fields_on_form()
-  p fields
   return true unless fields.size > 0
 #
   fields.each do |v|
     next if v['type'].match('embedded') # don't wipe embedded fields
     next if params[:edit_only] and params[:edit_only] != v['name'] # otherwise other fields would be wiped
     next unless @record.respond_to?(v['name']) # there can be temporary fields on the form
-#
-# TODO I used to ignore readonly fields. check if this is OK
-#    next if v['type'] == 'readonly' or v['readonly'] # ignore readonly fields
 # return value from form field definition
     value = DrgcmsFormField.const_get(v['type'].camelize).get_data(params, v['name'])
     @record.send("#{v['name']}=", value)
   end
-#
-  update_standards()
+# 
   operation = @record.new_record? ? :new : :update
-# callback methods
+# controls callback method
   if (m = callback_method('before_save') )
     ret = call_callback_method(m)
 # dont's save if callback method returns false    
     return false if ret.class == FalseClass
   end
-# check if model has dc_before_save method
+# maybe model has dc_before_save method defined. Call it.
   @record.dc_before_save(self) if @record.respond_to?('dc_before_save')
 #
   changes = @record.changes
+  update_standards() if changes.size > 0  # update only if there has been some changes
   if (saved = @record.save)
     save_journal(operation, changes)
 # callback methods
@@ -658,6 +712,7 @@ def save_data
   saved
 end
 
+=begin
 ########################################################################
 # Returns true if model has field defined. This might be defined by mongoid,
 # but I didn't found method.
@@ -669,5 +724,6 @@ def model_has_field?(model, field_name)
   model.fields.each {|f| return true if f.first == field_name.to_s}
   false
 end
+=end
 
 end