dragonfly_harfbuzz 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8780a3c9bff0ca80af60c9b793ab7fb0e04db07c600ee5010332b3a03c5d27d1
-  data.tar.gz: e19f34bce31c5b347fbb607d15e1944b771f96a76ae10f2d5c059d25fb8a3f76
+  metadata.gz: 8770ccbb7bfdfe8b736a4e2074118fe6229161dff997af7d72eba97ae5c2bade
+  data.tar.gz: 248e3e3d33af72f6362eb02fa733e3b97ee92c101f47d27323e0708b3ec40cb5
 SHA512:
-  metadata.gz: eb95dad4fb98e7a90a168261d7c483b3fc4602331968ccaa0499e431b5008c2d2b34aa9a6f68eb0178a1d883b0fbaa14ac67f2f5f6a484f5d881c455362e09dc
-  data.tar.gz: 2a6d9c7fe23ab4f8290f505363bcc51e9beb1b579f835b606dde94647616832d65ec73f8ace5bdd32869ba4e1fbb60c3fe7c041ec1bdeeb8fdfee8978f22749a
+  metadata.gz: 936adfbd294352ec1f41301d948fe06ea1d7045a47c68a053bef53bea718b9d7953baac758070afb066c593a035b6f6642402956cfd8a8d31a8b81a6731de6c9
+  data.tar.gz: 91a5e0d69b79347ecea40d1a8502ef4a56a2cb21a5b8ef19c90e4bc3786cbeeff8f3ffb202f3cbeedd465b621614ef3153e0288e4d2f75bedd47a458f394dd2f

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 1.1.3
+
+* make sure that `str` argument to `hb_view` is properly escaped
+
 ## 1.1.2
 
 * improved `SUPPORTED_FORMATS` matching that ignores case

data/lib/dragonfly_harfbuzz/processors/hb_view.rb

@@ -25,7 +25,7 @@ module DragonflyHarfbuzz
             --output-format=#{format}
           ]
 
-          args << "--text='#{str}'" unless options.has_key?('unicodes')
+          args << "--text=#{Shellwords.escape(str)}" unless options.key?('unicodes')
 
           options.reject { |k, _| %w[format markup_svg flatten_svg split_paths].include?(k.to_s) }.each do |k, v|
             args << "--#{k.to_s.tr('_', '-')}=#{Shellwords.escape(v)}" if v.present?
@@ -46,7 +46,7 @@ module DragonflyHarfbuzz
         content
       end
 
-      def update_url(attrs, str = '', options = {})
+      def update_url(attrs, _str = '', options = {})
         format = options.fetch('format', 'svg').to_s
         attrs.ext = format
       end
@@ -54,11 +54,11 @@ module DragonflyHarfbuzz
       private
 
       def str_from_unicodes(unicodes)
-        unicodes.split(",").map do |hexstring|
+        unicodes.split(',').map do |hexstring|
           begin
-            Array(hexstring).pack("H*").force_encoding('utf-16be').encode('utf-8')
-          rescue
-            " "
+            Array(hexstring).pack('H*').force_encoding('utf-16be').encode('utf-8')
+          rescue StandardError
+            ' '
           end
         end.join
       end

data/lib/dragonfly_harfbuzz/version.rb

@@ -1,3 +1,3 @@
 module DragonflyHarfbuzz
-  VERSION = '1.1.2'.freeze
+  VERSION = '1.1.3'.freeze
 end

data/test/dragonfly_harfbuzz/processors/hb_view_test.rb

@@ -5,11 +5,11 @@ describe DragonflyHarfbuzz::Processors::HbView do
   let(:content) { Dragonfly::Content.new(app, SAMPLES_DIR.join('sample.otf')) }
   let(:processor) { DragonflyHarfbuzz::Processors::HbView.new }
 
-  let(:string) { 'FOO' }
+  let(:string) { "F'OO" }
 
   describe 'SUPPORTED_FORMATS' do
     DragonflyHarfbuzz::SUPPORTED_FORMATS.each do |format|
-      unless File.exists?(SAMPLES_DIR.join("sample.#{format}"))
+      unless File.exist?(SAMPLES_DIR.join("sample.#{format}"))
         it(format) { skip "sample.#{format} does not exist, skipping" }
         next
       end
@@ -49,8 +49,8 @@ describe DragonflyHarfbuzz::Processors::HbView do
   end
 
   describe 'str as unicodes' do
-    before { processor.call(content, nil, unicodes: "0042,0043", flatten_svg: true) }
-    it { content.data.must_include "<svg character=\"B\" class=\"character\"" }
-    it { content.data.must_include "<svg character=\"C\" class=\"character\"" }
+    before { processor.call(content, nil, unicodes: '0042,0043', flatten_svg: true) }
+    it { content.data.must_include '<svg character="B" class="character"' }
+    it { content.data.must_include '<svg character="C" class="character"' }
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dragonfly_harfbuzz
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Tomas Celizna
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-19 00:00:00.000000000 Z
+date: 2018-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport