dradis-nessus 3.14.0 → 3.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dd7afd05a70168f26f4ceef72062d12190696b9ed57161f4ad530a749483c927
-  data.tar.gz: 2e05105e0c649763c636b9d7e97198f76911f414774a909c5068f39b3b45d8f1
+  metadata.gz: 1ffe6eb14f5e857063d0c8af0be18459fa0dd340eedae0dfe08bd129eb4a2994
+  data.tar.gz: 6e4687f774e30e59a33c9e2f287a7c6cbebc7791e940250fa80c44cc80bbf963
 SHA512:
-  metadata.gz: f39dbb129bc08c24cafb412d0cd8e6d595f042806699b7fb8466e70758b7db4cc563b1b0cf900e12b76b78ffe3e55920a06234265f6de9ab861b8b7e5e52f280
-  data.tar.gz: 5fed2a78b870244b93baf874eca6d673dbde08b9082bb9cf35274c6b45d956ac081015de65f0dd66e24024a0be0658ea86b84d9ed1df2151fdc6f469c097ce51
+  metadata.gz: db9e161e630d31c5fada8b4f5be00895207be2305cfb64b775c2045901d7b1697b3b3e1089ffa23858368b98370ef266d628b700b5399141e768b843b87a7838
+  data.tar.gz: 3321b5ba7b17ffa71a9292461d2e1b568038afbea954dc4292c469954e33ec8dba40131435c8b7c61b5272ddfdea4ff5e7fcce88a67f808f883eb405c16e1ea0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Dradis Framework 3.15 (November, 2019) ##
+
+*   Fixed bullet points formatting to handle internal text column widths
+
 ## Dradis Framework 3.14 (August, 2019) ##
 
 *   No changes.

data/lib/dradis/plugins/nessus/field_processor.rb

@@ -28,7 +28,7 @@ module Dradis
           else
             output = @nessus_object.try(name) || 'n/a'
 
-            if field == 'report_item.description' && output =~ /^  -/
+            if field == 'report_item.description' && output =~ /^\s+-/
               format_bullet_point_lists(output)
             else
               output
@@ -39,15 +39,17 @@ module Dradis
         private
         def format_bullet_point_lists(input)
           input.split("\n").map do |paragraph|
-            if paragraph =~ /^  - (.*)$/m
-              '* ' + $1.gsub(/    /, '').gsub(/\n/, ' ')
+            if paragraph =~ /(.*)\s+:\s*$/m
+              $1 + ':'
+            elsif paragraph =~ /^\s+-\s+(.*)$/m
+              '* ' + $1.gsub(/\s{3,}/, ' ').gsub(/\n/, ' ')
             else
               paragraph
             end
-          end.join("\n\n")
+          end.join("\n")
         end
       end
 
     end
   end
-end
+end

data/lib/dradis/plugins/nessus/gem_version.rb

@@ -8,7 +8,7 @@ module Dradis
 
       module VERSION
         MAJOR = 3
-        MINOR = 14
+        MINOR = 15
         TINY = 0
         PRE = nil
 

data/spec/dradis/plugins/nessus/field_processor_spec.rb

@@ -3,25 +3,39 @@ require 'ostruct'
 
 describe Dradis::Plugins::Nessus::FieldProcessor do
 
-  describe "%report_item.description% field formatting" do
-    context "bullet points" do
-      it "converts Nessus broken lists into Textile bullet-point lists" do
-        doc = Nokogiri::XML(File.read('spec/fixtures/files/report_item-with-list.xml'))
+  describe '%report_item.description% field formatting' do
+    context 'bullet points' do
+      before do
+        doc = Nokogiri::XML(
+          File.read('spec/fixtures/files/report_item-with-list.xml')
+        )
         processor = described_class.new(data: doc.root)
 
-        value = processor.value(field: 'report_item.description')
-        expect(value).to_not be_empty
+        @value = processor.value(field: 'report_item.description')
+      end
+
+      it 'converts Nessus broken lists into Textile bullet-point lists' do
+        expect(@value).to_not be_empty
+
+        expect(@value).to include(
+          '* A denial of service vulnerability exists relating to '\
+          'the \'mod_dav\' module as it relates to MERGE requests.'
+        )
+      end
 
-        expect(value).to include("* A denial of service vulnerability exists relating to the 'mod_dav' module as it relates to MERGE requests. (CVE-2013-1896)")
+      it 'does not add unnecessary newlines to list items' do
+        expect(@value).to include("vulnerabilities:\n\n* A flaw exists")
       end
     end
   end
 
-  it "Recasted severity values appear in the Evidence" do
-    doc = Nokogiri::XML(File.read('spec/fixtures/files/report_item-with-list.xml'))
+  it 'Recasted severity values appear in the Evidence' do
+    doc = Nokogiri::XML(
+      File.read('spec/fixtures/files/report_item-with-list.xml')
+    )
     processor = described_class.new(data: doc.root)
     value = processor.value(field: 'evidence.severity')
     expect(value).to_not be_empty
-    expect(value).to include("2")
+    expect(value).to include('2')
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dradis-nessus
 version: !ruby/object:Gem::Version
-  version: 3.14.0
+  version: 3.15.0
 platform: ruby
 authors:
 - Daniel Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-13 00:00:00.000000000 Z
+date: 2019-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dradis-plugins
@@ -158,7 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Nessus upload add-on for the Dradis Framework.