dradis-html_export 4.2.0 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3ea91825f0e0e103783e3d00268f924ca7a48eb7a6dee9328ba7566ba308b8e2
-  data.tar.gz: df85040ddc235ad054ba657e947c7181daa0c877fc986beb5168d107f9dd64f3
+  metadata.gz: d0d9fc4de71f006fa98925432abe6ebc106be1412f0d16199679b71b1ddd2cb4
+  data.tar.gz: b97d97b658c813c94cfc62397bade68f4e5f466386768f1f6410f8819334fadd
 SHA512:
-  metadata.gz: b456de048f00e40bbdc594d705e1d486bf02e28470a9a701fa9e381e6c4ae10f52f3cf76283a91b65918a3786ab6215ab2cbe54a7d6cc9d76ece048aa725423c
-  data.tar.gz: 23c4872736d4713ce8f13037305843eb475ded540782b9d56193faaff1c5ac0faa091367ca059885a958acc12149b98d91adc543bc1be345b579dd2d80b969b8
+  metadata.gz: 0d42f27e5cbce3ca6087b213fdb3a47bf01193cdc87d2cee2d85781ab2d9a17866181c57f352c741127bc95605e6c787658760c9fcc44600ceb8cee6322dcf0c
+  data.tar.gz: 30807f3bda9b6c23aa8023df4446404b3701e4290160766601ede9cfc5df92402b59a4d6f6335bb8e61d12f06c2b6c87d99ce8aca6062087b90a5ba0835af55d

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+v4.3.0 (April 2022)
+  - Add the RTP report title on export page in DradisPro
+
 v4.2.0 (February 2022)
   - No changes
 

data/app/presenters/dradis/plugins/html_export/template_presenter.rb

@@ -0,0 +1,38 @@
+module Dradis
+  module Plugins
+    module HtmlExport
+      class TemplatePresenter < BasePresenter
+        presents :template
+
+        def self.each_template(&block)
+          templates.each(&block)
+        end
+
+        def self.templates
+          if defined?(Dradis::Pro)
+            ReportTemplateProperties.all.where(plugin_name: :html_export).order(:title)
+          else
+            Dir["%s/*" % templates_dir].map { |t| File.basename(t) }.sort
+          end
+        end
+
+        def self.templates_dir
+          File.join(::Configuration::paths_templates_reports, 'html_export')
+        end
+
+        def title
+          return template if template.is_a?(String)
+
+          content_tag(:span, "#{template.title} - ") +
+            content_tag(:small, template.template_file)
+        end
+
+        def filename
+          return template if template.is_a?(String)
+
+          template.template_file
+        end
+      end
+    end
+  end
+end

data/app/views/dradis/plugins/html_export/export/_index-content.html.erb

@@ -1,21 +1,20 @@
-<%
-  templates_dir = File.join(::Configuration::paths_templates_reports, 'html_export')
-  templates = Dir["%s/*" % templates_dir].map { |t| File.basename(t) }.sort
-%>
-
 <%= content_tag :div, id: 'plugin-html_export', class: 'tab-pane fade' do %>
   <%= form_tag project_export_manager_path(current_project), target: '_blank' do %>
     <%= hidden_field_tag :plugin, :html_export %>
     <%= hidden_field_tag :route, :root %>
 
     <h4 class="header-underline">Choose a template</h4>
-    <p>Please choose one of the templates available for this plugin (find them in <code>.<%= templates_dir[Rails.root.to_s.length..-1] %></code>)</p>
+    <p>Please choose one of the templates available for this plugin (find them in <code>.<%= Dradis::Plugins::HtmlExport::TemplatePresenter.templates_dir[Rails.root.to_s.length..-1] %></code>)</p>
 
-    <% templates.each do |template| %>
-      <div class="custom-control custom-radio">
-        <%= radio_button_tag :template, template, template == templates.first, :class => 'custom-control-input' %>
-        <label class="custom-control-label" for="template_<%= template %>"><%= template %></label>
-      </div>
+    <% Dradis::Plugins::HtmlExport::TemplatePresenter.each_template do |template| %>
+      <% present(template, Dradis::Plugins::HtmlExport::TemplatePresenter) do |template_presenter| %>
+        <div class="custom-control custom-radio">
+          <%= radio_button_tag :template, template_presenter.filename, Dradis::Plugins::HtmlExport::TemplatePresenter.templates.first == template , class: 'custom-control-input' %>
+          <label class="custom-control-label" for="template_<%= template_presenter.filename %>">
+            <%= template_presenter.title %>
+          </label>
+        </div>
+      <% end %>
     <% end %>
 
     <button id="export-button" class="btn btn-lg btn-primary mt-4">Export</button>

data/lib/dradis/plugins/html_export/gem_version.rb

@@ -8,7 +8,7 @@ module Dradis
 
       module VERSION
         MAJOR = 4
-        MINOR = 2
+        MINOR = 3
         TINY  = 0
         PRE   = nil
 

data/spec/presenters/dradis/plugins/html_export/template_presenter_spec.rb

@@ -0,0 +1,47 @@
+require 'rails_helper'
+
+RSpec.describe Dradis::Plugins::HtmlExport::TemplatePresenter do
+  class FakeView
+    include ActionView::Helpers::TextHelper
+  end
+
+  let(:template_presenter) { described_class.new(template, FakeView.new) }
+
+  describe '#title' do
+    context 'when template is a string' do
+      let(:template) { 'basic.html.erb' }
+
+      it 'returns the string' do
+        expect(template_presenter.title).to eq template
+      end
+    end
+
+    context 'when template is a RTP' do
+      let(:template) do
+        double(
+          'ReportTemplateProperties',
+          title: 'Basic',
+          template_file: 'basic.html.erb'
+        )
+      end
+
+      it 'returns a formatted title' do
+        expect(template_presenter.title).to eq "<span>#{template.title} - </span><small>#{template.template_file}</small>"
+      end
+
+      context 'when title contains javascript' do
+        let(:template) do
+          double(
+            'ReportTemplateProperties',
+            title: '<script>alert("hello world")</script>',
+            template_file: 'basic.html.erb'
+          )
+        end
+
+        it 'prevents cross site scriptiing' do
+          expect(template_presenter.title).to eq "<span>&lt;script&gt;alert(&quot;hello world&quot;)&lt;/script&gt; - </span><small>#{template.template_file}</small>"
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dradis-html_export
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.3.0
 platform: ruby
 authors:
 - Daniel Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-02-14 00:00:00.000000000 Z
+date: 2022-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dradis-plugins
@@ -70,6 +70,7 @@ files:
 - README.md
 - Rakefile
 - app/controllers/dradis/plugins/html_export/base_controller.rb
+- app/presenters/dradis/plugins/html_export/template_presenter.rb
 - app/views/dradis/plugins/html_export/export/_index-content.html.erb
 - app/views/dradis/plugins/html_export/export/_index-tabs.html.erb
 - config/routes.rb
@@ -83,6 +84,7 @@ files:
 - lib/tasks/thorfile.rb
 - spec/fixtures/files/template.html.erb
 - spec/lib/dradis/plugins/html_export/exporter_spec.rb
+- spec/presenters/dradis/plugins/html_export/template_presenter_spec.rb
 - spec/requests/html_export_spec.rb
 - spec/spec_helper.rb
 - templates/basic.html.erb
@@ -113,5 +115,6 @@ summary: Dradis HTML export plugin
 test_files:
 - spec/fixtures/files/template.html.erb
 - spec/lib/dradis/plugins/html_export/exporter_spec.rb
+- spec/presenters/dradis/plugins/html_export/template_presenter_spec.rb
 - spec/requests/html_export_spec.rb
 - spec/spec_helper.rb