dpl 1.6.5.travis.470.1 → 1.6.5.travis.477.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzkxOWMxZTdkYzkzNmY5YjYyYmFlYzMzZGZhYzkxMzZkMjVjMDVlMg==
+    ZGZmMjkzNzg4MGE2Y2Y2ZDk1YTA4NWI1MWQ4MWU5OThlNWUyZDNjOA==
   data.tar.gz: !binary |-
-    MTJjZGNlMzI0OWU3N2NjNDdhOTBkMjZjZWU5MmU5OWEyY2ZkZTExOA==
+    ODEyOGE3MDJjMDdhMTRmMTk4YjdiYTU4NzM5MjhkZWVlYjdmMmEzNw==
 SHA512:
   metadata.gz: !binary |-
-    ZDUxNzYwNTk4ZDRkYWY2Yjc0YThhYzk0MmRlNDk5NDJmNGU4NmY0YjQwNmI4
-    Mzg1YzUxMzM3ZThlYjc1NjE3NjZhZGZiZDg1YjViMDZkMGM1MzliZTk0NzFj
-    NTQ5YTQ5YmU0MjM2NmEyZDk5MWY4MmViZGIxZjBhODlkZmMwYzQ=
+    MDljMmIxODk0ZmUxMzhkYmVhMzIzOGFjODk4MWQ1MmQwYzVmZDMzNThhNTI1
+    YzhiOTNjOTYwN2Y3ZTAxMjIyODQ3ZGVmYmEwNTQzMjRlZDhiNzJjMzMwZTM2
+    YzczNDg2OTQxM2I2MDg1ZThiNDRjZTU3YTZkNTI3ZjBlYzhmYjM=
   data.tar.gz: !binary |-
-    MGEzYzU1OGNiZWU2YjljYWVjYzliOTMyYWFiOWE0NTJhOTg1N2Y0MTE4NDI2
-    YTJlNzgyZDAzZWMxMGVjNjIyMTg0NWYyZjUyZTUwOTY0YzViZGVjN2ViZjVh
-    YzZiYzc1NWQyZGI0OWRiMjg3Y2I5NzI5MmQ5ODIxZWJiNTVhZTU=
+    MTc4Zjk5MjhkN2QxMjc3NzI2MWViMzRkZWE3MjlhM2YwZDdjNWEzOGNjYTM0
+    MDc1MDY4ZjdhOGE2ZDZmNDRkZjk0NDA2ZDM1YzIyMjgyMmY5YWZhYTdlZmI3
+    YjE5Nzk3Zjg3NWYzNjY5YTM1YmFlZGMzOWI0NzNmZmIzMDYzMTY=

data/README.md

@@ -157,7 +157,7 @@ As a rule of thumb, you should switch to the Git strategy if you run into issues
 #### Examples:
 
     dpl --provider=pypi --user=<username> --password=<password>
-    dpl --provider=pypi --user=<username> --password=<password> --server=`https://mypackageindex.com/index` --distributions='sdist bdist_wheel'
+    dpl --provider=pypi --user=<username> --password=<password> --server='https://mypackageindex.com/index' --distributions='sdist bdist_wheel'
 
 ### NPM:
 

data/lib/dpl/provider/releases.rb

@@ -85,7 +85,12 @@ module DPL
           if already_exists
             log "#{filename} already exists, skipping."
           else
-            api.upload_asset(release_url, file, {:name => filename, :content_type => MIME::Types.type_for(file).first.to_s})
+            content_type = MIME::Types.type_for(file).first.to_s
+            if content_type.empty?
+              # Specify the default content type, as it is required by GitHub
+              content_type = "application/octet-stream"
+            end
+            api.upload_asset(release_url, file, {:name => filename, :content_type => content_type})
           end
         end
       end

data/spec/provider/releases_spec.rb

@@ -70,7 +70,7 @@ describe DPL::Provider::Releases do
     example "When Release Exists but has no Files" do
       allow_message_expectations_on_nil
 
-      provider.options.update(:file => ["test/foo.bar", "bar.foo"])
+      provider.options.update(:file => ["test/foo.bar", "bar.txt"])
 
       allow(provider).to receive(:releases).and_return([""])
       allow(provider).to receive(:get_tag).and_return("v0.0.0")
@@ -86,8 +86,8 @@ describe DPL::Provider::Releases do
       allow(provider.api.release.rels[:assets]).to receive(:get).and_return({:data => [""]})
       allow(provider.api.release.rels[:assets].get).to receive(:data).and_return([])
 
-      expect(provider.api).to receive(:upload_asset).with(anything, "test/foo.bar", {:name=>"foo.bar", :content_type=>""})
-      expect(provider.api).to receive(:upload_asset).with(anything, "bar.foo", {:name=>"bar.foo", :content_type=>""})
+      expect(provider.api).to receive(:upload_asset).with(anything, "test/foo.bar", {:name=>"foo.bar", :content_type=>"application/octet-stream"})
+      expect(provider.api).to receive(:upload_asset).with(anything, "bar.txt", {:name=>"bar.txt", :content_type=>"text/plain"})
 
       provider.push_app
     end
@@ -95,7 +95,7 @@ describe DPL::Provider::Releases do
     example "When Release Exists and has Files" do
       allow_message_expectations_on_nil
 
-      provider.options.update(:file => ["test/foo.bar", "bar.foo"])
+      provider.options.update(:file => ["test/foo.bar", "bar.txt"])
 
       allow(provider).to receive(:releases).and_return([""])
       allow(provider).to receive(:get_tag).and_return("v0.0.0")
@@ -111,7 +111,7 @@ describe DPL::Provider::Releases do
       allow(provider.api.release.rels[:assets]).to receive(:get).and_return({:data => [""]})
       allow(provider.api.release.rels[:assets].get).to receive(:data).and_return([double(:name => "foo.bar"), double(:name => "foo.foo")])
 
-      expect(provider.api).to receive(:upload_asset).with(anything, "bar.foo", {:name=>"bar.foo", :content_type=>""})
+      expect(provider.api).to receive(:upload_asset).with(anything, "bar.txt", {:name=>"bar.txt", :content_type=>"text/plain"})
       expect(provider).to receive(:log).with("foo.bar already exists, skipping.")
 
       provider.push_app
@@ -120,7 +120,7 @@ describe DPL::Provider::Releases do
     example "When Release Doesn't Exist" do
       allow_message_expectations_on_nil
 
-      provider.options.update(:file => ["test/foo.bar", "bar.foo"])
+      provider.options.update(:file => ["test/foo.bar", "bar.txt"])
 
       allow(provider).to receive(:releases).and_return([""])
 
@@ -139,8 +139,8 @@ describe DPL::Provider::Releases do
       allow(provider.api.release.rels[:assets]).to receive(:get).and_return({:data => nil})
       allow(provider.api.release.rels[:assets].get).to receive(:data).and_return([])
 
-      expect(provider.api).to receive(:upload_asset).with(anything, "test/foo.bar", {:name=>"foo.bar", :content_type=>""})
-      expect(provider.api).to receive(:upload_asset).with(anything, "bar.foo", {:name=>"bar.foo", :content_type=>""})
+      expect(provider.api).to receive(:upload_asset).with(anything, "test/foo.bar", {:name=>"foo.bar", :content_type=>"application/octet-stream"})
+      expect(provider.api).to receive(:upload_asset).with(anything, "bar.txt", {:name=>"bar.txt", :content_type=>"text/plain"})
 
       provider.push_app
     end
@@ -148,7 +148,7 @@ describe DPL::Provider::Releases do
     example "With Release Number" do
       allow_message_expectations_on_nil
 
-      provider.options.update(:file => ["bar.foo"])
+      provider.options.update(:file => ["bar.txt"])
       provider.options.update(:release_number => "1234")
 
       allow(provider).to receive(:slug).and_return("foo/bar")
@@ -158,7 +158,7 @@ describe DPL::Provider::Releases do
       allow(provider.api.release.rels[:assets]).to receive(:get).and_return({:data => nil})
       allow(provider.api.release.rels[:assets].get).to receive(:data).and_return([])
 
-      expect(provider.api).to receive(:upload_asset).with("https://api.github.com/repos/foo/bar/releases/1234", "bar.foo", {:name=>"bar.foo", :content_type=>""})
+      expect(provider.api).to receive(:upload_asset).with("https://api.github.com/repos/foo/bar/releases/1234", "bar.txt", {:name=>"bar.txt", :content_type=>"text/plain"})
 
       provider.push_app
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dpl
 version: !ruby/object:Gem::Version
-  version: 1.6.5.travis.470.1
+  version: 1.6.5.travis.477.1
 platform: ruby
 authors:
 - Konstantin Haase
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-18 00:00:00.000000000 Z
+date: 2014-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec