dpickett-ramazon_advertising 0.3.0 → 0.3.1

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.3.1

data/features/searching_for_products.feature

@@ -22,7 +22,6 @@ Feature: Search for products
     When I perform the product search
     Then I should get a list of products
     And the list of products should have more than 1 product
-    And each product should have the "product_group" "Video Games"
 
   Scenario: Finding multiple browse nodes
     Given I am searching with the "search_index" of "VideoGames"
@@ -32,3 +31,17 @@ Feature: Search for products
     Then I should get a list of products
     And the list of products should have more than 1 product
     And each product should have the "product_group" "Video Games"
+
+  Scenario: Finding All Offers optimization
+    Given I am searching with the "search_index" of "VideoGames"
+    And I am searching with the "response_group" of "Medium,OfferListings"
+    And I am searching with the "merchant_id" of "All"
+    And I am searching with the "condition" of "All"
+    And I am searching with the "offer_page" of "1"
+    And I am searching with the "browse_node" of "11075221"
+    When I perform the product search
+    Then I should get a list of products
+    And each product should have "offer_pages"
+    And each product should have "has_first_page_of_full_offers"
+
+

data/features/step_definitions/product_steps.rb

@@ -66,3 +66,10 @@ Then /^the product should have a category tree for "([^\"]*)"$/ do |category_nam
   @product.category_tree[category_name].should_not be_nil
 end
 
+
+Then /^each product should have (a\s)?"([^\"]*)"$/ do |a, attr|
+  @products.each do |p|
+    p.send(attr).should_not be_nil
+  end
+end
+

data/lib/ramazon/product.rb

@@ -82,6 +82,7 @@ module Ramazon
     element :release_date, Date, :tag => 'ItemAttributes/ReleaseDate'
     element :original_release_date, Date, :tag => 'ItemAttributes/OriginalReleaseDate'
 
+    attr_accessor :has_first_page_of_full_offers
 
     # Creates the worker that performs the delta indexing
     # @param options Amazon request options (you can use an underscore convention) 
@@ -97,10 +98,17 @@ module Ramazon
         options[:search_index] ||= "Blended"
         options[:item_page] ||= 1
         res = Ramazon::Request.new(options).submit
-        Ramazon::ProductCollection.create_from_results(options[:item_page] || 1, 10, res)
+        products = Ramazon::ProductCollection.create_from_results(options[:item_page] || 1, 10, res)
+        if find_options_retrieve_all_offers?(options)
+          products.each do |p|
+            p.has_first_page_of_full_offers = true
+            p.offer_pages = offer_pages_for(p)
+          end
+        end
+        products
       end
     end
-
+ 
     # Performs an item lookup
     # @param item_id the ASIN or UPC you're looking for
     # @options additional Amazon request options (i.e. :response_group)
@@ -174,7 +182,6 @@ module Ramazon
       @offer_hash = {}
       offer_page = 1
       
-      
       offers = offer_page(offer_page)
       while offer_page <= offer_pages
         offers.each do |o|
@@ -191,7 +198,7 @@ module Ramazon
     end
 
     # gets the number of offer pages for the specified product
-    # @pram product the Ramazon::Product we want to get offer pages for
+    # @param [Ramazon::Product] product the we want to get offer pages for
     # @returns [Integer] number of offer pages
     def self.offer_pages_for(product)
       if !@offer_pages 
@@ -236,18 +243,22 @@ module Ramazon
     # @return [Array] Array of Offers returned from the page
     def offer_page(page = 1)
       #get all offers
-      products = self.class.find(:item_id => self.asin, 
-        :response_group => "OfferListings",
-        :merchant_id => "All",
-        :condition => "All",
-        :offer_page => page)
-
-      if products
-        product = products[0] 
-        self.offer_pages = self.class.offer_pages_for(product)
-        product.offers
+      if page == 1 && has_first_page_of_full_offers
+        self.offers 
       else
-        []
+        products = self.class.find(:item_id => self.asin, 
+          :response_group => "OfferListings",
+          :merchant_id => "All",
+          :condition => "All",
+          :offer_page => page)
+
+        if products
+          product = products[0] 
+          self.offer_pages = self.class.offer_pages_for(product)
+          product.offers
+        else
+          []
+        end
       end
     end
 
@@ -275,5 +286,18 @@ module Ramazon
         n.ancestors("//BrowseNodes/BrowseNode")
       end
     end
+
+    def self.find_options_retrieve_all_offers?(options = {})
+      if options[:response_group].is_a?(Array)
+        groups = options[:response_group].join(" ")
+      else
+        groups = options[:response_group] || ""
+      end
+
+      groups =~ /OfferListings/ && 
+        (options[:offer_page].nil? || options[:offer_page].to_i == 1) &&
+        (options[:merchant_id] == "All") &&
+        (options[:condition] == "All")
+    end
   end
 end

data/ramazon_advertising.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ramazon_advertising}
-  s.version = "0.3.0"
+  s.version = "0.3.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Dan Pickett"]
-  s.date = %q{2009-09-14}
+  s.date = %q{2009-09-15}
   s.description = %q{TODO: longer description of your gem}
   s.email = %q{dpickett@enlightsolutions.com}
   s.extra_rdoc_files = [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: dpickett-ramazon_advertising
 version: !ruby/object:Gem::Version 
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors: 
 - Dan Pickett
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-14 00:00:00 -07:00
+date: 2009-09-15 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency