down 2.3.7 → 2.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a627a73d7e6160d9dba196fbfc3abbcebcff7487
-  data.tar.gz: 9bc58d0030ef83a3c0eaa3d05c560d912917f15f
+  metadata.gz: eb93603bdd669c579229eed4924173323351f338
+  data.tar.gz: 985886e895e1c71328d812df17990c944efe8cb1
 SHA512:
-  metadata.gz: 42d20a8bd55512edab25ac2c7679503069c26f248adef49c9d50b1da0f23a15e14f6d0a182bd88dea121bd7e2f3191699aa3a13619639be13a7b08ed7bcf450c
-  data.tar.gz: 834d4189e69863ffa826ec82ba3eb721811570548f8251737667eee386b196a53c7d9eaf5a0bd47ae0da7aaf869e60d51b2124443dbb40f19e901a28eb93f877
+  metadata.gz: 03935d502e94f8a8b681996aa364f13cdee50c84cdc2b9655df2146d31a263bb2319280e9636cef90b8a70f59f5d80004e5ed0620af5085c72e9ed435391b430
+  data.tar.gz: bcb236b7447b47674c2adcf72047ca37f904f2507ba27e297db60c3869e7728d36b79b0be5f63132c5e9f5227f20fdabfe00bed95fa65e4681501e94df87c8a5

data/down.gemspec

@@ -16,5 +16,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "minitest", "~> 5.8"
   spec.add_development_dependency "webmock"
+  spec.add_development_dependency "addressable", "< 2.5"
   spec.add_development_dependency "mocha"
 end

data/lib/down.rb

@@ -116,11 +116,30 @@ module Down
 
     response = request.resume
 
-    ChunkedIO.new(
-      chunks: response.enum_for(:read_body),
-      size: response["Content-Length"] && response["Content-Length"].to_i,
-      on_close: -> { request.resume },
-    )
+    if response.chunked?
+      # Net::HTTP's implementation of reading "Transfer-Encoding: chunked"
+      # raises a Fiber error, so we work around it by downloading the whole
+      # response body without Enumerators (which internally use Fibers).
+      warn "Response from #{url} returned as \"Transfer-Encoding: chunked\", which Down cannot partially download, so the whole response body will be downloaded instead."
+
+      tempfile = Tempfile.new("down", binmode: true)
+      response.read_body { |chunk| tempfile << chunk }
+      tempfile.rewind
+
+      request.resume # close HTTP connection
+
+      ChunkedIO.new(
+        chunks: Enumerator.new { |y| y << tempfile.read(16*1024) until tempfile.eof? },
+        size: tempfile.size,
+        on_close: -> { tempfile.close! },
+      )
+    else
+      ChunkedIO.new(
+        chunks: response.enum_for(:read_body),
+        size: response["Content-Length"] && response["Content-Length"].to_i,
+        on_close: -> { request.resume }, # close HTTP connnection
+      )
+    end
   end
 
   def copy_to_tempfile(basename, io)

data/lib/down/version.rb

@@ -1,3 +1,3 @@
 module Down
-  VERSION = "2.3.7"
+  VERSION = "2.3.8"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: down
 version: !ruby/object:Gem::Version
-  version: 2.3.7
+  version: 2.3.8
 platform: ruby
 authors:
 - Janko Marohnić
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-06 00:00:00.000000000 Z
+date: 2016-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement