double_entry 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bee621c780c82e734a95964749650675683f1460
-  data.tar.gz: 326d9d02768905beede8b785215b1eb164a4c8cc
+  metadata.gz: 5979a152f5320a2cb5fc2838a966925abe66fbd6
+  data.tar.gz: b9486092cdaf973950bd38c27b64379064c34000
 SHA512:
-  metadata.gz: e98f6f1a3b11a5bd9f8b4e384eb3dff8a6cd56b40ae3f8b430565fdbc601e3532a6cc95f8fdacc469457425533745d99a7b6cc8accaf4a6dd67b0d2b27ed41b0
-  data.tar.gz: 945ba3173e2b170e1cee74fcb89e31f8ce4a2245fa75dbe6efa267850196c7470495ffd3b4f47bae23acef6aa89722e7ca0379a53ff927ca7f8e49d9727fdb48
+  metadata.gz: c3a79f8cffcb4925ed6146360477d5c97d8c49464ac7b550daf452bc3d4d10aac8c6221c3f2f2fa913181e72851fa16e3735c9adeb1137088ce6e2b50419a9a4
+  data.tar.gz: 11e7067886e3b813235f1cdae8affbfb7215fea67cc36e4bbec42f6e1bd900baf960ca4dc8ca4dec3e63542c366b3e31587489f5c9e4c24b07f61d3463d0c2e7

data/.travis.yml

@@ -1,7 +1,8 @@
 language: ruby
 rvm:
-  - 2.1.5
   - 1.9.3
+  - 2.0.0
+  - 2.1.5
 env:
   - DB=mysql
   - DB=postgres
@@ -16,3 +17,4 @@ script:
 gemfile:
   - spec/support/gemfiles/Gemfile.rails-3.2.x
   - spec/support/gemfiles/Gemfile.rails-4.1.x
+  - spec/support/gemfiles/Gemfile.rails-4.2.x

data/README.md

@@ -26,6 +26,7 @@ Ruby
 Rails
  * 3.2.x
  * 4.1.x
+ * 4.2.x
 
 Databases
  * MySQL

data/lib/double_entry/account.rb

@@ -80,7 +80,7 @@ module DoubleEntry
 
     class Instance
       attr_reader :account, :scope
-      delegate :identifier, :scope_identifier, :scoped?, :positive_only, :currency, :to => :account
+      delegate :identifier, :scope_identifier, :scoped?, :positive_only, :negative_only, :currency, :to => :account
 
       def initialize(args)
         @account = args[:account]
@@ -147,12 +147,13 @@ module DoubleEntry
       end
     end
 
-    attr_reader :identifier, :scope_identifier, :positive_only, :currency
+    attr_reader :identifier, :scope_identifier, :positive_only, :negative_only, :currency
 
     def initialize(args)
       @identifier = args[:identifier]
       @scope_identifier = args[:scope_identifier]
       @positive_only = args[:positive_only]
+      @negative_only = args[:negative_only]
       @currency = args[:currency] || Money.default_currency
       if identifier.length > Account.account_identifier_max_length
         raise AccountIdentifierTooLongError.new(

data/lib/double_entry/errors.rb

@@ -9,6 +9,7 @@ module DoubleEntry
   class DuplicateAccount < RuntimeError; end
   class DuplicateTransfer < RuntimeError; end
   class AccountWouldBeSentNegative < RuntimeError; end
+  class AccountWouldBeSentPositiveError < RuntimeError; end
   class MismatchedCurrencies < RuntimeError; end
   class MissingAccountError < RuntimeError; end;
   class AccountScopeMismatchError < RuntimeError; end;

data/lib/double_entry/line.rb

@@ -76,12 +76,12 @@ module DoubleEntry
     end
 
     def save(*)
-      check_balance_will_not_be_sent_negative
+      check_balance_will_remain_valid
       super
     end
 
     def save!(*)
-      check_balance_will_not_be_sent_negative
+      check_balance_will_remain_valid
       super
     end
 
@@ -151,10 +151,13 @@ module DoubleEntry
 
     private
 
-    def check_balance_will_not_be_sent_negative
-      if self.account.positive_only and self.balance < Money.new(0)
+    def check_balance_will_remain_valid
+      if account.positive_only && balance < Money.zero
         raise AccountWouldBeSentNegative.new(account)
       end
+      if account.negative_only && balance > Money.zero
+        raise AccountWouldBeSentPositiveError.new(account)
+      end
     end
   end
 

data/lib/double_entry/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module DoubleEntry
-  VERSION = "0.9.0"
+  VERSION = "0.10.0"
 end

data/lib/generators/double_entry/install/templates/migration.rb

@@ -5,7 +5,7 @@ class CreateDoubleEntryTables < ActiveRecord::Migration
       t.string     "account", :limit => 31, :null => false
       t.string     "scope",   :limit => 23
       t.integer    "balance",               :null => false
-      t.timestamps
+      t.timestamps                          :null => false
     end
 
     add_index "double_entry_account_balances", ["account"],          :name => "index_account_balances_on_account"
@@ -22,7 +22,7 @@ class CreateDoubleEntryTables < ActiveRecord::Migration
       t.string     "partner_scope",   :limit => 23
       t.integer    "detail_id"
       t.string     "detail_type"
-      t.timestamps
+      t.timestamps                                  :null => false
     end
 
     add_index "double_entry_lines", ["account", "code", "created_at"],  :name => "lines_account_code_created_at_idx"
@@ -43,7 +43,7 @@ class CreateDoubleEntryTables < ActiveRecord::Migration
       t.integer    "amount",                   :null => false
       t.string     "filter"
       t.string     "range_type", :limit => 15, :null => false
-      t.timestamps
+      t.timestamps                             :null => false
     end
 
     add_index "double_entry_line_aggregates", ["function", "account", "code", "year", "month", "week", "day"], :name => "line_aggregate_idx"
@@ -52,7 +52,7 @@ class CreateDoubleEntryTables < ActiveRecord::Migration
       t.integer    "last_line_id", :null => false
       t.boolean    "errors_found", :null => false
       t.text       "log"
-      t.timestamps
+      t.timestamps                             :null => false
     end
 
   end

data/spec/double_entry/line_spec.rb

@@ -55,22 +55,25 @@ describe DoubleEntry::Line do
     end
 
     context 'when balance is sent negative' do
-      let(:account) {
-        DoubleEntry.account(:savings, :scope => '17', :positive_only => true)
-      }
+      before { DoubleEntry::Account.accounts.define(:identifier => :a_positive_only_acc, :positive_only => true) }
+      let(:account) { DoubleEntry.account(:a_positive_only_acc) }
+      let(:line) { DoubleEntry::Line.new(:balance => Money.new(-1), :account => account) }
 
-      let(:line) {
-        DoubleEntry::Line.new(
-          :balance => Money.new(-1),
-          :account => account,
-        )
-      }
-
-      it 'raises AccountWouldBeSentNegative exception' do
+      it 'raises AccountWouldBeSentNegative error' do
         expect { line.save }.to raise_error DoubleEntry::AccountWouldBeSentNegative
       end
     end
 
+    context 'when balance is sent positive' do
+      before { DoubleEntry::Account.accounts.define(:identifier => :a_negative_only_acc, :negative_only => true) }
+      let(:account) { DoubleEntry.account(:a_negative_only_acc) }
+      let(:line) { DoubleEntry::Line.new(:balance => Money.new(1), :account => account) }
+
+      it 'raises AccountWouldBeSentPositiveError' do
+        expect { line.save }.to raise_error DoubleEntry::AccountWouldBeSentPositiveError
+      end
+    end
+
     it "has a table name prefixed with double_entry_" do
       expect(DoubleEntry::Line.table_name).to eq "double_entry_lines"
     end

data/spec/support/gemfiles/Gemfile.rails-4.2.x

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gemspec :path => '../../../'
+
+gem 'rails', '~> 4.2.0'

data/spec/support/schema.rb

@@ -5,7 +5,7 @@ ActiveRecord::Schema.define do
     t.string     "account", :limit => 31, :null => false
     t.string     "scope",   :limit => 23
     t.integer    "balance",               :null => false
-    t.timestamps
+    t.timestamps                          :null => false
   end
 
   add_index "double_entry_account_balances", ["account"],          :name => "index_account_balances_on_account"
@@ -22,7 +22,7 @@ ActiveRecord::Schema.define do
     t.string     "partner_scope",   :limit => 23
     t.integer    "detail_id"
     t.string     "detail_type"
-    t.timestamps
+    t.timestamps                                  :null => false
   end
 
   add_index "double_entry_lines", ["account", "code", "created_at"],  :name => "lines_account_code_created_at_idx"
@@ -43,7 +43,7 @@ ActiveRecord::Schema.define do
     t.integer    "amount",                   :null => false
     t.string     "filter"
     t.string     "range_type", :limit => 15, :null => false
-    t.timestamps
+    t.timestamps                             :null => false
   end
 
   add_index "double_entry_line_aggregates", ["function", "account", "code", "year", "month", "week", "day"], :name => "line_aggregate_idx"
@@ -52,13 +52,13 @@ ActiveRecord::Schema.define do
     t.integer    "last_line_id", :null => false
     t.boolean    "errors_found", :null => false
     t.text       "log"
-    t.timestamps
+    t.timestamps                 :null => false
   end
 
   # test table only
   create_table "users", :force => true do |t|
     t.string     "username", :null => false
-    t.timestamps
+    t.timestamps             :null => false
   end
 
   add_index "users", ["username"], :name => "index_users_on_username", :unique => true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: double_entry
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - Anthony Sellitti
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-08 00:00:00.000000000 Z
+date: 2015-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money
@@ -293,6 +293,7 @@ files:
 - spec/support/double_entry_spec_helper.rb
 - spec/support/gemfiles/Gemfile.rails-3.2.x
 - spec/support/gemfiles/Gemfile.rails-4.1.x
+- spec/support/gemfiles/Gemfile.rails-4.2.x
 - spec/support/reporting_configuration.rb
 - spec/support/schema.rb
 homepage: https://github.com/envato/double_entry
@@ -346,5 +347,6 @@ test_files:
 - spec/support/double_entry_spec_helper.rb
 - spec/support/gemfiles/Gemfile.rails-3.2.x
 - spec/support/gemfiles/Gemfile.rails-4.1.x
+- spec/support/gemfiles/Gemfile.rails-4.2.x
 - spec/support/reporting_configuration.rb
 - spec/support/schema.rb