double_agent 0.2.1 → 0.2.2

data/CHANGELOG

@@ -1,3 +1,11 @@
+== Release 0.2.2 (November 1, 2011)  ==
+
+* Detect Firefox on Android (Fennec)
+
+* Bugfix to Parser#version, which could blow up in some cases
+
+* Change Rspec to RSpec (Rspec is being deprecated)
+
 == Release 0.2.1 (September 15, 2011)
 
 * Syntax fixes to YAML data so it loads with Psych (basically Rails 3.1 support)

data/data/browsers.yml

@@ -20,6 +20,18 @@
   :version: (?<=chromium/)[0-9]+
   :safe_version: ["chromium/[0-9]+", "[0-9]+"]
 
+- :name: Opera %s
+  :sym: :opera
+  :regex: opera
+  :version: ((?<=version/)[0-9]+)|((?<=opera )[0-9]+)
+  :safe_version: ["(version/[0-9]+)|(opera [0-9]+)", "[0-9]+"]
+
+- :name: Firefox %s
+  :sym: :firefox
+  :regex: firefox
+  :version: (?<=firefox/)[0-9]+
+  :safe_version: ["firefox/[0-9]+", "[0-9]+"]
+
 - :name: Android %s
   :sym: :android
   :family_sym: :chromium
@@ -43,22 +55,10 @@
   :version: (?<=version/)[0-9]+
   :safe_version: ["version/[0-9]+", "[0-9]+"]
 
-- :name: Opera %s
-  :sym: :opera
-  :regex: opera
-  :version: ((?<=version/)[0-9]+)|((?<=opera )[0-9]+)
-  :safe_version: ["(version/[0-9]+)|(opera [0-9]+)", "[0-9]+"]
-
 - :name: Konqueror
   :sym: :konqueror
   :regex: konqueror
 
-- :name: Firefox %s
-  :sym: :firefox
-  :regex: firefox
-  :version: (?<=firefox/)[0-9]+
-  :safe_version: ["firefox/[0-9]+", "[0-9]+"]
-
 - :name: Unknown
   :sym: :unknown
   :regex: .*

data/lib/double_agent/parser.rb

@@ -61,7 +61,7 @@ module DoubleAgent
     # nil if nothing is found.
     def version(ua)
       if @safe_version
-        ua.slice(@safe_version[0]).slice(@safe_version[1])
+        ua.slice(@safe_version[0]).slice(@safe_version[1]) rescue nil
       else
         ua.slice(@version)
       end

data/spec/data_spec.rb

@@ -70,6 +70,11 @@ describe DoubleAgent do
     "#{DA.browser ua} on #{DA.os ua}".should == 'Firefox 4 on GNU/Linux'
   end
 
+  it 'should be Firefox 7 on Android' do
+    ua = "Mozilla/5.0 (Android; Linux armv7l; rv:7.0.1) Gecko/20110928 Firefox/7.0.1 Fennec/7.0.1"
+    "#{DA.browser ua} on #{DA.os ua}".should == 'Firefox 7 on Android'
+  end
+
   # Epiphany
   it 'should be Epiphany on GNU/Linux' do
     ua = "Mozilla/5.0 (X11; U; Linux x86_64; fr-FR) AppleWebKit/534.7 (KHTML, like Gecko) Epiphany/2.30.6 Safari/534.7"

data/spec/spec_helper.rb

@@ -4,7 +4,7 @@ require File.dirname(__FILE__) + '/../lib/double_agent/resources'
 require File.dirname(__FILE__) + '/../lib/double_agent/stats'
 require File.dirname(__FILE__) + '/../lib/double_agent/logs'
 
-Rspec.configure do |c|
+RSpec.configure do |c|
   c.mock_with :rspec
 end
 

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Jordan Hollinger
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-15 00:00:00 -04:00
+date: 2011-11-01 00:00:00 -04:00
 default_executable: 
 dependencies: []