double_agent 0.1.1 → 0.1.2

data/CHANGELOG

@@ -1,3 +1,7 @@
+== Release 0.1.2 (June 30, 2011)
+
+* Bugfix to #browser_sum and #os_sym returning nil on an empty or nil user agent. Should return :unkown.
+
 == Release 0.1.1 (May 10, 2011)
 
 * #log_entries takes :match and :ignore regexp options

data/data/browsers.yml

@@ -61,5 +61,5 @@
 
 - :name: Unknown
   :sym: :unknown
-  :regex: .+
-  :version: .+
+  :regex: .*
+  :version: .*

data/data/oses.yml

@@ -69,4 +69,4 @@
 
 - :name: Unknown
   :sym: :unknown
-  :regex: .+
+  :regex: .*

data/lib/double_agent/core.rb

@@ -161,7 +161,7 @@ module DoubleAgent
   # Parses and evals BROWSER_DATA into a case statement inside of the browser_sym method.
   def self.load_browsers!
     BROWSERS.clear
-    str = "case user_agent\n"
+    str = "case user_agent.to_s\n"
     BROWSER_DATA.each do |data|
       BROWSERS[data[:sym]] = BrowserParser.new(data)
       str << "  when %r{#{data[:regex]}}i then :#{data[:sym]}\n"
@@ -174,7 +174,7 @@ module DoubleAgent
   # Parses and evals OS_DATA into a case statement inside of the os_sym method.
   def self.load_oses!
     OSES.clear
-    str = "case user_agent\n"
+    str = "case user_agent.to_s\n"
     OS_DATA.each do |data|
       OSES[data[:sym]] = OSParser.new(data)
       str << "  when %r{#{data[:regex]}}i then :#{data[:sym]}\n"

data/spec/core_spec.rb

@@ -21,6 +21,12 @@ describe DoubleAgent do
     it 'returns :unknown for browser_sym' do
       DoubleAgent.browser_sym('froofroo').should == :unknown
     end
+    it 'returns :unknown for an empty browser_sym' do
+      DoubleAgent.browser_sym('').should == :unknown
+    end
+    it 'returns :unknown for a nil browser_sym' do
+      DoubleAgent.browser_sym(nil).should == :unknown
+    end
 
     #browser_family
     it 'returns Firefox for browser family' do
@@ -31,16 +37,34 @@ describe DoubleAgent do
     it 'returns :firefox for browser_family_sym' do
       DoubleAgent.browser_family_sym(@ua_string).should == :firefox
     end
+    it 'returns :unknown for an empty browser_family_sym' do
+      DoubleAgent.browser_family_sym('').should == :unknown
+    end
+    it 'returns :unknown for a nil browser_family_sym' do
+      DoubleAgent.browser_family_sym(nil).should == :unknown
+    end
 
     #browser_icon
     it 'returns :firefox for browser_sym' do
       DoubleAgent.browser_icon(@ua_string).should == :firefox
     end
+    it 'returns :unkown for an empty browser_sym' do
+      DoubleAgent.browser_icon('').should == :unknown
+    end
+    it 'returns :unkown for a nil browser_sym' do
+      DoubleAgent.browser_icon(nil).should == :unknown
+    end
 
     #browser_family_icon
     it 'returns :firefox for browser_family_sym' do
       DoubleAgent.browser_family_icon(@ua_string).should == :firefox
     end
+    it 'returns :unkown for an empty browser_family_sym' do
+      DoubleAgent.browser_family_icon('').should == :unknown
+    end
+    it 'returns :unkown for a nil browser_family_sym' do
+      DoubleAgent.browser_family_icon(nil).should == :unknown
+    end
 
     #os
     it 'returns Ubuntua for OS' do
@@ -49,6 +73,9 @@ describe DoubleAgent do
     it 'returns Unknowna for OS' do
       DoubleAgent.os('froofroo').should == 'Unknown'
     end
+    it 'returns Unknowna for OS' do
+      DoubleAgent.os('').should == 'Unknown'
+    end
 
     #os_sym
     it 'returns :ubuntu for os_sym' do
@@ -57,6 +84,12 @@ describe DoubleAgent do
     it 'returns :unknown for os_sym' do
       DoubleAgent.os_sym('froofroo').should == :unknown
     end
+    it 'returns :unknown for an empty os_sym' do
+      DoubleAgent.os_sym('').should == :unknown
+    end
+    it 'returns :unknown for a nil os_sym' do
+      DoubleAgent.os_sym(nil).should == :unknown
+    end
 
     #os_family
     it 'returns GNU/Linux OS family' do

metadata

@@ -1,8 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: double_agent
 version: !ruby/object:Gem::Version 
-  prerelease: 
-  version: 0.1.1
+  prerelease: false
+  segments: 
+  - 0
+  - 1
+  - 2
+  version: 0.1.2
 platform: ruby
 authors: 
 - Jordan Hollinger
@@ -10,7 +14,8 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-10 00:00:00 Z
+date: 2011-06-30 00:00:00 -04:00
+default_executable: 
 dependencies: []
 
 description: Browser User Agent string parser with resource, stats, and a log reader
@@ -23,24 +28,25 @@ extra_rdoc_files:
 - README.rdoc
 - CHANGELOG
 files: 
+- lib/double_agent.rb
 - lib/double_agent/all.rb
+- lib/double_agent/logs.rb
 - lib/double_agent/core.rb
 - lib/double_agent/resources.rb
-- lib/double_agent/logs.rb
 - lib/double_agent/stats.rb
-- lib/double_agent.rb
-- data/oses.yml
 - data/browsers.yml
-- spec/resources_spec.rb
-- spec/core_spec.rb
+- data/oses.yml
 - spec/spec_helper.rb
-- spec/parser_spec.rb
-- spec/data/httpd.access.log
+- spec/core_spec.rb
 - spec/data/httpd.access.log.1.gz
+- spec/data/httpd.access.log
 - spec/stats_spec.rb
+- spec/resources_spec.rb
+- spec/parser_spec.rb
 - README.rdoc
 - LICENSE
 - CHANGELOG
+has_rdoc: true
 homepage: http://github.com/jhollinger/double_agent
 licenses: []
 
@@ -54,17 +60,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.7.2
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Browser User Agent string parser