doubapi 0.0.4 → 0.0.5

data/lib/doubapi/version.rb

@@ -1,3 +1,3 @@
 module Doubapi
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/doubapi.rb

@@ -39,6 +39,9 @@ def self.search_ablum artist_chinese ,max=10
 end
 
 Douban_Event =  Struct.new :title, :when, :where, :what, :link
+
+#
+#release_date is in the format of YY-MM-DD
 Douban_Album =  Struct.new :author, :title, :release_date,  :link
 
 
@@ -66,13 +69,17 @@ def self.compare_date a , b
 	return true if (ya.to_i * 12 + ma.to_i ) >= (yb.to_i*12+mb.to_i)
 end
 
-def self.search_album_of artist , after_date = "1900.01"
+def self.search_albums_of artist , after_date = "1900.01"
 	doc = search_ablum artist
 	albums=[]
 
 	doc.xpath("//entry").each do |entry|
 		title = entry.at_xpath(".//title").text
-		author = entry.at_xpath(".//name").text
+		author = unless entry.at_xpath(".//name").nil?
+				 entry.at_xpath(".//name").text
+			     else
+				 "unknown(#{artist}?)"
+				 end
 		release_date = unless entry.at_xpath(".//attribute[@name='pubdate']").nil?
 							entry.at_xpath(".//attribute[@name='pubdate']").text
 					   else
@@ -80,10 +87,16 @@ def self.search_album_of artist , after_date = "1900.01"
 							"0000-00"
 					   end
     	link =  entry.at_xpath(".//link[@rel='alternate']")["href"]
-    	
+    
+		#make release data YY-MM-DD style
+		r = release_date.scan(/\d{1,4}/)
+		#if DD was not specified
+		r << "01"         if r.size == 2
+		r << "01" << "01" if r.size == 1 
+		formated_release_day = "#{r[0]}-#{r[1]}-#{r[2]}" 
 		#check the release date
 		if compare_date release_date, after_date			
-			albums << Douban_Album.new(author, title, release_date, link)
+			albums << Douban_Album.new(author, title, formated_release_day, link)
 		end
 	end
 	albums

data/spec/doubapi_spec.rb

@@ -14,7 +14,7 @@ describe Doubapi do
 
 	it "should be able to search albums of 李志 " do 
 		author = "李志"
-		Doubapi.search_album_of(author).each do |album|
+		Doubapi.search_albums_of(author).each do |album|
 			puts album.author	
 			puts album.release_date	
 			puts album.title	
@@ -24,12 +24,26 @@ describe Doubapi do
 
 	it "should be able to search albums of 李志 that released after 2010 " do 
 		author = "李志"
-		Doubapi.search_album_of(author, "2010/05").each do |album|
+		Doubapi.search_albums_of(author, "2010-05").each do |album|
+			puts album.author	
+			puts album.release_date	
+			puts album.title	
+			puts album.link	
+
+		   album.release_date.should >= "2010-05"
+		end
+	end
+
+
+	it "should be handle the search results that have no author node" do 
+		author = "何勇"
+		Doubapi.search_albums_of(author, "2010/01").each do |album|
 			puts album.author	
 			puts album.release_date	
 			puts album.title	
 			puts album.link	
 		end
+
 	end
 
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: doubapi
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 0
-  - 4
-  version: 0.0.4
+  - 5
+  version: 0.0.5
 platform: ruby
 authors: 
 - pierr chen