dorsale 3.7.7 → 3.7.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76b8dc71431e1a245a94bd289e89624b8125827b
-  data.tar.gz: 5c1c72b5535774ed5dffc5ae8b582bab5f554283
+  metadata.gz: ecb41bb191b0f0774874ccda3e131cb20eea812c
+  data.tar.gz: c6dd41119b5126fbff10a4cd72224139cc15dde3
 SHA512:
-  metadata.gz: 4d83ab74ba603fd01a7352ec1027a8882b52b42bbbadf85ad41395d95fe6dfb018d80b2d61550b8b7b992806ac3522019e179fae1444c5ed8a8c3886f62c5c94
-  data.tar.gz: 6dbfc36f1024d85150d9d3998f93537c8758ec6c8100036b4251fcc0af1733492ea849d123bbdbb46dc2ecb3312a3fa4a1030dccf1e4d60ee37f638ca4dac50e
+  metadata.gz: 3a5363b33345add30d2dc9e89aed9e4570b92b807f663da687cd3333f35436ad0a66cab48f6f6adbf86aed106192503ee941c710708c89b32c3bfbfc72ab743d
+  data.tar.gz: c78f2865a7de1834dd91396a0246c7c6c168564abe73ccce52dff0917c0141652b02f1269745d29719782f5149f546bd5dec0a0fd370bff180794da9dd085337

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Next version
 
+## 3.7.8
+
+- Person build address improvement
+
 ## 3.7.7
 
 - Change redirect after create task comment

data/app/models/dorsale/customer_vault/person.rb

@@ -36,7 +36,8 @@ class Dorsale::CustomerVault::Person < ::Dorsale::ApplicationRecord
     order("LOWER(COALESCE(corporation_name, '') || COALESCE(last_name, '') || COALESCE(first_name, '')) ASC")
   }
 
-  after_initialize :build_address, unless: :address
+  after_initialize  :build_address, if: proc { new_record? && address.nil? }
+  before_validation :build_address, if: proc { address.nil? }
 
   def person_type
     self.class.to_s.demodulize.downcase.to_sym

data/lib/dorsale/version.rb

@@ -1,3 +1,3 @@
 module Dorsale
-  VERSION = "3.7.7"
+  VERSION = "3.7.8"
 end

data/spec/models/dorsale/customer_vault/person_spec.rb

@@ -37,9 +37,28 @@ RSpec.describe ::Dorsale::CustomerVault::Person, type: :model do
   end
 
   describe "address" do
-    it "should auto create address" do
+    let(:person_without_address) {
       corporation = Dorsale::CustomerVault::Corporation.create!(name: "agilidée")
-      expect(corporation.address).to_not be nil
+      corporation.address.destroy
+      corporation
+    }
+
+    it "should auto create address on build" do
+      corporation = Dorsale::CustomerVault::Corporation.new
+      expect(corporation.address).to be_present
+    end
+
+    it "should NOT auto create address on find" do
+      corporation = Dorsale::CustomerVault::Corporation.find(person_without_address.id)
+      expect(corporation.address).to be_nil
+    end
+
+    it "should auto create address before validation" do
+      corporation = Dorsale::CustomerVault::Corporation.find(person_without_address.id)
+      expect(corporation.address).to be_nil
+
+      corporation.save!
+      expect(corporation.address).to be_present
     end
   end # describe "address"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dorsale
 version: !ruby/object:Gem::Version
-  version: 3.7.7
+  version: 3.7.8
 platform: ruby
 authors:
 - agilidée
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-11 00:00:00.000000000 Z
+date: 2017-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails