dorsale 3.5.0 → 3.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 870af5f1c6e4514f3673393d9d6661f1e2102150
-  data.tar.gz: 20fdcbb567db8d19f31413f4e4e64864e6663eac
+  metadata.gz: b8fd76e9602e5d327405b05c83df5f45a94d0b02
+  data.tar.gz: 3b7282e1f9d793d5dc0f687603051f816791e488
 SHA512:
-  metadata.gz: 09af05b5ab27cc8d965a630c54fb8b266e12f16c09f2bafc855f6a0e88a531bb92e94d7f5d0ef11184772f8d172dd46b9550262ef4f3be1ce1065ffa1eb6ad64
-  data.tar.gz: eb03d2134bee5347d5959c3a7657af7460a93edd68c5d0f31eda8631e87d078fea0cb85e3f207d7b6eb21e1850d9326cdf34b91c445c838e367ba1303f337456
+  metadata.gz: 9fc09fc9312276e737bf174326c9abd95199105c81e76fa26e3ed65330d5c0c264e88624db0acf38eaed1b58f79db1917d7fe3bf9021fc14e5687957f1ef4a3e
+  data.tar.gz: cfcedff1fe60c18667cc417a525a8f2257a72dbe8dca2fc6cd8415c94a4285f7147563b3009b1b1538d59e34f1eee2c72c45905cc75b69d76be1ab2a04fafc8c

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 3.5.1
+
+- Add title and date to comments
+- Truncate comments
+- CustomerVault : individual belongs to corporation
+- CustomerVault : add/remove fields
+
 ## 3.5.0
 
 - Move helpers/i18n/... to agilibox gem

data/app/assets/javascripts/dorsale/common/comments.coffee

@@ -4,6 +4,7 @@ window.dorsaleComments =
     dorsaleComments.setupEditForm()
     dorsaleComments.setupEditButtons()
     dorsaleComments.setupDeleteButtons()
+    dorsaleComments.setupShowMoreLinks()
 
   setupCreateForm: ->
     $("#dorsale-comments").on "ajax:success", "form[id*=new]", (e, data) ->
@@ -24,6 +25,7 @@ window.dorsaleComments =
         url: url
         success: (data) ->
           container.replaceWith(data)
+          setupDatepickers()
 
       return false
 
@@ -32,5 +34,10 @@ window.dorsaleComments =
       $(this).parents(".comment").fadeOut ->
         $(this).remove()
 
+  setupShowMoreLinks: ->
+    $("#dorsale-comments").on "click", ".comment-show_more", ->
+      $(this).parents(".comment-text-truncated").remove()
+      return false
+
 $(document).on "turbolinks:load", ->
   dorsaleComments.setup()

data/app/assets/javascripts/dorsale/common/datepicker.coffee

@@ -1,7 +1,7 @@
 # Doc : http://bootstrap-datepicker.readthedocs.io/en/stable/index.html
 
-window.setupDatepickers = ->
-  $("input[type*=date], input[name*=date], input[name$=_at]").map ->
+window.setupDatepickers = (scope = document) ->
+  $(scope).find("input[type*=date], input[name*=date], input[name$=_at]").map ->
     return if this.type == "hidden"
 
     this.type = "text"

data/app/assets/stylesheets/dorsale/common/comments.sass

@@ -4,7 +4,7 @@
 .comment
   @extend .well
   box-shadow: none
-  padding: 0.5em 1em
+  padding: 0.5em
   margin: 0.75em 0
 
   .avatar
@@ -13,19 +13,47 @@
     height: 50px
     width: 50px
 
-  .infos
+  .comment-fields
+    margin-left: 65px
+
+    .comment-title-field
+      display: inline-block
+      width: calc(100% - 10rem - 0.5rem)
+      margin-right: 0.5rem
+
+    .comment-date-field
+      display: inline-block
+      width: 10rem
+
+      input
+        text-align: center
+
+    .comment-text-field
+      margin-top: 0.5rem
+
+    .comment-submit
+      text-align: right
+      margin-top: 0.5rem
+
+      input
+        min-width: 10rem
+
+  .comment-infos
     font-size: 80%
     @extend .text-muted
 
-  .commentable
+  .comment-commentable
     font-weight: bold
 
-  .actions
+  .comment-actions
     float: right
 
     a
       font-size: 80%
-      margin-left: 1.5em
+      margin-left: 1.5rem
+
+  p.comment-text
+    margin: 1rem 0 0 65px
 
-  p.text
-    margin: 1em 0 0 65px
+  p.comment-text-truncated + p.comment-text
+    display: none

data/app/controllers/dorsale/comments_controller.rb

@@ -84,17 +84,18 @@ class Dorsale::CommentsController < ::Dorsale::ApplicationController
   end
 
   def permitted_params_for_comment
+    safe_params = [
+      :title,
+      :date,
+      :text,
+    ]
+
     if params[:action] == "create"
-      [
-        :commentable_id,
-        :commentable_type,
-        :text,
-      ]
-    else
-      [
-        :text,
-      ]
+      safe_params << :commentable_id
+      safe_params << :commentable_type
     end
+
+    safe_params
   end
 
   def comment_params

data/app/controllers/dorsale/customer_vault/people_controller.rb

@@ -155,6 +155,7 @@ class Dorsale::CustomerVault::PeopleController < ::Dorsale::CustomerVault::Appli
       :facebook,
       :linkedin,
       :viadeo,
+      :context,
       :tag_list => [],
       :address_attributes => [
         :street,
@@ -170,19 +171,21 @@ class Dorsale::CustomerVault::PeopleController < ::Dorsale::CustomerVault::Appli
     common_permitted_params + [
       :corporation_name,
       :capital,
-      :immatriculation_number_1,
-      :immatriculation_number_2,
+      :immatriculation_number,
       :european_union_vat_number,
       :legal_form,
+      :revenue,
+      :societe_com,
+      :number_of_employees,
     ]
   end
 
   def permitted_params_for_individuals
     common_permitted_params + [
+      :corporation_id,
       :first_name,
       :last_name,
       :title,
-      :context,
     ]
   end
 

data/app/helpers/dorsale/comments_helper.rb

@@ -14,4 +14,8 @@ module Dorsale::CommentsHelper
       },
     )
   end
+
+  def truncate_comment_text?
+    controller_name == "people" && action_name == "activity"
+  end
 end

data/app/models/dorsale/comment.rb

@@ -5,10 +5,17 @@ class Dorsale::Comment < ::Dorsale::ApplicationRecord
   validates :author,      presence: true
   validates :commentable, presence: true
   validates :text,        presence: true
+  validates :date,        presence: true
 
   default_scope -> {
     all
-      .order(created_at: :desc)
+      .order(date: :desc, created_at: :desc)
       .preload(:author)
   }
+
+  private
+
+  def assign_default_values
+    assign_default :date, Time.zone.now.to_date
+  end
 end

data/app/models/dorsale/customer_vault/corporation.rb

@@ -3,6 +3,7 @@ class Dorsale::CustomerVault::Corporation < Dorsale::CustomerVault::Person
   def_delegators :data, *Dorsale::CustomerVault::CorporationData.methods_to_delegate
 
   validates :corporation_name, presence: true
+  has_many :individuals
 
   def name
     corporation_name
@@ -16,4 +17,9 @@ class Dorsale::CustomerVault::Corporation < Dorsale::CustomerVault::Person
   private def first_name=; raise NoMethodError; end
   private def last_name;   raise NoMethodError; end
   private def last_name=;  raise NoMethodError; end
+  private def corporation;   raise NoMethodError; end
+  private def corporation=;  raise NoMethodError; end
+  private def corporation_id;   raise NoMethodError; end
+  private def corporation_id=;  raise NoMethodError; end
+
 end

data/app/models/dorsale/customer_vault/corporation_data.rb

@@ -1,8 +1,10 @@
 class Dorsale::CustomerVault::CorporationData < Dorsale::CustomerVault::PersonData
   attribute :legal_form,                String
-  attribute :immatriculation_number_1,  String
-  attribute :immatriculation_number_2,  String
+  attribute :immatriculation_number,    String
+  attribute :naf,                       String
   attribute :european_union_vat_number, String
+  attribute :societe_com,               String
   attribute :capital,                   Integer
+  attribute :revenue,                   Integer
+  attribute :number_of_employees,       Integer
 end
-

data/app/models/dorsale/customer_vault/individual.rb

@@ -4,6 +4,7 @@ class Dorsale::CustomerVault::Individual < Dorsale::CustomerVault::Person
 
   validates :first_name, presence: true
   validates :last_name,  presence: true
+  belongs_to :corporation
 
   def name
     [self.last_name, self.first_name].join(", ")

data/app/models/dorsale/customer_vault/individual_data.rb

@@ -1,5 +1,3 @@
 class Dorsale::CustomerVault::IndividualData < Dorsale::CustomerVault::PersonData
-  attribute :title,   String
-  attribute :context, String
+  attribute :title, String
 end
-

data/app/views/dorsale/billing_machine/invoices/_filters.html.slim

@@ -2,6 +2,7 @@
   = f.input(:bm_customer_guid,
     :collection    => @people.map { |p| [p.to_s, p.guid] },
     :include_blank => t("filters.all_customers"),
+    :input_html    => {class: "select2"},
   )
 
   = f.input(:bm_time_period,

data/app/views/dorsale/billing_machine/invoices/_form.html.slim

@@ -24,7 +24,7 @@
         .well
           = f.input :date, html5: true
           hr
-          = f.input :customer_guid, collection: @people.map{ |e| [e.to_s, e.guid] }
+          = f.input :customer_guid, collection: @people.map{ |e| [e.to_s, e.guid] }, input_html: {class: "select2"}
 
     table#lines-table
       thead

data/app/views/dorsale/billing_machine/quotations/_filters.html.slim

@@ -2,6 +2,7 @@
   = f.input(:bm_customer_guid,
     :collection    => @people.map { |p| [p.to_s, p.guid] },
     :include_blank => t("filters.all_customers"),
+    :input_html    => {class: "select2"},
   )
 
   = f.input(:bm_time_period,

data/app/views/dorsale/comments/_comment.html.slim

@@ -4,30 +4,39 @@
   - else
     = image_tag "dorsale/avatar.png", class: "avatar"
 
-  p.actions
+  p.comment-actions
     - if policy(comment).update?
       = icon_link_to :pencil, t("actions.edit"), dorsale.edit_comment_path(comment), class: "edit"
 
     - if policy(comment).delete?
       = icon_link_to :trash, t("actions.delete"), dorsale.comment_path(comment), method: :delete, remote: true, data: {confirm: t("actions.confirm")}
 
-  p.infos
-    span.commentable-container
-      span.commentable
-        = link_to_object(comment.commentable)
+  p.comment-infos
+    span.comment-commentable-container
+      span.comment-commentable = link_to_object(comment.commentable)
+      span.comment-separator   = " - "
 
-      span.separator
-        = " - "
+    - if comment.title.present?
+      span.title-container
+        strong.title  = comment.title
+        span.separator = " - "
 
-    span.date
-      = date(comment.created_at)
+    span.comment-date
+      = date(comment.date)
 
     = " "
-    = ::Dorsale::Comment.t(:written_by)
+    = comment.t(:written_by)
     = " "
-    span.author
+    span.comment-author
       = comment.author.to_s
 
-  p.text = text2html(comment.text)
+  - if truncate_comment_text? && comment.text.length > 300
+    p.comment-text-truncated
+      = truncate(comment.text, length: 200)
+      = " "
+      a.comment-show_more href="#"
+        = ta(:show_more)
+
+  p.comment-text = text2html(comment.text)
 
   .clearfix

data/app/views/dorsale/comments/_form.html.slim

@@ -8,8 +8,17 @@
     - else
       = image_tag "dorsale/avatar.png", class: "avatar"
 
-    .textarea-input-group
-      = f.text_area :text, rows: 3, class: "form-control"
-      input type="submit" value=t("actions.send")
+    .comment-fields
+      .comment-title-field
+        = f.text_field :title, class: "form-control input-sm", placeholder: f.object.t(:title)
+
+      .comment-date-field
+        = f.text_field :date, class: "form-control input-sm", placeholder: f.object.t(:date)
+
+      .comment-text-field
+        = f.text_area :text, rows: 3, class: "form-control input-sm", placeholder: f.object.t(:text)
+
+      .comment-submit
+        input type="submit" value=t("actions.send") class="btn btn-success btn-xs"
 
     .clearfix

data/app/views/dorsale/customer_vault/links/new.html.slim

@@ -5,7 +5,7 @@
 
     .panel-body
       = horizontal_form_for @link, as: :link, url: customer_vault_link_form_path do |f|
-        = f.association :bob, label: ::Dorsale::CustomerVault::Person.t, collection: @people
+        = f.association :bob, label: ::Dorsale::CustomerVault::Person.t, collection: @people, input_html: {class: "select2"}
 
         = f.input :title
         = form_buttons

data/app/views/dorsale/customer_vault/people/_context.html.slim

@@ -9,18 +9,14 @@
 
   .context-body
     p.text-center = avatar_img(person)
-
-    = info person, :tags,     tags(person)
-    = info person, :email,    helper: :email_link
-    = info person, :phone,    helper: :tel_link
-    = info person, :mobile,   helper: :tel_link
-    = info person, :fax,      helper: :tel_link
-    = info person, :skype,    helper: :email_link
-    = info person, :www,      helper: :web_link
-    = info person, :twitter,  helper: :web_link
-    = info person, :facebook, helper: :web_link
-    = info person, :linkedin, helper: :web_link
-    = info person, :viadeo,   helper: :web_link
+    = render "dorsale/customer_vault/people/context_general", person: person
+    hr
+    = render "dorsale/customer_vault/people/context_address", person: person
+    hr
+    = render 'dorsale/customer_vault/people/context_social', person: person
 
   .context-footer
     = actions_for(person)
+
+- if person.individual? && person.corporation.present?
+  = render "dorsale/customer_vault/people/context", person: person.corporation

data/app/views/dorsale/customer_vault/people/_context_address.html.slim

@@ -0,0 +1,6 @@
+- address = person.address
+= info address, :street
+= info address, :street_bis
+= info address, :city
+= info address, :zip
+= info address, :country

data/app/views/dorsale/customer_vault/people/_context_general.html.slim

@@ -0,0 +1,5 @@
+= info person, :tags,     tags(person)
+= info person, :email,    helper: :email_link
+= info person, :phone,    helper: :tel_link
+= info person, :mobile,   helper: :tel_link
+= info person, :fax,      helper: :tel_link

data/app/views/dorsale/customer_vault/people/_context_social.html.slim

@@ -0,0 +1,6 @@
+= info person, :skype,    helper: :email_link
+= info person, :www,      helper: :web_link
+= info person, :twitter,  helper: :web_link
+= info person, :facebook, helper: :web_link
+= info person, :linkedin, helper: :web_link
+= info person, :viadeo,   helper: :web_link

data/app/views/dorsale/customer_vault/people/_form.html.slim

@@ -18,15 +18,17 @@
     .panel-body
       - if @person.corporation?
         = f.input :capital
-        = f.input :immatriculation_number_1
-        = f.input :immatriculation_number_2
+        = f.input :immatriculation_number
+        = f.input :number_of_employees
+        = f.input :revenue
         = f.input :european_union_vat_number
         = f.input :legal_form
 
+
       - if @person.individual?
         = f.input :title
-        = f.input :context, as: :text, input_html: {rows: 4}
-
+        = f.association :corporation, collection: policy_scope(Dorsale::CustomerVault::Corporation), input_html: {class: 'select2'}
+      = f.input :context, as: :text, input_html: {rows: 4}
   .panel.panel-default
     .panel-heading: .panel-title = t("customer_vault.contact_informations")
     .panel-body
@@ -40,6 +42,8 @@
       = f.input :facebook, as: :string
       = f.input :linkedin, as: :string
       = f.input :viadeo,   as: :string
+      - if @person.corporation?
+        = f.input :societe_com
 
   .panel.panel-default
     .panel-heading: .panel-title = t("customer_vault.address_informations")

data/config/locales/customer_vault.en.yml

@@ -57,8 +57,12 @@ en:
         all_tags: "All tags"
         all_types: "All types"
         capital: "Capital"
-        immatriculation_number_1: "Immatriculation number 1"
-        immatriculation_number_2: "Immatriculation number 2"
+        immatriculation_number: "Immatriculation number 1"
+        revenue: "Revenue"
+        number_of_employees: "Number of employees"
+        naf: "NAF"
+        societe_com: "Societe.com"
+        corporation: "Corporation"
         european_union_vat_number: "European union VAT number"
         legal_form: "Legal form"
         count: "Number of people"

data/config/locales/customer_vault.fr.yml

@@ -57,12 +57,17 @@ fr:
         all_tags: "Tous les tags"
         all_types: "Tous les types"
         capital: "Capital"
-        immatriculation_number_1: "SIREN"
-        immatriculation_number_2: "RCS"
+        immatriculation_number: "SIREN"
+        revenue: "Chiffre d'affaire"
+        number_of_employees: "Effectif"
+        naf: "NAF"
+        corporation: "Entreprise"
+        societe_com: "Societe.com"
         european_union_vat_number: "Numéro TVA européenne"
         legal_form: "Forme juridique"
         count: "Nombre de contacts"
         person_type: "Type"
+        title: "Fonction"
       dorsale/customer_vault/individual:
         <<: *customer_vault_person_attributes
       dorsale/customer_vault/corporation:

data/config/locales/dorsale.en.yml

@@ -34,3 +34,8 @@ en:
       dorsale/comment:
         one: "Comment"
         other: "Comments"
+
+    attributes:
+      dorsale/comment:
+        title: "Title (optional)"
+        text: "Comment"

data/config/locales/dorsale.fr.yml

@@ -34,3 +34,8 @@ fr:
       dorsale/comment:
         one: "Commentaire"
         other: "Commentaires"
+
+    attributes:
+      dorsale/comment:
+        title: "Titre (facultatif)"
+        text: "Commentaire"

data/db/migrate/20170406121024_dorsale_comments_add_date_and_title.rb

@@ -0,0 +1,7 @@
+class DorsaleCommentsAddDateAndTitle < ActiveRecord::Migration[5.0]
+  def change
+    add_column :dorsale_comments, :date,  :date
+    add_column :dorsale_comments, :title, :string
+    Dorsale::Comment.update_all("date = created_at")
+  end
+end

data/db/migrate/20170406122047_add_attribute_to_dorsale_customer_vault_people.rb

@@ -0,0 +1,36 @@
+class AddAttributeToDorsaleCustomerVaultPeople < ActiveRecord::Migration[5.0]
+  class Person < ActiveRecord::Base
+    self.table_name = :dorsale_customer_vault_people
+  end
+
+  def change
+    add_column :dorsale_customer_vault_people, :context, :text
+    add_column :dorsale_customer_vault_people, :corporation_id, :integer
+    migrate_individuals_context
+    migrate_corporations_immatriculation_numbers
+  end
+
+  def migrate_individuals_context
+    Dorsale::CustomerVault::Individual.all.each do |individual|
+      data = JSON.parse(individual.data_before_type_cast)
+
+      individual.update_columns context: data["context"]
+      data.delete("context")
+
+      Person.where(id: individual.id).update_all(data: data.to_json)
+    end
+  end
+
+  def migrate_corporations_immatriculation_numbers
+    Dorsale::CustomerVault::Corporation.all.each do |corporation|
+      data = JSON.parse(corporation.data_before_type_cast)
+
+      immatriculation_number = "#{data['immatriculation_number_1']} / #{data['immatriculation_number_2']}"
+      data.delete("immatriculation_number_1")
+      data.delete("immatriculation_number_2")
+      data["immatriculation_number"] = immatriculation_number
+
+      Person.where(id: corporation.id).update_all(data: data.to_json)
+    end
+  end
+end

data/features/customer_vault_corporations.feature

@@ -11,7 +11,7 @@ Feature: Manage corporations
     When I create an new corporation
     And I add the corporation's informations
     And I fill the corporation's address
-    And I fill the corporation capital, immatriculation1, immatriculation2, legal form
+    And I fill the corporation capital, immatriculation, legal form
     And I validate the new corporation
     Then the corporation is created
     And I am on the corporation page

data/features/customer_vault_links.feature

@@ -9,7 +9,7 @@ Feature: Manage links
 
   Scenario: Add a new link on individual
     Given an existing corporation
-    And an existing indidual
+    And an existing individual
     When I navigate to the link section of the indidual details
     And I add a new link to the individual
     And I provide the link and the target corporation
@@ -32,7 +32,7 @@ Feature: Manage links
 
   Scenario: Add a new link on corporation
     Given an existing corporation
-    And an existing indidual
+    And an existing individual
     When I navigate to the link section of the corporation details
     And I add a new link to the corporation
     And I provide the link and the target individual

data/features/customer_vault_people.feature

@@ -9,3 +9,17 @@ Feature: People
     When I go the to people list
     And I export people list
     Then the file is downloaded
+
+  Scenario: Activity truncated comment
+    Given an existing individual
+    And a very long comment on this person
+    When I go on the people activity
+    Then I see the truncated comment
+    When I click on show more
+    Then I see the full comment
+
+  Scenario: Activity not truncated comment
+    Given an existing individual
+    And a short comment on this person
+    When I go on the people activity
+    Then I see the full comment

data/features/step_definitions/common_steps.rb

@@ -59,3 +59,7 @@ end
 
 When(/^(?:I|he|she) download XLSX file$/) do
 end
+
+When(/^I click on show more$/) do
+  find("a[class*=show_more]").click
+end

data/features/step_definitions/customer_vault_corporations_steps.rb

@@ -16,11 +16,14 @@ When(/^I add the corporation's informations$/) do
   fill_in 'person_fax', with: '09 00 00 00 00'
 end
 
-When(/^I fill the corporation capital, immatriculation1, immatriculation2, legal form$/) do
+When(/^I fill the corporation capital, immatriculation, legal form$/) do
   fill_in 'person_capital', with: '1000'
-  fill_in 'person_immatriculation_number_1', with: 'RCS 201523658'
-  fill_in 'person_immatriculation_number_2', with: 'SIREN 5485632569'
+  fill_in 'person_immatriculation_number', with: 'RCS 201523658'
   fill_in 'person_legal_form', with: 'SARL'
+  fill_in 'person_number_of_employees', with: '45'
+  fill_in 'person_revenue', with: "450000"
+  fill_in 'person_context', with: "Le joli contexte"
+  fill_in 'person_societe_com', with: "societe_com"
 end
 
 When(/^I fill the corporation's address$/) do
@@ -71,7 +74,7 @@ end
 Then(/^I see my new comment$/) do
   expect(Dorsale::Comment.count).to eq(@comments_count + 1)
 
-  expect(find(".comment p.text")).to have_content "MyNewComment"
+  expect(find("p.comment-text")).to have_content "MyNewComment"
 end
 
 Given(/^an existing comment on this corporation$/) do
@@ -87,7 +90,7 @@ When(/^I update the comment$/) do
 end
 
 Then(/^I see my updated comment$/) do
-  expect(find(".comment p.text")).to have_content "MyUpdatedComment"
+  expect(find("p.comment-text")).to have_content "MyUpdatedComment"
 end
 
 When(/^I delete the comment$/) do

data/features/step_definitions/customer_vault_individuals_steps.rb

@@ -36,10 +36,6 @@ Then(/^the individual is created$/) do
   expect(@individual.last_name).to eq "Gantaume"
 end
 
-Given(/^an existing individual$/) do
-  @individual = create(:customer_vault_individual)
-end
-
 When(/^I edit this individual$/) do
   visit dorsale.edit_customer_vault_individual_path(@individual)
 end

data/features/step_definitions/customer_vault_links_steps.rb

@@ -4,7 +4,7 @@ Given(/^an existing corporation$/) do
   @person = @corporation
 end
 
-Given(/^an existing indidual$/) do
+Given(/^an existing individual$/) do
   @individual = create(:customer_vault_individual)
   @person = @individual
 end

data/features/step_definitions/customer_vault_people_steps.rb

@@ -5,3 +5,21 @@ end
 Then(/^the file is downloaded$/) do
   # Nothing to do, error appears in previous step if any problem
 end
+
+Given(/^a very long comment on this person$/) do
+  @comment = create(:dorsale_comment, commentable: @person, text: Faker::Lorem.paragraph(10))
+end
+
+Then(/^I see the truncated comment$/) do
+  expect(page).to have_selector(".comment-text-truncated")
+  expect(page).to have_no_selector(".comment-text")
+end
+
+Then(/^I see the full comment$/) do
+  expect(page).to have_selector(".comment-text")
+  expect(page).to have_no_selector(".comment-text-truncated")
+end
+
+Given(/^a short comment on this person$/) do
+  @comment = create(:dorsale_comment, commentable: @person, text: "i am short")
+end

data/lib/dorsale/version.rb

@@ -1,3 +1,3 @@
 module Dorsale
-  VERSION = "3.5.0"
+  VERSION = "3.5.1"
 end

data/spec/models/dorsale/comment_spec.rb

@@ -8,7 +8,16 @@ RSpec.describe Dorsale::Comment, type: :model do
   it { is_expected.to belong_to :commentable }
   it { is_expected.to validate_presence_of :commentable }
 
+  it { is_expected.to validate_presence_of :date }
+  it { is_expected.to_not validate_presence_of :title }
+
   it "should have a valid factory" do
     expect(create(:dorsale_comment)).to be_valid
   end
+
+  describe "default values" do
+    it "should set date" do
+      expect(described_class.new.date).to be_present
+    end
+  end # describe "default values"
 end

data/spec/models/dorsale/customer_vault/corporation_spec.rb

@@ -5,15 +5,19 @@ RSpec.describe ::Dorsale::CustomerVault::Corporation, type: :model do
     it { is_expected.to have_many :comments }
     it { is_expected.to have_many :taggings }
     it { is_expected.to have_many :tags }
+    it { is_expected.to have_many :individuals }
     it { is_expected.to have_many(:tasks).dependent(:destroy) }
 
     it { is_expected.to respond_to :legal_form }
     it { is_expected.to respond_to :capital }
-    it { is_expected.to respond_to :immatriculation_number_1 }
-    it { is_expected.to respond_to :immatriculation_number_2 }
+    it { is_expected.to respond_to :immatriculation_number }
+    it { is_expected.to respond_to :naf }
+    it { is_expected.to respond_to :revenue }
+    it { is_expected.to respond_to :context }
+    it { is_expected.to respond_to :number_of_employees }
+    it { is_expected.to respond_to :societe_com }
 
     it { is_expected.to have_many(:comments).dependent(:destroy) }
 
     it { is_expected.to validate_presence_of :corporation_name }
 end
-

data/spec/models/dorsale/customer_vault/individual_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe ::Dorsale::CustomerVault::Individual, :type => :model do
   end
 
   it { is_expected.to have_one(:address).dependent(:destroy) }
+  it { is_expected.to belong_to :corporation }
   it { is_expected.to have_many :comments }
   it { is_expected.to have_many :taggings }
   it { is_expected.to have_many :tags }
@@ -14,4 +15,6 @@ RSpec.describe ::Dorsale::CustomerVault::Individual, :type => :model do
   it { is_expected.to have_many(:comments).dependent(:destroy) }
   it { is_expected.to validate_presence_of :first_name }
   it { is_expected.to validate_presence_of :last_name }
+
+  it { is_expected.to respond_to :context }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dorsale
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.1
 platform: ruby
 authors:
 - agilidée
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-03 00:00:00.000000000 Z
+date: 2017-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: 1.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: 1.0.3
 - !ruby/object:Gem::Dependency
   name: virtus
   requirement: !ruby/object:Gem::Requirement
@@ -701,6 +701,9 @@ files:
 - app/views/dorsale/customer_vault/links/index.html.slim
 - app/views/dorsale/customer_vault/links/new.html.slim
 - app/views/dorsale/customer_vault/people/_context.html.slim
+- app/views/dorsale/customer_vault/people/_context_address.html.slim
+- app/views/dorsale/customer_vault/people/_context_general.html.slim
+- app/views/dorsale/customer_vault/people/_context_social.html.slim
 - app/views/dorsale/customer_vault/people/_data_context.html.slim
 - app/views/dorsale/customer_vault/people/_filters.html.slim
 - app/views/dorsale/customer_vault/people/_form.html.slim
@@ -809,6 +812,8 @@ files:
 - db/migrate/20170127131537_delete_folders.rb
 - db/migrate/20170127151610_fix_expense_state.rb
 - db/migrate/20170127155636_billing_machine_add_pdf_file.rb
+- db/migrate/20170406121024_dorsale_comments_add_date_and_title.rb
+- db/migrate/20170406122047_add_attribute_to_dorsale_customer_vault_people.rb
 - features/access.feature
 - features/billing_machine_id_cards.feature
 - features/billing_machine_invoices.feature