dorsale 3.11.0 → 3.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c5b7404b272ca5ba112982222ab479da275f739afb4b81857ddad3ec5dcf132
-  data.tar.gz: d8f4cb12f3b9f02813c2b112d98479d86c1e9a6de21547a60c0237acd58f3f6f
+  metadata.gz: 2929616b8560e74343ed527fd6ede62bc2ee0bfa66e7629390ef8c0963bfd27f
+  data.tar.gz: b3d12ad8b3c19316706583baebe2790b8f26e94e263806781fe6622beb1947fc
 SHA512:
-  metadata.gz: cd150b1f65bec68063d60e6b792d46bf009083c7b5b03b7d269468c9c439dae7532da9fe6289a7e8a3c769fa64996bf02ba7cdb951483a2f97edf75eee91923a
-  data.tar.gz: 1666b09c7a94602c592cabe30bb22385cbb776762bec90952501e9233d71a4a48cb3363e30c9cd7a57e282e65dcafd5fcd529e60f7f2049986257ced1b9e8361
+  metadata.gz: 3817c01b04ff4a47bb5a87f0a9073314a4a1ceae7c55018ddddeb1ed1c692e8d4ab647f1931876bf657d20355557174a2cec19aaa9d99f6a1fd0c6ee2990a888
+  data.tar.gz: 8621383721811a53a903e7c214163ef12ae2919fbec6c05304b1e0af5a1d0a7ddd4d32f9b0c36b5fe922f66ef3c48ed83e500e8e5db76c351ca4fcf6b6bfd9f0

data/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Next version
 
+## 3.12.0
+- Change attachment observers
+
 ## 3.11.0
 - Various updates
 - Remove bh gem dependency

data/app/controllers/dorsale/alexandrie/attachments_controller.rb

@@ -23,7 +23,7 @@ class Dorsale::Alexandrie::AttachmentsController < ::Dorsale::ApplicationControl
     authorize @attachment, :create?
 
     if @attachment.save
-      notify_attachable
+      notify_attachable(:create)
     else
       flash.now[:alert] = t("messages.attachments.create_error")
     end
@@ -41,7 +41,7 @@ class Dorsale::Alexandrie::AttachmentsController < ::Dorsale::ApplicationControl
     authorize @attachment, :update?
 
     if @attachment.update(attachment_params_for_update)
-      notify_attachable
+      notify_attachable(:update)
     else
       flash.now[:alert] = t("messages.attachments.update_error")
     end
@@ -53,7 +53,7 @@ class Dorsale::Alexandrie::AttachmentsController < ::Dorsale::ApplicationControl
     authorize @attachment, :delete?
 
     if @attachment.destroy
-      notify_attachable
+      notify_attachable(:delete)
     else
       flash.now[:alert] = t("messages.attachments.delete_error")
     end
@@ -117,7 +117,7 @@ class Dorsale::Alexandrie::AttachmentsController < ::Dorsale::ApplicationControl
     render :index
   end
 
-  def notify_attachable
-    @attachment.attachable.send(:try, :after_attachments_changes)
+  def notify_attachable(action)
+    @attachment.attachable.send(:try, :on_attachment_action, @attachment, action)
   end
 end

data/app/models/dorsale/billing_machine/quotation.rb

@@ -118,7 +118,7 @@ class Dorsale::BillingMachine::Quotation < ::Dorsale::ApplicationRecord
     end
   end
 
-  def after_attachments_changes
+  def on_attachment_action(_attachment, _action)
     Dorsale::BillingMachine::PdfFileGenerator.(self)
   end
 end

data/features/step_definitions/expense_gun_expenses_steps.rb

@@ -15,7 +15,7 @@ When(/^I create a new expense$/) do
 
   within all(".nested-fields").first do
     find("input[id$='_name']").set "ExpenseLine1Name"
-    find("input[id$='_date']").set "21/06/2015"
+    find("input[id$='_date']").set "2015-06-21"
     select @category.name
     find("input[id$='_total_all_taxes']").set "100"
     find("input[id$='_vat']").set "20"
@@ -26,7 +26,7 @@ When(/^I create a new expense$/) do
 
   within all(".nested-fields").last do
     find("input[id$='_name']").set "ExpenseLine2Name"
-    find("input[id$='_date']").set "12/06/2015"
+    find("input[id$='_date']").set "2015-06-12"
     select @category.name
     find("input[id$='_total_all_taxes']").set "200"
     find("input[id$='_vat']").set "40"

data/features/support/env.rb

@@ -5,4 +5,4 @@ def Zonebie.set_random_timezone
   # https://github.com/agilidee/dorsale/issues/273
 end
 Agilibox::CucumberConfig.require_all_helpers!
-Agilibox::CucumberConfig.require_poltergeist!
+Agilibox::CucumberConfig.require_cuprite!

data/lib/dorsale/version.rb

@@ -1,3 +1,3 @@
 module Dorsale
-  VERSION = "3.11.0"
+  VERSION = "3.12.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dorsale
 version: !ruby/object:Gem::Version
-  version: 3.11.0
+  version: 3.12.0
 platform: ruby
 authors:
 - agilidée
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-03 00:00:00.000000000 Z
+date: 2019-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails