dor-workflow-client 3.17.1 → 3.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb09003e24b358cc7ff0fbe046830029499974fb168be00403c91a2747a903f7
-  data.tar.gz: 6b2408aab36b0cbdf8000cfd9ac35f3a7b0925596d64a63db78322c43d5c121e
+  metadata.gz: 8fd89b591f6e8e7790a80edd752f75c07fb26c229e66573d33a56622d776e354
+  data.tar.gz: 77fac4390044b85befcecde8fdbd4189881684b3ad525bed2532867cfdd7f763
 SHA512:
-  metadata.gz: 393fd1c94c6cabe7cb5f32ff6b0014e4ccfc98a4fdd45370044a779f0aba2797af5b57d874bf3a410aff191c13d7300b6a5ba5fa1e97cb7f05213ec1380fb08d
-  data.tar.gz: b6d5c197d3fb84df3e532755974cc0942e4634aea8e4916b8c52aa332a3262a4abccec938cb720a1170e7c089fb959f8b487cf6b8773da03dbd6386c40849885
+  metadata.gz: ee811c6387d9e647a3a6862d0f10d9f6136ccbd655c24d28664c0359c5c9925693388e95fab83fad0177049e627ffb690238b999a5b9c1c6bcddc6be4f0f469e
+  data.tar.gz: 0feec909ffb877f8e2dc5c4d57195c076853c4c1eda6f2a4cc5ba30923cf5f9270412f06f27b416cda226d5c88964b063b8adf8052de6916a1d2591af7f033fc

data/lib/dor/workflow/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Workflow
     class Client
-      VERSION = '3.17.1'
+      VERSION = '3.18.0'
     end
   end
 end

data/lib/dor/workflow/client/version_routes.rb

@@ -14,7 +14,7 @@ module Dor
         # - completes the versioningWF:submit-version and versioningWF:start-accession steps
         # - initiates accesssionWF
         #
-        # @param [String] repo The repository the object resides in.  The service recoginzes "dor" and "sdr" at the moment
+        # @param [String] repo The repository the object resides in. This parameter is deprecated
         # @param [String] druid The id of the object to delete the workflow from
         # @param [Boolean] create_accession_wf Option to create accessionWF when closing a version.  Defaults to true
         # rubocop:disable Metrics/MethodLength
@@ -37,7 +37,9 @@ module Dor
             raise ArgumentError, 'wrong number of arguments, must be 1-3'
           end
 
-          requestor.request(construct_url(repo, druid, version, create_accession_wf), 'post', '')
+          Deprecation.warn(self, 'passing the repo parameter to close_version is no longer necessary. This will raise an error in dor-workflow-client version 4') if repo
+
+          requestor.request(construct_url(druid, version, create_accession_wf), 'post', '')
           true
         end
         # rubocop:enable Metrics/MethodLength
@@ -46,8 +48,8 @@ module Dor
 
         attr_reader :requestor
 
-        def construct_url(repo, druid, version, create_accession_wf)
-          url = "#{repo}/objects/#{druid}/versionClose"
+        def construct_url(druid, version, create_accession_wf)
+          url = "objects/#{druid}/versionClose"
 
           qs_args = []
           qs_args << "version=#{version}" if version

data/spec/workflow/client/version_routes_spec.rb

@@ -19,40 +19,53 @@ RSpec.describe Dor::Workflow::Client::VersionRoutes do
 
       it 'calls the versionClose endpoint with druid' do
         routes.close_version(repo, druid)
-        expect(Deprecation).to have_received(:warn)
+        expect(Deprecation).to have_received(:warn).twice
       end
 
       it 'optionally prevents creation of accessionWF' do
         routes.close_version(repo, druid, false)
         expect(mock_requestor).to have_received(:request)
-          .with('dor/objects/druid:123/versionClose?create-accession=false', 'post', '')
-        expect(Deprecation).to have_received(:warn)
+          .with('objects/druid:123/versionClose?create-accession=false', 'post', '')
+        expect(Deprecation).to have_received(:warn).twice
       end
     end
 
     context 'with kwargs' do
       it 'calls the versionClose endpoint' do
-        routes.close_version(repo: repo, druid: druid)
+        routes.close_version(druid: druid)
         expect(mock_requestor).to have_received(:request)
-          .with('dor/objects/druid:123/versionClose', 'post', '')
+          .with('objects/druid:123/versionClose', 'post', '')
+      end
+
+      context 'with deprecated repo arg' do
+        before do
+          allow(Deprecation).to receive(:warn)
+        end
+
+        it 'calls the versionClose endpoint' do
+          routes.close_version(repo: repo, druid: druid)
+          expect(mock_requestor).to have_received(:request)
+            .with('objects/druid:123/versionClose', 'post', '')
+          expect(Deprecation).to have_received(:warn)
+        end
       end
 
       it 'optionally prevents creation of accessionWF' do
-        routes.close_version(repo: repo, druid: druid, create_accession_wf: false)
+        routes.close_version(druid: druid, create_accession_wf: false)
         expect(mock_requestor).to have_received(:request)
-          .with('dor/objects/druid:123/versionClose?create-accession=false', 'post', '')
+          .with('objects/druid:123/versionClose?create-accession=false', 'post', '')
       end
 
       it 'optionally passes version' do
-        routes.close_version(repo: repo, druid: druid, version: 3)
+        routes.close_version(druid: druid, version: 3)
         expect(mock_requestor).to have_received(:request)
-          .with('dor/objects/druid:123/versionClose?version=3', 'post', '')
+          .with('objects/druid:123/versionClose?version=3', 'post', '')
       end
 
       it 'optionally prevents creation of accessionWF and passes version' do
-        routes.close_version(repo: repo, druid: druid, create_accession_wf: false, version: 3)
+        routes.close_version(druid: druid, create_accession_wf: false, version: 3)
         expect(mock_requestor).to have_received(:request)
-          .with('dor/objects/druid:123/versionClose?version=3&create-accession=false', 'post', '')
+          .with('objects/druid:123/versionClose?version=3&create-accession=false', 'post', '')
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dor-workflow-client
 version: !ruby/object:Gem::Version
-  version: 3.17.1
+  version: 3.18.0
 platform: ruby
 authors:
 - Willy Mene
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-21 00:00:00.000000000 Z
+date: 2020-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -253,7 +253,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Provides convenience methods to work with the DOR Workflow Service