dor-workflow-client 3.12.0 → 3.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5cbb16ceddf569a9b82c822b1b885ebba29b592cd012ae340cb76882c61cc3d8
-  data.tar.gz: 4f1a7c2f940898abb328618ba1a8e09628fcf5a232e146b5546811a2bd3c223f
+  metadata.gz: ea39b8e90466517fda9d9c0c8a7d1e6bfe2fe09d38566e51db76031e2768eae0
+  data.tar.gz: d75001c1f99852c3cd0410ea5cb018abf713162c04fcc81cc43c58817bcae34a
 SHA512:
-  metadata.gz: 228c451516708789a413be980b76fe25cb1efa7cf12865763291350ff86b2bdb63adfae2390ad02c3ef5fe33a213e68213a5a8dfb35a99531bded86fe396e21b
-  data.tar.gz: 42646cbdf62345f5128f7cc7c3391f245a387d6255734ddd498c71f38d82e6f6ec6ddbd2d3ad33c553abc09a9fee6525276343f7e6802cda1ed156aa8d55f643
+  metadata.gz: 6e414f5936d21fed90a4690ada9cf3df8c6130734c043a9b0e4c178c8fbe17f5320547dc83c0982e17ee11fb660054b644f8d57cf873128ca91fd05aabe31dc7
+  data.tar.gz: cc096fad25055d2f31fb3344d9af42fddeeb36aa90a12795a620c6b6a14dbd1946fd3996902a6092ecb352bc49bd10f6ef51eab2fd585faf4e039796c6e8fdae

data/Gemfile

@@ -9,5 +9,4 @@ gem 'activesupport', ENV['RAILS_VERSION'] if ENV['RAILS_VERSION']
 
 group :development, :test do
   gem 'byebug'
-  gem 'simplecov'
 end

data/lib/dor/missing_workflow_exception.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+module Dor
+  class MissingWorkflowException < WorkflowException
+  end
+end

data/lib/dor/workflow/client/requestor.rb

@@ -18,13 +18,21 @@ module Dor
         # @param [String] payload body for (e.g. put) request
         # @param [Hash] opts addtional headers options
         # @return [Object] response from method
+        # @raise [Dor::WorkflowException,Dor::MissingWorkflowException] if there are Faraday exceptions
         def request(uri_string, meth = 'get', payload = '', opts = {})
           response = send_workflow_resource_request(uri_string, meth, payload, opts)
           response.body
         rescue Faraday::Error => e
+          # `status` is set to `nil` if:
+          # * `e` does not respond to `:response`
+          # * `e` responds to `:response` and:
+          #   * `e.response` is `nil`
+          #   * `e.response` is a hash missing the `:status` key
+          # else it is set to the value of `e.response[:status]`
+          status = e.try(:response)&.fetch(:status, nil)
           msg = "Failed to retrieve resource: #{meth} #{base_url}/#{uri_string}"
-          msg += " (HTTP status #{e.response[:status]})" if e.respond_to?(:response) && e.response
-          raise Dor::WorkflowException, msg
+          msg += " (HTTP status #{status})" unless status.nil?
+          raise (status == 404 ? Dor::MissingWorkflowException : Dor::WorkflowException), msg
         end
 
         private

data/lib/dor/workflow/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Workflow
     class Client
-      VERSION = '3.12.0'
+      VERSION = '3.13.0'
     end
   end
 end

data/lib/dor/workflow_exception.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Dor
-  class WorkflowException < ::RuntimeError
+  class WorkflowException < RuntimeError
   end
 end

data/spec/workflow/client_spec.rb

@@ -329,9 +329,17 @@ RSpec.describe Dor::Workflow::Client do
       end
     end
 
-    context 'when it fails for any reason' do
+    context 'when the status is not found' do
       let(:status) { 404 }
 
+      it 'throws the missing workflow exception' do
+        expect { subject }.to raise_error Dor::MissingWorkflowException
+      end
+    end
+
+    context 'when it fails with status other than 404' do
+      let(:status) { 422 }
+
       it 'throws an exception' do
         expect { subject }.to raise_error Dor::WorkflowException
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dor-workflow-client
 version: !ruby/object:Gem::Version
-  version: 3.12.0
+  version: 3.13.0
 platform: ruby
 authors:
 - Willy Mene
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-10 00:00:00.000000000 Z
+date: 2019-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -209,6 +209,7 @@ files:
 - README.md
 - Rakefile
 - dor-workflow-client.gemspec
+- lib/dor/missing_workflow_exception.rb
 - lib/dor/workflow/client.rb
 - lib/dor/workflow/client/connection_factory.rb
 - lib/dor/workflow/client/lifecycle_routes.rb
@@ -251,7 +252,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubyforge_project: 
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Provides convenience methods to work with the DOR Workflow Service