dor-services-client 6.27.0 → 6.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27f8d5a9a2aa24911e5f169e843c7512971808087ea1164c1c08b6fa746c053b
-  data.tar.gz: be2661cb87f7d338a47ade38e331ea582522dbc739d1ab92ba4a08bb23f28f16
+  metadata.gz: 7deb2e9cf11e029ea63aa7bad9b918c09ccb0e8e556eff7e4fda128f8c6ad02e
+  data.tar.gz: 71e3ddd60c340352e76e1a2f97cca49238a900deaa15216507761abab2d3b51a
 SHA512:
-  metadata.gz: e4f943d0c005e0b92c166836ef3fe8c141023292cb59fbaca75caf33bf8c71d8c53068a2454ec6f3baaa55aade87a13fcd1560ba19baea61d014a5191979e2de
-  data.tar.gz: 01cea84dc24fbe256125e5c0df71547d29f33e621e556184f88f6d7274d035075835c3bc2bc223eb912edf4c4afde1fad6073317375ac28b81487cac9c7ec2d2
+  metadata.gz: 130bb091aac14a28ed07bfcae47cf610ae301195252b15a8a69b26e073eb6258e29f25ea1971000a5189dfa10a4c313b786566c9b934c1dc87bd85b0bf3555bf
+  data.tar.gz: c9c729fdbb5b8191e676467703a225f70678fc884d8e79abb01a940a7d3b55ff6f6850b7478af4c59d16e649e9a75ac751ca27272309994764e3a278138f1dbe

data/.rubocop.yml

@@ -1,8 +1,10 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.6
+  SuggestExtensions: false
 
 Metrics/BlockLength:
   Exclude:
+    - 'dor-services-client.gemspec'
     - 'spec/**/*'

data/.rubocop_todo.yml

@@ -1,23 +1,18 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-04-23 17:01:17 -0400 using RuboCop version 0.82.0.
+# on 2021-03-17 17:24:07 UTC using RuboCop version 1.11.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 2
-# Configuration parameters: IgnoredMethods.
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 20
+  Max: 22
 
 # Offense count: 1
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 115
-
-# Offense count: 1
-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
   Max: 11
 
@@ -28,9 +23,9 @@ Style/Documentation:
     - 'test/**/*'
     - 'lib/dor/services/client.rb'
 
-# Offense count: 338
+# Offense count: 77
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   Max: 164

data/README.md

@@ -110,6 +110,9 @@ object_client.update_marc_record
 # Copy metadata from Symphony into descMetadata
 object_client.refresh_metadata
 
+# Apply defaults from the item's AdminPolicy to the item itself
+object_client.apply_admin_policy_defaults
+
 # Send a notification to goobi
 object_client.notify_goobi
 

data/dor-services-client.gemspec

@@ -22,6 +22,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
+  spec.required_ruby_version = '~> 2.6'
+
   spec.add_dependency 'activesupport', '>= 4.2', '< 7'
   spec.add_dependency 'cocina-models', '~> 0.55.0' # leave pinned to patch level until cocina-models hits 1.0
   spec.add_dependency 'deprecation', '>= 0'
@@ -33,7 +35,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'byebug'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '~> 0.61.0'
+  spec.add_development_dependency 'rubocop', '~> 1.0'
   spec.add_development_dependency 'simplecov', '~> 0.17.0' # CodeClimate cannot use SimpleCov >= 0.18.0 for generating test coverage
   spec.add_development_dependency 'webmock'
 end

data/lib/dor/services/client/administrative_tag_search.rb

@@ -7,8 +7,7 @@ module Dor
     class Client
       # API calls that are about searching AdministrativeTags
       class AdministrativeTagSearch < VersionedService
-        # rubocop:disable Naming/UncommunicativeMethodParamName
-        def search(q:)
+        def search(q:) # rubocop:disable Naming/MethodParameterName
           resp = connection.get do |req|
             req.url "#{api_version}/administrative_tags/search?q=#{q}"
           end
@@ -18,7 +17,6 @@ module Dor
 
           raise_exception_based_on_response!(resp)
         end
-        # rubocop:enable Naming/UncommunicativeMethodParamName
       end
     end
   end

data/lib/dor/services/client/mutate.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+module Dor
+  module Services
+    class Client
+      # API calls that update the data.
+      class Mutate < VersionedService
+        # @param object_identifier [String] the pid for the object
+        def initialize(connection:, version:, object_identifier:)
+          super(connection: connection, version: version)
+          @object_identifier = object_identifier
+        end
+
+        # Copies the values from the admin policy to the item
+        # @raise [NotFoundResponse] when the response is a 404 (object not found)
+        # @raise [UnexpectedResponse] when the response is not successful.
+        # @return [boolean] true on success
+        def apply_admin_policy_defaults
+          resp = connection.post do |req|
+            req.url "#{object_path}/apply_admin_policy_defaults"
+          end
+
+          raise_exception_based_on_response!(resp) unless resp.success?
+
+          true
+        end
+
+        # Updates the object
+        # @param [Cocina::Models::RequestDRO,Cocina::Models::RequestCollection,Cocina::Models::RequestAPO] params model object
+        # @raise [NotFoundResponse] when the response is a 404 (object not found)
+        # @raise [UnexpectedResponse] when the response is not successful.
+        # @return [Cocina::Models::DRO,Cocina::Models::Collection,Cocina::Models::AdminPolicy] the returned model
+        def update(params:)
+          resp = connection.patch do |req|
+            req.url object_path
+            req.headers['Content-Type'] = 'application/json'
+            # asking the service to return JSON (else it'll be plain text)
+            req.headers['Accept'] = 'application/json'
+            req.body = params.to_json
+          end
+
+          raise_exception_based_on_response!(resp) unless resp.success?
+
+          Cocina::Models.build(JSON.parse(resp.body))
+        end
+
+        # Pull in metadata from Symphony and updates descriptive metadata
+        # @raise [NotFoundResponse] when the response is a 404 (object not found)
+        # @raise [UnexpectedResponse] when the response is not successful.
+        # @return [boolean] true on success
+        def refresh_metadata
+          resp = connection.post do |req|
+            req.url "#{object_path}/refresh_metadata"
+          end
+
+          raise_exception_based_on_response!(resp) unless resp.success?
+
+          true
+        end
+
+        # Destroys an object
+        # @return [Boolean] true if successful
+        # @raise [NotFoundResponse] when the response is a 404 (object not found)
+        # @raise [UnexpectedResponse] if the request is unsuccessful.
+        def destroy
+          resp = connection.delete do |req|
+            req.url object_path
+          end
+          raise_exception_based_on_response!(resp, object_identifier) unless resp.success?
+
+          true
+        end
+
+        private
+
+        def object_path
+          "#{api_version}/objects/#{object_identifier}"
+        end
+
+        attr_reader :object_identifier
+      end
+    end
+  end
+end

data/lib/dor/services/client/object.rb

@@ -4,7 +4,7 @@ module Dor
   module Services
     class Client
       # API calls that are about a repository object
-      class Object < VersionedService # rubocop:disable Metrics/ClassLength
+      class Object < VersionedService
         attr_reader :object_identifier
 
         # @param object_identifier [String] the pid for the object
@@ -73,25 +73,6 @@ module Dor
           [model, metadata]
         end
 
-        # Updates the object
-        # @param [Cocina::Models::RequestDRO,Cocina::Models::RequestCollection,Cocina::Models::RequestAPO] params model object
-        # @raise [NotFoundResponse] when the response is a 404 (object not found)
-        # @raise [UnexpectedResponse] when the response is not successful.
-        # @return [Cocina::Models::DRO,Cocina::Models::Collection,Cocina::Models::AdminPolicy] the returned model
-        def update(params:)
-          resp = connection.patch do |req|
-            req.url object_path
-            req.headers['Content-Type'] = 'application/json'
-            # asking the service to return JSON (else it'll be plain text)
-            req.headers['Accept'] = 'application/json'
-            req.body = params.to_json
-          end
-
-          return Cocina::Models.build(JSON.parse(resp.body)) if resp.success?
-
-          raise_exception_based_on_response!(resp)
-        end
-
         # Get a list of the collections. (Similar to Valkyrie's find_inverse_references_by)
         # @raise [UnexpectedResponse] if the request is unsuccessful.
         # @return [Array<Cocina::Models::DRO>]
@@ -106,56 +87,17 @@ module Dor
           Members.new(**parent_params).members
         end
 
-        # Publish an object (send to PURL)
-        # @raise [NotFoundResponse] when the response is a 404 (object not found)
-        # @raise [UnexpectedResponse] when the response is not successful.
-        # @param [String] workflow ('accessionWF') which workflow to callback to.
-        # @param [String] lane_id for prioritization (default or low)
-        # @return [boolean] true on success
-        def publish(workflow: nil, lane_id: nil)
-          query_params = [].tap do |params|
-            params << "workflow=#{workflow}" if workflow
-            params << "lane-id=#{lane_id}" if lane_id
-          end
-          query_string = query_params.any? ? "?#{query_params.join('&')}" : ''
-          publish_path = "#{object_path}/publish#{query_string}"
-          resp = connection.post do |req|
-            req.url publish_path
-          end
-          return resp.headers['Location'] if resp.success?
-
-          raise_exception_based_on_response!(resp)
+        def transfer
+          Transfer.new(**parent_params)
         end
 
-        # Preserve an object (send to SDR)
-        # @raise [NotFoundResponse] when the response is a 404 (object not found)
-        # @raise [UnexpectedResponse] when the response is not successful.
-        # @param [String] lane_id for prioritization (default or low)
-        # @return [String] URL from Location response header if no errors
-        def preserve(lane_id: nil)
-          query_string = lane_id ? "?lane-id=#{lane_id}" : ''
-          resp = connection.post do |req|
-            req.url "#{object_path}/preserve#{query_string}"
-          end
-          return resp.headers['Location'] if resp.success?
+        delegate :publish, :preserve, :shelve, to: :transfer
 
-          raise_exception_based_on_response!(resp)
+        def mutate
+          Mutate.new(**parent_params)
         end
 
-        # Shelve an object (send to Stacks)
-        # @raise [NotFoundResponse] when the response is a 404 (object not found)
-        # @raise [UnexpectedResponse] when the response is not successful.
-        # @param [String] lane_id for prioritization (default or low)
-        # @return [boolean] true on success
-        def shelve(lane_id: nil)
-          query_string = lane_id ? "?lane-id=#{lane_id}" : ''
-          resp = connection.post do |req|
-            req.url "#{object_path}/shelve#{query_string}"
-          end
-          return resp.headers['Location'] if resp.success?
-
-          raise_exception_based_on_response!(resp)
-        end
+        delegate :refresh_metadata, :update, :destroy, :apply_admin_policy_defaults, to: :mutate
 
         # Update the marc record for the given object
         # @raise [NotFoundResponse] when the response is a 404 (object not found)
@@ -170,32 +112,6 @@ module Dor
           raise_exception_based_on_response!(resp)
         end
 
-        # Pull in metadata from Symphony and update descMetadata
-        # @raise [NotFoundResponse] when the response is a 404 (object not found)
-        # @raise [UnexpectedResponse] when the response is not successful.
-        # @return [boolean] true on success
-        def refresh_metadata
-          resp = connection.post do |req|
-            req.url "#{object_path}/refresh_metadata"
-          end
-          return true if resp.success?
-
-          raise_exception_based_on_response!(resp)
-        end
-
-        # Destroys an object
-        # @return [Boolean] true if successful
-        # @raise [NotFoundResponse] when the response is a 404 (object not found)
-        # @raise [UnexpectedResponse] if the request is unsuccessful.
-        def destroy
-          resp = connection.delete do |req|
-            req.url object_path
-          end
-          raise_exception_based_on_response!(resp, object_identifier) unless resp.success?
-
-          true
-        end
-
         # Notify the external Goobi system for a new object that was registered in DOR
         # @raise [NotFoundResponse] when the response is a 404 (object not found)
         # @raise [UnexpectedResponse] when the response is not successful.

data/lib/dor/services/client/object_version.rb

@@ -38,9 +38,10 @@ module Dor
 
           raise_exception_based_on_response!(resp) unless resp.success?
 
-          if resp.body == 'true'
+          case resp.body
+          when 'true'
             true
-          elsif resp.body == 'false'
+          when 'false'
             false
           else
             raise MalformedResponse, "Expected true or false, not #{resp.body}"

data/lib/dor/services/client/transfer.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+module Dor
+  module Services
+    class Client
+      # API calls that move data around.
+      class Transfer < VersionedService
+        # @param object_identifier [String] the pid for the object
+        def initialize(connection:, version:, object_identifier:)
+          super(connection: connection, version: version)
+          @object_identifier = object_identifier
+        end
+
+        # Publish an object (send to PURL)
+        # @raise [NotFoundResponse] when the response is a 404 (object not found)
+        # @raise [UnexpectedResponse] when the response is not successful.
+        # @param [String] workflow ('accessionWF') which workflow to callback to.
+        # @param [String] lane_id for prioritization (default or low)
+        # @return [boolean] true on success
+        def publish(workflow: nil, lane_id: nil)
+          query_params = [].tap do |params|
+            params << "workflow=#{workflow}" if workflow
+            params << "lane-id=#{lane_id}" if lane_id
+          end
+          query_string = query_params.any? ? "?#{query_params.join('&')}" : ''
+          publish_path = "#{object_path}/publish#{query_string}"
+          resp = connection.post do |req|
+            req.url publish_path
+          end
+          return resp.headers['Location'] if resp.success?
+
+          raise_exception_based_on_response!(resp)
+        end
+
+        # Preserve an object (send to SDR)
+        # @raise [NotFoundResponse] when the response is a 404 (object not found)
+        # @raise [UnexpectedResponse] when the response is not successful.
+        # @param [String] lane_id for prioritization (default or low)
+        # @return [String] URL from Location response header if no errors
+        def preserve(lane_id: nil)
+          query_string = lane_id ? "?lane-id=#{lane_id}" : ''
+          resp = connection.post do |req|
+            req.url "#{object_path}/preserve#{query_string}"
+          end
+          return resp.headers['Location'] if resp.success?
+
+          raise_exception_based_on_response!(resp)
+        end
+
+        # Shelve an object (send to Stacks)
+        # @raise [NotFoundResponse] when the response is a 404 (object not found)
+        # @raise [UnexpectedResponse] when the response is not successful.
+        # @param [String] lane_id for prioritization (default or low)
+        # @return [boolean] true on success
+        def shelve(lane_id: nil)
+          query_string = lane_id ? "?lane-id=#{lane_id}" : ''
+          resp = connection.post do |req|
+            req.url "#{object_path}/shelve#{query_string}"
+          end
+          return resp.headers['Location'] if resp.success?
+
+          raise_exception_based_on_response!(resp)
+        end
+
+        private
+
+        def object_path
+          "#{api_version}/objects/#{object_identifier}"
+        end
+
+        attr_reader :object_identifier
+      end
+    end
+  end
+end

data/lib/dor/services/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Services
     class Client
-      VERSION = '6.27.0'
+      VERSION = '6.28.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dor-services-client
 version: !ruby/object:Gem::Version
-  version: 6.27.0
+  version: 6.28.0
 platform: ruby
 authors:
 - Justin Coyne
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-03-12 00:00:00.000000000 Z
+date: 2021-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -169,14 +169,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.61.0
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.61.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -240,11 +240,13 @@ files:
 - lib/dor/services/client/marcxml.rb
 - lib/dor/services/client/members.rb
 - lib/dor/services/client/metadata.rb
+- lib/dor/services/client/mutate.rb
 - lib/dor/services/client/object.rb
 - lib/dor/services/client/object_version.rb
 - lib/dor/services/client/objects.rb
 - lib/dor/services/client/release_tags.rb
 - lib/dor/services/client/response_error_formatter.rb
+- lib/dor/services/client/transfer.rb
 - lib/dor/services/client/version.rb
 - lib/dor/services/client/versioned_service.rb
 - lib/dor/services/client/virtual_objects.rb
@@ -258,9 +260,9 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="