dor-services-client 4.9.0 → 4.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7cbcc8c0942079ad92c72c56a5e50f5eec40874aca88b9c5d71afda95410332
-  data.tar.gz: 04710fd23832ce6a1de24c9b067afc392ce383c2e5a6628ce6d5de3a24953c2b
+  metadata.gz: 2318b72fea424890cea6809d9015250bb1efa68bc748ddf6aad0524ac9023df3
+  data.tar.gz: 7c1ec4bc41177fdbf97318bd338f46c6e8d084ed658036a17c75344c3b7654cb
 SHA512:
-  metadata.gz: 01d80a9bfaab329fada884588ac4ccd09403c928f2742afafe7e3928ade0e3ae40a0156afe74b42c8b05f43452e2db882ceaad4db43921e3e91563914e500dfe
-  data.tar.gz: 3aa18d9ad738413341fcd57ebc1a48ecc55842cdb8bc58b656fa24b0eaf6bd7f2015d9f5b8c4d074e16cc187da1d36fa141a350722225d5a8759f90938ccbcea
+  metadata.gz: 1bdf07a56ae7d348fa2e2682605d09865a449ff561b427d772d919a51cd39023f5289d88637ca683d4b37fd6dc780b4975bfff0220236aec172e5de91516113a
+  data.tar.gz: 9e2fe89165c72007d00bd018466557ddb9236dc51edc8f4c8efd5b141e09e3eeddc56ca46c60faeef8feb5ef32cd5cadb2482056433e6b4bb42ddc5ae6d68612

data/README.md

@@ -73,7 +73,13 @@ background_jobs_client.show(job_id: 123)
 marcxml_client = Dor::Services::Client.marcxml
 
 # Retrieve a catkey for a given barcode
-marcxml_client.catkey(barcode: 'foobarcode')
+marcxml_client.catkey(barcode: '123456789')
+
+# Retrieve MARCXML for a given barcode
+marcxml_client.marcxml(barcode: '123456789')
+
+# Retrieve MARCXML for a given catkey
+marcxml_client.marcxml(catkey: '987654321')
 
 # For performing operations on a known, registered object
 object_client = Dor::Services::Client.object(object_identifier)

data/dor-services-client.gemspec

@@ -26,7 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'cocina-models', '~> 0.15.0'
   spec.add_dependency 'faraday', '~> 0.15'
   spec.add_dependency 'moab-versioning', '~> 4.0'
-  spec.add_dependency 'nokogiri', '~> 1.8'
   spec.add_dependency 'zeitwerk', '~> 2.1'
 
   spec.add_development_dependency 'bundler'

data/lib/dor/services/client/marcxml.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'nokogiri'
+
 module Dor
   module Services
     class Client
@@ -9,7 +11,7 @@ module Dor
         # @param barcode [String] required string representing a barcode
         # @raise [NotFoundResponse] when the response is a 404 (object not found)
         # @raise [UnexpectedResponse] on an unsuccessful response from the server
-        # @return [String] result of background job
+        # @return [String] catkey
         def catkey(barcode:)
           resp = connection.get do |req|
             req.url "#{api_version}/catalog/catkey"
@@ -21,6 +23,41 @@ module Dor
 
           raise_exception_based_on_response!(resp)
         end
+
+        # Gets MARCXML corresponding to a barcode or catkey
+        # @param barcode [String] required string representing a barcode
+        # @param catkey [String] required string representing a catkey
+        # @raise [NotFoundResponse] when the response is a 500 with "Record not found in Symphony"
+        # @raise [UnexpectedResponse] on an unsuccessful response from the server
+        # @return [String] MARCXML
+        def marcxml(barcode: nil, catkey: nil)
+          check_args(barcode, catkey)
+
+          resp = connection.get do |req|
+            req.url "#{api_version}/catalog/marcxml"
+            req.params['barcode'] = barcode unless barcode.nil?
+            req.params['catkey'] = catkey unless catkey.nil?
+          end
+
+          raise_exception_based_on_marcxml_response!(resp)
+
+          resp.body
+        end
+
+        private
+
+        def check_args(barcode, catkey)
+          raise ArgumentError, 'Barcode or catkey must be provided' if barcode.nil? && catkey.nil?
+          raise ArgumentError, 'Both barcode and catkey may not be provided' if !barcode.nil? && !catkey.nil?
+        end
+
+        def raise_exception_based_on_marcxml_response!(resp)
+          # DOR Services App does not respond with a 404 when no match in Symphony.
+          # Rather, it responds with a 500 containing "Record not found in Symphony" in the body.
+          raise NotFoundResponse if !resp.success? && resp.body.match?(/Record not found in Symphony/)
+
+          raise UnexpectedResponse, ResponseErrorFormatter.format(response: resp) unless resp.success?
+        end
       end
     end
   end

data/lib/dor/services/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Services
     class Client
-      VERSION = '4.9.0'
+      VERSION = '4.10.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dor-services-client
 version: !ruby/object:Gem::Version
-  version: 4.9.0
+  version: 4.10.0
 platform: ruby
 authors:
 - Justin Coyne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-02-05 00:00:00.000000000 Z
+date: 2020-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -73,20 +73,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: zeitwerk
   requirement: !ruby/object:Gem::Requirement
@@ -243,7 +229,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A client for dor-services-app