dor-services-client 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d232d7cef9804e67fe55c361e33de98c052ee850aded786cf3cacd57868cbb5
-  data.tar.gz: 153b8235501ab55780248c1f55dd3e96d3074b1ac61f337e33e073f6965530dc
+  metadata.gz: 2b750e59b5465e3b4c75b7122071f3398618ec9c861ac0494c77956ba97b3a1a
+  data.tar.gz: 1a86fa9cf387b199fc3560a101d889ab9287e1183c2b32f165d7f87503d9a6c6
 SHA512:
-  metadata.gz: 00d3c92d8055e29dce098854e4fd0f68753adeddaa5499802dfc2867847d604f9602cc0072a03b12d1a0f9758cacc4cb21561faf1f0ae00bdb38b20f05c777e7
-  data.tar.gz: 1e7a5d3cb8b9a561800b4296fbae8310c0999257a34bb8c305b7a08fa7167aa9d0045eed6eba4cffdaec189dd1e163cfe76f631ff44c4243d81d33ddfdac891d
+  metadata.gz: 11b7a35b2a9be2bbf1abff74c8a17ab5fdf3725fb45423b8f148d15bfe28a8eda16ece00a9d7e4d8e6d59f937ba34c1d88a224ff8ffb3a8f6f50d364561e3dbe
+  data.tar.gz: 4738fc58390fd1465299c7df58c2cf5af700231e63ee6f02486f3ad852f8cb251d895da4bee11072917925a7cc39e48a45fcf7990881f5a90dee23573e1d8ca6

data/.travis.yml

@@ -1,6 +1,3 @@
-
-# single test suite, non-parallel build.
-
 env:
   global:
     - CC_TEST_REPORTER_ID=47b57fbbf65654b17f33b6ff4a108ce2abed31a86468033f20eb4d4e9e09935a
@@ -8,7 +5,6 @@ language: ruby
 cache: bundler
 rvm:
   - 2.5.3
-before_install: gem install bundler -v 1.17.1
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
   - chmod +x ./cc-test-reporter

data/dor-services-client.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'faraday', '~> 0.15'
   spec.add_dependency 'nokogiri', '~> 1.8'
 
-  spec.add_development_dependency 'bundler', '~> 1.17'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 0.61.0'

data/lib/dor/services/client.rb

@@ -28,10 +28,21 @@ module Dor
 
       include Singleton
 
+      # @param object_identifier [String] the pid for the object
+      # @raise [ArgumentError] when `object_identifier` is `nil`
+      # @return [Dor::Services::Client::Object] an instance of the `Client::Object` class
       def object(object_identifier)
-        Object.new(connection: connection, version: DEFAULT_VERSION, object_id: object_identifier)
+        raise ArgumentError, '`object_identifier` argument cannot be `nil` in call to `#object(object_identifier)' if object_identifier.nil?
+
+        # Return memoized object instance if object identifier value is the same
+        # This allows us to test the client more easily in downstream codebases,
+        # opening up stubbing without requiring `any_instance_of`
+        return @object if @object&.object_id == object_identifier
+
+        @object = Object.new(connection: connection, version: DEFAULT_VERSION, object_id: object_identifier)
       end
 
+      # @return [Dor::Services::Client::Objects] an instance of the `Client::Objects` class
       def objects
         @objects ||= Objects.new(connection: connection, version: DEFAULT_VERSION)
       end

data/lib/dor/services/client/object.rb

@@ -11,6 +11,8 @@ module Dor
     class Client
       # API calls that are about a repository object
       class Object < VersionedService
+        attr_reader :object_id
+
         # @param object_id [String] the pid for the object
         def initialize(connection:, version:, object_id:)
           raise ArgumentError, "The `object_id` parameter must be an identifier string: #{object_id.inspect}" unless object_id.is_a?(String)
@@ -109,8 +111,6 @@ module Dor
 
         private
 
-        attr_reader :object_id
-
         def object_path
           "#{api_version}/objects/#{object_id}"
         end

data/lib/dor/services/client/version.rb

@@ -3,7 +3,7 @@
 module Dor
   module Services
     class Client
-      VERSION = '1.0.0'
+      VERSION = '1.1.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dor-services-client
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Justin Coyne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-14 00:00:00.000000000 Z
+date: 2019-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -77,16 +77,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement