doorkeeper 5.9.2 → 5.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5511de8196966ae7db845cac15ebcef1be9f3b2ad6861b677cdc9ca80783c775
-  data.tar.gz: a939acb1f8734a1d6f2dedd58c5f006fb8db1726c6f87f0c4a14eec8f37ae7e8
+  metadata.gz: 71a32b8766b44f5eff16fbc128cfff6ab676b5af9104d16d58f060a0ed6d894c
+  data.tar.gz: 864e07764f1ba86d6f52a10e5a081291c2748dcecbfb8bcc60b0f27baa4e616e
 SHA512:
-  metadata.gz: aaee9b32df715f74aa621e256c284a7a968f78ee11183d9b5e43695c0c59bbb1de0559ce8b4e232d5d4b9e4c404b8a926fa4a9f4c7e3c52da3c0f9f19cd6b169
-  data.tar.gz: 92a836decf7418aa5bedb7793d9c924486b35485e9c0706e96064a7c984fcd90c204eef8c8260de30b89e501f1a71bb4372b01c8050cb96b638c5d68bd4c512a
+  metadata.gz: 4116cfa7e4e06a1bff79489ddeced66af1803dedd6f2e1b1b5edd67db0d90e444922a87cfc2215a4e61357e54ddf988606c3ecce40e50afb24fdd5e06808a2bd
+  data.tar.gz: 558ec2ac88215ba2cde034380a27d44d0c989841942c070e4ea02a746d154944b094ae2aa6a9284c7cca6d310705634fde4f6566fbf8a268a0c1b33e41937107

data/CHANGELOG.md

@@ -9,6 +9,11 @@ User-visible changes worth mentioning.
 
 - Please add here
 
+## 5.9.3
+
+- [#1834] Fix default `allow_token_introspection` returning `false` when a custom `application_class` is configured. The default proc compared application objects with `==`, which fails when the authorized client and the introspected token's application are resolved as different classes (e.g. a base `Doorkeeper::Application` vs. a configured subclass) even though they reference the same record. It now compares application ids instead.
+- [#1832] Fix confusing `belongs_to :owner` side effect: `Doorkeeper::Models::Ownership` is now included only when `enable_application_owner?` is set (read at include time), so models no longer expose a misleading `owner` association/reflection when the application owner feature is disabled and the schema lacks the owner columns.
+
 ## 5.9.2
 
 - [#1822][#1823][#1825] Update Rubocop config, auto-corrections and codebase cleanup.

data/lib/doorkeeper/config.rb

@@ -444,9 +444,9 @@ module Doorkeeper
     option :allow_token_introspection,
            default: (lambda do |token, authorized_client, authorized_token|
              if authorized_token
-               authorized_token.application == token&.application
+               authorized_token.application_id == token&.application_id
              elsif token&.application
-               authorized_client == token.application
+               authorized_client.id == token.application_id
              else
                true
              end

data/lib/doorkeeper/orm/active_record/mixins/application.rb

@@ -9,13 +9,12 @@ module Doorkeeper::Orm::ActiveRecord::Mixins
       self.strict_loading_by_default = false if respond_to?(:strict_loading_by_default)
 
       include ::Doorkeeper::ApplicationMixin
-      # Included unconditionally: this block runs once at parent-class
-      # autoload time, so gating on `enable_application_owner?` would
-      # freeze behavior at first-load time. The actual owner validation
-      # is still gated dynamically via `validate_owner?` →
-      # `confirm_application_owner?`, and `belongs_to :owner` is lazy on
-      # schemas that lack the columns.
-      include ::Doorkeeper::Models::Ownership
+      # `enable_application_owner?` is read once, at parent-class autoload
+      # time (#1831): with the feature off the model exposes no `:owner`
+      # association — avoiding a misleading reflection on schemas that lack
+      # the owner columns. The flag is therefore a load-time switch; turning
+      # it on later requires defining a fresh model class.
+      include ::Doorkeeper::Models::Ownership if Doorkeeper.config.enable_application_owner?
 
       has_many :access_grants,
                foreign_key: :application_id,

data/lib/doorkeeper/version.rb

@@ -5,7 +5,7 @@ module Doorkeeper
     # Semantic versioning
     MAJOR = 5
     MINOR = 9
-    TINY = 2
+    TINY = 3
     PRE = nil
 
     # Full version number

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: doorkeeper
 version: !ruby/object:Gem::Version
-  version: 5.9.2
+  version: 5.9.3
 platform: ruby
 authors:
 - Felipe Elias Philipp