domoscio_rails 0.3.5 → 0.3.6a

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b7cabe98aeb3d48cbe9e3221c798052ca22e9838641b0f0eb5c814651b56b86e
-  data.tar.gz: add23b57f3520e3c63c943beb1e915b3ca75f82ff1a015048079342c2f9ba981
+  metadata.gz: 7bbf2ea22b36b20eadb110276e6a4ade7486229737fd774a7bd2661cd11d369d
+  data.tar.gz: 20499ce3dfc249579446b59a04baec31bf6a8ce7594098a419be5f93979265a4
 SHA512:
-  metadata.gz: 641267c7319ab1653ceb738267fa8f4faa2705d13d19f0e139c95b6f862c33eaedb23c4d0ae47bde11dd37ba7dbf2a423d63976b61e699ae1fdca0855030e403
-  data.tar.gz: 0db98990280a8ea3eb7d4ed485f02e5a0117127c03b8474220740d247ebd307e64161e1ead8200dc4235b22dc822e389d19c24326c0123dfa1aa4a813a443ae7
+  metadata.gz: 78bdd7a85f07abec406fc8d5715b461cd17a6772e14c0ad357e5dcf44b66f76195d0ba18b007e535d6a0ffc77c44a5b9e3276f3d66fd291ee295c68342caef7e
+  data.tar.gz: fe4cf096c7a3378451f6c5cb5f037ad4dacc613f18f0acb862f1d9fdeda26c0ff0fce42f3b12583df22ee5f881ca5ce49ef8737f9bd3e3c1be0c1752521de88f

data/lib/domoscio_rails.rb

@@ -38,11 +38,11 @@ module DomoscioRails
 
     # Refers to AdaptiveEngine Version
     def version
-      @version || 2
+      @version ||= 2
     end
 
     def root_url
-      @root_url || ""
+      @root_url ||= ""
     end
   end
 
@@ -63,42 +63,44 @@ module DomoscioRails
   # - +method+: HTTP method; lowercase symbol, e.g. :get, :post etc.
   # - +url+: the part after Configuration#root_url
   # - +params+: hash; entity data for creation, update etc.; will dump it by JSON and assign to Net::HTTPRequest#body
-  # - +filters+: hash; pagination params etc.; will encode it by URI and assign to URI#query
-  # - +headers+: hash; request_headers by default
-  # - +before_request_proc+: optional proc; will call it passing the Net::HTTPRequest instance just before Net::HTTPRequest#request
   #
-  # Raises DomoscioRails::ResponseError if response code != 200.
+  # Performs HTTP requests to Adaptive Engine
+  # On token issues, will try once to get a new token then will output a DomoscioRails::ReponseError with details
   #
-  def self.request(method, url, params={}, filters={}, headers = request_headers, before_request_proc = nil)
-    return false if @disabled
-    # sets a default page size to 2k
+  # Raises DomoscioRails::ResponseError on Adaptive Error Status
+  # Raises DomoscioRails::ProcessingError on Internal Error
+  #
+  def self.request(method, url, params={})
+
+    store_tokens, headers = request_headers
     params.merge!({'per_page': 2000}) unless params[:per_page]
     uri = api_uri(url)
-    uri.query = URI.encode_www_form(filters) unless filters.empty?
-    res = DomoscioRails.send_request(uri, method, params, headers, before_request_proc)
-    return res if res.kind_of? DomoscioRails::ProcessingError
+
+    response = DomoscioRails.send_request(uri, method, params, headers)
+    return response if response.kind_of? DomoscioRails::ProcessingError
+
     begin
-      raise_http_failure(uri, res, params)
-      data = DomoscioRails::JSON.load(res.body.nil? ? '' : res.body)
-      DomoscioRails::AuthorizationToken::Manager.storage.store({access_token: res['Accesstoken'], refresh_token: res['Refreshtoken']})
+      raise_http_failure(uri, response, params)
+      data = DomoscioRails::JSON.load(response.body.nil? ? '' : response.body)
+      DomoscioRails::AuthorizationToken::Manager.storage.store({access_token: response['Accesstoken'], refresh_token: response['Refreshtoken']}) if store_tokens
     rescue MultiJson::LoadError => exception
-      data = ProcessingError.new(uri, 500, exception, res.body, params)
+      data = ProcessingError.new(uri, 500, exception, response.body, params)
     rescue ResponseError => exception
       data = exception
     end
 
-    if res['Total'] && !filters[:page]
-      pagetotal = (res['Total'].to_i / res['Per-Page'].to_f).ceil
+    if response['Total']
+      pagetotal = (response['Total'].to_i / response['Per-Page'].to_f).ceil
       for j in 2..pagetotal
-        res = DomoscioRails.send_request(uri, method, params.merge({page: j}), headers, before_request_proc)
-        return res if res.kind_of? DomoscioRails::ProcessingError
+        response = DomoscioRails.send_request(uri, method, params.merge({page: j}), headers)
+        return response if response.kind_of? DomoscioRails::ProcessingError
         begin
-          raise_http_failure(uri, res, params)
-          body = DomoscioRails::JSON.load(res.body.nil? ? '' : res.body)
+          raise_http_failure(uri, response, params)
+          body = DomoscioRails::JSON.load(response.body.nil? ? '' : response.body)
           data += body
           data.flatten!
         rescue MultiJson::LoadError => exception
-          return ProcessingError.new(uri, 500, exception, res.body, params)
+          return ProcessingError.new(uri, 500, exception, response.body, params)
         rescue ResponseError => exception
           return exception
         end
@@ -107,32 +109,52 @@ module DomoscioRails
     data
   end
 
-  def self.send_request(uri, method, params, headers, before_request_proc)
+  private
+
+  # This function catches usual Http errors during calls
+  #
+  def self.send_request(uri, method, params, headers)
     begin
-      res = Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') do |http|
-        req = Net::HTTP::const_get(method.capitalize).new(uri.request_uri, headers)
-        req.body = DomoscioRails::JSON.dump(params)
-        before_request_proc.call(req) if before_request_proc
-        http.request req
-      end
+      response = perform_call(uri, method, params, headers)
+      response = retry_call_and_store_tokens(uri, method, params, headers) if ['401','403'].include? response.code
+      response
     rescue Timeout::Error, Errno::EINVAL, Errno::ECONNREFUSED, Errno::ECONNRESET, EOFError, Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError, Net::ProtocolError => exception
-      ProcessingError.new(uri, 500, exception, res)
+      ProcessingError.new(uri, 500, exception, response)
     end
   end
 
-  private
-
-  def self.raise_http_failure(uri, res, params)
-    unless res.kind_of? Net::HTTPSuccess
-      if res.blank?
+  # This helper will check the response status and build the correcponding DomoscioRails::ResponseError
+  #
+  def self.raise_http_failure(uri, response, params)
+    unless response.kind_of? Net::HTTPSuccess
+      if response.blank?
         raise ResponseError.new(uri, 500, {error: {status: 500, message: 'AdaptiveEngine not available'}}, {}, params)
       else
-        body = DomoscioRails::JSON.load((res.body.nil? ? '' : res.body), :symbolize_keys => true)
-        raise ResponseError.new(uri, res.code.to_i, body, res.body, params)
+        body = {error: {status: response.code, message: DomoscioRails::JSON.load((response.body.nil? ? '' : response.body), :symbolize_keys => true)}}
+        raise ResponseError.new(uri, response.code.to_i, body, response.body, params)
       end
     end
   end
 
+  # Actual HTTP call is performed here
+  #
+  def self.perform_call(uri, method, params, headers)
+    Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') do |http|
+      req = Net::HTTP::const_get(method.capitalize).new(uri.request_uri, headers)
+      req.body = DomoscioRails::JSON.dump(params)
+      http.request req
+    end
+  end
+
+  # This method is called when AdaptiveEngine returns tokens errors
+  # Action on those errors is to retry and request new tokens, those new token are then stored
+  def self.retry_call_and_store_tokens(uri, method, params, headers)
+    headers = request_new_tokens
+    response = perform_call(uri, method, params, headers)
+    DomoscioRails::AuthorizationToken::Manager.storage.store({access_token: response['Accesstoken'], refresh_token: response['Refreshtoken']})
+    response
+  end
+
   def self.user_agent
     @uname ||= get_uname
     {
@@ -150,22 +172,39 @@ module DomoscioRails
     'uname lookup failed'
   end
 
+  # Process the token loading and analyze
+  # will return the processed headers and a token store flag
+  #
   def self.request_headers
-    auth_token = DomoscioRails::AuthorizationToken::Manager.get_token
-    if !auth_token.is_a? String
-      headers = {
-        'user_agent' => "#{DomoscioRails.user_agent}",
-        'AccessToken' => "#{auth_token[:access_token]}",
-        'RefreshToken' => "#{auth_token[:refresh_token]}",
-        'Content-Type' => 'application/json'
-      }
-    else
-      headers = {
-        'user_agent' => "#{DomoscioRails.user_agent}",
-        'Authorization' => "Token token=#{DomoscioRails.configuration.client_passphrase}",
-        'Content-Type' => 'application/json'
-      }
+    begin
+      auth_token = DomoscioRails::AuthorizationToken::Manager.get_token
+      if auth_token && auth_token[:access_token] && auth_token[:refresh_token]
+        [false, send_current_tokens(auth_token)]
+      else
+        [true, request_new_tokens]
+      end
+    rescue SyntaxError, StandardError
+      [true, request_new_tokens]
     end
-    headers
+  end
+
+  # If stored token successfully loaded we build the header with them
+  #
+  def self.send_current_tokens(auth_token)
+    {
+      'user_agent' => "#{DomoscioRails.user_agent}",
+      'AccessToken' => "#{auth_token[:access_token]}",
+      'RefreshToken' => "#{auth_token[:refresh_token]}",
+      'Content-Type' => 'application/json'
+    }
+  end
+
+  # If we cant find tokens of they are corrupted / expired, then we set headers to request new ones
+  def self.request_new_tokens
+    {
+      'user_agent' => "#{DomoscioRails.user_agent}",
+      'Authorization' => "Token token=#{DomoscioRails.configuration.client_passphrase}",
+      'Content-Type' => 'application/json'
+    }
   end
 end

data/lib/domoscio_rails/authorization_token.rb

@@ -11,9 +11,7 @@ module DomoscioRails
         end
 
         def get_token
-          token = storage.get
-          token = DomoscioRails.configuration.client_passphrase if token.nil?
-          token
+          storage.get
         end
       end
     end
@@ -29,13 +27,9 @@ module DomoscioRails
 
     class FileStorage
       require 'yaml'
-      @temp_dir
 
-      def initialize(temp_dir = nil)
-        @temp_dir = temp_dir || DomoscioRails.configuration.temp_dir
-        if !@temp_dir
-          raise "Path to temporary folder is not defined"
-        end
+      def initialize
+        raise "Path to temporary folder is not defined" unless DomoscioRails.configuration.temp_dir
       end
 
       def get
@@ -60,8 +54,7 @@ module DomoscioRails
       end
 
       def file_path
-        @temp_dir = DomoscioRails.configuration.temp_dir
-        File.join(@temp_dir, "DomoscioRails.AuthorizationToken.FileStore.tmp")
+        File.join(DomoscioRails.configuration.temp_dir, "DomoscioRails.AuthorizationToken.FileStore.tmp")
       end
     end
   end

data/lib/domoscio_rails/errors.rb

@@ -10,7 +10,7 @@ module DomoscioRails
       @request_url, @code, @details, @body, @request_params = request_url, code, details, body, request_params
       super(message) if message
     end
-    def message; @details.is_a?(Hash) ? @details.dig(:error, :message) : @details; end
+    def message; (@details.is_a?(Hash) && @details[:error].is_a?(Hash)) ? @details.dig(:error, :message) : @details; end
   end
 
   # ProcessingError from DomoscioRails

data/lib/domoscio_rails/version.rb

@@ -1,3 +1,3 @@
 module DomoscioRails
-  VERSION = "0.3.5"
+  VERSION = "0.3.6a"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: domoscio_rails
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6a
 platform: ruby
 authors:
 - Benoit Praly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-11 00:00:00.000000000 Z
+date: 2021-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -78,9 +78,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.8
 signing_key: